• Igor Sheludko's avatar
    [ext-code-space] Fix CodeRange hint logic on Windows and Linux · 4ecd70a2
    Igor Sheludko authored
    Windows requires additional writable page to be allocated in front of
    the code range, but at the same time the code range must not cross 4 GB
    boundary in order to make Code pointer compression work for Code
    pointers. All these constraints make the logic of hint calculation too
    dependent on what VirtualMemoryCage::InitReservation() would do with
    the provided hint. This CL simplifies the hint calculation and fully
    relies on VirtualMemoryCage::InitReservation() to do the right thing.
    
    On Linux the implementation of OS::GetFreeMemoryRangesWithin() doesn't
    work when Chromium sandbox is enabled, so we use the beginning of the
    preferred short builtin calls region as a hint. It should be at least
    as good as the fallback hint but with higher chances to point to free
    address space location.
    
    Bug: v8:11880
    Change-Id: I0b6ebec98dd0cf483f67e6ba8a919deb9ce7cc25
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3380585Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78568}
    4ecd70a2
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...