- 04 May, 2020 22 commits
-
-
Dan Elphick authored
This removes the static ReadOnlyHeap::Instance method replacing it with PopulateReadOnlySpaceStatistics on the way to removing the global ReadOnlyHeap object. Bug: v8:10454 Change-Id: Ic78c898ff99c6a7dac023d2b5230fbbbf6f36f46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179805 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67545}
-
Bill Budge authored
- Implements WasmInt32ToHeapNumber, WasmTaggedNonSmiToInt32, and WasmTaggedToFloat64 as Torque builtins. Bug: v8:10070 Change-Id: I8b16d000b5283f27f7762341e9dbbaf5ab3ebb62 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173395Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#67544}
-
Thibaud Michaud authored
This allows us to preserve the script URL when importing a module in a worker. R=ahaas@chromium.org,clemensb@chromium.org CC=kimanh@chromium.org Bug: chromium:1064548 Change-Id: Id5e48c840e2dba8eadb5c854fcb389787ce11215 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2167866 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#67543}
-
Tobias Tebbi authored
Summary of changes: - GC visitors no longer rely on superclass visitors, but instead visit everything themselves. This enables generating better code. - Try to match simple body descriptors to reduce the amount of generated code. - Turn SizeFor(instance) into an AllocatedSize() method. - Remove the special handling of resizable object sizes from Torque and instead overwrite AllocatedSize in classes that need special handling in C++. - Split the visitor id lists depending on whether the class has pointer fields. - Turn Torque-generated body descriptors into an .inc file to simplify includes. - Fix generated size functions to properly align the size. - Generate GC visitors (and C++ class definitions) for all string classes and FixedArray, WeakFixedArray, and WeakArrayList. - Store generated instance types in Torque class types. This is only used to determine if a type has a single instance type in this CL. Bug: v8:7793 Change-Id: I4d362e96b047c305bd6d065247734957b8958c42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2110014 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67542}
-
Igor Sheludko authored
... to be in sync with KeyedLoadIC_SloppyArguments in handling OOB accesses which may involve prototype chain walk. Bug: chromium:1063796 Change-Id: I8421c19085dfd2f3b6360c64fd04f53b1351576c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2174504Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#67541}
-
Michael Lippautz authored
The detection was overbroad and the underlying issue in QueryPerformanceCounter is supposedly fixed from Win XP SP2 on. Chromium removed the detection in https://crrev.com/c/1138241 in July 2018. Bug: v8:10362 Change-Id: I87baa47c2aad2428a92923a60916c0a9d07afdad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2128052Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67540}
-
Santiago Aboy Solanes authored
Since not all uses are going to be needing a revisit, we can introduce additional bookkeeping to search in the subset does need it. Sadly, it can only be used during the Visit part of RETYPE, since during the revisit all uses might need to be revisited. Bug: v8:10424 Change-Id: I4650ea42a93316d54de7d3aa32ce8a5eef2e10e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139573 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#67539}
-
Daniel Bevenius authored
Change-Id: I4336c761cbf04800e07b2533be38265725a0d7a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179302Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67538}
-
Toon Verwaest authored
Previously such maps were marked as prototype, but that has bad performance / memory characteristics if objects are used as dictionaries. Bug: b:148346655, v8:10339 Change-Id: I287c5664c8b7799a084669aaaffe3affcf73e95f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179322Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#67537}
-
Jakob Gruber authored
This variant passes the --stress-snapshot d8 flag. There's a large initial list of skips, these should be removed as issues are fixed over time. The variant is currently not enabled on any bots. Bug: v8:10416 Change-Id: I80aea80600c51b2f5d28b8ec8a09ff0ba2ebaa7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179002 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#67536}
-
Jakob Gruber authored
... and weak context code lists. These are non-empty when an isolate is running and the serializer cannot handle them. Bug: v8:10416 Change-Id: I11a3d25dfd1980bcddae8b65c429df3c2cf16b19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172423 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#67535}
-
Marja Hölttä authored
The objects are already in fast mode so they were NOOP. The commit that obsoleted them was https://chromium-review.googlesource.com/c/v8/v8/+/571750/ Bug: v8:10479,v8:5902 Change-Id: Ic3611f899d3138cda5bcff6debe529118ced5c93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172746 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#67534}
-
Igor Sheludko authored
Bug: v8:10391 Change-Id: I316a3c5cd986a74d7f46da6d0b85cb3d549be497 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2153209 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67533}
-
Michael Lippautz authored
The callback is useful to embedders to trigger various actions such as recomputing live set. Bug: chromium:1056170 Change-Id: I7d80b9b768a728e23303f945e416df97fd9b7805 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173358 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67532}
-
Dan Elphick authored
Moves ReadOnlyPage, ReadOnlyArtifacts, ReadOnlySpace and SharedReadOnlySpace out of spaces.h and into read-only-spaces.h, as well as creating a corresponding .cc file. Bug: v8:10473 Change-Id: I9d8b49d61ed643fd6e16919d571a909ab6fce407 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2171197Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#67531}
-
Manos Koukoutos authored
Motivation: Improve code efficiency by replacing runtime calls with manually written turbofan code where possible. Changes: - Remove the runtime functions `Runtime_WasmExceptionGetTag` and `Runtime_WasmExceptionGetValues` and replace them with turbofan code. - Introduce the builtin function `GetOwnProperty`. - Change `wasm-compiler.h` and `wasm-compiler.cc` to accomodate the new changes. - Introduce three new macros in `wasm-compiler.cc`. - Use those macros in two additional places to remove code duplication. Change-Id: I4a32f9e5f7ee55dc50cd03378a68897888ece5c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2162905Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#67530}
-
Dan Elphick authored
Change-Id: Ifa344d7f1d3173d85cf8fd2e1d72afbae27797a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179013 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67529}
-
Leszek Swirski authored
Create a static version of Heap::CreateFillerObjectAt which can't clear slots (as it doesn't access the heap), but can therefore be used in the OffThreadHeap. This will allow off-thread deserialization in the future. Bug: chromium:1075999 Change-Id: I4b4046ccfaa51822350ff7c384dbe33e621ed4f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2170230 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67528}
-
Jakob Gruber authored
When enabled, this flag triggers a serialize-deserialize-verify pass after script execution completes. Bug: v8:10416 Change-Id: I377b8387762495eba07c807229fa464b00485bae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172426 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67527}
-
Nico Hartmann authored
Bug: v8:5660 Change-Id: I8952535b2a361d56ae6822b1efbda88a4149c593 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2162166 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#67526}
-
Victor Gomes authored
Change-Id: Ib9a14265692dbcdce05accb78b753d268e77ad9e Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150587Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#67525}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fb3b9e0..81c45bb TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I1374c82fa2994c76e80bfd8cf6074de63597a2e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2178131Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#67524}
-
- 03 May, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3f2bcc3..fb3b9e0 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5095fb4..72830df Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/ebb382b..082a11a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ff6eeec..116e3ee TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I42c5a0b3c2c5e1355b5a300eedb5d96423ad65fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2177311Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#67523}
-
- 02 May, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/188dda2..3f2bcc3 Rolling v8/third_party/aemu-linux-x64: 5G0SNnG7y5vrRx9uieYCXluC7lrENI134I3ts-s7BckC..KkC1dMnOt3dQMJqp-GzpAoyULRktX6-7fxUPrsEeEJMC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b0ad61f..5095fb4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/37518fb..ebb382b TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I0f7e2c821e79333d0ea1122790e9e7dc6cd055e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2175252Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#67522}
-
- 01 May, 2020 10 commits
-
-
Milad Farazmand authored
Port c0eee179 Original Commit Message: ROL will be optional operator as arm, arm64 only have ROR. The reason for this CL is inefficient Wasm codegen for 64-bit left-rotation. R=duongn@microsoft.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I2803237712e45235ac53be07a28b4dc0c0f4a329 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173574Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67521}
-
Deepti Gandluri authored
As per the all-hands a couple of weeks ago, the interpreter will be removed soon. Remove running tests on this tier, so we no longer put effort into maintaining tests for this tier. Change-Id: I9fce0f3a7cd869d6ccecf1c1f820b794e89858e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2175021Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#67520}
-
Seth Brenith authored
Any function with heap-allocated variables starts by creating and pushing a new context for its execution. When entering the debugger due to the stack check in the beginning of InterpreterEntryTrampoline, the function has not yet had a chance to push that new context. The code in ScopeIterator currently assumes that any function which needs a context already has one by the time the debugger attempts to iterate scopes, but in this case that assumption is invalid, which can cause a null deref. This change introduces a new function ScopeIterator::NeedsAndHasContext to replace previous calls to current_scope_->NeedsContext(). This new function checks for the case where the current scope matches the closure scope but the context matches the containing context for the function, which implies that the function has not yet pushed its own context. Bug: v8:10319, chromium:1038747 Change-Id: I29636f269c44d35b68d8446769d17170eed50e89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2168021 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#67519}
-
Z Nguyen-Huu authored
ROL will be optional operator as arm, arm64 only have ROR. The reason for this CL is inefficient Wasm codegen for 64-bit left-rotation. Bug: v8:10216 Change-Id: I0cd13e4b6de5276a0d0b80eac5ed9c2e52ba1f96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2157648 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67518}
-
Deepti Gandluri authored
- Update opcode numbers, tests - As the wasm-module-builder currently assumes opcode bytes, skip the test that needs a multi-byte leb128 opcode - Renumber post-MVP opcodes Change-Id: I6531e954e63986dc6f7a3144ec054d16e6dc1b05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173952Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#67517}
-
Tobias Tebbi authored
Torque desugars try-catch/label constructs with several handlers into nested try structures, with the first handler ending-up innermost. So currently, if you write try { ... } label Foo { Throw(...); } catch (e) { } The catch will catch the preceding Throw in another handler. This is different from how multiple try-catch handlers are done in languages like Java, where throwing from a preceding catch handler is not caught by a later one. To avoid this possible ambiguity, this CL prohibits this pattern, enforcing that a catch handler comes first, before any other label-handler attached to the same try. This way, a catch handler never catches from any other handler on the same try, since they have to come later. Bug: v8:7793 Change-Id: I943f14b2393d307c4254a3fc3a78f236dbcf86df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2169098 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67516}
-
Igor Sheludko authored
Bug: v8:10391 Change-Id: If1db52dc74f9027f06104ce719514b751b4d9504 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2149417 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67515}
-
Milad Farazmand authored
Without the added header, GCC may produce the following error: <_CharT>, std::istreambuf_iterator<_CharT>, const _CharT2&) find(istreambuf_iterator<_CharT> __first, ^~~~ note: template argument deduction/substitution failed Change-Id: I92b226e469d780a778262847d90cf12a372dcc46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2176052Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67514}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d56e126..188dda2 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2072ffc..37518fb Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/b6a9eb3..ff6eeec TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I74f811dc53db076bbe6124759ca47b732e82536c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2174699Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#67513}
-
Ng Zhi An authored
Formatter does not recognize #include, since we format .tq files as TS. So replace it with a comment first, then substitute it back. This should also fix the Presubmit in waterfall https://ci.chromium.org/p/v8/builders/ci/V8%20Presubmit/10296 Change-Id: I316d52fc24e099474c542f75773683b54e8d0a63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2175089Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67512}
-
- 30 Apr, 2020 6 commits
-
-
Ng Zhi An authored
Bug: v8:10180 Change-Id: I71a5c63abdcca2b11d29a1d25844cda738384161 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173815Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67511}
-
Deepti Gandluri authored
This reverts commit fd2548f3. Reason for revert: Breaks telemetry benchmark, blocks deps roll. https://ci.chromium.org/p/chromium/builders/try/linux-rel/373686? https://chromium-swarm.appspot.com/task?id=4be57eb0279bbb10 Original change's description: > Reland^4 "[runtime] Amortize descriptor array growing for fast-mode prototypes" > > This CL: > - stops tracking transitions for fast maps that are known to be detached > - reuses descriptor arrays when transitioning detached maps to avoid O(n^2) performance and garbage creation > > Fix2 in reland: constructor_or_backpointer can be a smi since it can also hold a user-provided function.prototype > Fix in reland: check whether the map of the back pointer is the metamap rather than reading the map of the constructor-or-backpointer slot. If the slot contains a constructor, it's possible that the object transitions while the concurrent marker is reading the map (from which it's reading the instance type); and it's possible that the transitioned map isn't set up yet fully when we read the instance type. An acquire load for the constructor-or-backpointer map would also fix it by serializing stores, but is more expensive. Checking the metamap is faster. > > Original commit message: > > This avoids an O(n^2) algorithm that creates an equal amount of garbage. > > Even though the actual final descriptor array might be a little bigger, > > it reduces peak memory usage by allocating less. > > Change-Id: Id99dc76a369057e5c4d76a31163605cb38a66867 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172080 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67501} TBR=ulan@chromium.org,verwaest@chromium.org Change-Id: If305b5410ca37e04e9ec0ce50e9b494f5c4cd4dc No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2174767Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#67510}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/26e9d48..d56e126 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/7977eb1..204a35a Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/43bb9f8..d999d54 Rolling v8/third_party/aemu-linux-x64: 7YlCgase5GlIanqHn-nZClSlZ5kQETJyVUYRF7Jjy6UC..5G0SNnG7y5vrRx9uieYCXluC7lrENI134I3ts-s7BckC Rolling v8/third_party/android_sdk/public: Jxtur3_L9RzY4q79K-AwIahwFW4oi5uYVD5URx9h62wC..zMVtBEihXp2Z0NYFNjLLmNrwy6252b_YWG6sh2l0QAcC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/032c783..b0ad61f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/dd2f620..2072ffc Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/2457e41..277fe91 Rolling v8/third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/b41863e..3f90fa0 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/156be8c..21c6af6 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/105a846..b6a9eb3 Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/99e00d6..160b445 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I0a496658336c731c715a10d79c167e6159c48881 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2174543Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#67509}
-
Ng Zhi An authored
Bug: v8:9909 Change-Id: I095a57d25cd03fb390e745b9fcb83566a70d044e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173658Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67508}
-
Ng Zhi An authored
I missed out the i8x16 implementation in https://crrev.com/c/2169017. Bug: v8:9909 Change-Id: I3264e9dce51acca262ad71885379b320008555b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173657Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67507}
-
Maya Lekova authored
Apply the change from this CL to V8's version of googletest too: https://chromium-review.googlesource.com/c/chromium/src/+/2059008 TBR=thakis@chromium.org Bug: chromium:1076363 Change-Id: If51c47c88178e75bdc205dd6b72f6aa357ec2d4c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172742 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#67506}
-