- 02 Mar, 2016 9 commits
-
-
bmeurer authored
Initial version of a new StrictEqualStub written as TurboFan code stub, that implements the full strict equality comparison and is usable for both TurboFan and Ignition (and soon for the generic CompareIC case too). The stub is not fully optimized yet, i.e. we still go to the runtime for string comparisons, but that'll be addressed in a follow-up CL. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1753173003 Cr-Commit-Position: refs/heads/master@{#34423}
-
yangguo authored
The function literal consists of a list of statements. Each statement is associated with a statement position including break location. The only exception to this rule is when the function immediately throws if scope resolution found an illegal redeclaration. Make sure that we add a break location for this case as well. The debugger relies on this. R=bmeurer@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Review URL: https://codereview.chromium.org/1759603002 Cr-Commit-Position: refs/heads/master@{#34422}
-
jochen authored
R=danno@chromium.org,rschoen@chromium.org,seththompson@chromium.org BUG= NOTRY=true Review URL: https://codereview.chromium.org/1754723002 Cr-Commit-Position: refs/heads/master@{#34421}
-
zhengxing.li authored
port dbf5fffd (r34397) original commit message: In ia32 PushArgsAndConstruct builtin, we run out of registers and need to temporarily store the data in the stack. In the earlier implementation, a location outside the esp was used. This causes a problem if there is a interrupt/signals which would use the same stack and corrupt the data that is above the esp. This cl fixes it by pushing it onto the stack so that the stack pointer is updated and hence the corruption will not happen. We reuse the slot meant for receiver as a temporary store. BUG= Review URL: https://codereview.chromium.org/1756743002 Cr-Commit-Position: refs/heads/master@{#34420}
-
machenbach authored
Revert of [api] Don't go to javascript to construct API functions (patchset #3 id:40001 of https://codereview.chromium.org/1756433002/ ) Reason for revert: [Sheriff] Breaks webkit unittests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5043 Original issue's description: > [api] Don't go to javascript to construct API functions > > BUG= > R=bmeurer@chromium.org,verwaest@chromium.org > > Committed: https://crrev.com/21a5bfbd2ced6e4a3545bbde712630c0d8734c0b > Cr-Commit-Position: refs/heads/master@{#34411} TBR=bmeurer@chromium.org,verwaest@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1758623002 Cr-Commit-Position: refs/heads/master@{#34419}
-
v8-autoroll authored
Rolling v8/tools/clang to a8288b3f25cdc4e3c3f4dd7ea2f7765ae8847459 Rolling v8/tools/swarming_client to df6e95e7669883c8fe9ef956c69a544154701a49 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1753133002 Cr-Commit-Position: refs/heads/master@{#34418}
-
sergeyv authored
blink-side cl: https://codereview.chromium.org/1653053002/ BUG=327092 LOG=Y Review URL: https://codereview.chromium.org/1653083002 Cr-Commit-Position: refs/heads/master@{#34417}
-
rmcilroy authored
Add support to log source position offsets to the profiler. As part of this change PositionsRecorder is split into two, with the subset needed by log.cc moved into log.h and the remainder kept in assembler.h as AssemblerPositionsRecorder. The interpreter's source position table builder is updated to log positions when the profiler is active. BUG=v8:4766 LOG=N Review URL: https://codereview.chromium.org/1737043002 Cr-Commit-Position: refs/heads/master@{#34416}
-
bradnelson authored
Fixing a memory leak in CompileAndRunModule. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=wasm-fuzzer R=jochen@chromium.org,jarin@chromium.org,kcc@chromium.org,machenbach@chromium.org,titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1738943004 Cr-Commit-Position: refs/heads/master@{#34415}
-
- 01 Mar, 2016 31 commits
-
-
titzer authored
This is a reland of: http://crrev.com/1746063003 R=binji@chromium.org,ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1752103002 Cr-Commit-Position: refs/heads/master@{#34414}
-
binji authored
This will be used for generating the Atomics builtins. BUG=v8:4614 R=jarin@chromium.org LOG=y Review URL: https://codereview.chromium.org/1705073005 Cr-Commit-Position: refs/heads/master@{#34413}
-
fmeawad authored
This should land after the chromium CL that starts using the new AddTraceEvent lands (https://codereview.chromium.org/1742603004/) BUG=4565 LOG=N Review URL: https://codereview.chromium.org/1744733002 Cr-Commit-Position: refs/heads/master@{#34412}
-
jochen authored
BUG= R=bmeurer@chromium.org,verwaest@chromium.org Review URL: https://codereview.chromium.org/1756433002 Cr-Commit-Position: refs/heads/master@{#34411}
-
oth authored
Marks additional generator tests as failing. BUG=V8:4680 LOG=N Review URL: https://codereview.chromium.org/1744353003 Cr-Commit-Position: refs/heads/master@{#34410}
-
yangguo authored
R=vogelheim@chromium.org BUG=v8:4690,v8:4765 LOG=N Review URL: https://codereview.chromium.org/1751873003 Cr-Commit-Position: refs/heads/master@{#34409}
-
yangguo authored
TBR=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1755813002 Cr-Commit-Position: refs/heads/master@{#34408}
-
machenbach authored
Revert of [wasm] Add support for 64-bit LEB encodings. (patchset #6 id:100001 of https://codereview.chromium.org/1746063003/ ) Reason for revert: [Sheriff] Seems to break chromium win compile: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/3800/steps/compile/logs/stdio Original issue's description: > [wasm] Add support for 64-bit LEB encodings. > > R=binji@chromium.org,ahaas@chromium.org > BUG= > > Committed: https://crrev.com/616f05496e9867cfa934098a76826cfde7feeaa2 > Cr-Commit-Position: refs/heads/master@{#34406} TBR=ahaas@chromium.org,binji@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1749343002 Cr-Commit-Position: refs/heads/master@{#34407}
-
titzer authored
R=binji@chromium.org,ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1746063003 Cr-Commit-Position: refs/heads/master@{#34406}
-
verwaest authored
e.g., for (var k in o) { if (!o.hasOwnProperty(k)) continue; ... } without enumerable properties on the prototype chain of o. BUG= Committed: https://crrev.com/dec80752eb344dfeb85588e61ac0afd22b11aadb Cr-Commit-Position: refs/heads/master@{#34379} Review URL: https://codereview.chromium.org/1742253002 Cr-Commit-Position: refs/heads/master@{#34405}
-
bradnelson authored
BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Review URL: https://codereview.chromium.org/1749233002 Cr-Commit-Position: refs/heads/master@{#34404}
-
oth authored
Fixes a bug in the constant pool padding calculation. BUG=v8:4680 LOG=N Review URL: https://codereview.chromium.org/1749853002 Cr-Commit-Position: refs/heads/master@{#34403}
-
jochen authored
This means we can't cache templates that have object properties. Disable caching for those. BUG= R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1753643002 Cr-Commit-Position: refs/heads/master@{#34402}
-
littledan authored
Runtime asserts are were previously a bit annoying to debug, due to the lack of a useful error message, even in debug mode. This patch prints out some more information in debug mode for runtime assert failures while preserving their exception-throwing semantics. While we're at it, it requires a semicolon after RUNTIME_ASSERT macro invocations. ``` $ rlwrap out/Debug/d8 --allow-natives-syntax V8 version 5.1.0 (candidate) d8> %ArrayBufferNeuter(1) # # Runtime error in ../../src/runtime/runtime-typedarray.cc, line 52 # # args[0]->IsJSArrayBuffer() ==== C stack trace =============================== 1: 0xf70ab5 2: 0xadeebf 3: 0xadedd4 4: 0x2ef17630693b (d8):1: illegal access %ArrayBufferNeuter(1) ^ d8> ``` Also give the other 'illegal access' case (a special SyntaxError type) a more descriptive error message for its sole usage. R=adamk Review URL: https://codereview.chromium.org/1748183002 Cr-Commit-Position: refs/heads/master@{#34401}
-
joransiu authored
Initial implementation of S390 specific debug and IC functions. R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1743263003 Cr-Commit-Position: refs/heads/master@{#34400}
-
caitpotter88 authored
BUG=v8:4663, v8:4725 LOG=N R=littledan@chromium.org, adamk@chromium.org Review URL: https://codereview.chromium.org/1744193002 Cr-Commit-Position: refs/heads/master@{#34399}
-
mstarzinger authored
R=bmeurer@chromium.org BUG=v8:3956 LOG=n Review URL: https://codereview.chromium.org/1731063007 Cr-Commit-Position: refs/heads/master@{#34398}
-
mythria authored
In ia32 PushArgsAndConstruct builtin, we run out of registers and need to temporarily store the data in the stack. In the earlier implementation, a location outside the esp was used. This causes a problem if there is a interrupt/signals which would use the same stack and corrupt the data that is above the esp. This cl fixes it by pushing it onto the stack so that the stack pointer is updated and hence the corruption will not happen. We reuse the slot meant for receiver as a temporary store. TBR=rmcilroy@chromium.org BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1750373002 Cr-Commit-Position: refs/heads/master@{#34397}
-
jkummerow authored
When we try to optimize a function with Crankshaft, but compilation bails out, don't disable optimization for that function entirely, just disable Crankshaft, so TurboFan will be used for the next attempt. Thereby this widens the TurboFan intake valve. Review URL: https://codereview.chromium.org/1751873002 Cr-Commit-Position: refs/heads/master@{#34396}
-
yangguo authored
R=rossberg@chromium.org, ulan@chromium.org, vogelheim@chromium.org Review URL: https://codereview.chromium.org/1751863002 Cr-Commit-Position: refs/heads/master@{#34395}
-
yangguo authored
R=mstarzinger@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Review URL: https://codereview.chromium.org/1748343003 Cr-Commit-Position: refs/heads/master@{#34394}
-
mythria authored
Adds the translation from optimized frame to bytecode offset in FrameSummary. For interpreter, the bailout id represents the bytecode array offset. So we can directly use the bailout id as the code offset in the FrameSummary. Also updates mjsunit.status with more information about failing tests. BUG=v8:4280, v8:4689 LOG=N Review URL: https://codereview.chromium.org/1740753002 Cr-Commit-Position: refs/heads/master@{#34393}
-
nikolaos authored
The preparser should ignore "use strong" if the --strong_mode flag is not turned on, but this should not stop processing subsequent directives. R=rossberg@chromium.org BUG= LOG=N Review URL: https://codereview.chromium.org/1752753002 Cr-Commit-Position: refs/heads/master@{#34392}
-
bmeurer authored
Similar to fullcodegen, Ignition now also marks a for-in statement as slow (via the TypeFeedbackVector) when we have to call %ForInFilter, i.e. we either have no enumeration cache or the receiver map changes during an iteration of the for-in map. R=mstarzinger@chromium.org BUG=v8:3650 LOG=n Review URL: https://codereview.chromium.org/1755563002 Cr-Commit-Position: refs/heads/master@{#34391}
-
Jochen Eisinger authored
BUG= R=yangguo@chromium.org, machenbach@chromium.org Review URL: https://codereview.chromium.org/1748393002 . Cr-Commit-Position: refs/heads/master@{#34390}
-
yangguo authored
R=rmcilroy@chromium.org BUG=v8:4680 LOG=N Review URL: https://codereview.chromium.org/1750573002 Cr-Commit-Position: refs/heads/master@{#34389}
-
yangguo authored
We used to emit debug break location on block entry. This cannot be ported to the interpreted as we do not emit bytecode for block entry. This made no sense to begin with though, but accidentally added break locations for var declarations. With this change, the debugger no longer breaks at var declarations without initialization. This is in accordance with the fact that the interpreter does not emit bytecode for uninitialized var declarations. Also fix the bytecode to match full-codegen's behavior wrt return positions: - there is a break location before the return statement, with the source position of the return statement. - right before the actual return, there is another break location. The source position points to the end of the function. R=rmcilroy@chromium.org, vogelheim@chromium.org TBR=rossberg@chromium.org BUG=v8:4690 LOG=N Review URL: https://codereview.chromium.org/1744123003 Cr-Commit-Position: refs/heads/master@{#34388}
-
neis authored
We must not use for-of since that could be observed. R=yangguo@chromium.org BUG=v8:4769 LOG=n Review URL: https://codereview.chromium.org/1748633002 Cr-Commit-Position: refs/heads/master@{#34387}
-
neis authored
ArrayIteratorPrototype must not provide Symbol.iterator. R=rossberg BUG= Review URL: https://codereview.chromium.org/1749093002 Cr-Commit-Position: refs/heads/master@{#34386}
-
ssanfilippo authored
Runtime errors will be suppressed in --rebaseline mode, unless the --verbose flag is passed. The reasoning behind (rebaseline && !verbose) and not just (verbose) is to suppress harmless noise while updating the expectation for existing, known good snippets, without hiding actually relevant errors when the tool is used to write new expectation files. In fact, some tests are supposed to produce a runtime error, which might nevertheless alarm a developer who is just --rebaseline'ing. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1742723003 Cr-Commit-Position: refs/heads/master@{#34385}
-
neis authored
The for-of-finalization CL incorrectly removed the input argument from BuildIteratorClose. I'm reverting this, adding a regression test, and fixing an existing test that was wrong. BUG= R=rossberg Review URL: https://codereview.chromium.org/1750543002 Cr-Commit-Position: refs/heads/master@{#34384}
-