Commit 21622dda authored by yangguo's avatar yangguo Committed by Commit bot

[debugger, interpreter] add break location at if-statement.

R=mstarzinger@chromium.org, vogelheim@chromium.org
BUG=v8:4690
LOG=N

Review URL: https://codereview.chromium.org/1748343003

Cr-Commit-Position: refs/heads/master@{#34394}
parent 844e410d
......@@ -833,6 +833,7 @@ void BytecodeGenerator::VisitEmptyStatement(EmptyStatement* stmt) {
void BytecodeGenerator::VisitIfStatement(IfStatement* stmt) {
builder()->SetStatementPosition(stmt);
BytecodeLabel else_label, end_label;
if (stmt->condition()->ToBooleanIsTrue()) {
// Generate then block unconditionally as always true.
......
......@@ -504,7 +504,6 @@
# TODO(yangguo,4690): Test failures in debugger tests.
'test-debug/DebugStepKeyedLoadLoop': [FAIL],
'test-debug/DebugStepKeyedStoreLoop': [FAIL],
'test-debug/DebugStepIf': [FAIL],
'test-debug/DebugStepNamedLoadLoop': [FAIL],
'test-debug/BreakPointConstructCallWithGC': [PASS, FAIL],
'test-debug/DebugStepNamedStoreLoop': [FAIL],
......@@ -517,9 +516,6 @@
'test-debug/DebugConditional': [FAIL],
'test-debug/DebugStepForBreak': [FAIL],
'test-debug/DebugStepWith': [FAIL],
'test-debug/DebugStepFunctionApply': [FAIL],
'test-debug/StepInOutBranch': [FAIL],
'test-debug/DebugStepFunctionCall': [FAIL],
# BUG(4333). Function name inferrer does not work for ES6 clases.
'test-func-name-inference/UpperCaseClass': [TIMEOUT],
......
......@@ -800,7 +800,6 @@
# TODO(yangguo,4690): Check failure in debug.cc BreakLocation::SetBreakPoint
# DCHECK(IsDebugBreak() || IsDebuggerStatement());
'regress/regress-1523': [FAIL],
'regress/regress-crbug-119800': [FAIL],
'regress/regress-crbug-467180': [FAIL],
'regress/regress-opt-after-debug-deopt': [FAIL],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment