• mythria's avatar
    [Interpreter] Fixes PushArgsAndConstruct builtin to not store any data outside esp. · dbf5fffd
    mythria authored
    In ia32 PushArgsAndConstruct builtin, we run out of registers and need to
    temporarily store the data in the stack. In the earlier implementation,
    a location outside the esp was used. This causes a problem if there is a
    interrupt/signals which would use the same stack and corrupt the data that
    is above the esp. This cl fixes it by pushing it onto the stack so that
    the stack pointer is updated and hence the corruption will not happen. We
    reuse the slot meant for receiver as a temporary store.
    
    TBR=rmcilroy@chromium.org
    BUG=v8:4280
    LOG=N
    
    Review URL: https://codereview.chromium.org/1750373002
    
    Cr-Commit-Position: refs/heads/master@{#34397}
    dbf5fffd
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...