- 27 Apr, 2020 1 commit
-
-
Clemens Backes authored
The category name changed in https://crrev.com/c/2159690 (in depot_tools), hence presubmit tests start failing whenever someone touches a file which still refers to the old category. R=zhin@chromium.org TBR=machenbach@chromium.org No-Try: true No-Tree-Checks: true Change-Id: I62813a42d63e512d421c4fe94229d04a56056978 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2165760Reviewed-by: Zhi An Ng <zhin@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67403}
-
- 18 Dec, 2019 1 commit
-
-
Sigurd Schneider authored
This CL adds an argument to the heap profiler that allows to control whether global objects (e.g. 'window' in JavaScript) are treated as roots in the heap snapshot. Doing so hides blink-internal details and is often a good choice when user-JS leaks are investigated. Sometimes, however, this introduces spurious retainer cycles, which are hard to debug. Previously, this option was exposed as a V8 flag. The blink implications of the build-time V8 flag are now available via the new blink flag `enable_additional_blink_object_names`. Tbr: hpayer@chromium.org Bug: chromium:1034504 Change-Id: Ibe9412917ae598a3ff0c3dc956ab0bc179f50a21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967387Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#65491}
-
- 27 Nov, 2019 1 commit
-
-
Peter Marshall authored
Deprecated in 79. Change-Id: If0e2b95b4b66328858b33a533454a469c80fad63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940147 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#65204}
-
- 09 Oct, 2019 1 commit
-
-
Clemens Backes authored
Since C++14, there is a spec'ed attribute for deprecation of methods, functions, types, aliases or anything else. This CL switches from the GCC __attribute__ to this standard attribute. This allows to use the V8_DEPRECATED and V8_DEPRECATE_SOON macros on anything where the standard attribute can be used (including {using} statements that were not working before). It also avoids the need to nest the whole declaration in the macro, making the code more readable. R=adamk@chromium.org Bug: v8:9810 Change-Id: I7adab7694af75423fb31ade2fc982dbf9c9bc699 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847361Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64174}
-
- 24 Sep, 2019 1 commit
-
-
Matheus Marchini authored
Also report code relocation events through the public CodeEventHandler API, so that embedders can expose this information to external profilers, allowing those profilers to correctly translate function names even after they were relocated. R=bmeurer@chromium.org, jgruber@chromium.org, yangguo@chromium.org Change-Id: I8795186f5f5c58ede9054e4b83e2d290d92b6e00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1802657Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#63943}
-
- 16 Sep, 2019 1 commit
-
-
Peter Marshall authored
Remove CollectSample() and SetIdle(), advance deprecation of GetCallUid() Change-Id: Idb8c4f4d14bc5318a430e3549aaff7a41a911557 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1805641Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#63805}
-
- 13 Sep, 2019 1 commit
-
-
Clemens Hammacher authored
After https://crrev.com/c/1800575 and https://crrev.com/c/1803343, which tried to fix this on occuring compile errors, this CL systematically adds the <memory> include to each header that uses {std::unique_ptr}. R=sigurds@chromium.org TBR=mlippautz@chromium.org,alph@chromium.org,rmcilroy@chromium.org,verwaest@chromium.org Bug: v8:9396 Change-Id: If7f9c3140842f9543135dddd7344c0f357999da0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803349Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#63767}
-
- 22 Aug, 2019 1 commit
-
-
Peter Marshall authored
We have internal::TickSample which inherits from this, but we never use the public version in the API despite defining it there. Change-Id: I6f0ce7ee663ef821be57cfbad540c1660484a525 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1745472 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63329}
-
- 20 Aug, 2019 1 commit
-
-
Andrew Comminos authored
Adds support to the CPU profiler for scraping the incumbent contexts of V8 stack frames. While it is generally unsafe to access heap objects during a profiling interrupt, the native context is uniquely usable due to being guaranteed an alive root on the stack, as well as its slots being immutable after context creation. Change-Id: I2c3149c1302b74d2f13aa99d1fdd0cf006e0f9d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1580020 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#63258}
-
- 09 Aug, 2019 1 commit
-
-
Michael Lippautz authored
- Adds regular native heap entries to the HeapObjectsMap. - Adds a side map for keeping a mapping of native objects to their canonical heap entry that they have been merged into. Change-Id: Ida00628126ded1948ceb2a0cbe14da817af7f361 Bug: chromium:988350 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1720810 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#63140}
-
- 26 Jul, 2019 1 commit
-
-
Andrew Comminos authored
Implements ProfilerCodeObserver, a class to track the generation and movement of code on the heap for the lifetime of each CpuProfiler. When sampling is inactive, logged code is committed directly to the CodeMap. During profiling, ProfilerCodeObserver redirects these events onto the profiling thread for later dispatch. Bug: v8:9151 Change-Id: Ib5b152446d2a3838e1b00a80253fc4fbd2f6e8c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1604143Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#62943}
-
- 22 May, 2019 1 commit
-
-
Andrew Comminos authored
Now that we support a max_samples parameter, it isn't actually necessary to have a record_samples flag (as it can just be modeled by 0). Change-Id: I578ecc9f6ee73ecbe1f93d0d04ee8028a9a2716d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1611015 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61717}
-
- 15 May, 2019 1 commit
-
-
Andrew Comminos authored
Permit individual calls to CpuProfiler::StartSampling to provide their own requested sampling interval, to be snapped to the profiler's sampling interval. Use the greatest common divisor of all sample rates to determine what sample rate should be chosen for the sampling thread, and dispatch samples to attached profilers based on their requested sample periodicity. Change-Id: I0b076d09761d7176f31725e112578b68ab5da54c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1484461Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#61548}
-
- 13 May, 2019 1 commit
-
-
gengjiawen authored
Effective Modern C++ Items 11: Prefer deleted functions to private undefined ones Change-Id: I35c6277fcc77c60fc0a3d904763039c916d62b78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1608325Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61433}
-
- 10 May, 2019 1 commit
-
-
Andrew Comminos authored
Helps make configuring profilers more scalable as our number of parameters grows. Change-Id: I81263a30c221edaa3934a92eb000b71ddfbdea60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601585Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#61402}
-
- 08 May, 2019 1 commit
-
-
Andrew Comminos authored
To prevent OOMs for leaked CPU profilers, add the option to limit the maximum number of samples that are included in a CPU profile. Bug: chromium:956688 Change-Id: I119d0622e7d39c187f8e09e2d49dec91fd724ecb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588412 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61352}
-
- 25 Apr, 2019 1 commit
-
-
Andrew Comminos authored
Adds a new flag to CpuProfiler to control whether or not "debug" names (potentially inferred from scope) are used for captured frames associated with a SharedFunctionInfo instance. Bug: v8:9135 Change-Id: Ia1db20e389f3d0beb60eb47798820fb11d501c88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1583042 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#61015}
-
- 24 Apr, 2019 2 commits
-
-
Sigurd Schneider authored
This reverts commit fa6ec3cb. Reason for revert: v8:9169, v8:9170 https://ci.chromium.org/p/v8/builders/ci/V8%20Linux/31457 https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64/31417 https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20debug/19919 Original change's description: > [cpu-profiler] Split out debug mode for CPU profiler naming > > Adds a new flag to CpuProfiler to control whether or not "debug" names > (potentially inferred from scope) are used for captured frames > associated with a SharedFunctionInfo instance. > > Bug: v8:9135 > Change-Id: I104f3246431dc6336de4e4688c0d98c86e0bb776 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566169 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60972} TBR=ulan@chromium.org,alph@chromium.org,yangguo@chromium.org,petermarshall@chromium.org,acomminos@fb.com Change-Id: I573194b5affd31fd0748b9ef3c45052e8ab420f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9135 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581639Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60973}
-
Andrew Comminos authored
Adds a new flag to CpuProfiler to control whether or not "debug" names (potentially inferred from scope) are used for captured frames associated with a SharedFunctionInfo instance. Bug: v8:9135 Change-Id: I104f3246431dc6336de4e4688c0d98c86e0bb776 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566169Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#60972}
-
- 16 Apr, 2019 1 commit
-
-
Andrew Comminos authored
Adds CpuProfiler::SetUsePreciseSampling, which provides a hint whether to sacrifice CPU cycles to reduce the level of sampling interval variance. On Windows, this controls whether or not busy waiting is performed for sample rates < 100ms. Defaults to enabled (old behaviour). Bug: v8:3967 Change-Id: Iee84c3ae8132541c78b1f78bf294ec7c718bb19b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510577 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60866}
-
- 03 Apr, 2019 1 commit
-
-
Andrew Comminos authored
Adds the notion of a "source type" to CpuProfileNode instances, hinting at the underlying source of the function or state that resulted in the generation of the node. Bug: v8:9001 Change-Id: Ie14c54d41b99eb02f54b423fa5d939e9d7f63785 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510576 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#60590}
-
- 26 Mar, 2019 1 commit
-
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: Ieeec2b237b0531a84ea71dc53d24444c3425dda7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538130Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60456}
-
- 18 Mar, 2019 1 commit
-
-
Andrew Comminos authored
Consumers can use this to derive the full stack from sampled leaf nodes without having to flatten the tree. Bug: v8:8999 Change-Id: I42c638dd2c757837b0c03514c204be0182653291 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525877Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#60309}
-
- 13 Mar, 2019 1 commit
-
-
Andrew Comminos authored
Enable cross-origin frame filtering by exposing this bit from ScriptOriginOptions. Bug: v8:8956 Change-Id: I109eec9db8b3d42d68d32abc5edd437b1c91a9b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1493294 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#60205}
-
- 09 Mar, 2019 1 commit
-
-
Anna Henningsen authored
This should not be used anymore (and it definitely is not by Node.js or Chromium). Change-Id: I4a1ce1fda98efd197a64ce0969dae5c8b18f6e97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511484Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#60139}
-
- 24 Jan, 2019 1 commit
-
-
Ulan Degenbaev authored
Bug: chromium:749490 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I4ae6883dd5ed5f313e21af20c29e560c73c33675 Reviewed-on: https://chromium-review.googlesource.com/c/948903 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#59076}
-
- 09 Nov, 2018 1 commit
-
-
Yang Guo authored
This allows Node.js to enable detailed source positions for optimized code early on, without having to pass a flag string. R=petermarshall@chromium.org Change-Id: Ie74ea41f600cf6e31acbe802116df4976ccf1c75 Reviewed-on: https://chromium-review.googlesource.com/c/1319757 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#57380}
-
- 18 Oct, 2018 1 commit
-
-
Alexei Filippov authored
Make heap profiler provide information about each sample currently alive. That information can be used to build diagrams of memory allocations over time. BUG=chromium:889545 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ibcbe2f5302263d0b3976ee4cd3601eff11375cae Reviewed-on: https://chromium-review.googlesource.com/c/1285130 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#56793}
-
- 20 Sep, 2018 1 commit
-
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ibc5124e06f5774e7695029e2d21084a7efb965e6 Reviewed-on: https://chromium-review.googlesource.com/1224412 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#56065}
-
- 14 Sep, 2018 1 commit
-
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I4f9eb0fedbe1d35a571f3d5b111705a820edfb5b Reviewed-on: https://chromium-review.googlesource.com/1224377 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55905}
-
- 17 Aug, 2018 1 commit
-
-
Alexei Filippov authored
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I99b98fc131e90788902662e6cb837d93168c93fc Reviewed-on: https://chromium-review.googlesource.com/1169921Reviewed-by: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#55198}
-
- 06 Aug, 2018 1 commit
-
-
Anna Henningsen authored
This is not used in Chrome or Node anymore. (This could also potentially be just removed at this point.) Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I59ecc216faeb3d56d3a52c548a863544570b6173 Reviewed-on: https://chromium-review.googlesource.com/1161936 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54913}
-
- 12 Jul, 2018 1 commit
-
-
Joyee Cheung authored
This patch adds a variant of EmbedderGraph::AddEdge() which allows the embedder to specify the name of an edge. The edges added without name are element edges with auto-incremented indexes while the edges added with names will be internal edges with the specified names for more meaningful output in the heap snapshot. Refs: https://github.com/nodejs/node/pull/21741 Bug: v8:7938 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I8feefa2cf6911743e24b3b2024e0e849b0c65cd3 Reviewed-on: https://chromium-review.googlesource.com/1133299 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54412}
-
- 06 Jun, 2018 1 commit
-
-
Anna Henningsen authored
`SetBuildEmbedderGraphCallback`, unlike `SetWrapperClassInfoProvider`, assumes a monolithic embedder that can provide all necessary information. That is not the case for e.g. Node.js, which can e.g. provide multiple Node.js instances per V8 Isolate, as well as native addons that may allocate resources on their own. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib53dfde82416dd69934b08623e27d674a483ac2d Reviewed-on: https://chromium-review.googlesource.com/1082441 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53545}
-
- 31 May, 2018 1 commit
-
-
Alexei Filippov authored
It is created automatically for each isolate. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: If366becb2fe4c02b150cbbe9a2d425f4de63687b Reviewed-on: https://chromium-review.googlesource.com/1079900Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#53465}
-
- 28 May, 2018 1 commit
-
-
Yang Guo authored
Introduce a new public API called CodeEventListener to allow embedders to better support external profilers and other diagnostic tools without relying on unsupported methods like --perf-basic-prof. Bug: v8:7694 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I063cc965394d59401358757634c9ea84c11517e9 Co-authored-by: Daniel Beckert <daniel@sthima.com.br> Reviewed-on: https://chromium-review.googlesource.com/1028770 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#53382}
-
- 23 May, 2018 1 commit
-
-
Peter Marshall authored
The current profiling mode (called kLeafNodeLineNumbers in this CL) produces a tree, with each node representing a stack frame that is seen in one or more samples taken during profiling. These nodes refer to a particular function in a stack trace, but not to a particular line or callsite within that function. This CL adds a new more (called kCallerLineNumbers) which produces a different profile tree, where each stack trace seen during profiling, including the line number, has a unique path in the tree. The profile tree was previously keyed on CodeEntry*. Now it is keyed on the pair of CodeEntry* and line_number, meaning it has distinct nodes for those combinations which exist, and each distinct stack trace that was sampled is represented in the tree. For optimized code where we have inline frames, there are no line numbers for the inline frames in the stack trace, causing duplicate branches in the tree with kNoLineNumberInfo as the reported line number. This will be addressed in follow-ups. Bug: v8:7018 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I512e221508f5b50ec028306d212263b514a9fb24 Reviewed-on: https://chromium-review.googlesource.com/1013493 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53298}
-
- 11 Apr, 2018 1 commit
-
-
Alexei Filippov authored
Previously embedder had to create an instance of TracingCpuProfiler explicitly. The patch makes the profiler created automatically for every isolate. The profiler has no overhead unless tracing with v8.cpu_profiler category is enabled. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I9369c2c56bcddc72093eda33dc2bc185c9253b4a Reviewed-on: https://chromium-review.googlesource.com/1006049 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52552}
-
- 20 Mar, 2018 2 commits
-
-
Ulan Degenbaev authored
The embedders should use the EmbedderGraph API. The similar structure can be created with the following steps: 1) Create a root node for each retainer info group. 2) Iterate all handles using Isolate::VisitHandlesWithClassIds. 3) Add an edge from the retainer info node to the v8 wrapper node. 4) Add an edge from the v8 wrapper node to the retainer info node. See how HeapSnapshotRetainedObjectInfo is converted to the new API. Bug: chromium:749490 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I124ae3853354863b4f888e6aa2ea13777dcaa37d Reviewed-on: https://chromium-review.googlesource.com/948842 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#52067}
-
Ulan Degenbaev authored
The embedders should use the new EmbedderGraph API to provide retainer info. Bug: chromium:749490 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Iac8dc1e749ef14277b027f43e799357c5bd413ea Reviewed-on: https://chromium-review.googlesource.com/948489 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#52059}
-