Commit 99268b15 authored by Peter Marshall's avatar Peter Marshall Committed by Commit Bot

[cpu-profiler] Remove deprecated GetCallUid()

Deprecated in 79.

Change-Id: If0e2b95b4b66328858b33a533454a469c80fad63
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940147
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65204}
parent 90cf2b83
......@@ -144,10 +144,6 @@ class V8_EXPORT CpuProfileNode {
*/
unsigned GetHitCount() const;
/** Returns function entry UID. */
V8_DEPRECATED("Use GetScriptId, GetLineNumber, and GetColumnNumber instead.")
unsigned GetCallUid() const;
/** Returns id of the node. The id is unique within the tree */
unsigned GetNodeId() const;
......
......@@ -10188,10 +10188,6 @@ unsigned CpuProfileNode::GetHitCount() const {
return reinterpret_cast<const i::ProfileNode*>(this)->self_ticks();
}
unsigned CpuProfileNode::GetCallUid() const {
return reinterpret_cast<const i::ProfileNode*>(this)->function_id();
}
unsigned CpuProfileNode::GetNodeId() const {
return reinterpret_cast<const i::ProfileNode*>(this)->id();
}
......
......@@ -46,10 +46,6 @@ ProfileNode::ProfileNode(ProfileTree* tree, CodeEntry* entry,
tree_->EnqueueNode(this);
}
inline unsigned ProfileNode::function_id() const {
return tree_->GetFunctionId(this);
}
inline CpuProfileNode::SourceType ProfileNode::source_type() const {
// Handle metadata and VM state code entry types.
if (entry_ == CodeEntry::program_entry() ||
......
......@@ -371,24 +371,13 @@ class DeleteNodesCallback {
ProfileTree::ProfileTree(Isolate* isolate)
: next_node_id_(1),
root_(new ProfileNode(this, CodeEntry::root_entry(), nullptr)),
isolate_(isolate),
next_function_id_(1) {}
isolate_(isolate) {}
ProfileTree::~ProfileTree() {
DeleteNodesCallback cb;
TraverseDepthFirst(&cb);
}
unsigned ProfileTree::GetFunctionId(const ProfileNode* node) {
CodeEntry* code_entry = node->entry();
auto map_entry = function_ids_.find(code_entry);
if (map_entry == function_ids_.end()) {
return function_ids_[code_entry] = next_function_id_++;
}
return function_ids_[code_entry];
}
ProfileNode* ProfileTree::AddPathFromEnd(const std::vector<CodeEntry*>& path,
int src_line, bool update_stats) {
ProfileNode* node = root_;
......
......@@ -284,7 +284,6 @@ class V8_EXPORT_PRIVATE ProfileNode {
unsigned self_ticks() const { return self_ticks_; }
const std::vector<ProfileNode*>* children() const { return &children_list_; }
unsigned id() const { return id_; }
unsigned function_id() const;
ProfileNode* parent() const { return parent_; }
int line_number() const {
return line_number_ != 0 ? line_number_ : entry_->line_number();
......@@ -354,7 +353,6 @@ class V8_EXPORT_PRIVATE ProfileTree {
ContextFilter* context_filter = nullptr);
ProfileNode* root() const { return root_; }
unsigned next_node_id() { return next_node_id_++; }
unsigned GetFunctionId(const ProfileNode* node);
void Print() {
root_->Print(0);
......@@ -378,9 +376,6 @@ class V8_EXPORT_PRIVATE ProfileTree {
ProfileNode* root_;
Isolate* isolate_;
unsigned next_function_id_;
std::unordered_map<CodeEntry*, unsigned> function_ids_;
DISALLOW_COPY_AND_ASSIGN(ProfileTree);
};
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment