Commit 8c641547 authored by Alexei Filippov's avatar Alexei Filippov Committed by Commit Bot

[profiler] Remove deprecated TracingCpuProfiler from API.

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I99b98fc131e90788902662e6cb837d93168c93fc
Reviewed-on: https://chromium-review.googlesource.com/1169921Reviewed-by: 's avatarAli Ijaz Sheikh <ofrobots@google.com>
Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55198}
parent e82f793e
......@@ -47,24 +47,6 @@ template class V8_EXPORT std::vector<v8::CpuProfileDeoptInfo>;
namespace v8 {
/**
* TracingCpuProfiler monitors tracing being enabled/disabled
* and emits CpuProfile trace events once v8.cpu_profiler tracing category
* is enabled. It has no overhead unless the category is enabled.
*/
class V8_EXPORT TracingCpuProfiler {
public:
V8_DEPRECATED(
"The profiler is created automatically with the isolate.\n"
"No need to create it explicitly.",
static std::unique_ptr<TracingCpuProfiler> Create(Isolate*));
virtual ~TracingCpuProfiler() = default;
protected:
TracingCpuProfiler() = default;
};
// TickSample captures the information collected for each sample.
struct TickSample {
// Internal profiling (with --prof + tools/$OS-tick-processor) wants to
......
......@@ -9,15 +9,6 @@
#include "src/v8.h"
namespace v8 {
std::unique_ptr<TracingCpuProfiler> TracingCpuProfiler::Create(
v8::Isolate* isolate) {
// Dummy profiler that does nothing.
// Remove it along with the deprecated code.
// The actual profiler is created by the isolate itself.
return std::unique_ptr<TracingCpuProfiler>(new TracingCpuProfiler());
}
namespace internal {
TracingCpuProfilerImpl::TracingCpuProfilerImpl(Isolate* isolate)
......
......@@ -6,7 +6,6 @@
#define V8_PROFILER_TRACING_CPU_PROFILER_H_
#include "include/v8-platform.h"
#include "include/v8-profiler.h"
#include "src/base/atomic-utils.h"
#include "src/base/macros.h"
#include "src/base/platform/mutex.h"
......@@ -18,8 +17,7 @@ class CpuProfiler;
class Isolate;
class TracingCpuProfilerImpl final
: public TracingCpuProfiler,
private v8::TracingController::TraceStateObserver {
: private v8::TracingController::TraceStateObserver {
public:
explicit TracingCpuProfilerImpl(Isolate*);
~TracingCpuProfilerImpl();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment