Commits · 46bf70a5670137535316155149c4c2b66177baa8 · Linshizhi / V8

18 Aug, 2020 3 commits

[regexp] Prototype new linear time EXPERIMENTAL regexp engine · 46bf70a5

Martin Bidlingmaier authored Aug 17, 2020

This adds the new JsRegExp::Type EXPERIMENTAL, which should eventually
be implemented with the algorithm based on automata. Currently the new
engine deals with plain search strings only, i.e. regexps that do not
contain operators or escape sequences.

R=jgruber@chromium.org

Bug: v8:10765
Change-Id: I6a10d9cdf4605d219dbe7cc1989df3bfa7349ff8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339094Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69442}

46bf70a5

[heap] Start StressConcurrentAllocatorTask through AllocationObserver · 491f9794

Dominik Inführ authored Aug 17, 2020

Starting the task right on NotifyDeserializationComplete() turned out
to be too early for some tests. So let an AllocationObserver start
the stress allocation after deserialization is finished.

Bug: v8:10315
Change-Id: I00a4294add5ec87074f9e775c602b3031cc16d58
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358735
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69441}

491f9794

Update V8 DEPS. · 7b7fbff4

v8-ci-autoroll-builder authored Aug 18, 2020

Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/939db33..13765d6

Rolling v8/third_party/aemu-linux-x64: zCy9vIuheNK--OaT_8WBj3IbVxW_RuxRLMp8KWTLqzIC..p5IjOVYEoaWHNJ28H6OKk3LlpDPCUruvOahozwiZAIgC

Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5abddab..03f5451

Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3bd3c99..5664586

Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/7492de9..d53accf

Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/361d367..7c75562

TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Idbf0b55b91374c8edda27e7ff5a2648c1747e926
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360749Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#69440}

7b7fbff4

17 Aug, 2020 29 commits

[wasm-simd] Support returning Simd128 on caller's stack · 360c9294

Ng Zhi An authored Aug 17, 2020

In Liftoff, we were missing kS128 cases to load to/from stack.

For the x64 and ARM64 instruction selector, the calculation of
reverse_slot is incorrect for 128-bit values:

- reverse_slot += 2 (size of 128-bit values, 2 pointers)
- this copies from slot -2 into register
- but the value starts at slot -1, it occupies slots -1 and -2
- we end up copying slot -2 (most significant half) of the register, and
also slot -3, which is where rsi was store (Wasm instance addr)
- the test ends up with a different result every time

The calculation of reverse_slot is changed to follow how ia32 and ARM
does it, which is to start with

- reverse_slot = 0
- in the code-generator, add 1 to the slot
- then after emitting Peek operation, reverse_slot += 2

The fixes for x64 and ARM64 are in both instruction-selector and
code-generator.

ia32 and ARM didn't support writing kSimd128 values yet, it was only a
missing check in code-generator, so add that in.

For ARM, the codegen is more involved, vld1 does not support addressing
with an offset, so we have to do the addition into a scratch register.

Also adding a test for returning multiple v128. V128 is not exposed to
JavaScript, so we use a Wasm function call, and then an involved chain
of extract lanes, returning 6 i32 which we verify the values of. It
extracts the first and last lane of the i32x4 value in order to catch
bugs where we write or read to a wrong stack slot (off by 1).

The simd-scalar-lowering for kCall was only handling single s128 return,
we adopt the way i64-lowering handles kCall, so that is can now handle
any kinds of calls with s128 in the descriptor.

Bug: v8:10794
Bug: chromium:1115230
Change-Id: I2ccdd55f6292bc5794be78053b27e14da8cce70e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2355189
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69439}

360c9294

Revert "Reland^3 "[flags] warn about contradictory flags"" · a5756085

Francis McCabe authored Aug 17, 2020

This reverts commit dc18b822.

Reason for revert: still causing failures: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/31566

Original change's description:
> Reland^3 "[flags] warn about contradictory flags"
> 
> This is a reland of 0ba115e6
> Changes:
> - Also allow second parameter influenced by --cache to be reassigned.
> - Fix --stress-opt to only --always-opt in the last iteration as before.
> 
> Original change's description:
> > Reland^2 "[flags] warn about contradictory flags"
> >
> > This is a reland of d8f8a7e2
> > Change compared to last reland:
> > - Do not check for d8 flag contradictions in the presence of --fuzzing
> > - Allow identical re-declaration of --cache=*
> >
> > Original change's description:
> > > Reland "[flags] warn about contradictory flags"
> > >
> > > This is a reland of b8f91666
> > > Difference to previous CL: Additional functionality to specify
> > > incompatible flags based on GN variables and extra-flags, used
> > > to fix the issues that came up on the waterfall.
> > >
> > > This also changes the rules regarding repeated flags: While
> > > explicitly repeated flags are allowed for boolean values as long
> > > as they are identical, repeated flags or explicit flags in the
> > > presence of an active implication are disallowed for non-boolean
> > > flags. The latter simplifies specifying conflict rules in
> > > variants.py. Otherwise a rule like
> > >
> > > INCOMPATIBLE_FLAGS_PER_EXTRA_FLAG = {
> > >   "--gc-interval=*": ["--gc-interval=*"],
> > > }
> > >
> > > wouldn't work because specifying the same GC interval twice
> > > wouldn't actually count as a conflict. This was an issue with
> > > test/mjsunit/wasm/gc-buffer.js, which specifies
> > > --gc-interval=500 exactly like the extra flag by the stress bot.
> > >
> > > Also, this now expands contradictory flags checking to d8 flags
> > > for consistency.
> > >
> > > Original change's description:
> > > > [flags] warn about contradictory flags
> > > >
> > > > Design Doc: https://docs.google.com/document/d/1lkvu8crkK7Ei39qjkPCFijpNyxWXsOktG9GB-7K34jM/
> > > >
> > > > Bug: v8:10577
> > > > Change-Id: Ib9cfdffa401c48c895bf31caed5ee03545beddab
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154792
> > > > Reviewed-by: Clemens Backes <clemensb@chromium.org>
> > > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> > > > Reviewed-by: Georg Neis <neis@chromium.org>
> > > > Reviewed-by: Tamer Tas <tmrts@chromium.org>
> > > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#68168}
> > >
> > > Bug: v8:10577
> > > Change-Id: I268e590ee18a535b13dee14eeb15ddd0a9ee8341
> > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235115
> > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> > > Reviewed-by: Tamer Tas <tmrts@chromium.org>
> > > Reviewed-by: Clemens Backes <clemensb@chromium.org>
> > > Reviewed-by: Georg Neis <neis@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#68989}
> >
> > Bug: v8:10577
> > Change-Id: I31d2794d4f9ff630f3444210100c64d67d881276
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339464
> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> > Reviewed-by: Clemens Backes <clemensb@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#69339}
> 
> Bug: v8:10577
> Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng
> Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng
> Change-Id: I4a69dc57a102782cb453144323e3752ac8278624
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352770
> Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
> Reviewed-by: Clemens Backes <clemensb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#69433}

TBR=machenbach@chromium.org,neis@chromium.org,clemensb@chromium.org,tebbi@chromium.org,tmrts@chromium.org

Change-Id: I4ccdd7b931d0ddccbcec1d6cfae8d4874ee49cfc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:10577
Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng
Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360414Reviewed-by: Francis McCabe <fgm@chromium.org>
Commit-Queue: Francis McCabe <fgm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69438}

a5756085

Revert "[csa][cleanup] Remove ParameterMode/TNodify IntPtrOrSmiConstant" · 7a5d72d3

Francis McCabe authored Aug 17, 2020

This reverts commit 0fe7a6cf.

Reason for revert: Causing tree to fail: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/31566

Original change's description:
> [csa][cleanup] Remove ParameterMode/TNodify IntPtrOrSmiConstant
> 
> Bug: v8:9708, v8:6949
> Change-Id: I0a17eab689d8297218af92658bf5e63d34c94dfc
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2356387
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#69435}

TBR=rmcilroy@chromium.org,solanes@chromium.org

Change-Id: Ie816bffee696bb03cf26e195405f0fe8509dd0f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:9708
Bug: v8:6949
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360048Reviewed-by: Francis McCabe <fgm@chromium.org>
Commit-Queue: Francis McCabe <fgm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69437}

7a5d72d3

[csa][cleanup] Remove ParameterMode versions of parameter casting · 4ca68db1

Santiago Aboy Solanes authored Aug 14, 2020

Removed all uses of ParameterToTagged and TaggedToParameter but
forgot to remove the method themselves.

Bug: v8:9708, v8:6949
Change-Id: I8718a0739ce81ca42546125fac765618e0208cb2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2356388Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69436}

4ca68db1

[csa][cleanup] Remove ParameterMode/TNodify IntPtrOrSmiConstant · 0fe7a6cf

Santiago Aboy Solanes authored Aug 14, 2020

Bug: v8:9708, v8:6949
Change-Id: I0a17eab689d8297218af92658bf5e63d34c94dfc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2356387Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69435}

0fe7a6cf

[Atomics.waitAsync] Fix a potential deadlock situation · 615a355e

Marja Hölttä authored Aug 17, 2020

The deadlock occurs because of cyclical "first mutex1, then mutex2"
mutex locking patterns between 3 mutexes: the futex-emulation mutex, the
gc mutex and the isolate break_access mutex.

The fix is to not allocate memory while holding the futex-emulation
mutex. This breaks the cycle.

Bug: v8:10239, v8:10800
Change-Id: Ifbb693549a28db11d8affc56de0bbed3ef0dd701
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2356345Reviewed-by: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69434}

615a355e

Reland^3 "[flags] warn about contradictory flags" · dc18b822

Tobias Tebbi authored Aug 17, 2020

This is a reland of 0ba115e6
Changes:
- Also allow second parameter influenced by --cache to be reassigned.
- Fix --stress-opt to only --always-opt in the last iteration as before.

Original change's description:
> Reland^2 "[flags] warn about contradictory flags"
>
> This is a reland of d8f8a7e2
> Change compared to last reland:
> - Do not check for d8 flag contradictions in the presence of --fuzzing
> - Allow identical re-declaration of --cache=*
>
> Original change's description:
> > Reland "[flags] warn about contradictory flags"
> >
> > This is a reland of b8f91666
> > Difference to previous CL: Additional functionality to specify
> > incompatible flags based on GN variables and extra-flags, used
> > to fix the issues that came up on the waterfall.
> >
> > This also changes the rules regarding repeated flags: While
> > explicitly repeated flags are allowed for boolean values as long
> > as they are identical, repeated flags or explicit flags in the
> > presence of an active implication are disallowed for non-boolean
> > flags. The latter simplifies specifying conflict rules in
> > variants.py. Otherwise a rule like
> >
> > INCOMPATIBLE_FLAGS_PER_EXTRA_FLAG = {
> >   "--gc-interval=*": ["--gc-interval=*"],
> > }
> >
> > wouldn't work because specifying the same GC interval twice
> > wouldn't actually count as a conflict. This was an issue with
> > test/mjsunit/wasm/gc-buffer.js, which specifies
> > --gc-interval=500 exactly like the extra flag by the stress bot.
> >
> > Also, this now expands contradictory flags checking to d8 flags
> > for consistency.
> >
> > Original change's description:
> > > [flags] warn about contradictory flags
> > >
> > > Design Doc: https://docs.google.com/document/d/1lkvu8crkK7Ei39qjkPCFijpNyxWXsOktG9GB-7K34jM/
> > >
> > > Bug: v8:10577
> > > Change-Id: Ib9cfdffa401c48c895bf31caed5ee03545beddab
> > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154792
> > > Reviewed-by: Clemens Backes <clemensb@chromium.org>
> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> > > Reviewed-by: Georg Neis <neis@chromium.org>
> > > Reviewed-by: Tamer Tas <tmrts@chromium.org>
> > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#68168}
> >
> > Bug: v8:10577
> > Change-Id: I268e590ee18a535b13dee14eeb15ddd0a9ee8341
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235115
> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> > Reviewed-by: Tamer Tas <tmrts@chromium.org>
> > Reviewed-by: Clemens Backes <clemensb@chromium.org>
> > Reviewed-by: Georg Neis <neis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#68989}
>
> Bug: v8:10577
> Change-Id: I31d2794d4f9ff630f3444210100c64d67d881276
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339464
> Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> Reviewed-by: Clemens Backes <clemensb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#69339}

Bug: v8:10577
Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng
Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng
Change-Id: I4a69dc57a102782cb453144323e3752ac8278624
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352770
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69433}

dc18b822

[csa][cleanup] Remove ParameterMode/TNodify array allocation methods · 46dac207

Santiago Aboy Solanes authored Aug 17, 2020

* AllocateFixedArray
* GetArrayAllocationSize
* GetFixedArrayAllocationSize

Bug: v8:9708, v8:6949
Change-Id: I30c810d49a4b5b2f5782a66f17061a0cf8737bcf
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2356348Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69432}

46dac207

Add "test262" to mac_arm64 bots · 23ea6c66

Almothana Athamneh authored Aug 17, 2020

Bug: chromium:1113183
Change-Id: I0715257b5e929ae6877e1d031138ec24d2789c29
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358732Reviewed-by: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69431}

23ea6c66

[Atomics.waitAsync] Add regression test · 97846e03

Marja Hölttä authored Aug 14, 2020

Bug: v8:10239, chromium:1115354
Change-Id: I64b028b383dcff1e4224c945ee1f982d1979eb9d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2354813Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69430}

97846e03

[csa][cleanup] Remove ParameterMode/TNodify size check methods · 47636f18

Santiago Aboy Solanes authored Aug 14, 2020

Do:
  * FixedArraySizeDoesntFitInNewSpace
  * GotoIfFixedArraySizeDoesntFitInNewSpace

Bug: v8:9708, v8:6949
Change-Id: Ic76b6b98620e6fcec9b13a940c51a36616c21a56
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2356347Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69429}

47636f18

[runtime] Make Code::SourcePositionTableIfCollected() read only once · fe3b24a6

Georg Neis authored Aug 17, 2020

Bug: v8:7790
Change-Id: I8160a3729fcff8037e83eb4566e15b6b0f42781f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358736Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69428}

fe3b24a6

Reland "[regalloc] Place spill instructions optimally" · 2f809531

Seth Brenith authored Aug 12, 2020

This is a reland of f4548e75

Original change's description:
> [regalloc] Place spill instructions optimally
>
> Design doc:
> https://docs.google.com/document/d/1n9ADWnDI-sw0OvdSmrthf61prmDqbDmQq-NSrQw2MVI/edit?usp=sharing
>
> Most of this change follows directly what is discussed in the design
> document. A few other things are also changed:
>
> - PopulateReferenceMapsPhase is moved after ResolveControlFlowPhase so
>   that it can make use of the decision regarding whether a value is
>   spilled at its definition or later.
> - SpillSlotLocator is removed. It was already somewhat confusing,
>   because the responsibility for marking blocks as needing frames was
>   split: in some cases they were marked by SpillSlotLocator, and in
>   other cases they were marked by CommitSpillsInDeferredBlocks. With
>   this change, that split responsibility would become yet more
>   confusing if we kept SpillSlotLocator for the values that are spilled
>   at their definition, so I propose a simpler rule that whatever code
>   adds the spill move also marks the block.
> - A few class definitions (LiveRangeBound, FindResult,
>   LiveRangeBoundArray, and LiveRangeFinder) are moved without
>   modification from register-allocator.cc to register-allocator.h so
>   that we can refer to them from another cc file.
>
> Bug: v8:10606
> Change-Id: I374a3219a5de477a53bc48117e230287eae89e72
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2285390
> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#69345}

Bug: v8:10606
Change-Id: I10fc1ef4b0bebb6c9f55ebdefe33e8c1e5646f0a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352483
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69427}

2f809531

[offthread] Enable off-thread logging · f5051f02

Leszek Swirski authored Aug 14, 2020

Enable logging script events and code position events during a
background compile. This isn't technically thread-safe, but neither
are the existing logger accesses in the parser, so something has to
be done here in general.

Bug: chromium:1011762
Change-Id: I3b610c3bb146880ef826928b6f341f402ca6247e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2162853Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69426}

f5051f02

[ukm][wasm] Add event WasmModuleDecoded · 4c153339

Emanuel Ziegler authored Aug 13, 2020

Add an event for recording metrics related to decoding Wasm modules.

R=clemensb@chromium.org

Bug: chromium:1092417
Change-Id: Id60560d8eb8c14edb5b863857b18c1c82f48e7e7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351672
Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69425}

4c153339

minor tidy up of v8/include/v8.h · 5488d2db

Yuki Shiino authored Aug 15, 2020

Moves a forward declaration of v8::CFunction to the appropriate
position.

Change-Id: I9ea8c7697a0abd39a0c8fdc536aae0417e04cafe
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2359091Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69424}

5488d2db

Revert "[wasm] Map JS_TO_WASM frame marker to proper frame type" · 5f298b96

Maya Lekova authored Aug 17, 2020

This reverts commit 8984a258.

Reason for revert: Breaks GC stress custom snapshot bot - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/32681

Original change's description:
> [wasm] Map JS_TO_WASM frame marker to proper frame type
> 
> Bug: v8:10701
> Change-Id: Ic924352195076c9cdc6a2b5f20cd75a1dcc489df
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2355950
> Commit-Queue: Eva Herencsárová <evih@google.com>
> Reviewed-by: Andreas Haas <ahaas@chromium.org>
> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#69421}

TBR=jkummerow@chromium.org,ahaas@chromium.org,thibaudm@chromium.org,evih@google.com

Change-Id: Iabc9de9fa1f1478369bf6a7dde77e661d8467542
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:10701
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358677Reviewed-by: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69423}

5f298b96

[ukm] Some fixes to the metrics recording framework · 189dc5ac

Emanuel Ziegler authored Aug 12, 2020

Some fixes that were required to make the metric recording framework run
better:
  - Set the foreground task runner later so it can still be modified in
    test cases
  - Add Start and Stop methods to TimedScope for more control
  - Clear map of contexts explicitly to avoid it being triggered at the
    end of the destructor when counters are already destroyed and a
    SEGFAULT may occur due to histogram updates during destruction of
    the weak persistent handles.

R=rmcilroy@chromium.org

Bug: chromium:1101749
Change-Id: Ib41c7aeb1aac96f0fa102f0fceadbf7ec2dd78dc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351668Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69422}

189dc5ac

[wasm] Map JS_TO_WASM frame marker to proper frame type · 8984a258

evih authored Aug 14, 2020

Bug: v8:10701
Change-Id: Ic924352195076c9cdc6a2b5f20cd75a1dcc489df
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2355950
Commit-Queue: Eva Herencsárová <evih@google.com>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69421}

8984a258

[heap] Support removing of observers during Step() · d75753f8

Dominik Inführ authored Aug 17, 2020

Allow AllocationObserver::Step to remove allocation observers as well.
They could already add new observers (to start incremental marking),
removing will be used when starting StressConcurrentAllocator from
an allocation observer.

Bug: v8:10315
Change-Id: I823ded2f9a408b3fa5269ee8416060d0cabb3162
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2357690Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69420}

d75753f8

[wasm] Disable multi-value · 20728eeb

Thibaud Michaud authored Aug 17, 2020

Temporarily disable multi-value until the launch is approved.

R=ahaas@chromium.org

Bug: chromium:1097717
Change-Id: Ifb2370d87ec5e531257852bc5fc5259386a022d8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358675Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69419}

20728eeb

[compiler] Remove BytecodeArrayData's source_positions · ae5b624e

Santiago Aboy Solanes authored Aug 17, 2020

We can bypass the data() and do a direct access read.

Bug: v8:7790
Change-Id: Id1d5b4ad9dcde1673fae07a076ad11322da4c724
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358730Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69418}

ae5b624e

[cleanup] Consistent comments on namespace ends · aefbcbdd

Jakob Kummerow authored Aug 13, 2020

This is a comment-only CL.

Change-Id: I002b1765bfa839982ab11c22f744734fdd34d4ce
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352788Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69417}

aefbcbdd

[print] Add external string prefix to string print · 367cef20

Leszek Swirski authored Aug 17, 2020

Change-Id: I86d8b2046a0809287be31172ec261e4679da66f2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358731
Commit-Queue: Marja Hölttä <marja@chromium.org>
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69416}

367cef20

[tools][system-analyzer] Fix Layout and Remove Scrollbars · c5f952dc

Zeynep Cankara authored Aug 14, 2020

This CL changes min/max of panel sizes for a better user
experience. Additionally, removes the scroll bars while
keeping the scroll functionality to alleviate the
cluttered view.

Bug: v8:10644

Change-Id: Ib95ed79dd58dbcd6b1932eb366f9d2177407c853
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2356346Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
Commit-Queue: Zeynep Cankara <zcankara@google.com>
Cr-Commit-Position: refs/heads/master@{#69415}

c5f952dc

[compiler] Don't serialize BytecodeArrayData's bytecodes_ · 677a02d2

Santiago Aboy Solanes authored Aug 17, 2020

object() is already a canonical persistent handle so we can use that.

The necessary *Ref methods can be changed to bypass the data() and do
the direct access into the bytecodes. Then, we can safely eliminate
the bytecodes_ member.

Bug: v8:7790
Change-Id: I84302e02bcb37ce1f4cd345b15ebadc0528a7028
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288865Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69414}

677a02d2

Reland "Improve NumberToString when cache miss and Smi" · 22874998

Z Nguyen-Huu authored Aug 14, 2020

This is a reland of 1b35c0fa

Reason for revert: Seems to reliably break a numerics test:
https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/31516

It was really slow and timeout with debug build run this test
mjsunit/math-exp-precision with --optimize-for-size because we resize
cache in CSA. Default this to runtime would avoid the timeout.

Also with --optimize-for-size, we don't have enough space to allocate
full-size cache so avoid to resize cache in this case.

In my local PC, time for this test decreases as follows.
Before: 52s
After: 3s

Original change's description:
> Improve NumberToString when cache miss and Smi
>
> Cache miss was handled in runtime before. This change add fast path for
> Smi in this case.
>
> Perf show 30% improvement for the following example.
> Before 67 ms
> After 42 ms
>
> const start = new Date();
> const MAX = 1000000;
> for (var i = 0; i < MAX; i++) {
>     i.toString();
> }
> const end = new Date();
> console.log("Time :"+ (end-start));
>
> Change-Id: I162e9c35f58551ca6a5a0efe79fb7c7b482a8594
> Bug: v8:10477
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2332866
> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#69362}

Bug: v8:10477
Change-Id: I892a9007210032640d0bf22e61c8e7ad1a4377c4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2351398Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69413}

22874998

[turbofan] Don't crash while printing static assert failure · bd094d0d

Georg Neis authored Aug 17, 2020

We want to crash after printing :)

Change-Id: Ia739b54655e9cbce56b4f774ef6af1a771db4c1f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358674Reviewed-by: Marja Hölttä <marja@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Auto-Submit: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69412}

bd094d0d

Update V8 DEPS. · 0510c7a6

v8-ci-autoroll-builder authored Aug 17, 2020

Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e7ee57c..939db33

Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/93f80bc..361d367

TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ib0b75df46bca0c7fe2076c5180ffca097dfbbb79
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2359268Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#69411}

0510c7a6

16 Aug, 2020 2 commits

Update V8 DEPS. · d4641e6c

v8-ci-autoroll-builder authored Aug 16, 2020

Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/055e1ba..e7ee57c

Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/724075d..93f80bc

TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I04b90882754a1fc75c224ae44706a3120a725e37
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2359261Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#69410}

d4641e6c

Update V8 DEPS. · 347b6e21

v8-ci-autoroll-builder authored Aug 16, 2020

Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c843282..055e1ba

Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/69d9325..5abddab

TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2e4b9ecb0b219910f4d5a9a9aaa3b95e56550699
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2359253Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#69409}

347b6e21

15 Aug, 2020 2 commits

Update V8 DEPS. · 87b7b2bf

v8-ci-autoroll-builder authored Aug 15, 2020

Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7dff8d4..c843282

Rolling v8/third_party/aemu-linux-x64: NHKI_hy9EiYHTk25-SwU9lqq_Nmk1LQ748n-ZAtBu9YC..zCy9vIuheNK--OaT_8WBj3IbVxW_RuxRLMp8KWTLqzIC

Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/5edcbfd..fc6c684

Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c4d3ff4..69d9325

Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0fa91d0..3bd3c99

Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/8ce2286..6a38b0e

Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/bb3f180..3c52ccd

Rolling v8/third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/3f90fa0..61cfe2a

Rolling v8/third_party/markupsafe: https://chromium.googlesource.com/chromium/src/third_party/markupsafe/+log/8f45f5c..f2fb0f2

Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/6b794b9..724075d

TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia6dc928e4d92d83fb7245bccad96d09312ea89c8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2358554Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#69408}

87b7b2bf

Simplified Segmenter remove unused method. · c7cbf911

Frank Tang authored Aug 12, 2020

Bug: v8:6891
Change-Id: I3552afff9cd6f065aba82eddcf3f4719ee1283e9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2353414Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69407}

c7cbf911

14 Aug, 2020 4 commits

[atomics] Fix PPC/MIPS/S390 builds in Atomics builtins · c084bd93

Shu-yu Guo authored Aug 14, 2020

Bug: v8:10687, v8:9921
Change-Id: I7a81e9f9882c9a50d8ca70690e2ea409dc5c6c2f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2357169Reviewed-by: Milad Farazmand <miladfar@ca.ibm.com>
Reviewed-by: Ben Smith <binji@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69406}

c084bd93

Revert "[wasm][fuzzer] Fix exception detection" · a2268e6e

Bill Budge authored Aug 14, 2020

This reverts commit 899cb348.

Reason for revert: Added regression test fails on Arm Sim:
https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite/11584

Original change's description:
> [wasm][fuzzer] Fix exception detection
> 
> Exceptions were detected by checking for a pending exception on the
> isolate, but {CallWasmFunctionForTesting} was clearing any pending
> exception before returning.
> This CL fixes that by explicitly passing back a boolean which is set if
> an exception occurred during execution.
> 
> R=ahaas@chromium.org
> 
> Bug: chromium:1115280
> Change-Id: Ife71ceef0751d18e0870335b9520c2bf77e351cc
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352787
> Reviewed-by: Andreas Haas <ahaas@chromium.org>
> Commit-Queue: Clemens Backes <clemensb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#69404}

TBR=ahaas@chromium.org,clemensb@chromium.org

Change-Id: I1d3c0e57df7ec25b09f2037c31c9b30eb0866548
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1115280
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2357189Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69405}

a2268e6e

[wasm][fuzzer] Fix exception detection · 899cb348

Clemens Backes authored Aug 13, 2020

Exceptions were detected by checking for a pending exception on the
isolate, but {CallWasmFunctionForTesting} was clearing any pending
exception before returning.
This CL fixes that by explicitly passing back a boolean which is set if
an exception occurred during execution.

R=ahaas@chromium.org

Bug: chromium:1115280
Change-Id: Ife71ceef0751d18e0870335b9520c2bf77e351cc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352787Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69404}

899cb348

[wasm-gc] Implement call_ref, return_call_ref, add some basic tests · dd152527

Manos Koukoutos authored Aug 14, 2020

Drive-by: Add flag implications for wasm experimental features:
  gc -> typed_funcref, typed_funcref -> reftypes.

Bug: v8:9495
Change-Id: Ia6054886935d68e79b8f463289aa9e1e9d6484f2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352777Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69403}

dd152527