Commit aefbcbdd authored by Jakob Kummerow's avatar Jakob Kummerow Committed by Commit Bot

[cleanup] Consistent comments on namespace ends

This is a comment-only CL.

Change-Id: I002b1765bfa839982ab11c22f744734fdd34d4ce
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352788Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69417}
parent 367cef20
......@@ -327,7 +327,7 @@ class Clock final {
namespace {
DEFINE_LAZY_LEAKY_OBJECT_GETTER(Clock, GetClock)
}
} // namespace
Time Time::Now() { return GetClock()->Now(); }
......
......@@ -37,7 +37,7 @@ class TimeTicks;
namespace time_internal {
template<class TimeClass>
class TimeBase;
}
} // namespace time_internal
class TimeConstants {
public:
......
......@@ -25,7 +25,7 @@ class RootVisitor;
enum class InterpreterPushArgsMode : unsigned;
namespace compiler {
class CodeAssemblerState;
}
} // namespace compiler
template <typename T>
static constexpr T FirstFromVarArgs(T x, ...) noexcept {
......
......@@ -1439,7 +1439,7 @@ void Generate_InterpreterPushZeroAndArgsAndReturnAddress(
#endif
}
} // end anonymous namespace
} // anonymous namespace
// static
void Builtins::Generate_InterpreterPushArgsThenConstructImpl(
......
......@@ -16,7 +16,7 @@ class CodeDesc;
namespace wasm {
class WasmCode;
}
} // namespace wasm
class CodeReference {
public:
......
......@@ -18,7 +18,7 @@ class BytecodeArray;
namespace wasm {
class WasmCode;
}
} // namespace wasm
// HandlerTable is a byte array containing entries for exception handlers in
// the code object it is associated with. The tables come in two flavors:
......
......@@ -24,7 +24,7 @@ namespace v8 {
namespace tracing {
class TracedValue;
}
} // namespace tracing
namespace internal {
......@@ -36,7 +36,7 @@ class Zone;
namespace wasm {
struct WasmCompilationResult;
}
} // namespace wasm
// OptimizedCompilationInfo encapsulates the information needed to compile
// optimized code for a given function, and the results of the optimized
......
......@@ -17,7 +17,7 @@ namespace internal {
namespace wasm {
class WasmCode;
}
} // namespace wasm
class SafepointEntry {
public:
......
......@@ -20,7 +20,7 @@ namespace compiler {
class Node;
}
} // namespace compiler
struct UntaggedT {};
......
......@@ -95,7 +95,7 @@ bool PerThreadAssertScope<kType, kAllow>::IsAllowed() {
namespace {
template <PerIsolateAssertType kType>
using DataBit = base::BitField<bool, kType, 1>;
}
} // namespace
template <PerIsolateAssertType kType, bool kAllow>
PerIsolateAssertScope<kType, kAllow>::PerIsolateAssertScope(Isolate* isolate)
......
......@@ -13,7 +13,7 @@ namespace v8 {
namespace base {
class RandomNumberGenerator;
}
} // namespace base
namespace internal {
namespace compiler {
......
......@@ -889,7 +889,7 @@ struct CommonOperatorGlobalCache final {
namespace {
DEFINE_LAZY_LEAKY_OBJECT_GETTER(CommonOperatorGlobalCache,
GetCommonOperatorGlobalCache)
}
} // namespace
CommonOperatorBuilder::CommonOperatorBuilder(Zone* zone)
: cache_(*GetCommonOperatorGlobalCache()), zone_(zone) {}
......
......@@ -713,7 +713,7 @@ struct JSOperatorGlobalCache final {
namespace {
DEFINE_LAZY_LEAKY_OBJECT_GETTER(JSOperatorGlobalCache, GetJSOperatorGlobalCache)
}
} // namespace
JSOperatorBuilder::JSOperatorBuilder(Zone* zone)
: cache_(*GetJSOperatorGlobalCache()), zone_(zone) {}
......
......@@ -1213,7 +1213,7 @@ struct SimplifiedOperatorGlobalCache final {
namespace {
DEFINE_LAZY_LEAKY_OBJECT_GETTER(SimplifiedOperatorGlobalCache,
GetSimplifiedOperatorGlobalCache)
}
} // namespace
SimplifiedOperatorBuilder::SimplifiedOperatorBuilder(Zone* zone)
: cache_(*GetSimplifiedOperatorGlobalCache()), zone_(zone) {}
......
......@@ -27,7 +27,7 @@ class D8Console;
namespace internal {
class CancelableTaskManager;
}
} // namespace internal
// A single counter in a counter collection.
class Counter {
......
......@@ -16,7 +16,7 @@ namespace v8 {
namespace internal {
class BuiltinArguments;
} // internal
} // namespace internal
namespace debug {
......
......@@ -13,7 +13,7 @@
namespace v8 {
namespace debug {
struct LiveEditResult;
}
} // namespace debug
namespace internal {
class Script;
......
......@@ -218,7 +218,7 @@ void InstructionTable::AddJumpConditionalShort() {
namespace {
DEFINE_LAZY_LEAKY_OBJECT_GETTER(InstructionTable, GetInstructionTable)
}
} // namespace
static const InstructionDesc cmov_instructions[16] = {
{"cmovo", TWO_OPERANDS_INSTR, REG_OPER_OP_ORDER, false},
......
......@@ -15,7 +15,7 @@ namespace v8 {
namespace internal {
namespace wasm {
class WasmCode;
}
} // namespace wasm
// Forward declarations.
class AbstractCode;
......
......@@ -49,7 +49,7 @@ namespace v8 {
namespace base {
class RandomNumberGenerator;
}
} // namespace base
namespace debug {
class ConsoleDelegate;
......@@ -112,19 +112,19 @@ class VMState;
namespace interpreter {
class Interpreter;
}
} // namespace interpreter
namespace compiler {
class PerIsolateCompilerCache;
}
} // namespace compiler
namespace wasm {
class WasmEngine;
}
} // namespace wasm
namespace win64_unwindinfo {
class BuiltinUnwindInfo;
}
} // namespace win64_unwindinfo
namespace metrics {
class Recorder;
......
......@@ -20,7 +20,7 @@ namespace v8 {
namespace internal {
namespace wasm {
class WasmCode;
}
} // namespace wasm
// Forward declarations.
class AbstractCode;
......
......@@ -34,7 +34,7 @@ namespace internal {
namespace testing {
class TestWithHeap;
}
} // namespace testing
class MarkerBase;
class PageBackend;
......
......@@ -52,7 +52,7 @@ class TestMemoryAllocatorScope;
namespace third_party_heap {
class Heap;
}
} // namespace third_party_heap
class IncrementalMarking;
class BackingStore;
......
......@@ -18,7 +18,7 @@ namespace v8 {
namespace base {
class Semaphore;
}
} // namespace base
namespace internal {
......
......@@ -14,7 +14,7 @@ namespace internal {
namespace compiler {
class CodeAssemblerState;
}
} // namespace compiler
class ExitPoint;
......
......@@ -13,7 +13,7 @@ namespace internal {
namespace compiler {
class CodeAssemblerState;
}
} // namespace compiler
class BinaryOpAssembler : public CodeStubAssembler {
public:
......
......@@ -18,7 +18,7 @@ namespace v8 {
namespace tracing {
class TracedValue;
}
} // namespace tracing
namespace internal {
......
......@@ -12,7 +12,7 @@ namespace internal {
namespace compiler {
class CodeAssemblerState;
}
} // namespace compiler
class UnaryOpAssembler final {
public:
......
......@@ -17,7 +17,7 @@ namespace v8 {
// Forward declarations.
namespace base {
class BoundedPageAllocator;
}
} // namespace base
namespace internal {
......
......@@ -21,6 +21,6 @@ searchInTextByLinesImpl(V8InspectorSession*, const String16& text,
const String16& query, bool caseSensitive,
bool isRegex);
} // namespace v8_inspector
} // namespace v8_inspector
#endif // V8_INSPECTOR_SEARCH_UTIL_H_
......@@ -83,7 +83,7 @@ std::unique_ptr<StringBuffer> StringBufferFrom(std::vector<uint8_t> str);
String16 stackTraceIdToString(uintptr_t id);
} // namespace v8_inspector
} // namespace v8_inspector
// See third_party/inspector_protocol/crdtp/serializer_traits.h.
namespace v8_crdtp {
......
......@@ -14,6 +14,6 @@ class V8Inspector;
V8_EXPORT void SetMaxAsyncTaskStacksForTest(V8Inspector* inspector, int limit);
V8_EXPORT void DumpAsyncTaskStacksStateForTest(V8Inspector* inspector);
} // v8_inspector
} // namespace v8_inspector
#endif // V8_INSPECTOR_TEST_INTERFACE_H_
......@@ -14,7 +14,7 @@ namespace v8_inspector {
namespace ConsoleAgentState {
static const char consoleEnabled[] = "consoleEnabled";
}
} // namespace ConsoleAgentState
V8ConsoleAgentImpl::V8ConsoleAgentImpl(
V8InspectorSessionImpl* session, protocol::FrontendChannel* frontendChannel,
......
......@@ -27,7 +27,7 @@ static const char allocationTrackingEnabled[] = "allocationTrackingEnabled";
static const char samplingHeapProfilerEnabled[] = "samplingHeapProfilerEnabled";
static const char samplingHeapProfilerInterval[] =
"samplingHeapProfilerInterval";
}
} // namespace HeapProfilerAgentState
class HeapSnapshotProgress final : public v8::ActivityControl {
public:
......
......@@ -15,7 +15,7 @@
namespace v8 {
class CpuProfiler;
class Isolate;
}
} // namespace v8
namespace v8_inspector {
......
......@@ -115,7 +115,7 @@ std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObjectCommon(
return stackTrace;
}
} // namespace
} // namespace
V8StackTraceId::V8StackTraceId() : id(0), debugger_id(V8DebuggerId().pair()) {}
......
......@@ -18,7 +18,7 @@ namespace v8 {
namespace sampler {
class Sampler;
}
} // namespace sampler
namespace internal {
......
......@@ -27,7 +27,7 @@ class CodeDesc;
namespace interpreter {
class Register;
}
} // namespace interpreter
// CodeDataContainer is a container for all mutable fields associated with its
// referencing {Code} object. Since {Code} objects reside on write-protected
......
......@@ -24,7 +24,7 @@
namespace U_ICU_NAMESPACE {
class Collator;
} // namespace U_ICU_NAMESPACE
} // namespace U_ICU_NAMESPACE
namespace v8 {
namespace internal {
......
......@@ -24,7 +24,7 @@
namespace U_ICU_NAMESPACE {
class ListFormatter;
}
} // namespace U_ICU_NAMESPACE
namespace v8 {
namespace internal {
......
......@@ -20,7 +20,7 @@
namespace U_ICU_NAMESPACE {
class Locale;
}
} // namespace U_ICU_NAMESPACE
namespace v8 {
namespace internal {
......
......@@ -26,8 +26,8 @@ namespace U_ICU_NAMESPACE {
class UnicodeString;
namespace number {
class LocalizedNumberFormatter;
} // namespace number
} // namespace U_ICU_NAMESPACE
} // namespace number
} // namespace U_ICU_NAMESPACE
namespace v8 {
namespace internal {
......
......@@ -26,8 +26,8 @@ namespace U_ICU_NAMESPACE {
class PluralRules;
namespace number {
class LocalizedNumberFormatter;
} // namespace number
} // namespace U_ICU_NAMESPACE
} // namespace number
} // namespace U_ICU_NAMESPACE
namespace v8 {
namespace internal {
......
......@@ -24,7 +24,7 @@
namespace U_ICU_NAMESPACE {
class RelativeDateTimeFormatter;
}
} // namespace U_ICU_NAMESPACE
namespace v8 {
namespace internal {
......
......@@ -23,7 +23,7 @@
namespace U_ICU_NAMESPACE {
class BreakIterator;
}
} // namespace U_ICU_NAMESPACE
namespace v8 {
namespace internal {
......
......@@ -15,7 +15,7 @@ namespace v8 {
namespace internal {
TQ_OBJECT_CONSTRUCTORS_IMPL(PropertyDescriptorObject)
}
} // namespace internal
} // namespace v8
#include "src/objects/object-macros-undef.h"
......
......@@ -57,7 +57,7 @@ PreParserIdentifier GetIdentifierHelper(Scanner* scanner,
return PreParserIdentifier::Default();
}
} // unnamed namespace
} // namespace
PreParserIdentifier PreParser::GetIdentifier() const {
const AstRawString* result = scanner()->CurrentSymbol(ast_value_factory());
......
......@@ -19,7 +19,7 @@
namespace v8 {
namespace sampler {
class Sampler;
}
} // namespace sampler
namespace internal {
// Forward declarations.
......
......@@ -2050,7 +2050,7 @@ class NullContextForSnapshotScope {
Isolate* isolate_;
Context prev_;
};
} // namespace
} // namespace
bool HeapSnapshotGenerator::GenerateSnapshot() {
v8_heap_explorer_.TagGlobalObjects();
......
......@@ -86,7 +86,7 @@ inline CpuProfileNode::SourceType ProfileNode::source_type() const {
case CodeEventListener::NUMBER_OF_LOG_EVENTS:
return CpuProfileNode::kInternal;
}
} // namespace internal
}
inline Isolate* ProfileNode::isolate() const { return tree_->isolate(); }
......
......@@ -18,7 +18,7 @@ namespace v8 {
namespace base {
class RandomNumberGenerator;
}
} // namespace base
namespace internal {
......
......@@ -492,7 +492,7 @@ static MaybeHandle<String> EscapePrivate(Isolate* isolate,
return dest;
}
} // Anonymous namespace
} // anonymous namespace
MaybeHandle<String> Uri::Escape(Isolate* isolate, Handle<String> string) {
Handle<String> result;
......
......@@ -38,7 +38,7 @@ constexpr bool kEnableSlowChecks = true;
#else
constexpr bool kEnableSlowChecks = false;
#endif
}
} // namespace
namespace v8 {
namespace internal {
......
......@@ -26,7 +26,7 @@ namespace internal {
// Forward declarations.
namespace compiler {
class CallDescriptor;
}
} // namespace compiler
namespace wasm {
......
......@@ -34,7 +34,7 @@ namespace wasm {
#ifdef V8_ENABLE_WASM_GDB_REMOTE_DEBUGGING
namespace gdb_server {
class GdbServer;
}
} // namespace gdb_server
#endif // V8_ENABLE_WASM_GDB_REMOTE_DEBUGGING
class AsyncCompileJob;
......
......@@ -12,7 +12,7 @@ namespace internal {
namespace wasm {
class StreamingDecoder;
}
} // namespace wasm
// Exposes a WebAssembly API to JavaScript through the V8 API.
class WasmJs {
......
......@@ -15,7 +15,7 @@ namespace v8 {
namespace base {
class BoundedPageAllocator;
}
} // namespace base
namespace internal {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment