- 25 Mar, 2021 22 commits
-
-
Frank Emrich authored
This CL adds: a) FindEntry, Add, and Delete operations on SwissNameDictionary in Torque b) Helpers needed for that on both the CSA and Torque side Bug: v8:11330 Change-Id: I549b9039108217a34ec1e95af84eb28af7dfc9d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2778175Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Frank Emrich <emrich@google.com> Cr-Commit-Position: refs/heads/master@{#73674}
-
Zhi An Ng authored
This reverts commit 9eba2d85. Reason for revert: TSAN failures https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20isolates/14265/overview Original change's description: > [fastcall] Add fast API testing facilities to d8 > > This CL provides the minimum necessary functionality to expose fast API > for testing in mjsunit, exposing the fast path for fuzzing. It exposes > a d8.test.fast_c_api with an `add_all` method, which exercises primitive > types. On x64, all integer and floating point types are supported. On > other platforms currently only 32-bit integers are included in the test. > > Design doc: > https://docs.google.com/document/d/1KUKPfXkSRZTA2gMwaWbpQKlYfw0C-T6AE3XzC4viHbo/ > > Bug: chromium:1052746 > Change-Id: Icc824199a26dd2abd2b869f5483a39d38e4dce3e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2749154 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73670} Bug: chromium:1052746 Change-Id: Iaf5083540ddfe882a747eaa9d1d2a2a8b4ba0ec0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2787081 Auto-Submit: Zhi An Ng <zhin@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73673}
-
Igor Sheludko authored
... and don't enable them for CFI builds. Bug: v8:11527 Change-Id: I651473833c1e74d942bd75dc7574dbca45b34b64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2786855Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73672}
-
Andreas Haas authored
When copying the setup of the WebAssembly.Exception constructor to InstallConditionalFeatures, I forgot to copy some parts. R=thibaudm@chromium.org Bug: chromium:1191853 Change-Id: Iacba30b3356fc42b7d97f8c105ef91b776b95eb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2786853Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73671}
-
Maya Lekova authored
This CL provides the minimum necessary functionality to expose fast API for testing in mjsunit, exposing the fast path for fuzzing. It exposes a d8.test.fast_c_api with an `add_all` method, which exercises primitive types. On x64, all integer and floating point types are supported. On other platforms currently only 32-bit integers are included in the test. Design doc: https://docs.google.com/document/d/1KUKPfXkSRZTA2gMwaWbpQKlYfw0C-T6AE3XzC4viHbo/ Bug: chromium:1052746 Change-Id: Icc824199a26dd2abd2b869f5483a39d38e4dce3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2749154Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#73670}
-
Z Nguyen-Huu authored
Change-Id: Iea2fa346bb4d6cd34a1e3f892b9787e75f26237d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2786681Reviewed-by: Seth Brenith <seth.brenith@microsoft.com> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#73669}
-
Leszek Swirski authored
Disable or support --always-sparkplug in various tests that until now were always expecting only bytecode. Bug: v8:11420 Change-Id: Ida45041739fb55851aa493c51f1ed796aa1c0606 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2786852Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73668}
-
Leszek Swirski authored
Fix a broken DCHECK when logging existing baseline code. Bug: v8:11420 Change-Id: I66cf1b1b806aef74bcc9c1a0061bec1834b719f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2786850Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73667}
-
Leszek Swirski authored
CreateShallowArrayLiteral can fail and bail out to the runtime. We therefore have to pass the literal flags to the builtin, so that the runtime e.g. initialises the AllocationSite correctly. Bug: v8:11420 Change-Id: I57dfbbc202aa2c3b0e7ac01f65ee84f6e3763180 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2786848Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73666}
-
Leszek Swirski authored
JSFunctions can store a pointer to baseline code, which would trigger that code to be serialized in the context serializer. Since we don't support baseline code serialization, we have to flush these baseline code pointers. This is similar to the existing optimized code flushing. Bug: v8:11420 Change-Id: Idabd0caea24aed484d5cf39ad0dad8c2c8180b91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2786849Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73665}
-
Leszek Swirski authored
Some baseline implementations of non-accumulator-writing bytecodes would call builtins without saving the accumulator. This clobbers the accumulator. This was particularly observable with IncBlockCounter. Bug: v8:11420 Change-Id: I1e8a06526ea6ed018da0d6213775cce130c72aee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2786847 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73664}
-
Leszek Swirski authored
Use a local context and compilation cache clearing to trigger code deletion in ClearUnusedWithEagerLogging, rather than relying on bytecode flushing. This allows the test to succeed with non-flushable native-context-independent code, like Sparkplug baseline code. Bug: v8:11420 Change-Id: Id6e3626b6245b4308d95aa3995a8fb2ee53684f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2786851Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73663}
-
Milad Fa authored
We will need to use both the vector multiply even and odd instructions. Change-Id: I1af3517dc3359d395682e3d661068b429edba8f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2785427Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73662}
-
Milad Fa authored
This reverts commit d8c6b2ec. Reason for revert: original cl has relanded Original change's description: > Revert "PPC/s390: [sparkplug][deoptimizer] Deoptimize to baseline." > > This reverts commit 94272ea5. > > Reason for revert: original port was reverted > > Original change's description: > > PPC/s390: [sparkplug][deoptimizer] Deoptimize to baseline. > > > > Port bdcd7d79 > > > > Original Commit Message: > > > > If we have baseline code, deoptimize to baseline instead of the > > interpreter. The process is similar to deopting to the interpreter. > > We just use different builtins > > (BaselineEnterAtBytecode/BaselineEnterAtNextBytecode) instead of > > InterpreterEnterBytecodeDispatch/InterpreterEnterBytecodeAdvance, that > > patch an interpreter frame to a baseline frame and continue execution in > > baseline code (based on the deopt type, at the current or next > > bytecode). > > > > R=pthier@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com > > BUG= > > LOG=N > > > > Change-Id: I3230f3f3c6506230b2751a3389f10b022dec61a3 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783022 > > Reviewed-by: Junliang Yan <junyan@redhat.com> > > Commit-Queue: Milad Fa <mfarazma@redhat.com> > > Cr-Commit-Position: refs/heads/master@{#73618} > > Change-Id: I903ad90099c4dc5f153d28aea9246933ac69972b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784002 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Milad Fa <mfarazma@redhat.com> > Cr-Commit-Position: refs/heads/master@{#73630} Change-Id: I7746f42472ae63e49770f491ae6b8ef7b596cfce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2785380 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73661}
-
Nico Hartmann authored
The implementation of Flatten() Torque generates for CSA struct types and the current implementation of EmitCCValue make heavy use of std::make_tuple and std::tuple_cat, which had a noticeable impact on build times of generated files including these outputs. This CL eliminates all uses of std::tuple_cat and most uses of std::make_tuple. Bug: v8:9861 Change-Id: Ib950b2c87983171b8c32c388fc115d2407087717 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784563 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#73660}
-
Michael Achenbach authored
This reverts commit db16dce2. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Linux%20Debug/8771 Original change's description: > [api] Assign serial numbers when template infos are added to cache > > Instead of assigning serial numbers when the template infos are > created, this patch creates serial numbers only when they are added to > cache. > > This way only the ones that are first instantiated are allocated the > fast template cache. Previously, various accessors and methods that > would almost never get instantiated got assigned to the fast template > cache. > > Bug: v8:11284 > Change-Id: I6b633e56e59cbfc3fa5d4ee2db53ca2849eecdd7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2621081 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73655} Bug: v8:11284 Change-Id: I382915b2c1be1d87d7a7a961d13e1dd5e3951a4f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2786844 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73659}
-
Andreas Haas authored
The installation of conditional features in WebAssembly needs the context to be set in the isolate to fix https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/b8851955177753045904/overview. The context cannot be passed explicitly to all uses of the context, because Isolate::object_function() accesses the native_context through the isolate. Change-Id: I20334fd6779326e64825a15ba2aca3ae06a5c0d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784684Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73658}
-
Sam Parker authored
Add Float32Select and Float64Select as OptionalOperators and insert these, if supported, when handling a Select expression in the wasm graph builder. FlagsContinuation have been modified to support the select operation and code generation support has been added for arm64. This improves the 'Bullet' physics benchmark by ~2-3%. Change-Id: I928c3085c9136ad8baeeb34c71c47c1c8338844c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763871 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#73657}
-
Patrick Thier authored
This is a reland of e3ccb538 No changes for the reland. This CL was speculatively reverted, but was not the cause of the problem. TBR=jgruber@chromium.org Original change's description: > Reland "[sparkplug][deoptimizer] Deoptimize to baseline." > > This is a reland of bdcd7d79 > > Handle lazy deopts when the current bytecode is JumpLoop. > Instead of advancing to the next bytecode, re-execute the JumpLoop. > > TBR=jgruber@chromium.org, neis@chromium.org > > Original change's description: > > [sparkplug][deoptimizer] Deoptimize to baseline. > > > > If we have baseline code, deoptimize to baseline instead of the > > interpreter. The process is similar to deopting to the interpreter. > > We just use different builtins > > (BaselineEnterAtBytecode/BaselineEnterAtNextBytecode) instead of > > InterpreterEnterBytecodeDispatch/InterpreterEnterBytecodeAdvance, that > > patch an interpreter frame to a baseline frame and continue execution in > > baseline code (based on the deopt type, at the current or next > > bytecode). > > > > Bug: v8:11420 > > Change-Id: Iabaefb36c05155a435c7b380906a86d9b9d549fa > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2695591 > > Commit-Queue: Patrick Thier <pthier@chromium.org> > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#73609} > > Bug: v8:11420 > Change-Id: Ib8cac028121188ddc23ff29377760ed684eb7392 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783035 > Reviewed-by: Patrick Thier <pthier@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73636} Bug: v8:11420 Change-Id: I7fbbb73a4fdaeab8b294862ee6ae952928c57994 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784695 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#73656}
-
Sathya Gunasekaran authored
Instead of assigning serial numbers when the template infos are created, this patch creates serial numbers only when they are added to cache. This way only the ones that are first instantiated are allocated the fast template cache. Previously, various accessors and methods that would almost never get instantiated got assigned to the fast template cache. Bug: v8:11284 Change-Id: I6b633e56e59cbfc3fa5d4ee2db53ca2849eecdd7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2621081Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#73655}
-
Sathya Gunasekaran authored
This reverts commit c10aa432. Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/try/mac-rel/b8851806981073807856/overview Original change's description: > [sparkplug] Enable short builtin calls by default > > ... when they are enabled via the GN flag. > > Also disable this optimizaion for CFI builds for now. > > Sheriffs: This CL adds ~1.2-1.4Mb of memory overhead per Isolate on > certain configurations and that's expected. This is a temporary fix > until the full solution is implemented. > See the design doc linked to the issue for details. > > Bug: v8:11527 > Change-Id: I7444c6878ea58d67ef580cf50cb550b3820c85c4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784690 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73650} Bug: v8:11527 Change-Id: I96ff92e3f5c1a1a7ebe68d7f9d2981b5cf9c0094 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784697Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#73654}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f628144..7b935eb Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/731dd85..f50df92 Rolling v8/third_party/aemu-linux-x64: oZxl99tyPs7o9Eq0hlPel1m4iyPu1Z92wj2Llb6HWwEC..wvBTICmOxqrOyqTGFXVMcKyHB3KmKkB4Xo6VVahwXs8C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/dbc2c42..4f773bc TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I11a315567cd12d4010a191f4b6e5fad8f9735c82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2785805Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73653}
-
- 24 Mar, 2021 18 commits
-
-
Ng Zhi An authored
SharedTurboAssembler is shared between ia32 and x64. It contains shared functionality between these two backends. It derives from TurboAssemblerBase, and the backend-specific TurboAssembler derives from SharedTurboAssembler. That way, LiftoffAssembler does not need to change. As an example, we move a single member function I64x2SConvertI32x4High into SharedTurboAssembler. This function has the exact same implementation on ia32 and x64, and is now defined in a single place. Bug: v8:11589 Change-Id: I1c4a0628d61960e7398d458fb813561751e0614f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773609Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73652}
-
Frank Emrich authored
This CL adds: a) Allocation and Copy operations on the CSA side b) Helpers needed for that on both the CSA and Torque side Bug: v8:11330 Change-Id: I322c84e1762d2d3503a0d4809c6e1c0bc9d442e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2775563Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73651}
-
Igor Sheludko authored
... when they are enabled via the GN flag. Also disable this optimizaion for CFI builds for now. Sheriffs: This CL adds ~1.2-1.4Mb of memory overhead per Isolate on certain configurations and that's expected. This is a temporary fix until the full solution is implemented. See the design doc linked to the issue for details. Bug: v8:11527 Change-Id: I7444c6878ea58d67ef580cf50cb550b3820c85c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784690 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#73650}
-
Igor Sheludko authored
In particular Copy and EnumerationOrder. Tbr: emrich@google.com Change-Id: Iff3e67b1c51fc070672e1b041dea43339518b6c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784694Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73649}
-
Milad Fa authored
Change-Id: I2fe3b9431fbb22ee045090ba199bfa3b6fd5e19d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2785424Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73648}
-
Frank Emrich authored
This test is unnecessarily slow due to the CSA test suite for SwissNameDictionary doing excessive runtime calls at the moment. This causes timeouts on various bot configurations. Change-Id: Id872698f88f699982362e68da7e9c4a26333f233 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784691 Commit-Queue: Frank Emrich <emrich@google.com> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73647}
-
Camillo Bruni authored
Change-Id: Ia163acfd04d287d33570374254b661becaf1cc67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2782160Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#73646}
-
Ng Zhi An authored
We now canonicalize earlier in the pipeline, and don't need to worry about non-canonicalized shuffles. Bug: v8:11542,v8:11257 Change-Id: If9f5c44061465be339c98e479fd8c5a437bbd74b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2778673Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73645}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b43166a..f628144 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/4e07843..731dd85 Rolling v8/third_party/aemu-linux-x64: osbsa1Jjgk8WbE3Ckv8288sgvejWZeAN8DB42wp0YV8C..oZxl99tyPs7o9Eq0hlPel1m4iyPu1Z92wj2Llb6HWwEC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e46359d..dbc2c42 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/0964a78..6900bf4 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/24cecab..84682eb Rolling v8/tools/luci-go: git_revision:edffd3478bb26469c614610d1a1c323b7e798b07..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b Rolling v8/tools/luci-go: git_revision:edffd3478bb26469c614610d1a1c323b7e798b07..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b Rolling v8/tools/luci-go: git_revision:edffd3478bb26469c614610d1a1c323b7e798b07..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I14ec8ad5ccca6d30ca5cc23e0145cb0cbed1f634 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2785241Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73644}
-
Deepti Gandluri authored
This reverts commit e3ccb538. Reason for revert: Speculative revert for ARM 64 CFI fails - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20CFI/5174? Original change's description: > Reland "[sparkplug][deoptimizer] Deoptimize to baseline." > > This is a reland of bdcd7d79 > > Handle lazy deopts when the current bytecode is JumpLoop. > Instead of advancing to the next bytecode, re-execute the JumpLoop. > > TBR=jgruber@chromium.org, neis@chromium.org > > Original change's description: > > [sparkplug][deoptimizer] Deoptimize to baseline. > > > > If we have baseline code, deoptimize to baseline instead of the > > interpreter. The process is similar to deopting to the interpreter. > > We just use different builtins > > (BaselineEnterAtBytecode/BaselineEnterAtNextBytecode) instead of > > InterpreterEnterBytecodeDispatch/InterpreterEnterBytecodeAdvance, that > > patch an interpreter frame to a baseline frame and continue execution in > > baseline code (based on the deopt type, at the current or next > > bytecode). > > > > Bug: v8:11420 > > Change-Id: Iabaefb36c05155a435c7b380906a86d9b9d549fa > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2695591 > > Commit-Queue: Patrick Thier <pthier@chromium.org> > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#73609} > > Bug: v8:11420 > Change-Id: Ib8cac028121188ddc23ff29377760ed684eb7392 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783035 > Reviewed-by: Patrick Thier <pthier@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73636} Bug: v8:11420 Change-Id: Icd797b4979a114a2a627e12c8bb7d2215df03182 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2785074Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#73643}
-
Deepti Gandluri authored
This reverts commit 407ce2d9. Reason for revert: Speculative revert for Test262 failures on ARM 64 CFI - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20CFI/5174? Original change's description: > [sparkplug] Enable short builtin calls by default > > ... when they are enabled via the GN flag. > > Sheriffs: This CL adds ~1.2-1.4Mb of memory overhead per Isolate on > certain configurations and that's expected. This is a temporary fix > until the full solution is implemented. > See the design doc linked to the issue for details. > > Bug: v8:11527 > Change-Id: Ie59f55050c02fe523e2be890e2a6f74ff3eca1ea > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784682 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73637} Bug: v8:11527 Change-Id: I1376bfeb9297ff4929e4fda00dc0ca2a54fb68c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2785075Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73642}
-
Frank Emrich authored
This is the second reland of https://chromium-review.googlesource.com/c/v8/v8/+/2744138. It shortens the runtime of further tests. Original description: This CL is part of a series that adds the C++ implementation of SwissNameDictionary, a deterministic property backing store based on Swiss Tables. This CL adds the actual tests for SwissNameDictionary, defined in test-swiss-name-dictionary-shared-tests.h, using the infrastructure in test-swiss-name-dictionary-infra.[h|cc]. Change-Id: I5b8a7cefb4115ade25b4f8ce032fab9aa10a7b04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784683Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Frank Emrich <emrich@google.com> Cr-Commit-Position: refs/heads/master@{#73641}
-
Andreas Haas authored
R=nicohartmann@chromium.org Change-Id: I48294d6944c32ad6b3ee00099c682cb63ad28442 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784685Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73640}
-
Ng Zhi An authored
Support the various combinations of arch-mode-target that gm.py understands, and also completion of cctests. Bug: v8:11567 No-Try: true Change-Id: I05285a93253f4225889e949890f5352bbc173c91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2774708 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73639}
-
Santiago Aboy Solanes authored
We set the bit_field_2 fields at map construction. Bug: v8:7790, chromium:1150811 Change-Id: I673334d6900993b8a52e3b85d504cbc3f457c020 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773053 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#73638}
-
Igor Sheludko authored
... when they are enabled via the GN flag. Sheriffs: This CL adds ~1.2-1.4Mb of memory overhead per Isolate on certain configurations and that's expected. This is a temporary fix until the full solution is implemented. See the design doc linked to the issue for details. Bug: v8:11527 Change-Id: Ie59f55050c02fe523e2be890e2a6f74ff3eca1ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784682 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#73637}
-
Patrick Thier authored
This is a reland of bdcd7d79 Handle lazy deopts when the current bytecode is JumpLoop. Instead of advancing to the next bytecode, re-execute the JumpLoop. TBR=jgruber@chromium.org, neis@chromium.org Original change's description: > [sparkplug][deoptimizer] Deoptimize to baseline. > > If we have baseline code, deoptimize to baseline instead of the > interpreter. The process is similar to deopting to the interpreter. > We just use different builtins > (BaselineEnterAtBytecode/BaselineEnterAtNextBytecode) instead of > InterpreterEnterBytecodeDispatch/InterpreterEnterBytecodeAdvance, that > patch an interpreter frame to a baseline frame and continue execution in > baseline code (based on the deopt type, at the current or next > bytecode). > > Bug: v8:11420 > Change-Id: Iabaefb36c05155a435c7b380906a86d9b9d549fa > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2695591 > Commit-Queue: Patrick Thier <pthier@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73609} Bug: v8:11420 Change-Id: Ib8cac028121188ddc23ff29377760ed684eb7392 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783035Reviewed-by: Patrick Thier <pthier@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#73636}
-
Andreas Haas authored
LiftoffCompiler::ProcessParameter assumed that by processing parameters in the order of their index, register parameters get processed first, and that for processing stack parameters it can already use all registers as temp registers. This is not true with reference type parameters, because registers always first get assigned to value type parameters even when there is a reference type parameter with a lower index. Because of this incorrect assumption register parameters were overwritten by reference type parameters on the stack that got processed first. With this CL, only those registers get used as temp registers for reference type parameters that are not used for parameters. CC=jkummerow@chromium.org, clemensb@chromium.org R=thibaudm@chromium.org Bug: v8:11596 Change-Id: I30ed7f073147df0bd81b9ef4d2b2a54d7badc937 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784560 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73635}
-