- 17 Jul, 2018 14 commits
-
-
Dan Elphick authored
Pass Isolate directly into several LayoutDescriptor methods so they don't call GetIsolate on unsafe objects. Also marks DebugInfo as non-read-only (so our GetIsolate removal tools stop trying to change BreakIterator::isolate() to call itself). Bug: v8:7786 Change-Id: I626a83d603ab74f648c72eb50d027b3866cedceb Reviewed-on: https://chromium-review.googlesource.com/1138326 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54490}
-
Clemens Hammacher authored
The instruction selector currently sometimes emits a lea32 with an offset of 0, which the code generator just ignores (emits no code at all). This can result in the result of TruncateInt64ToInt32 to not be zero extended. This CL fixes that by disallowing lea32 instructions with 0 offset, and fixing the instruction selector to generate a movl or just no code for that case. R=jarin@chromium.org Bug: chromium:863810, v8:7947 Change-Id: I1b21fc5f0fda9ca3144917538c3d0bbf46601c33 Reviewed-on: https://chromium-review.googlesource.com/1137825Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54489}
-
Dan Elphick authored
Ran GetIsolate/GetHeap removal script over all the header files included into objects.cc. Affected classes include: ScriptContextTable RuntimeCallTimerScope GlobalDictionaryShape Map LookupIterator PrototypeIterator FixedArrayBuilder Manually fixed up Map to mark its write operations as safe for GetIsolate since they modify the object as so can't be done in RO_SPACE. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I2fd0960f085d1bcb4cf54b3418899ac0217917ca Reviewed-on: https://chromium-review.googlesource.com/1138076 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Dan Elphick authored
Also deletes lots of code that attempts to detect when the heap is corrupt but would likely just crash if the heap was corrupt. Bug: v8:7786 Change-Id: I2e6bbea2e393b0f640a9d7180114560e7f6d3670 Reviewed-on: https://chromium-review.googlesource.com/1140061Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54487}
-
Sigurd Schneider authored
kMaximalCodeRangeSize can be zero to indicate no limit, which was misinterpreted by mksnapshot. Bug: v8:6666 Change-Id: I512412a5ef866c0595654aa78c6761bc00b82c56 Reviewed-on: https://chromium-review.googlesource.com/1140057Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54486}
-
Vasili Skurydzin authored
Change-Id: Ia05e949e1a823e30a45894c47f6f6df2e159befe Reviewed-on: https://chromium-review.googlesource.com/1135540 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54485}
-
Sergiy Byelozyorov authored
This is a reland of f0a9a6a5 Original change's description: > Update GN configs for v8_perf target to allow running perf tests in swarming > > This will allow us to migrate our deprecated configs to android_docker. > > R=machenbach@chromium.org > > Bug: chromium:838864 > Change-Id: I5f7db648520847aa2077e9fc2a5970e63daa9a50 > Reviewed-on: https://chromium-review.googlesource.com/1131944 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54441} R=machenbach@chromium.org Bug: chromium:838864 Change-Id: I35e1ab911ac3b5ddd8478faae4799ed5d7bbccbf Reviewed-on: https://chromium-review.googlesource.com/1139973Reviewed-by:
-
Yang Guo authored
R=bmeurer@chromium.org Change-Id: Iece8e73581e99456f9647b9ae6af6045305811f4 Reviewed-on: https://chromium-review.googlesource.com/1139058Reviewed-by:
-
Sigurd Schneider authored
This changes several CHECK macros textually (but not semantically) to make them distinguishable by message in crash dumps. Bug: chromium:855041 Change-Id: I74b66a80c63b264b463eadb333b5359fb412130a Reviewed-on: https://chromium-review.googlesource.com/1138320Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54482}
-
Marja Hölttä authored
It's a growing weak array which also has an API for marking slots empty (those will then be filled before growing the array again). This is a more efficient implementation than the corresponding feature in FixedArrayOfWeakCells, because we chain the empty slots together. BUG=v8:7308 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I335cd3f9cc7838c7f6ca350735b1503b2f5b8eed Reviewed-on: https://chromium-review.googlesource.com/1090922 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54481}
-
Georg Neis authored
This makes it more convenient to work with brokerized data. Bug: v8:7790 Change-Id: I7ffb4054b809c10c67787b2fb89a05e8ce8f4575 Reviewed-on: https://chromium-review.googlesource.com/1138248 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL adds local const bindings. This means that instead of generating TVARIABLEs for variables, we can generate simple TNodes. Example: macro FooBar(): { const kSomeSmi: Smi = 10; ... } This CL also enforces that variables with a constexpr type are bound using 'const' and not 'let'. R=tebbi@chromium.org Bug: v8:7793 Change-Id: Id20a18149df9fc374ce718bdb1478e3eabb6e6df Reviewed-on: https://chromium-review.googlesource.com/1138316 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#54479}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c0771e9..7315579 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/be45355..f5342c4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8d3925b..fb73403 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/e9cc24f..c0b1d89 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I314761df6ad3e08de1ea13bff1daf2c9f85a2c05 Reviewed-on: https://chromium-review.googlesource.com/1139582 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54478}
-
Frank Tang authored
[Intl] Change PluralRules.prototype.resolvedOptions to return newly created array for pluralCategories Test: test262/intl402/PluralRules/prototype/resolvedOptions/pluralCategories Bug: v8:7830 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie527f51fab67e63cf5bf56a1da883a3e16ce48ac Reviewed-on: https://chromium-review.googlesource.com/1132339Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#54477}
-
- 16 Jul, 2018 26 commits
-
-
Dan Elphick authored
Deprecate String::Utf8Length in favor of a new, similar function that takes the Isolate used for the String::Flatten call as an argument. BUG: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Icaf04b272679fd853e9cdbe6c7088f63e9aacb95 Reviewed-on: https://chromium-review.googlesource.com/1124724 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54476}
-
Matheus Marchini authored
* JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see https://github.com/nodejs/llnode/pull/215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see https://github.com/nodejs/llnode/pull/204 for a usage example) R=bmeurer@google.com, yangguo@google.com Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493Reviewed-by: -
Frank Tang authored
Use the given locale and options when performing toLocaleString on each individual element in a given array. Bug: v8:7832 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I718a33c42e85819065599ee6bad59fb25afa7e15 Reviewed-on: https://chromium-review.googlesource.com/1132464 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Leszek Swirski authored
SharedFunctionInfos store their original function literal's id. This is also their index in the Script's SFI list. The function literal id is only needed for lazy compilation and live edit, and access only has to be fast in the former. So, we can move the SFI function literal id field to UncompiledData, and if patching with live edit, or discarding compiled code, we can perform a slower linear search through the Script's SFI list. This is a reland of 1) https://chromium-review.googlesource.com/1082480 and 2) https://chromium-review.googlesource.com/1128854 the differences being: 1) caching the literal id on UncompiledData rather than always linearly searching the SFI list, and removing the unused runtime-liveedit.cc file instead of fixing it to support this change. 2) clearing padding on UncompiledData now that it has 3 int32 fields, making its end unaligned on x64. TBR=yangguo@chromium.org,marja@chromium.org,ulan@chromium.org,cbruni@chromium.org Bug: chromium:818642 Change-Id: I58dcb12a2a60a680f662568da428e01189c62638 Reviewed-on: https://chromium-review.googlesource.com/1138325Reviewed-by:
-
Dan Elphick authored
Since RO_SPACE objects can't move then IsDereferenceAllowed, just return true for any objects in RO_SPACE. R=leszeks Bug: v8:7786 Change-Id: I67d2d8902a3c2196991bf57ba719c8b05220cdbb Reviewed-on: https://chromium-review.googlesource.com/1138324Reviewed-by:
-
Jaroslav Sevcik authored
This also fixes JSCreateLowering::ReduceJSCreate to use in-object property count after slack tracking. This would still deserve some more bullet-proof treatment; in particular, we should make it somehow hard to access the pre-slack-tracking instance_size and inobject_property_count (and possibly other things that might be derived from the stale instance_size). Bug: v8:7790 Change-Id: Ie374e5a030ec2fe000647e94d848ca0f9ee346f4 Reviewed-on: https://chromium-review.googlesource.com/1138235 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:7424 Change-Id: I3055d4d98c108ce6e576f7171b8fae4e6b2c3948 Reviewed-on: https://chromium-review.googlesource.com/1131132 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54470}
-
Dan Elphick authored
This marks the following methods as V8_DEPRECATE_SOON and adds new versions that take Isolate* as their first parameter: PrimitiveArray::Set PrimitiveArray::Get StackTrace::GetFrame String::Write String::WriteOneByte String::WriteUtf8 String::Concat StringObject::New Additionally StackFrameInfo, Module and TemplateInfo are marked as NeverReadOnlySpaceObject so their GetIsolates calls are safe. In api.cc, ContextFromHeapObject is split into ContextFromNeverReadOnlySpaceObject and UnsafeContextFromHeapObject, where the latter uses the deprecated methods but is only called from methods that were themselves already marked V8_DEPRECATE_SOON. Deprecation warnings for using HeapObject::GetHeap/GetIsolate are suppressed for all the uses in V8_DEPRECATE_SOON methods so that stats produced using tools/collect_deprecation_stats.sh don't show them. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I48799b5599711661b14d0cd04f21a0a00322da4a Reviewed-on: https://chromium-review.googlesource.com/1136641 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Max Moroz authored
Bug: Chromium:841975 Change-Id: Ife77805fa3977dc874087ca7ae810eded2ae1c55 Reviewed-on: https://chromium-review.googlesource.com/1136986Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54468}
-
Maya Lekova authored
We used to have an optimized version for nodes that are concatenating two strings which was allocating an object on the heap, therefore preventing this code from being executed on the compiler thread. Octane benchmark results show insignificant increase in performance (< 0.5%) without this optimization - see https://docs.google.com/spreadsheets/d/1MC5NrMoMSsqxZqw0ojoZvomBb7q2EOt1S0sFoJ8ld2c/edit?usp=sharing which leads to the conclusion we can safely remove the optimization for now. Bug: v8:7790 Change-Id: I6492c6a76118cac568d28805995d55c5360bb123 Reviewed-on: https://chromium-review.googlesource.com/1138246Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 1d4a1172. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/21989 Original change's description: > [sfi] Remove SFI function literal id field > > SharedFunctionInfos store their original function literal's id. This is > also their index in the Script's SFI list. > > The function literal id is only needed for lazy compilation and live edit, > and access only has to be fast in the former. So, we can move the SFI > function literal id field to UncompiledData, and if patching with live > edit, or discarding compiled code, we can perform a slower linear search > through the Script's SFI list. > > This is a reland of > https://chromium-review.googlesource.com/c/v8/v8/+/1082480 > but caching the literal id on UncompiledData rather than always linearly > searching the SFI list. Also, removes the unused runtime-liveedit.cc file > instead of fixing it to support this change. > > Bug: chromium:818642 > Change-Id: I977bcca0dc72903ca476a7079d156cc8bbe88fde > Reviewed-on: https://chromium-review.googlesource.com/1128854 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54464} TBR=ulan@chromium.org,marja@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,cbruni@chromium.org,leszeks@chromium.org,verwaest@chromium.org Change-Id: Icee5ee3ab7688b93e2963f91debed65a58164534 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:818642 Reviewed-on: https://chromium-review.googlesource.com/1138276Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54466}
-
Camillo Bruni authored
- Log script sources with --log-function-events - Don't show confusing duration in graphs - Introduce separate compilation category - Log script details after deserialization - Log parse times for eval scripts - Display deserialized scripts and functions Change-Id: I58f3bf8efe3955632322f958716c36ad38761fd0 Bug: chromium:757467, chromium:850038 Reviewed-on: https://chromium-review.googlesource.com/1128082Reviewed-by:
-
Leszek Swirski authored
SharedFunctionInfos store their original function literal's id. This is also their index in the Script's SFI list. The function literal id is only needed for lazy compilation and live edit, and access only has to be fast in the former. So, we can move the SFI function literal id field to UncompiledData, and if patching with live edit, or discarding compiled code, we can perform a slower linear search through the Script's SFI list. This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/1082480 but caching the literal id on UncompiledData rather than always linearly searching the SFI list. Also, removes the unused runtime-liveedit.cc file instead of fixing it to support this change. Bug: chromium:818642 Change-Id: I977bcca0dc72903ca476a7079d156cc8bbe88fde Reviewed-on: https://chromium-review.googlesource.com/1128854Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Maya Lekova authored
Bug: v8:7790 Change-Id: Iba1c887897d17d75c4371b18f375983f7499120a Reviewed-on: https://chromium-review.googlesource.com/1138075 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This is a reland of b7f0951f Original change's description: > [wasm] Add a separate CodeTracer to the WasmEngine. > > This makes sure the TurboFan pipeline is independent of the Isolate by > getting the CodeTracer from the WasmEngine for WebAssembly compilations. > > R=clemensh@chromium.org > > Change-Id: I343af1a2bfaeff77e2f41ef0c53fbfe165e2e202 > Reviewed-on: https://chromium-review.googlesource.com/1134997 > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54455} Change-Id: I48b161b5f35dd388fd3ef299afe04214a666b5a6 Reviewed-on: https://chromium-review.googlesource.com/1138114 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:863362 Change-Id: I88896d7477d893f1b7fae08f6dfd5709748a6edd Reviewed-on: https://chromium-review.googlesource.com/1138080Reviewed-by:
-
Yang Guo authored
R=bmeurer@chromium.org, ulan@chromium.org Bug: chromium:680662 Change-Id: I5e1486ad2a42db2998d5485a0c4e711378678e6c Reviewed-on: https://chromium-review.googlesource.com/1136034Reviewed-by:
-
Sigurd Schneider authored
This reverts commit b7f0951f. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/21517 Original change's description: > [wasm] Add a separate CodeTracer to the WasmEngine. > > This makes sure the TurboFan pipeline is independent of the Isolate by > getting the CodeTracer from the WasmEngine for WebAssembly compilations. > > R=clemensh@chromium.org > > Change-Id: I343af1a2bfaeff77e2f41ef0c53fbfe165e2e202 > Reviewed-on: https://chromium-review.googlesource.com/1134997 > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54455} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: I5f69f12ab29dcb92e7b7f53632eb73a3abc1f6af No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1138113Reviewed-by:
-
Clemens Hammacher authored
This helps debugging wasm crashes. {WasmCompiledFrame::Print} should also print the position inside the current function, additional to the absolute position in the wasm module. The source positions encoded in wasm code are also function-relative, so with the additional output it's easier to match them. R=ahaas@chromium.org Change-Id: I40f99e75e3ba25fdfd24943ea96e49868b91844f Reviewed-on: https://chromium-review.googlesource.com/1138053Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54458}
-
Peter Marshall authored
We convert this {ptr, size} pair to an ArrayBuffer::Allocation when we need to free it anyway, so we can get rid of this intermediate step to make things simpler. Change-Id: I6e82949ec02acb5794f4d668afb2313ebdcb9d52 Reviewed-on: https://chromium-review.googlesource.com/1136309 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54457}
-
Michael Starzinger authored
R=clemensh@chromium.org TEST=mjsunit/wasm/worker-module Change-Id: I56c274c67354d534f86312ee8fe7b7761da8ca44 Reviewed-on: https://chromium-review.googlesource.com/1138074Reviewed-by:
-
Michael Starzinger authored
This makes sure the TurboFan pipeline is independent of the Isolate by getting the CodeTracer from the WasmEngine for WebAssembly compilations. R=clemensh@chromium.org Change-Id: I343af1a2bfaeff77e2f41ef0c53fbfe165e2e202 Reviewed-on: https://chromium-review.googlesource.com/1134997 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This CL adds inlining for the Number constructor if new.target is not present. The lowering is BigInt compatible, i.e. it converts BigInts to numbers. Bug: v8:7904 Change-Id: If03b9f872d82e50b6ded7709069181c33dc44e82 Reviewed-on: https://chromium-review.googlesource.com/1118557 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL renames Constant to ExternConstant (this already happend in the grammar). It also enforces the rule that such extern constants require "constexpr" types. Drive-by-change: Replaced non constexpr extern constants with module constants. R=tebbi@chromium.org Bug: v8:7793 Change-Id: Icb3f75071b15b1fcabbe447941e05dd5a09d4b23 Reviewed-on: https://chromium-review.googlesource.com/1136434Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: I96fa8f6c2dbc9fb3da0be9a8b8d730cc1d1e3415 Reviewed-on: https://chromium-review.googlesource.com/1131456 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Iab7210eaddb14c9ca8638cbc8d69206bbaf15462 Reviewed-on: https://chromium-review.googlesource.com/1134785Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54451}
-
