• Clemens Hammacher's avatar
    [turbofan] lea32 must create zero-extended value · b2b2583d
    Clemens Hammacher authored
    The instruction selector currently sometimes emits a lea32 with an
    offset of 0, which the code generator just ignores (emits no code at
    all). This can result in the result of TruncateInt64ToInt32 to not be
    zero extended.
    This CL fixes that by disallowing lea32 instructions with 0 offset, and
    fixing the instruction selector to generate a movl or just no code for
    that case.
    
    R=jarin@chromium.org
    
    Bug: chromium:863810, v8:7947
    Change-Id: I1b21fc5f0fda9ca3144917538c3d0bbf46601c33
    Reviewed-on: https://chromium-review.googlesource.com/1137825Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54489}
    b2b2583d
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...