- 03 Feb, 2021 1 commit
-
-
Michael Lippautz authored
Adds testing API that can only be used after enabling it on a heap. The call that enables testing is only provided via v8_for_testing or cppgc_for_testing build targets which protects against misusing from production code. Change-Id: I24a8f5543a2bb479481384e2c555d231383e5d12 Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2667513Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#72503}
-
- 28 Jan, 2021 3 commits
-
-
Clemens Backes authored
The "noexcept" annotation is part of the type since C++17, so we cannot just change v8.h to add the annotation everywhere. So instead ignore missing V8_NOEXCEPT annotations in api.cc R=marja@chromium.org CC=jdoerrie@chromium.org No-Try: true Bug: v8:8616 Change-Id: I8f68a6d20653ee8c0e3d995cf585b36cbc15c5f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655446 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#72397}
-
Marja Hölttä authored
This reverts commit 1b4811f7. Reason for revert: makes "git cl upload" fail (the change related to files_to_skip) Original change's description: > [debug][api] Move debugger support to debug-interface.cc. > > Previously we had the debugger / inspector support declared in > debug-interface.h, but the implementation was sprinkled all across > api.cc, which was quite messy. This moves the relevant macros and > other bits into api-macros.h (with api-macros-undef.h to support > jumbo builds), and moves the debugger interface implementation to > src/debug/debug-interface.cc. > > Bug: chromium:1162229 > Change-Id: I6965ebf2301459c89e3217bd87396ec353d814e9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653154 > Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72392} TBR=yangguo@chromium.org,bmeurer@chromium.org Change-Id: Ib9460709df799cd63b221f9f30dc33dff53075bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1162229 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655508Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#72393}
-
Benedikt Meurer authored
Previously we had the debugger / inspector support declared in debug-interface.h, but the implementation was sprinkled all across api.cc, which was quite messy. This moves the relevant macros and other bits into api-macros.h (with api-macros-undef.h to support jumbo builds), and moves the debugger interface implementation to src/debug/debug-interface.cc. Bug: chromium:1162229 Change-Id: I6965ebf2301459c89e3217bd87396ec353d814e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653154 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#72392}
-
- 10 Nov, 2020 1 commit
-
-
Sathya Gunasekaran authored
Instead of just warning, let's try to format the files as well Bug: v8:10670 Change-Id: I0dfbdc0ed4a96af7f2a2a472f1d0d3d332d39c90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2523193 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71076}
-
- 03 Nov, 2020 1 commit
-
-
Sathya Gunasekaran authored
This is a reland of 1ec8f1da Original change's description: > [presubmit] Add JS formatting for tools/system-analyzer > > Bug: v8:10670 > Change-Id: Ifb653ada003719faff261b6e5b2169db37cffdaf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282522 > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68909} Bug: v8:10670 Change-Id: I4903b3eb8ff39a76594324076f0840b06290044e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307229 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70938}
-
- 10 Aug, 2020 1 commit
-
-
Clemens Backes authored
We consider some function "test-only" function, e.g. if they have a "ForTesting" in their name. The src/runtime/runtime-test.cc file should be allowed to call such functions. R=tmrts@chromium.org CC=ahaas@chromium.org Change-Id: Ib57bba36ba35f29c7673d4cef6d6b1e5ad9c7f65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339623Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#69308}
-
- 27 Jul, 2020 1 commit
-
-
Michael Achenbach authored
Updating was prepared on depot_tools side by https://crbug.com/1098560. No-Try: true Bug: v8:10619 Change-Id: If24aec3344e83857c09ce165be4203846b3a91b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316302Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#69083}
-
- 17 Jul, 2020 2 commits
-
-
Clemens Backes authored
This reverts commit 1ec8f1da. Reason for revert: Fails presubmit: https://ci.chromium.org/p/v8/builders/ci/V8%20Presubmit/11696 Original change's description: > [presubmit] Add JS formatting for tools/system-analyzer > > Bug: v8:10670 > Change-Id: Ifb653ada003719faff261b6e5b2169db37cffdaf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282522 > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68909} TBR=gsathya@chromium.org,tmrts@chromium.org Change-Id: I0824ede745b5fe054b8e9984440f6013de271b83 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10670 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2304577Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68910}
-
Sathya Gunasekaran authored
Bug: v8:10670 Change-Id: Ifb653ada003719faff261b6e5b2169db37cffdaf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282522Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#68909}
-
- 24 Jan, 2020 1 commit
-
-
Al Muthanna Athamina authored
This CL attempts to remove the #undef check from the Presubmit for .cc files because we are removing Jumbo support. Bug: chromium:994387 Change-Id: I1bb6d22393c1b533f23dd586e5028ecc6d254c99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2013119Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#65978}
-
- 13 Dec, 2019 1 commit
-
-
Michael Starzinger authored
R=clemensb@chromium.org Change-Id: Ibd6790a222590fd4dce9f918219a19f01c2e1e0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1960293Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65439}
-
- 30 Sep, 2019 1 commit
-
-
Liviu Rau authored
When a DEPS file changes we need to verify at presubmit all other files sitting in the same dir as the DEPS file (& below recursively). Bug: v8:9692 Change-Id: I7ae3b4cec5ab3bf970f0d04afe54e8f40138b819 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803644Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#64034}
-
- 26 Sep, 2019 1 commit
-
-
Clemens Backes authored
R=adamk@chromium.org No-Try: true Change-Id: I71824f52802c125dbee51216054575f44d08d534 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1825243 Commit-Queue: Clemens Backes [né Hammacher] <clemensb@chromium.org> Auto-Submit: Clemens Backes [né Hammacher] <clemensb@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#63983}
-
- 16 Sep, 2019 1 commit
-
-
Liviu Rau authored
No-Try: true Bug: v8:9396 Change-Id: Ife254c964a418b5a2c666acf618b66e5273f31d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800284 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63778}
-
- 20 May, 2019 1 commit
-
-
Yang Guo authored
TBR=verwaest@chromium.org,rmcilroy@chromium.org NOTREECHECKS=true NOPRESUBMIT=true Bug: v8:9247 Change-Id: I9ddfb6e56ca8e47c4ac186a8df5f442d26420a69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617661 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61642}
-
- 20 Feb, 2019 4 commits
-
-
Sigurd Schneider authored
This reverts commit 0052f12a. Reason for revert: Fix available Original change's description: > [torque] Temporarily disable torque format check to pass presubmit > > Revert this once the bug is fixed. > > Change-Id: I28490ecc9290b5c1f09e1ee8bcd8b600f79f017d > Bug: v8:8873 > Notry: true > Notreechecks: true > Reviewed-on: https://chromium-review.googlesource.com/c/1477747 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59720} TBR=machenbach@chromium.org,sigurds@chromium.org,tebbi@chromium.org Change-Id: I1a51ee93d7adbd1f14103da68e64548141163706 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8873 Reviewed-on: https://chromium-review.googlesource.com/c/1478198Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59735}
-
Sigurd Schneider authored
This reverts commit 91213b5c. Reason for revert: Fix available Original change's description: > [torque] Temporarily remove torque format check to pass presubmit > > Revert this once the bug is fixed. > > TBR=machenbach@chromium.org > > Change-Id: I32c9ef41b968e37b6de9eddb7e4e27c1d60c87c8 > Bug: v8:8873 > Notry: true > Notreechecks: true > Reviewed-on: https://chromium-review.googlesource.com/c/1477749 > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59721} TBR=sigurds@chromium.org Change-Id: Icf4454ca9ed1d276fe0a0a3fa0bba3553a6b8a87 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8873 Reviewed-on: https://chromium-review.googlesource.com/c/1478197Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59734}
-
Sigurd Schneider authored
Revert this once the bug is fixed. TBR=machenbach@chromium.org Change-Id: I32c9ef41b968e37b6de9eddb7e4e27c1d60c87c8 Bug: v8:8873 Notry: true Notreechecks: true Reviewed-on: https://chromium-review.googlesource.com/c/1477749Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59721}
-
Sigurd Schneider authored
Revert this once the bug is fixed. Change-Id: I28490ecc9290b5c1f09e1ee8bcd8b600f79f017d Bug: v8:8873 Notry: true Notreechecks: true Reviewed-on: https://chromium-review.googlesource.com/c/1477747 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59720}
-
- 09 Jan, 2019 2 commits
-
-
Yang Guo authored
Change-Id: Ibd14f7b3fe78635675c76ae864112e3a3a7bc701 Reviewed-on: https://chromium-review.googlesource.com/c/1382463 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#58674}
-
Tamer Tas authored
R=sergiyb@chromium.org No-Try: true Change-Id: I94937b6852c8e7e8aece3b67eb1c2a79dbf71c25 Reviewed-on: https://chromium-review.googlesource.com/c/1392193 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58671}
-
- 07 Jan, 2019 1 commit
-
-
Clemens Hammacher authored
We were missing a few declarations, especially fully-qualified declarations in cc files like here: https://crrev.com/c/1396459 R=mlippautz@chromium.org Bug: v8:8616 No-Try: true Change-Id: Iff93f1cd4fde18ac7fc8391e459e6bdcb4eb8f9b Reviewed-on: https://chromium-review.googlesource.com/c/1397706Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58585}
-
- 03 Jan, 2019 1 commit
-
-
Clemens Hammacher authored
We don't have our macros available there, so we should not enforce V8_NOEXCEPT on types declared in include/v8.h or other files in include/. R=mlippautz@chromium.org Bug: v8:8616 No-Try: true Change-Id: I51550a072a7957921c6cbd7e0866093f0462ff4e Reviewed-on: https://chromium-review.googlesource.com/c/1394547Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58520}
-
- 20 Dec, 2018 2 commits
-
-
Clemens Hammacher authored
The V8_NOEXCEPT annotation is not needed for deleted class members. Also our DISALLOW_COPY_AND_ASSIGN macro does not add it there. Additionally, include the file name to find the reported location more easy. R=jkummerow@chromium.org Bug: v8:8616 No-Try: true Change-Id: I93162804493542fed2a5832649b80386e338bd47 Reviewed-on: https://chromium-review.googlesource.com/c/1386870 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58406}
-
Clemens Hammacher authored
Forgetting V8_NOEXCEPT annotations on copy constructors, move constructors, copy assignment operators or move assignment operators can cause subtle performance bugs or compilation failures, sometimes only on specific architectures or compilers. Thus check that all those special class members are marked V8_NOEXCEPT. This check is only executed on modified files for now, and can be bypassed. Please report any false positives on the associated bug. Bug: v8:8616 R=jgruber@chromium.org, machenbach@chromium.org Change-Id: Ieefd8e39fbb1b314dc8d72ee87f6138b784205af Reviewed-on: https://chromium-review.googlesource.com/c/1386496Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58404}
-
- 30 Oct, 2018 1 commit
-
-
Sergiy Byelozyorov authored
We define a TestFailedError exception and raise it when we can reliably detect that a test has crashed. All other exceptions are treated as infra failures and are captured by the try-catch clause in MainWrapper function. This also fixes all tests in run_perf_test.py, run_tests_test.py and makes sure that both are run on any changes in tools directory. R=machenbach@chromium.org Bug: chromium:899028 Change-Id: I283bc87b31c814be476bebe9fdda414975494183 Reviewed-on: https://chromium-review.googlesource.com/c/1303293 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57134}
-
- 24 Oct, 2018 1 commit
-
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org No-Try: true No-Tree-Checks: true Bug: chromium:892433 Change-Id: Id323739be44ea55d73c712059520d7f5e684c97e Reviewed-on: https://chromium-review.googlesource.com/c/1280304Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#56949}
-
- 25 Sep, 2018 2 commits
-
-
Daniel Clifford authored
Change-Id: I69a4db1d8be47bad56df74447a29526e9623cb80 Reviewed-on: https://chromium-review.googlesource.com/1243107 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#56219}
-
Daniel Clifford authored
Bug: v8:7793 Change-Id: I18bd30b36be3c3f89962a2e9c04d8f159c8cfe2b Reviewed-on: https://chromium-review.googlesource.com/1240415 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#56202}
-
- 06 Jun, 2018 1 commit
-
-
Sergiy Byelozyorov authored
This will prevent failures like this one: https://ci.chromium.org/p/v8/builds/b8945509831610302560 R=machenbach@chromium.org No-Try: true Bug: chromium:831171 Change-Id: I3f5c5ce6ea2148c22e4ef0b18495e10e37fd3fed Reviewed-on: https://chromium-review.googlesource.com/1074367Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#53558}
-
- 27 Apr, 2018 1 commit
-
-
Michael Achenbach authored
This adds parts of Chromium's PanProjectChecks. We don't add all yet as there is to much chance for the checks to fire on files later. We first need to find a way to run the checks on all files (not only changed ones). NOTRY=true Bug: v8:7689 Change-Id: I747b49a9a362cf76f329e7f743545c6e6cb56f85 Reviewed-on: https://chromium-review.googlesource.com/1029854Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52828}
-
- 08 Feb, 2018 1 commit
-
-
Yang Guo authored
R=machenbach@chromium.org Bug: v8:7335 Change-Id: Ied1101295fc9ee37fcc038b9aeb557229722df0b Reviewed-on: https://chromium-review.googlesource.com/897566 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51185}
-
- 02 Feb, 2018 1 commit
-
-
jgruber authored
This check verifies that all .h files in the src/ directory have an include guard of the form #ifndef V8_PATH_TO_FILE_H_ #define V8_PATH_TO_FILE_H_ // ... #endif // V8_PATH_TO_FILE_H_ The check can be skipped with a magic comment: // PRESUBMIT_INTENTIONALLY_MISSING_INCLUDE_GUARD Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0a7b96abec289ad60f64ba8418f1892a6969596d Reviewed-on: https://chromium-review.googlesource.com/897487Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#51079}
-
- 23 Jan, 2018 1 commit
-
-
Yang Guo authored
Bug: v8:7341 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I90879be3a94745859b7da7c9bb9b6533af11cc2d Reviewed-on: https://chromium-review.googlesource.com/878221Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50790}
-
- 22 Dec, 2017 1 commit
-
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org No-Try: true Bug: chromium:797083 Change-Id: I6376f1bd652dd20fb44f551e029ce8b71eba7545 Reviewed-on: https://chromium-review.googlesource.com/842866 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#50296}
-
- 03 Nov, 2017 1 commit
-
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:777893 Change-Id: I2816934494309da458589b7d9b0c46fba9beaf38 Reviewed-on: https://chromium-review.googlesource.com/741221 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49102}
-
- 14 Sep, 2017 1 commit
-
-
Michael Starzinger authored
R=machenbach@chromium.org Change-Id: I9adf50ef62abf310a0722160ff7997b87e1733f6 Reviewed-on: https://chromium-review.googlesource.com/664800 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48009}
-
- 11 Sep, 2017 1 commit
-
-
Clemens Hammacher authored
With jumbo builds, we get spurious errors if several .cc files define the same preprocessor macro without undefining it. This is also disallowed by the style guide. This patch adds a presubmit check to check that each #define is eventually followed by a corresponding #undef. Special care has to be taken for conditionally defined macros. Here, the logic to check that there are not multiple defines and that they are undefined in all cases is not perfect; it's optimistic in order to avoid false positives. R=mstarzinger@chromium.org, machenbach@chromium.org Bug: v8:6811 Change-Id: I55cde499399d97a5eb02fbc5ecfa34e6a8099d06 Reviewed-on: https://chromium-review.googlesource.com/657104 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#47944}
-
- 06 Jun, 2017 1 commit
-
-
Daniel Ehrenberg authored
Change-Id: Ibd0cfc0c03b94ed6e15c6496cf16d9059447467c Reviewed-on: https://chromium-review.googlesource.com/525472Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#45729}
-