1. 03 Feb, 2021 1 commit
  2. 28 Jan, 2021 3 commits
    • Clemens Backes's avatar
      [presubmit] Skip api.cc when checking for V8_NOEXCEPT · f630c44d
      Clemens Backes authored
      The "noexcept" annotation is part of the type since C++17, so we cannot
      just change v8.h to add the annotation everywhere. So instead ignore
      missing V8_NOEXCEPT annotations in api.cc
      
      R=marja@chromium.org
      CC=jdoerrie@chromium.org
      
      No-Try: true
      Bug: v8:8616
      Change-Id: I8f68a6d20653ee8c0e3d995cf585b36cbc15c5f0
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655446
      Commit-Queue: Clemens Backes <clemensb@chromium.org>
      Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#72397}
      f630c44d
    • Marja Hölttä's avatar
      Revert "[debug][api] Move debugger support to debug-interface.cc." · ab7c7c78
      Marja Hölttä authored
      This reverts commit 1b4811f7.
      
      Reason for revert: makes "git cl upload" fail (the change related to files_to_skip)
      
      Original change's description:
      > [debug][api] Move debugger support to debug-interface.cc.
      >
      > Previously we had the debugger / inspector support declared in
      > debug-interface.h, but the implementation was sprinkled all across
      > api.cc, which was quite messy. This moves the relevant macros and
      > other bits into api-macros.h (with api-macros-undef.h to support
      > jumbo builds), and moves the debugger interface implementation to
      > src/debug/debug-interface.cc.
      >
      > Bug: chromium:1162229
      > Change-Id: I6965ebf2301459c89e3217bd87396ec353d814e9
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653154
      > Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#72392}
      
      TBR=yangguo@chromium.org,bmeurer@chromium.org
      
      Change-Id: Ib9460709df799cd63b221f9f30dc33dff53075bd
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:1162229
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655508Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Commit-Queue: Marja Hölttä <marja@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#72393}
      ab7c7c78
    • Benedikt Meurer's avatar
      [debug][api] Move debugger support to debug-interface.cc. · 1b4811f7
      Benedikt Meurer authored
      Previously we had the debugger / inspector support declared in
      debug-interface.h, but the implementation was sprinkled all across
      api.cc, which was quite messy. This moves the relevant macros and
      other bits into api-macros.h (with api-macros-undef.h to support
      jumbo builds), and moves the debugger interface implementation to
      src/debug/debug-interface.cc.
      
      Bug: chromium:1162229
      Change-Id: I6965ebf2301459c89e3217bd87396ec353d814e9
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653154
      Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#72392}
      1b4811f7
  3. 10 Nov, 2020 1 commit
  4. 03 Nov, 2020 1 commit
  5. 10 Aug, 2020 1 commit
  6. 27 Jul, 2020 1 commit
  7. 17 Jul, 2020 2 commits
  8. 24 Jan, 2020 1 commit
  9. 13 Dec, 2019 1 commit
  10. 30 Sep, 2019 1 commit
  11. 26 Sep, 2019 1 commit
  12. 16 Sep, 2019 1 commit
  13. 20 May, 2019 1 commit
  14. 20 Feb, 2019 4 commits
  15. 09 Jan, 2019 2 commits
  16. 07 Jan, 2019 1 commit
  17. 03 Jan, 2019 1 commit
  18. 20 Dec, 2018 2 commits
  19. 30 Oct, 2018 1 commit
  20. 24 Oct, 2018 1 commit
  21. 25 Sep, 2018 2 commits
  22. 06 Jun, 2018 1 commit
  23. 27 Apr, 2018 1 commit
    • Michael Achenbach's avatar
      [V8] Add back owners check · 8961287a
      Michael Achenbach authored
      This adds parts of Chromium's PanProjectChecks. We don't add all yet
      as there is to much chance for the checks to fire on files later. We
      first need to find a way to run the checks on all files (not only
      changed ones).
      
      NOTRY=true
      
      Bug: v8:7689
      Change-Id: I747b49a9a362cf76f329e7f743545c6e6cb56f85
      Reviewed-on: https://chromium-review.googlesource.com/1029854Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52828}
      8961287a
  24. 08 Feb, 2018 1 commit
  25. 02 Feb, 2018 1 commit
  26. 23 Jan, 2018 1 commit
  27. 22 Dec, 2017 1 commit
  28. 03 Nov, 2017 1 commit
  29. 14 Sep, 2017 1 commit
  30. 11 Sep, 2017 1 commit
    • Clemens Hammacher's avatar
      [presubmit] Add check for unbalanced #define / #undef · b8cc63ee
      Clemens Hammacher authored
      With jumbo builds, we get spurious errors if several .cc files define
      the same preprocessor macro without undefining it. This is also
      disallowed by the style guide.
      This patch adds a presubmit check to check that each #define is
      eventually followed by a corresponding #undef. Special care has to be
      taken for conditionally defined macros. Here, the logic to check that
      there are not multiple defines and that they are undefined in all
      cases is not perfect; it's optimistic in order to avoid false positives.
      
      R=mstarzinger@chromium.org, machenbach@chromium.org
      
      Bug: v8:6811
      Change-Id: I55cde499399d97a5eb02fbc5ecfa34e6a8099d06
      Reviewed-on: https://chromium-review.googlesource.com/657104
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47944}
      b8cc63ee
  31. 06 Jun, 2017 1 commit