Skip to content

V
V8
Commit 961125b7 authored by Sergiy Byelozyorov's avatar Sergiy Byelozyorov Committed by Commit Bot
Browse files
Options

[tools] Move path-specific try-builders to the CQ config 

R=machenbach@chromium.org

No-Try: true
No-Tree-Checks: true
Bug: chromium:892433
Change-Id: Id323739be44ea55d73c712059520d7f5e684c97e
Reviewed-on: https://chromium-review.googlesource.com/c/1280304Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56949}
parent f19c4a59
Hide whitespace changes
Inline Side-by-side
Showing with 37 additions and 115 deletions
PRESUBMIT.py
View file @ 961125b7
......@@ -458,19 +458,3 @@ def CheckChangeOnCommit(input_api, output_api):
input_api, output_api,
json_url='http://v8-status.appspot.com/current?format=json'))
return results
def PostUploadHook(cl, change, output_api):
"""git cl upload will call this hook after the issue is created/modified.
This hook adds a noi18n bot if the patch affects Intl.
"""
def affects_intl(f):
return 'intl' in f.LocalPath() or 'test262' in f.LocalPath()
if not change.AffectedFiles(file_filter=affects_intl):
return []
return output_api.EnsureCQIncludeTrybotsAreAdded(
cl,
[
'luci.v8.try:v8_linux_noi18n_rel_ng'
],
'Automatically added noi18n trybots to run tests on CQ.')
include/PRESUBMIT.py deleted 100644 → 0
View file @ f19c4a59
# Copyright 2017 the V8 project authors. All rights reserved.')
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Presubmit script for //v8/include
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details about the presubmit API built into depot_tools.
"""
import os
def PostUploadHook(cl, change, output_api):
"""git cl upload will call this hook after the issue is created/modified.
This hook adds extra try bots to the CL description in order to run layout
tests in addition to CQ try bots.
"""
def header_filter(f):
return '.h' in os.path.split(f.LocalPath())[1]
if not change.AffectedFiles(file_filter=header_filter):
return []
return output_api.EnsureCQIncludeTrybotsAreAdded(
cl,
[
'luci.chromium.try:linux_chromium_rel_ng'
],
'Automatically added layout test trybots to run tests on CQ.')
infra/config/cq.cfg
View file @ 961125b7
......@@ -112,24 +112,56 @@ verifiers {
name: "v8_win_rel_ng_triggered"
triggered_by: "v8_win_rel_ng"
}
builders {
name: "v8_linux_noi18n_rel_ng"
path_regexp: ".*intl.*"
path_regexp: ".*test262.*"
}
}
# TODO(machenbach): Remove after testing in practice and migrate to
# PRESUBMIT.py scripts.
buckets {
name: "luci.chromium.try"
builders {
name: "linux_chromium_rel_ng"
path_regexp: "include/.+\\.h"
path_regexp: "src/api\\.cc"
}
builders {
name: "linux_chromium_headless_rel"
path_regexp: "src/inspector/.+"
path_regexp: "test/inspector/.+"
}
# TODO(machenbach): Uncomment path_regexp after testing, as currently,
# path_regexp can not be combined with experiment_percentage. See more
# details at crbug.com/v8/8058.
builders {
name: "cast_shell_android"
#path_regexp: "include/.+\\.h"
#path_regexp: "src/api\\.cc"
experiment_percentage: 20
}
builders {
name: "cast_shell_linux"
#path_regexp: "include/.+\\.h"
#path_regexp: "src/api\\.cc"
experiment_percentage: 20
}
builders {
name: "linux-chromeos-rel"
#path_regexp: "include/.+\\.h"
#path_regexp: "src/api\\.cc"
experiment_percentage: 20
}
}
buckets {
name: "master.tryserver.blink"
builders {
name: "linux_trusty_blink_rel"
path_regexp: "src/inspector/.+"
path_regexp: "test/inspector/.+"
}
}
}
}
src/PRESUBMIT.py deleted 100644 → 0
View file @ f19c4a59
# Copyright 2017 the V8 project authors. All rights reserved.')
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Presubmit script for //v8/src
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details about the presubmit API built into depot_tools.
"""
import os
def PostUploadHook(cl, change, output_api):
"""git cl upload will call this hook after the issue is created/modified.
This hook adds extra try bots to the CL description in order to run layout
tests in addition to CQ try bots.
"""
def is_api_cc(f):
return 'api.cc' == os.path.split(f.LocalPath())[1]
if not change.AffectedFiles(file_filter=is_api_cc):
return []
return output_api.EnsureCQIncludeTrybotsAreAdded(
cl,
[
'luci.chromium.try:linux_chromium_rel_ng'
],
'Automatically added layout test trybots to run tests on CQ.')
src/inspector/OWNERS
View file @ 961125b7
......@@ -16,4 +16,7 @@ per-file js_protocol.pdl=set noparent
per-file js_protocol.pdl=dgozman@chromium.org
per-file js_protocol.pdl=pfeldman@chromium.org
per-file PRESUBMIT.py=machenbach@chromium.org
per-file PRESUBMIT.py=sergiyb@chromium.org
# COMPONENT: Platform>DevTools>JavaScript
src/inspector/PRESUBMIT.py
View file @ 961125b7
......@@ -51,17 +51,3 @@ def CheckChangeOnCommit(input_api, output_api):
results = []
results.extend(_CompileScripts(input_api, output_api))
return results
def PostUploadHook(cl, change, output_api):
"""git cl upload will call this hook after the issue is created/modified.
This hook adds extra try bots to the CL description in order to run layout
tests in addition to CQ try bots.
"""
return output_api.EnsureCQIncludeTrybotsAreAdded(
cl,
[
'master.tryserver.blink:linux_trusty_blink_rel',
'luci.chromium.try:linux_chromium_headless_rel',
],
'Automatically added layout test trybots to run tests on CQ.')
test/inspector/PRESUBMIT.py deleted 100644 → 0
View file @ f19c4a59
#!/usr/bin/env python
#
# Copyright 2018 the V8 project authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details about the presubmit API built into gcl.
"""
def PostUploadHook(cl, change, output_api):
"""git cl upload will call this hook after the issue is created/modified.
This hook adds extra try bots to the CL description in order to run layout
tests in addition to CQ try bots.
"""
return output_api.EnsureCQIncludeTrybotsAreAdded(
cl,
[
'master.tryserver.blink:linux_trusty_blink_rel',
'luci.chromium.try:linux_chromium_headless_rel',
],
'Automatically added layout test trybots to run tests on CQ.')
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment