Commit f630c44d authored by Clemens Backes's avatar Clemens Backes Committed by Commit Bot

[presubmit] Skip api.cc when checking for V8_NOEXCEPT

The "noexcept" annotation is part of the type since C++17, so we cannot
just change v8.h to add the annotation everywhere. So instead ignore
missing V8_NOEXCEPT annotations in api.cc

R=marja@chromium.org
CC=jdoerrie@chromium.org

No-Try: true
Bug: v8:8616
Change-Id: I8f68a6d20653ee8c0e3d995cf585b36cbc15c5f0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655446
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72397}
parent f91949a1
......@@ -480,8 +480,10 @@ def _CheckNoexceptAnnotations(input_api, output_api):
def FilterFile(affected_file):
return input_api.FilterSourceFile(
affected_file,
files_to_check=(r'src/.*', r'test/.*'))
files_to_check=(r'src[\\\/].*', r'test[\\\/].*'),
# Skip api.cc since we cannot easily add the 'noexcept' annotation to
# public methods.
files_to_skip=(r'src[\\\/]api[\\\/]api\.cc',))
# matches any class name.
class_name = r'\b([A-Z][A-Za-z0-9_:]*)(?:::\1)?'
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment