- 04 Mar, 2019 25 commits
-
-
Irina Yatsenko authored
AllocateUninitializedJSArrayWithElements into the method. Prior to the change, if the caller forgets to handle empty case on their side, AllocateUninitializedJSArrayWithElements would allocate a new empty FixedArray rather than return the canonical one. This refactor shifts the burden of canonicalization from the callers to AllocateUninitializedJSArrayWithElements. Bug: v8:6777 Change-Id: I1246cb288861b65b51938414a454f21af78f8399 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1480330Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#60015}
-
Simon Zünd authored
Moving to gtest allows negative test cases as the current parser implementation exits the process on a parser error. The CL adds two small negative tests. The idea is less to get full coverage, but to have a place for regression tests. Drive-by-change: Lexer errors need a valid source position scope and Json parser needs a valid SourceId, otherwise we read OOB when the error message is generated. R=petermarshall@chromium.org Bug: v8:8880 Change-Id: I56c4b9e0a29c8333b2e5e44f8116e5178552d2f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1498472Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60014}
-
Igor Sheludko authored
This CL also gives up trying to maintain double and system word fields at aligned addresses because currently it's not always maintained (v8:8875) and Torque object definitions do not support padding fields (v8:8863). Given that both platforms where pointer compression is going to be enabled (x64 and arm64) support loading of doubles and full words from 4-byte aligned addresses we are fine. Bug: v8:7703 Change-Id: I99fc6da5a0927f4db9b8fb24c7cc0bfc416523bc Reviewed-on: https://chromium-review.googlesource.com/c/1496974 Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60013}
-
Georg Neis authored
... by skipping over them. Such variables appear in the case of direct namespace exports and default exports. (Actually, the name used for default exports used to be "*default*" which is not recognized as synthetic, so I'm renaming it here to ".default"). Bug: chromium:932111 Change-Id: I0554dae9614334fdc02e78606f2db47e92196429 Reviewed-on: https://chromium-review.googlesource.com/c/1494010 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This CL removes PPC specific constants and makes the regular heap object size limit a power of two. Bug: chromium:852420 Change-Id: I5f4000f76d029d689d22112877eea124774b29d2 Reviewed-on: https://chromium-review.googlesource.com/c/1496367Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60011}
-
Tobias Tebbi authored
Bug: v8:8880 Change-Id: I835c465ccb63bcc20e9ec9cafda153a49de2bf7d Reviewed-on: https://chromium-review.googlesource.com/c/1497010Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#60010}
-
peterwmwong authored
Bug: v8:8906 Change-Id: I61c04471530ecf8b97e1e6a0670f52f55232395e Reviewed-on: https://chromium-review.googlesource.com/c/1497517 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
-
Simon Zünd authored
This CL introduces a declaration_position_ field on TypeAlias, corresponding with the SourcePosition of the name of the Type where it is declared. This information is needed by the language server for "goto defintion". R=tebbi@chromium.org Bug: v8:7793 Change-Id: I0de2f7b7ba23b86de34441107ca9982d190c227f Reviewed-on: https://chromium-review.googlesource.com/c/1497952 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
peterwmwong authored
Bug: v8:8906 Change-Id: I7a07482d2d5de13de11fa2611e3c6ae18439e820 Reviewed-on: https://chromium-review.googlesource.com/c/1493136 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
In the early days of Chrome when we used WebKit there was no support for ASCII strings on the C++ side, so we put a hint onto these two-byte strings that said "string only contains one byte data", such that internally in V8 when these were involved in string operations, we could instead create the *cheaper* one byte strings. Nowadays Blink properly supports one-byte string representations and this additional hint only comes with overhead, since we check it in quite a few places (i.e. on the hot path for string concatenation), plus we end up consuming more memory due to the additional string maps. Removing the hint also frees one bit in the InstanceType zoo for strings. This alone improves performance on the `bench-dom-serialize.js` test case by around **3%**. Tbr: mstarzinger@chromium.org Bug: v8:6622, v8:8834, v8:8939 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Change-Id: I0753f2859cee7b5a37b6f0da64d8ec39fcb044ff Doc: https://bit.ly/fast-string-concatenation-in-javascript Reviewed-on: https://chromium-review.googlesource.com/c/1498478 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#60006}
-
Igor Sheludko authored
Bug: v8:7703 Change-Id: I3d521423eec725915d1a197c79c076ad54eeef14 Reviewed-on: https://chromium-review.googlesource.com/c/1496368Reviewed-by:
-
Sven Sauleau authored
Removes the result_size parameter in TFC definitions which can be infered from the provided CallInterfaceDescriptor. Previously, the result size was added to support stubs with custom linkage. However, In pratice, the size don't differ from the provided CallInterfaceDescriptor (given that it's a DCHECK) and use mostly JS linkage (only one return). Change-Id: I8efdb3e3ce1a470735dac84ec6be506e071d2756 Bug: v8:6116 Reviewed-on: https://chromium-review.googlesource.com/c/1495554 Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#60004}
-
Dan Elphick authored
This adds a new method Isolate::LocaleConfigurationChangeNotification that clears the cached Locale allowing new Locales to be picked up in later Locale operations. It moves Date::DateTimeConfigurationChangeNotification to Isolate (deprecating the old one) so that the configuration change methods are found together. Change-Id: Iffc15e326933c5bc5baf2f0eafdd5c148b8279a8 Reviewed-on: https://chromium-review.googlesource.com/c/1491608Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#60003}
-
Dan Elphick authored
Removes JavaScriptFrame::CollectTopFrameForICStats whose last usage was removed in https://chromium-review.googlesource.com/626016. Bug: v8:8834 Change-Id: I9ffad0c712816696c56b746a137bed30362550bc Reviewed-on: https://chromium-review.googlesource.com/c/1496365 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60002}
-
Ross McIlroy authored
BUG=v8:8801 Change-Id: I9d9d9824c6c9ad0176bbfd3723da1b578b17c256 Reviewed-on: https://chromium-review.googlesource.com/c/1495555 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#60001}
-
Sigurd Schneider authored
This reverts commit 131f4a30. Reason for revert: Breaks snapshot builder: https://ci.chromium.org/p/v8/builders/ci/Linux%20Snapshot%20Builder/16103 Original change's description: > [gn] use relative paths for gtest and gmock > > TBR=machenbach@chromium.org > > Bug: v8:8941 > Change-Id: I0bbd119f7a613785b6e5e01cd8e59d5de40d68e1 > Reviewed-on: https://chromium-review.googlesource.com/c/1498473 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59996} TBR=machenbach@chromium.org,yangguo@chromium.org Change-Id: Ia2f377aa2e0fc69206104c4942085a9ded4534e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8941 Reviewed-on: https://chromium-review.googlesource.com/c/1497077 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60000}
-
peterwmwong authored
As the TODO's indicate, these helpers only used by TypedArray#join when it was implemented in JS. As of https://chromium-review.googlesource.com/c/v8/v8/+/1369330 TypedArray#join is now implemented Torque and was optimized in a way that no longer requires these helpers anymore. Bug: v8:7624 Change-Id: I1d1ff80235a12feb3846ff92764e8593ce7c72c9 Reviewed-on: https://chromium-review.googlesource.com/c/1498692Reviewed-by:
-
Dan Elphick authored
BytecodeArray::SourcePosition and BytecodeArray::SourceStatementPosition have no implementations and are never called. Bug: v8:8834 Change-Id: I919c871795084766856dfbff5344c037b6f33dd0 Reviewed-on: https://chromium-review.googlesource.com/c/1497009 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#59998}
-
Yu Yin authored
Change-Id: I3be3dc8815015c0215d3e3d655394850d85db871 Reviewed-on: https://chromium-review.googlesource.com/c/1490812Reviewed-by:
Predrag Rudic <prudic@wavecomp.com> Reviewed-by:
-
Yang Guo authored
TBR=machenbach@chromium.org Bug: v8:8941 Change-Id: I0bbd119f7a613785b6e5e01cd8e59d5de40d68e1 Reviewed-on: https://chromium-review.googlesource.com/c/1498473Reviewed-by:
-
Yu Yin authored
After 54a18895, Bug:7464, the permission of the page is read only, but this function need write permission. Since this function is not used, just remove it. Change-Id: I5a5976ab773bd808920893bbd2e3d9796e89e804 Reviewed-on: https://chromium-review.googlesource.com/c/1490813Reviewed-by:
-
Yu Yin authored
Change-Id: I2264b7850f2c091bfd28d90c5bfe36dcfe6e8a11 Reviewed-on: https://chromium-review.googlesource.com/c/1369908Reviewed-by:
-
Benedikt Meurer authored
Remove the duplication of the allocation logic via the AllocateOneByteConsString and AllocateTwoByteConsString helpers, and instead just have a diamond to figure out the result map. This reduces code size of the StringAdd_CheckNone builtin and even seems to be beneficial performance wise. It seems to improve the performance on the `bench-dom-serialize.js` test by around 1% just doing this. Drive-by-fix: Remove the `flags` from CodeStubAssembler::StringAdd() and its helpers, since we no longer support pretenuring of string additions (for quite a while now). Bug: v8:8834, v8:8939 Change-Id: Ia23e02c974b5f572930fcd45be0643094ab2fa98 Doc: https://bit.ly/fast-string-concatenation-in-javascript Reviewed-on: https://chromium-review.googlesource.com/c/1498133 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Simon Zünd authored
Stringification of Json wrongly used quotes for "true", "false" and "null". Drive-by: Manually flush std::cout when sending messages. This might fix the server on windows. R=tebbi@chromium.org Bug: v8:8880 Change-Id: Ie499595a1b429514c5d8b1d3ece24f4690ece02e Reviewed-on: https://chromium-review.googlesource.com/c/1498132Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9ed5110..9e80056 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/71bae22..e9e89e3 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I1d682a1b5ea7121f431366f1b65d05252c50e78a Reviewed-on: https://chromium-review.googlesource.com/c/1498693Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#59991}
-
- 03 Mar, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/74fd4a8..9ed5110 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/bd30f49..b3bee2e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c903198..71bae22 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I80dba99b9c73cf6d705fe91f7757d6a315392ad8 Reviewed-on: https://chromium-review.googlesource.com/c/1497519Reviewed-by:
-
- 02 Mar, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/04fc46b..74fd4a8 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/9950df1..bd30f49 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a6d41e2..c903198 Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/d50a88f..7a61cf3 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7233879445d4df56678de72707f3994891eaea72 Reviewed-on: https://chromium-review.googlesource.com/c/1497512Reviewed-by:
-
- 01 Mar, 2019 13 commits
-
-
Anton Bikineev authored
This is a cosmetic change aimed to reduce compilation time spent on instantiating things and potentially reduce code (in case instantiated specializations are in different shared objects). Change-Id: I719b4d376a0d707f4724555a2f404327d19d8477 Reviewed-on: https://chromium-review.googlesource.com/c/1484298 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Tom Tan authored
When running under simulator, all arm64 JIT instructions are interpreted by simulator via normal memory read, then no need to do icache/dcache flush. Also when running under simulator, cache_type_register_ is set to 0 explicitly in above CacheLineSizes class, which results in 0 value in both dstart and istart, then causes flush on this incorrect range. Bug: chromium:893460 Change-Id: Ief6cb09a0e89f7ede0761ad676ea6a882e9f4600 Reviewed-on: https://chromium-review.googlesource.com/c/1492514 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#59987}
-
Toon Verwaest authored
Change-Id: I1654da286ae15bc028803286a188b5d89111c3d3 Reviewed-on: https://chromium-review.googlesource.com/c/1495983 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#59986}
-
Sathya Gunasekaran authored
I thought about potentially adding the identifer ref to the error but that would require allocating a new string or at the very least increasing the size of the resulting cons string. Given that the parser is pretty performance sensitive, I've decided to not display the identifier. Previously, the error was: _test.js:3: Error a[foo].c = () => { throw Error(); }; ^ Error at a.(anonymous function).c (_test.js:3:26) at _test.js:5:1 With this patch, the error becomes: _test.js:3: Error a[foo].c = () => { throw Error(); }; ^ Error at a.<computed>.c (_test.js:3:26) at _test.js:5:1 Bug: v8:8823 Change-Id: I557b3517e317652c447ca06c5a400e9625353d9b Reviewed-on: https://chromium-review.googlesource.com/c/1495017 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Jeff Fisher authored
New tests added for: * Runtime.getProperties while debugger is paused * Runtime.exceptionThrown * Runtime.releaseObject/releaseObjectGroup Change-Id: I72b3455e9fb3269c097bf9a383187c119158a722 Reviewed-on: https://chromium-review.googlesource.com/c/1490172 Commit-Queue: Jeff Fisher <jeffish@microsoft.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#59984}
-
Georgia Kouveli authored
This is a port of the improvements to the ArgumentsAdaptorTrampoline that previously landed for x64. It skips the arguments adaptor frame creation if the callee cannot observe the actual arguments (as indicated by the "is_safe_to_skip_arguments_adaptor" bit on the SharedFunctionInfo), and instead just massages the current stack frame appropriately (either by pushing more undefineds in case of under application, or by removing the superfluous arguments in case of over application). Due to the 16 byte stack alignment requirement on arm64, we only skip the arguments adaptor frame creation when the difference between the expected and the actual argument number is even. When it is odd, we would still need to copy the actual arguments in the existing frame to account for the padding, which would defeat the point of the improvement. Bug: v8:8895 Tbr: jgruber@chromium.org Doc: http://bit.ly/v8-faster-calls-with-arguments-mismatch Change-Id: I7f13f6f0ba86edb483e088aac145cfcf9c937fef Reviewed-on: https://chromium-review.googlesource.com/c/1491633 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Sven Sauleau authored
Replaces assertErrorMessage by assertThrows. Previously assertErrorMessage didn't assert the error message that was provided. Change-Id: I30410b43ff16db448776d9f3cae817b1c0966b3d Reviewed-on: https://chromium-review.googlesource.com/c/1496973Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Cr-Commit-Position: refs/heads/master@{#59982}
-
Maciej Goszczycki authored
Bug: v8:8562 Change-Id: I05421c9fa96e6c1d424c6d529922cde02ba2dc37 Reviewed-on: https://chromium-review.googlesource.com/c/1494760Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Cr-Commit-Position: refs/heads/master@{#59981}
-
Daniel Bratell authored
There is both a v8::internal::SourcePosition and a v8::internal::torque::SourcePositon and in jumbo builds an unqualified SourcePositon ended up referring to the wrong one since nobody had told the compiler that the correct one existed. This broke jumbo builds of v8 cctests on Windows (because only in Windows will the compiler look for the symbol in a parent namespace). R=szuend@chromium.org Bug: v8:8880 Change-Id: I7c9ebf68629642b65e86d6a8ae458ec5ff01f2ce Reviewed-on: https://chromium-review.googlesource.com/c/1496972Reviewed-by:
-
Mike Stanton authored
If we make use of this in the generic Array.prototype.filter case we get a performance boost of over 60%. Bug: v8:8213, chromium:920187 Change-Id: Ia116a852f355a9f037850aee86db7284f0023929 Reviewed-on: https://chromium-review.googlesource.com/c/1484297Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#59979}
-
Tobias Tebbi authored
To make it obvious these are not defined in C++. Bug: v8:7793 Change-Id: Ib846023992e32ddd10dadc3834ce42b7604a1f48 Reviewed-on: https://chromium-review.googlesource.com/c/1495993Reviewed-by:
-
Simon Zünd authored
This CL changes 'Value' to use an 'Identifier' for its name, where the source position represents the point where it is defined. This is used to support "goto definition" for constants and extern constants. R=tebbi@chromium.org Bug: v8:8880 Change-Id: Ifb9ff08b36cbd9fb2691dbae579d2df29edd651d Reviewed-on: https://chromium-review.googlesource.com/c/1495986Reviewed-by:
-
Michael Achenbach authored
This makes the test runner and numfuzz share the same exit code behavior on errors. This is needed as they also share the same infrastructure logic to collect swarming tasks. Bug: chromium:937228 Change-Id: I155b37c7b10dd22959a4dcf30bbd0321c452236b Reviewed-on: https://chromium-review.googlesource.com/c/1495987Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59976}
-
