• Daniel Bratell's avatar
    Fixing SourcePosition ambiguity · e5ec83fb
    Daniel Bratell authored
    There is both a v8::internal::SourcePosition and a
    v8::internal::torque::SourcePositon and in jumbo builds
    an unqualified SourcePositon ended up referring to the wrong
    one since nobody had told the compiler that the correct one
    existed. This broke jumbo builds of v8 cctests
    on Windows (because only in Windows will the compiler look for
    the symbol in a parent namespace).
    
    R=szuend@chromium.org
    
    Bug: v8:8880
    Change-Id: I7c9ebf68629642b65e86d6a8ae458ec5ff01f2ce
    Reviewed-on: https://chromium-review.googlesource.com/c/1496972Reviewed-by: 's avatarMathias Bynens <mathias@chromium.org>
    Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Commit-Queue: Daniel Bratell <bratell@opera.com>
    Cr-Commit-Position: refs/heads/master@{#59980}
    e5ec83fb
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...