• Sathya Gunasekaran's avatar
    [fni] Mark computed props as computed, not anonymous function · ab24897c
    Sathya Gunasekaran authored
    I thought about potentially adding the identifer ref to the error but
    that would require allocating a new string or at the very least
    increasing the size of the resulting cons string. Given that the
    parser is pretty performance sensitive, I've decided to not display
    the identifier.
    
    Previously, the error was:
      _test.js:3: Error
      a[foo].c = () => { throw Error(); };
                         ^
      Error
        at a.(anonymous function).c (_test.js:3:26)
        at _test.js:5:1
    
    With this patch, the error becomes:
      _test.js:3: Error
      a[foo].c = () => { throw Error(); };
                         ^
      Error
        at a.<computed>.c (_test.js:3:26)
        at _test.js:5:1
    
    Bug: v8:8823
    Change-Id: I557b3517e317652c447ca06c5a400e9625353d9b
    Reviewed-on: https://chromium-review.googlesource.com/c/1495017
    Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
    Reviewed-by: 's avatarMathias Bynens <mathias@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59985}
    ab24897c
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...