- 19 Feb, 2018 3 commits
-
-
https://chromium-review.googlesource.com/c/v8/v8/+/924073/10Gabriel Charette authored
This is an attempt to isolate what's causing the hard-to-diagnose bots only failures with that CL. Bug: chromium:812178 Change-Id: I50ffe8953bebbbc6b5a5e2f689718662a537acb4 Reviewed-on: https://chromium-review.googlesource.com/924864Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#51348}
-
Erik Luo authored
Bug: chromium:810176 Change-Id: I089a1678dfbe0c3bb664e54818a6853f66d364b2 Reviewed-on: https://chromium-review.googlesource.com/923387 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#51347}
-
Marja Hölttä authored
Change-Id: I4f1d3bd609c48a8deed04e3e59ef326c0e4735c3 Reviewed-on: https://chromium-review.googlesource.com/923985Reviewed-by:
-
- 17 Feb, 2018 4 commits
-
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:616879 Change-Id: I5023040d3ce7753d39345033f91848e4f0ed36d9 Reviewed-on: https://chromium-review.googlesource.com/921101 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#51345}
-
Michael Achenbach authored
This reverts commit dda0419e. Reason for revert: msvc unhappy: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20msvc/builds/1434 Original change's description: > [bigint] Add BigInt64Array, BigUint64Array > > Bug: v8:6791 > Tbr: hpayer@chromium.org > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng > Change-Id: I637e9084d2fe4869ad0be2fb996149ab9940f346 > Reviewed-on: https://chromium-review.googlesource.com/914513 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51342} TBR=jkummerow@chromium.org,neis@chromium.org,hpayer@chromium.org Change-Id: I49237fa323f0d3ea70e744d92d5cbdd4d5c4b39f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6791 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/924663Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51344}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c5c828a..e2c6aae Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/a09e064..2888931 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e7298f3..4aa92ef TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id6e6a5be6a6c2480a83489b2c5f82d8f7139c4b3 Reviewed-on: https://chromium-review.googlesource.com/924357Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#51343}
-
Jakob Kummerow authored
Bug: v8:6791 Tbr: hpayer@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I637e9084d2fe4869ad0be2fb996149ab9940f346 Reviewed-on: https://chromium-review.googlesource.com/914513 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#51342}
-
- 16 Feb, 2018 23 commits
-
-
Michael Achenbach authored
Depends on: https://crrev.com/c/924114 TBR=yangguo@chromium.org Bug: chromium:756691 Change-Id: Ibbc3bd35e8727296c1539edc961e3184830575ff Reviewed-on: https://chromium-review.googlesource.com/924609Reviewed-by:
-
Bill Budge authored
- Replaces calls to Allocator Reserve, Free, and SetPermissions with equivalent page allocator calls (allocation.h). - Un-implements these methods to catch usage, in preparation for removing these. Bug: chromium:799573 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Id233b7a9cfc8e332c64e514f6359e8b670c2d75e Reviewed-on: https://chromium-review.googlesource.com/911883 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Eric Holk <eholk@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#51340}
-
Mathias Bynens authored
Intent to ship: https://groups.google.com/d/msg/v8-users/YZnlGa8ZMoc/_w7H3x_BAgAJ Bug: v8:7418 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I9e80dd98fa7b04fee3be591282e455f5576eeed2 Reviewed-on: https://chromium-review.googlesource.com/923728Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#51339}
-
Bill Budge authored
Bug: chromium:799573 Change-Id: I467c74b5b26bc6f1e1a35c1104df12b77f072bac Reviewed-on: https://chromium-review.googlesource.com/923430Reviewed-by:
-
Alexey Kozyatinskiy authored
We already cleanup these scripts on frontend side. It is crucial to cleanup them on backend side as well, since some web applications use following logic: get some data from network, add this data to buffer, try to parse buffer using JSON.parse. On each unsuccessfull JSON.parse we get another scriptFailedToParse event. Frontend logic of discarding scripts: https://goo.gl/FDtaWK Some idea of smarter logic here: track what script ids are reported using protocol and cleanup only script ids which reported not only as part of scriptFailedToParse event. R=alph@chromium.org Bug: chromium:810812 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifd67764c232e4abc7dc6e8e69a651bf9ac0e381b Reviewed-on: https://chromium-review.googlesource.com/919834 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#51337}
-
Michael Achenbach authored
NOTRY=true Bug: v8:7455 Change-Id: Icb82e8196bc16b4c8b0eebb3c5820e6b3d581735 Reviewed-on: https://chromium-review.googlesource.com/924309Reviewed-by:
-
Michael Achenbach authored
This will enable some fuzzers to alter the thread-pool size. Bug: v8:7455 Change-Id: Ic9c9600cdb3dc50e860dbda8432a23bb20f1dd44 Reviewed-on: https://chromium-review.googlesource.com/924273Reviewed-by:
-
Benedikt Meurer authored
The ES2017 specification contains a so-called "throwaway" promise that is used to specify the behavior of await in terms of PerformPromiseThen, but it's actually not necessary and never exposed to user code. In addition to that, hooking up the promise in await required a context (to refer to the generator object) and two closures for the reject/fulfill handling, which would resume the generator corresponding to the async function. That meant, we had to allocate 4 additional objects for every await. Instead of using a JSPromise plus the callbacks, this CL adds logic to allow PromiseReaction and PromiseReactionJobTask to carry arbitrary payloads and Code handlers. We use this for await to avoid the additional 4 objects mentioned above, and instead just have simple Code handlers that resume the generator (for the async function), either by throwing (in case of a rejection) or by resuming normally (in case of fulfillment). For this to work properly the JSGeneratorObject has to have a link to the outer promise returned by the async function, so that the catch prediction can still figure out what to do in case of promise rejection. This is done by adding a new generator_outer_promise_symbol when the debugger is active, which refers from the generator to the outer promise. With this change the doxbee-async-es2017-native test goes from around 100.54ms to around 82.45ms, which corresponds to a ~18% reduction in execution time. Bug: v8:7253 Change-Id: Iae25b3300bac351c3417be5ae687eff469b0e61f Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/924069Reviewed-by:
-
Erik Luo authored
Bug: chromium:810176 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I330fa0bdf81d0bb926cf6db794736e89c069f8f2 Reviewed-on: https://chromium-review.googlesource.com/907707Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#51333}
-
Benedikt Meurer authored
Add TurboFan inlining support for the following V8 Extras: - v8.createPromise - v8.rejectPromise - v8.resolvePromise These are used by the streams implementation in Chrome currently, and were previously not inlined into TurboFan, although TurboFan already had all the necessary functionality (namely the JSCreatePromise, JSRejectPromise and JSResolvePromise operators). We might eventually want to use these functions in Node core as well (at least short-term for Node 10), to replace the C++ internal API functions with the same name that are currently being used by parts of Node core. For this to work, the rejectPromise and resolvePromise builtins had to be moved back to CSA, as for JavaScript builtins we still have the policy that the optimizing compiler must not inline them. But that's straight-forward since the CSA has all the necessary functionality available anyways. Bug: v8:7253 Change-Id: I39ab015c379956cd58ace866e17f8ec23b2257b2 Reviewed-on: https://chromium-review.googlesource.com/924146Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:616879 Change-Id: Id0de15718308b3ed5d5c47be6959513b9a95dc34 Reviewed-on: https://chromium-review.googlesource.com/916762 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Andreas Haas authored
This flag is the WebAssembly native heap equivalent to FLAG_write_protect_code_memory. R=mstarzinger@chromium.org Bug: v8:7454 Change-Id: Id4f671af2e8676d08599c8c30ce03b00e9d33780 Reviewed-on: https://chromium-review.googlesource.com/924071 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#51330}
-
Camillo Bruni authored
Drive-by-fixes: - brief print prototype Bug: v8:7310 Change-Id: I4df82bd76c05ff48a5860bd14cf7711140c0b062 Reviewed-on: https://chromium-review.googlesource.com/923737 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: v8:7310 Change-Id: I13cc97aa138ad95248e1d366bd0d326cbe1a090e Reviewed-on: https://chromium-review.googlesource.com/923736Reviewed-by:
-
Peter Marshall authored
Change-Id: Idf3a38c0750071263c6450a17d311cbab632523c Reviewed-on: https://chromium-review.googlesource.com/924141Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#51327}
-
jgruber authored
Will be needed in a follow-up (the constants cache builder needs to grow arrays in old space). Bug: v8:6666 Change-Id: Ibd911ffd30e2b0f43881e649b5601111d23e4509 Reviewed-on: https://chromium-review.googlesource.com/924068Reviewed-by:
-
jgruber authored
This flag will be used to toggle things for isolate-independent builtins during development. Bug: v8:6666 Change-Id: I8a97f08b3d677a01a2a55a4c6445e71e74471f51 Reviewed-on: https://chromium-review.googlesource.com/924067 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: v8:7310 Change-Id: I82e7ada4c0f7e415887a859719eb01bb45fd3012 Reviewed-on: https://chromium-review.googlesource.com/921742Reviewed-by:
-
Peter Marshall authored
Change-Id: I2f2b688b50d8f3b6d5aeb17bb0ed88148660b490 Reviewed-on: https://chromium-review.googlesource.com/924066Reviewed-by:
-
Jakob Kummerow authored
This doesn't enable the warning yet, but adds V8_FALLTHROUGH annotations in enough places so that v8 can build with the warning on on my linux box. Found one real bug (in effect-control-linearizer.cc, https://chromium-review.googlesource.com/c/v8/v8/+/850392/3/src/compiler/effect-control-linearizer.cc#825 ). Bug: chromium:812686 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3542550b9c24b545641d0f0fc43f28f2780b0ab3 Reviewed-on: https://chromium-review.googlesource.com/911731Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
When decoding a br_table instruction, check each br target only once, even if it appears several times in the break table. Also, only mark the merge points as reached after calling the interface method. This is consistent with the behaviour for br and br_if, and is needed for implementing Liftoff correctly. Drive-by: Remove {BreakTo} method which hides trivial functionality behind a non-trivial method name. Drive-by^2: Remove redundant reachability tests. R=titzer@chromium.org Bug: v8:6600 Change-Id: I3f2678c0a6b801b94065dc3e0d452bc2ff82dd50 Reviewed-on: https://chromium-review.googlesource.com/921581Reviewed-by:Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#51321}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/89fa02a..c5c828a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5c2b4120f994f8354f92df5d00d36874c6215cc1 Reviewed-on: https://chromium-review.googlesource.com/923522Reviewed-by:
-
Michael Achenbach authored
Change-Id: I9420be73a48db83b622e40f1c2b0dc4364a8d5d0 Reviewed-on: https://chromium-review.googlesource.com/923120Reviewed-by:
-
- 15 Feb, 2018 10 commits
-
-
Adam Klein authored
R=gsathya@chromium.org Change-Id: Ia03ec888617a492720c78b6c105323182fec351e Reviewed-on: https://chromium-review.googlesource.com/922784Reviewed-by:
-
Adam Klein authored
Tbr: jarin@chromium.org Change-Id: I17477e2c82398b228a366a3d1fd8eb521dd51eae Reviewed-on: https://chromium-review.googlesource.com/922270 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#51317}
-
Michael Achenbach authored
TBR=easterbunny Change-Id: I22f05b717ecdf4e480d6edc09937f2a69544d9f9 Reviewed-on: https://chromium-review.googlesource.com/922901Reviewed-by:
-
Adam Klein authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I5fc71633f2412c2bec3a4363a40da9920a3e25e2 Reviewed-on: https://chromium-review.googlesource.com/922386Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:6791 Change-Id: I43c43d217f00720ab666ff9908555fcd0fffe3b5 Reviewed-on: https://chromium-review.googlesource.com/919566Reviewed-by:
-
Mathias Bynens authored
This patch makes ECMAScript a syntactic superset of JSON by allowing U+2028 and U+2029 in string literals. Proposal repo: https://github.com/tc39/proposal-json-superset Bug: v8:7418 Change-Id: I7ef4ae6d85854ebc44a66e0eaf789814576832b7 Reviewed-on: https://chromium-review.googlesource.com/921228Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#51313}
-
Andreas Haas authored
The call to isolate_->AdjustAmountOfExternalAllocatedMemory in WasmCodeManager::FreeNativeModuleMemories can cause a GC, which can indirectly call WasmCodeManager::FreeNativeModuleMemories again. It seems that this recursive call can cause memory to be deallocated twice. With this CL we clear the list of owned_memory after all entries were deallocated so that we cannot deallocate them again. I think this CL fixes a crash we saw on ChromeCrash. I don't know how to reproduce the issue though, or how to write a test for it. R=mstarzinger@chromium.org Bug: chromium:812532 Change-Id: I3b66274f9b72919952a4211e984192c0867a6c22 Reviewed-on: https://chromium-review.googlesource.com/921226Reviewed-by:
-
Georg Neis authored
This is a reland of af677f29, fixing an issue with negative indices. Original change's description: > [ic] EmitElementStore: don't miss when hitting new space limit. > > CSA::EmitElementStore used to bail out (IC miss) via > CSA::CheckForCapacityGrow when the capacity hits the new space > limit, causing the store IC to go megamorphic in my example (see > referenced bug). With this CL, we do what TF'ed code does already: > call into Runtime::kGrowArrayElements (in this situation), thus > staying monomorphic. > > Here's a contrived test case: > > //////////////////////// > let x = []; > > function bar() { > for (let i = 0; i < 50000; ++i) x[i] = i; > } > > function foo() { > for (let i = x.length; i < 100e6; ++i) x[i] = i; > } > > bar(); > foo(); > //////////////////////// > > This took about 4s on my machine, now it takes 3s. > > Bug: v8:7447 > Change-Id: I7f268fc55835f363d250613ce0357444a663051c > Reviewed-on: https://chromium-review.googlesource.com/918723 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51297} Bug: v8:7447, chromium:812451 Change-Id: I345b5e5b2437c4f50e42bbd87947630f24cd95eb Reviewed-on: https://chromium-review.googlesource.com/921201 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#51311}
-
Toon Verwaest authored
Bug: Change-Id: Ie8b269467c8b1c5e97d1da9879f41319a49d5407 Reviewed-on: https://chromium-review.googlesource.com/911793 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#51310}
-
Toon Verwaest authored
instance_class_name takes up space unnecessarily, and %_ClassOf and class_name implement [[Class]] which isn't part of ES2015+ anymore. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I3a73f732ad83a616817fde9992f4e4d584638fa8 Reviewed-on: https://chromium-review.googlesource.com/776683Reviewed-by:
-
