Commit fd9251db authored by Mathias Bynens's avatar Mathias Bynens Committed by Commit Bot

Ship JSON ⊂ ECMAScript

Intent to ship:
https://groups.google.com/d/msg/v8-users/YZnlGa8ZMoc/_w7H3x_BAgAJ

Bug: v8:7418
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: I9e80dd98fa7b04fee3be591282e455f5576eeed2
Reviewed-on: https://chromium-review.googlesource.com/923728Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51339}
parent 018f1192
......@@ -207,7 +207,6 @@ DEFINE_IMPLICATION(harmony_class_fields, harmony_private_fields)
// Features that are still work in progress (behind individual flags).
#define HARMONY_INPROGRESS(V) \
V(harmony_subsume_json, "harmony subsume JSON") \
V(harmony_array_prototype_values, "harmony Array.prototype.values") \
V(harmony_function_sent, "harmony function.sent") \
V(harmony_do_expressions, "harmony do-expressions") \
......@@ -225,6 +224,7 @@ DEFINE_IMPLICATION(harmony_class_fields, harmony_private_fields)
// Features that are shipping (turned on by default, but internal flag remains).
#define HARMONY_SHIPPING_BASE(V) \
V(harmony_subsume_json, "harmony subsume JSON") \
V(harmony_string_trimming, "harmony String.prototype.trim{Start,End}") \
V(harmony_sharedarraybuffer, "harmony sharedarraybuffer") \
V(harmony_regexp_named_captures, "harmony regexp named captures") \
......
......@@ -3914,7 +3914,9 @@ TEST(LineOrParagraphSeparatorAsLineTerminator) {
TEST(LineOrParagraphSeparatorInStringLiteral) {
// Tests that both preparsing and parsing treat U+2028 LINE SEPARATOR and
// U+2029 PARAGRAPH SEPARATOR as line terminators within string literals.
// U+2029 PARAGRAPH SEPARATOR as line terminators within string literals
// when the "subsume JSON" flag is disabled.
v8::internal::FLAG_harmony_subsume_json = false;
const char* context_data[][2] = {
{"\"", "\""}, {"'", "'"}, {nullptr, nullptr}};
const char* statement_data[] = {"\x31\xE2\x80\xA8\x32", // 1<U+2028>2
......@@ -3927,7 +3929,7 @@ TEST(LineOrParagraphSeparatorInStringLiteral) {
TEST(LineOrParagraphSeparatorInStringLiteralHarmony) {
// Tests that both preparsing and parsing don't treat U+2028 LINE SEPARATOR
// and U+2029 PARAGRAPH SEPARATOR as line terminators within string literals
// with the "subsume JSON" flag enabled.
// when the "subsume JSON" flag is enabled.
v8::internal::FLAG_harmony_subsume_json = true;
const char* context_data[][2] = {
{"\"", "\""}, {"'", "'"}, {nullptr, nullptr}};
......
......@@ -510,6 +510,10 @@
# Test262 Bug: https://bugs.ecmascript.org/show_bug.cgi?id=596
'built-ins/Array/prototype/sort/bug_596_1': [PASS, FAIL_OK],
# https://bugs.chromium.org/p/v8/issues/detail?id=7418
'language/line-terminators/S7.3_A2.3': [FAIL],
'language/line-terminators/S7.3_A2.4': [FAIL],
# https://github.com/tc39/test262/pull/688#pullrequestreview-14025354
'built-ins/Function/internals/Construct/derived-this-uninitialized-realm': [FAIL],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment