• Andreas Haas's avatar
    [wasm] Clear owned_memory list of native modules after freeing · 9bd1e7d3
    Andreas Haas authored
    The call to isolate_->AdjustAmountOfExternalAllocatedMemory in
    WasmCodeManager::FreeNativeModuleMemories can cause a GC, which can
    indirectly call WasmCodeManager::FreeNativeModuleMemories again. It
    seems that this recursive call can cause memory to be deallocated
    twice. With this CL we clear the list of owned_memory after all entries
    were deallocated so that we cannot deallocate them again.
    
    I think this CL fixes a crash we saw on ChromeCrash. I don't know how
    to reproduce the issue though, or how to write a test for it.
    
    R=mstarzinger@chromium.org
    
    Bug: chromium:812532
    Change-Id: I3b66274f9b72919952a4211e984192c0867a6c22
    Reviewed-on: https://chromium-review.googlesource.com/921226Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51312}
    9bd1e7d3
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...