- 17 Feb, 2021 9 commits
-
-
pthier authored
The expected exception in this regression test is thrown due to a limitation in the IrRegExp engine. The experimental engine is unaffected and won't throw. Bug: v8:11363 Change-Id: If37d86f5d4494b40c47ecc5e5bc4f86fda30389c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699251 Auto-Submit: Patrick Thier <pthier@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#72806}
-
Victor Gomes authored
Change-Id: Icdd2d4a178415d240a82378ffa575e6e6b79dca1 Bug: v8:11429 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697353Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#72805}
-
Toon Verwaest authored
This threads through a JumpMode kJump/kReturn to JumpCodeObject so we can use a return instruction to jump instead by first pushing the jump target and then using a return instruction. Bug: v8:11429 Change-Id: I8658ed9c5bade28bd6efc76e26fd92bad22b3c68 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697196 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Georg Neis authored
This reverts commit e27b7b60, which was a workaround. The original problem is not reproducible anymore. Bug: v8:9717 Change-Id: I11e165d7ec9643ec805ab8c075b720b58e7769bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699249 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#72803}
-
Leszek Swirski authored
Bug: v8:11429, v8:11461 Change-Id: Iffe9ac09eea008b45a6b9734a3c78ac8ba508222 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699253 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Georg Neis authored
Bug: v8:9717 Change-Id: I2338e11ec8263b18e60eb5206431738a8532c977 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699248 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Victor Gomes authored
Change-Id: I9eb86c5ca40734ec61864bce7d0f757fcd4b7d93 Bug: v8:11429 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697205Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bc28354..a42736b Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/228b1c1..fe293b0 Rolling v8/third_party/aemu-linux-x64: AFb5I0J9LTvrxaixyFmiKgTuOLLQ3YJ_FAEwRZq1basC..9VxcXi3GhpRxrjwHQwa801vcevGa1Pew2lw1KkUkgmgC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/35976bf..832539c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7386a1e..0391863 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/dbe0d80..823dc87 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idc687f5ee60652f381dca0c9d0f7c8293ea6a73a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2699354Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#72799}
-
Milad Fa authored
Bug: v8:11416 Change-Id: I0c993ee564358f5c5f8880cbae1bce9ff2128087 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698308 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#72798}
-
- 16 Feb, 2021 31 commits
-
-
Ng Zhi An authored
Bug: v8:11415,v8:11348,v8:11416,v8:11347 Change-Id: I0c945ecf10264fdaf90dab7b854cb2392976a8ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2693988 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#72797}
-
Milad Fa authored
Bug: v8:11415 Change-Id: I0101d88d19e5cad20d5f0fa6926cf0ebd9d000e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698091 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#72796}
-
Ng Zhi An authored
Bug: v8:11265 Change-Id: I133c050a4d4c479c2d5adb1b95ef758d2875e773 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692731Reviewed-by:
-
Nicolas Dubus authored
samples being discarded - Passed in as CpuProfilingOptions parameter, client is responsible for determining if function is still safe to execute. Includes unit tests - Client (blink) side CR: https://chromium-review.googlesource.com/c/chromium/src/+/2649617, - Client (blink) side CR requires this to be pushed prior to it being pushed Change-Id: I3ef4640186115d4e14c1b73f902c889c776e310f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2652206 Commit-Queue: Nicolas Dubus <nicodubus@fb.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#72794}
-
Ng Zhi An authored
Bug: v8:11416 Change-Id: I094e91b1e5b382e5eced24d198e1f6bbc1b4ae0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2686311 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#72793}
-
Junliang Yan authored
Change-Id: I9241573c3644918028e2b302da2988cca0973cb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698089Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#72792}
-
Junliang Yan authored
Port adf035fb Original Commit Message: This CL avoids redundant loads of the instance from the frame by caching it in a register if possible. This register will be the first one to be cleared once we run out of registers (hence it's called a "volatile register"). On local tests, this seems to reduce most redundant loads within a function, and it also reduces the load for the stack check in the function prologue. After the stack check, we need to discard the cached instance though, since the potential runtime call for the stack check might clobber it. This will be addressed in a follow-up CL by re-loading the cached instance after the stack check. This is expected to remove another good chunk of instance loads, because the instance would initially be available in a register when starting the function code. R=clemensb@chromium.org, midawson@redhat.com, mfarazma@redhat.com BUG= LOG=N Change-Id: I3756ce98d4dfefb44c946a4948f1a6dbe0ce44dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2698291Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:8091 Change-Id: I2933342da65ef75cfe36f81f8828411fd78d45e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2696659 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72790}
-
Ng Zhi An authored
Bug: v8:11415 Change-Id: I8ad0aab2c1ac89ec66779b44542833c3a4eb96fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2693323Reviewed-by:
-
Milad Fa authored
As of https://crrev.com/c/2629465, Simd tests cannot pass on architectures without Simd support. Tests will need to be re-enabled once Simd support is fully implemented on PPC. Change-Id: I963639f1afa0c0ca7be3ca4b2fc06e874235b903 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2693056Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:11416 Change-Id: I9fe70ae588147a3e04c719f14d86fb80ed9b6caa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2686310 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Milad Fa authored
Change-Id: I66c3dc4a92f814b7ee1771136a5ab794bae9cd98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697649Reviewed-by:
-
Thibaud Michaud authored
Implicitly rethrow the exception when we reach the end of a try..unwind..end. Also make it a validation error to rethrow an exception caught by an unwind block. R=clemensb@chromium.org Bug: v8:8091 Change-Id: Ia149d2e81b1fbfa9209047b35ff0c9fedc1b8895 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2696662 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Clemens Backes authored
The WasmThrow and WasmRethrow runtime functions have the same signature, but we should still use the correct description in case the signature changes (which is planned for a follow-up CL). R=thibaudm@chromium.org Bug: v8:11453 Change-Id: Iaec9c353d30fa7673ceb8994e3029c4adfc01311 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697348Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72784}
-
Milad Fa authored
Change-Id: Iebd2bcbe8587fe079b8f058f9546294d020e23d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697389Reviewed-by:
-
Benedikt Meurer authored
The Debug::SetBreakPointForScript() method essentially figures out the SharedFunctionInfo and then duplicates the logic from SetBreakpoint(). Bug: chromium:1162229 Change-Id: Iae98ab5d182739d44e0277b799509723d950f381 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697351 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#72782}
-
Bill Budge authored
- Adds DCHECKs to make sure no stack slots are allocated after aligning a frame. - Changes Arm64 CodeGenerator::FinishFrame to align the frame after allocating callee-saved registers, and relaxes the constraints on the number of callee-saved registers. Bug: v8:9198 Change-Id: Iacb0518b57fa3ea2ff801eda69719f4c32733850 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2694104Reviewed-by:
-
Milad Fa authored
Port 89ea44bf Original Commit Message: - Also changes in arm and ia32 for consistency - Removes fall-through since MaybeOptimizeCode never returns R=victorgomes@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I5a91f709f10065692ae654bdd79e6088e1fe88c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697388Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#72780}
-
Clemens Backes authored
This CL avoids redundant loads of the instance from the frame by caching it in a register if possible. This register will be the first one to be cleared once we run out of registers (hence it's called a "volatile register"). On local tests, this seems to reduce most redundant loads within a function, and it also reduces the load for the stack check in the function prologue. After the stack check, we need to discard the cached instance though, since the potential runtime call for the stack check might clobber it. This will be addressed in a follow-up CL by re-loading the cached instance after the stack check. This is expected to remove another good chunk of instance loads, because the instance would initially be available in a register when starting the function code. R=thibaudm@chromium.org Bug: v8:11336 Change-Id: Ie65ab81263fb9d972f4b7a6daaef86cf704874ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2695401 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
pthier authored
Bug: v8:11420 Change-Id: I82365b1db0e09fbc04e9ae3b41d9d60c1a9cacd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697203 Commit-Queue: Patrick Thier <pthier@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit cf93071c. Reason for revert: Speculative revert because of Mac4 GC stress failure: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64%20GC%20Stress/16697/overview Original change's description: > [interpreter] Short Star bytecode > > Design doc: > https://docs.google.com/document/d/1g_NExMT78II_KnIYNa9MvyPYIj23qAiFUEsyemY5KRk/edit > > This change adds 16 new interpreter opcodes, kStar0 through kStar15, so > that we can use a single byte to represent the common operation of > storing to a low-numbered register. This generally reduces the quantity > of bytecode generated on web sites by 8-9%. > > In order to not degrade speed, a couple of other changes are required: > > The existing lookahead logic to check for Star after certain other > bytecode handlers is updated to check for these new short Star codes > instead. Furthermore, that lookahead logic is updated to contain its own > copy of the dispatch jump rather than merging control flow with the > lookahead-failed case, to improve branch prediction. > > A bunch of constants use bytecode size in bytes as a proxy for the size > or complexity of a function, and are adjusted downward proportionally to > the decrease in generated bytecode size. > > Other small drive-by fix: update generate-bytecode-expectations to emit > \n instead of \r\n on Windows. > > Change-Id: I6307c2b0f5794a3a1088bb0fb94f6e1615441ed5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2641180 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#72773} TBR=rmcilroy@chromium.org,mythria@chromium.org,seth.brenith@microsoft.com Change-Id: I0162b9400861b90bacef27cca9aebc8ab9d74c10 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697350Reviewed-by:
-
Andreas Haas authored
Bug: v8:11384 Change-Id: I08bf27af977e94e6d441a83a62cae49eeaf856e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697198Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#72776}
-
Georg Neis authored
My previous CL was missing a negation in two places. Bug: chromium:1178731 Change-Id: I5bc4d78226e43a62ddd374c3d7dd36a9ed0c1a2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697192 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#72775}
-
Clemens Backes authored
Custom platform implementations which do not run all foreground tasks before shutting down an isolate could trigger a DCHECK (see linked issue). This was introduced in https://crrev.com/c/2578980, but the bug does not trigger in the default platform implementation, hence went unnoticed. Since it's only a spurious DCHECK error without security implications, I decided against a test with a custom platform implementation to reproduce the bug. R=ahaas@chromium.org Bug: v8:11456 Change-Id: Ie01562af7bdffe23cad7172180f2bc19ea61dfda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697189Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72774}
-
Seth Brenith authored
Design doc: https://docs.google.com/document/d/1g_NExMT78II_KnIYNa9MvyPYIj23qAiFUEsyemY5KRk/edit This change adds 16 new interpreter opcodes, kStar0 through kStar15, so that we can use a single byte to represent the common operation of storing to a low-numbered register. This generally reduces the quantity of bytecode generated on web sites by 8-9%. In order to not degrade speed, a couple of other changes are required: The existing lookahead logic to check for Star after certain other bytecode handlers is updated to check for these new short Star codes instead. Furthermore, that lookahead logic is updated to contain its own copy of the dispatch jump rather than merging control flow with the lookahead-failed case, to improve branch prediction. A bunch of constants use bytecode size in bytes as a proxy for the size or complexity of a function, and are adjusted downward proportionally to the decrease in generated bytecode size. Other small drive-by fix: update generate-bytecode-expectations to emit \n instead of \r\n on Windows. Change-Id: I6307c2b0f5794a3a1088bb0fb94f6e1615441ed5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2641180Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#72773}
-
Victor Gomes authored
Change-Id: I9f41fc97c2ca9a1c62b1de4ee8c9878d5d69b560 Bug: v8:11429 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697195Reviewed-by:
-
Toon Verwaest authored
Baseline scratch registers don't include the regular kScratchRegister (for now at least) because the rest of the system doesn't use the ScratchRegisterScope (yet). Bug: v8:11429 Change-Id: I7a2f27a814e262e5b14bd30b2ae53d53e173bcc3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697194Reviewed-by:
-
Michael Lippautz authored
Lazy sweeping may have found a memory block not positioned at the head of the corresponding bucket. Such a block is not found during a subsequent free list allocation, as such allocations do not linearly walk the free list. Bug: chromium:1056170 Change-Id: I288b6ad768987705d86fc78d0aa6fe46e99417b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692822 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#72770}
-
Sathya Gunasekaran authored
The current API returns a Handle<NativeContext> which can be optionally null and all the users of this API never actually checked for this null value. Previously, this wasn't a problem as all the possible JSObjects that were user visible would return a valid NativeContext but now there are wasm objects that don't have a valid constructor so don't have a NativeContext. Bug: v8:11451, chromium:1166077 Change-Id: I4fd5edf8f1a750e6f0abb931fd41358e5ae4dfcf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692695 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
When there are multiple nested catch blocks, the rethrow immediate disambiguates which catch block to take the exception from. We add a FixedArray to keep track of exceptions that are currently in scope, and compute the mappings between rethrow/catch instructions and the index to fetch/store the exception from/to in the FixedArray during pre-processing. R=clemensb@chromium.org Bug: v8:8091 Change-Id: If55242c551f42262c790b5bf3f1543a003280623 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2695388 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Change the interpreter tracing functions to be generic unoptimized code tracing functions. The type of the code is now inferred from the frame, rather than passed in. Also expands the set of gn flags to explicitly enable unoptimized tracing, with a helper gn flags for enabling it for Ignition and for baseline (both just set unoptimized tracing to be enabled for now, we could split this up in the future though), and V8 flags separate tracing Ignition and tracing baseline. Bug: v8:11420, v8:11429 Change-Id: I040c2628fe5744dcb38ef8623df3e34f9c86a5b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692817 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
