- 12 Apr, 2022 16 commits
-
-
Michael Lippautz authored
Concurrrent marking for v8::TracedReference requires a single bit in global handles to be written concurrently. While no other bits require concurrent access, initialization still needs to properly publish the bits. Avoid this problem by just referring to a persistent marking bitmap that's always present and accessed concurrently, similar to V8's regular marking bitmap. Bug: chromium:1315498, v8:12600 Change-Id: I49ba1af0f5a0a8c7fd2865c7178a9a956bbd953e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3582920Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79946}
-
Victor Gomes authored
It currently only checks if the node inputs are expected to be tagged or untagged. Bug: v8:7700 Change-Id: Ibf068098dfb08c28b2744cb321fa857572998948 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578804Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#79945}
-
Clemens Backes authored
The constant was updated in https://crrev.com/c/3328783 without updating the comment, which brought them out of sync. R=jkummerow@chromium.org No-Try: true Change-Id: I68b30aca878b5ed5a37ba39c36480d571c62f563 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578806 Auto-Submit: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#79944}
-
Michael Lippautz authored
Most paths filter out empty reference on cppgc::Visitor or v8::JSVisitor level. For v8::TracedReference we may end up with empty reference in case of ephemeron tracing which cannot perfom the null checks on the outer visitor. Bug: chromium:1315550, v8:12600 Change-Id: I5ebb466100a6f2cf25a75585fc2267a632497548 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3582124Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#79943}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: I5290b6af6158dece0d38b24bc80b887f67c2747b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3582921 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Victor Gomes authored
This allows to easily introduce new nodes with untagged represenation. It also speeds up the is_untagged_value check. Bug: v8:7700 Change-Id: Ie391d32ae7742dbad481674de262050c0d564ee6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3581773 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:1314954 Change-Id: I22b0f5792f8f65a066b1d167f5f86d9071dff6cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3582919 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Victor Gomes authored
We track untagged values through the InterpreterFrameState, that allows us to re-use already emitted CheckedSmiUntag and elide CheckedSmiTag whenever the next node wants the untagged value as input. It uses LoadRegisterTaggedValue, LoadRegisterSmiUntaggedValue and accumulator variants as helper in the graph builder. Spilled values can now be untagged, since we currently do not support stack slot re-use, we use a ZoneVector to keep track of the stack slot representation. We tag (lazily) any value that will be passed as input to a Phi node. Bug: v8:7700 Change-Id: I34cb69c8f1fbeb6a8158a251a4dd2e114e894ea0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574559Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#79939}
-
Nikolaos Papaspyrou authored
Method GCTracer::UpdateStatistics was responsible for copying incremental and background scopes to the current event, before reporting. It was called, however, at the end of the atomic pause and, as a result, some of these scopes would be prematurely copied to the current event (e.g., incremental and background sweeping scopes) and misreported. This CL fixes this by splitting the update of statistics and the copying of incremental and background scopes. It introduces the method GCTracer::FinalizeCurrentEvent which does the latter, which is called from GCTracer::StopCycle. It also introduces methods for correctly accessing and updating scopes, before the current event is finalized, and eliminates the distinction between GCTracer::AddScopeSample and GCTracer::AddScopeSampleBackground. Bug: chromium:1154636 Change-Id: I2a6d9abb3daa2c48b2dce12dc2685cfc84130abf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3576792Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
jameslahm authored
... in Runtime::kCopyDataPropertiesWithExcludedPropertiesOnStack. Bug: v8:11614 Change-Id: Ief6d62fff242d3d38c4e586c7252935d3527ddf1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3581534Reviewed-by:
-
Hannes Payer authored
This reverts commit c27b15b4. Reason for revert: crbug.com/1314191 Original change's description: > [heap] Enable --separate-gc-phases flag. > > Bug: v8:12503 > Change-Id: I81d02231b7e40fb0ed487de128ffaedcd3cd2126 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571898 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79817} Bug: v8:12503, chromium:1314191 Change-Id: I82bd1db765344601cc0118da4a91345dd5001acf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578655 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
jameslahm authored
For strict equal boolean literal like "a===true" or "a===false", we could generate TestReferenceEqual rather than TestStrictEqual. And in `execution_result()->IsTest()` case, we could directly emit JumpIfTrue/JumpIfFalse. E.g. ``` a === true ``` Generated Bytecode From: ``` LdaGlobal Star1 LdaTrue TestEqualStrict ``` To: ``` LdaGlobal Star1 LdaTrue TestReferenceEqual ``` E.g. ``` if (a === true) ``` Generated Bytecode From: ``` LdaGlobal Star1 LdaTrue TestEqualStrict JumpIfFalse ``` To ``` LdaGlobal JumpIfTrue Jump ``` Bug: v8:6403 Change-Id: Ieaca147acd2d523ac0d2466e7861afb2d29a1310 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568923Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#79935}
-
Joyee Cheung authored
This patch makes sure that NearHeapLimitCallback can invoke operations that trigger garbage collections. In addition this adds code to make the tracers aware of NearHeapLimitCallback. Bug: v8:12777 Change-Id: I959a23a3e0224ba536cb18b14933813e56fc5292 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3575468Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/6f75bb5..dc901ff Fix wheel job name for PyPI uploads (#1384) (Nicholas Junge) https://chromium.googlesource.com/external/github.com/google/benchmark/+/dc901ff R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I79ab5393db52f4b6142562ab37c9df720dad86b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3581054 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79933}
-
Liu Yu authored
Port commit b8473c52 Bug: v8:12161 Change-Id: I4cdf161356039b47ecf054aeba85c7a3d0d06de0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3583218Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Yu Liu <liuyu@loongson.cn> Auto-Submit: Yu Liu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#79932}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2c3758a..75f73c9 Rolling v8/third_party/android_ndk: https://chromium.googlesource.com/android_ndk/+log/9644104..8388a2b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4326c47..117c61c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e222245..3b97fa8 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c61f267..a6d209a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/3eacd6c..b5e2f7c R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I08e857674de2d4bd852eb8805e7305eb99746aeb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3581053 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79931}
-
- 11 Apr, 2022 24 commits
-
-
Thibaud Michaud authored
For stack-switching, we create a callable object from the WasmResume builtin and pass that as the onFulfilled argument of Promise#then. We don't need to create this callable object each time we suspend. Instead, create it when we initialize the Suspender object and store it there. R=jkummerow@chromium.org CC=fgm@chromium.org Bug: v8:12191 Change-Id: If8495493a71794cddc81b21a17a821fed8f4ede7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3579162Reviewed-by:
-
Milad Fa authored
Simulator needs a way to check if a fp input is a signalling NaN and `issignaling` doesn't seem to be supported on the latest gclient update and causes link errors. Change-Id: Id2a7200b6cf13bb6174b052728fc5a0d5436321c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3581768Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#79929}
-
Michael Lippautz authored
The barrier is published in the atomic pause following the final step. Bug: v8:12775 Change-Id: Ia77e1d213cc02a086d7a557999481b633e6b4df4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3582039Reviewed-by:
-
Camillo Bruni authored
Change-Id: I3e3a59172a0ffa482a9a3d0c23f616bbf1cf7fb5 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578858Reviewed-by:
-
Leszek Swirski authored
We need to make sure that a node doesn't think it's still allocated in a register (and doesn't need spilling) when it is freed to make space for another allocation. Bug: v8:7700 Change-Id: I6e35cd467bb7f17bb20dc6f4ab0a1df9efe78ffa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3582220 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#79926}
-
Leszek Swirski authored
We were doing this for synchronous compiles, but not for asynchronous ones. Bug: v8:7700 Change-Id: I10173ddc34bd8750051272c0ec065e21bbd20082 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3581767 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Samuel Groß authored
The external code space is required for the sandbox, so enable it on Android to be able to enable the sandbox there as well in the future. Bug: v8:11880 Change-Id: Ic7ba29c77affc3e0e83c8a93f2f6f53b3c72b8e8 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578799Reviewed-by:
-
Junliang Yan authored
Change-Id: I8a46ee0f64d6e9b7d71c7f494cac3eff817fbdda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3582417Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#79923}
-
Maksim Sadym authored
1. Added `generateWebDriverValue` flag to `Runtime.evaluate` and `Runtime.callFunctionOn`. 2. Added `webDriverValue` field to `RemoteObject`, and set it in case of the `generateWebDriverValue` flag was set. 3. Added virtual method `bidiSerialize` to allow embedder-implemented serialization (like in https://crrev.com/c/3472491). 4. Implemented V8 serialization in a separate class `V8WebDriverSerializer`. 5. Hardcode `max_depth=1`. 6. Added tests. Not implemented yet: 1. `objectId`. 2. Test of embedder-implemented serialization. Tested automatically by: ``` python3 tools/run-tests.py --outdir out/foo inspector/runtime/add-web-driver-value ``` Naming to be discussed. Suggestions are very welcome. Design doc: http://go/bidi-serialization Change-Id: Ib35ed8ff58e40b3304423cc2139050136d844e2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3472077Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Maksim Sadym <sadym@chromium.org> Cr-Commit-Position: refs/heads/main@{#79922}
-
Victor Gomes authored
... and fix AddSmi operation. Bug: v8:7700 Change-Id: If81030e1e0d457076e09db62553342f04477e255 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3581983 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Lu Yahan authored
FlagScope can't automatically disable wasm-dynamic-tiering. Bug: v8:7748 Change-Id: Ieb59e20b4cb4436277aa88b615bca07657a1212c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578109 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#79920}
-
Michael Lippautz authored
This is a reland of commit 1f0d7d20 The fix merges concurrent marking tasks when marking in the atomic pause. Without the fix, Oilpan markers would continue running concurrently, possibly discovering new V8 objects. This violates the assumption that the final transitive closure runs on a single thread. Original change's description: > cppgc-js: Concurrently process v8::TracedReference > > Adds concurrent marking for reaching through v8::TracedReference. > Before this CL, a v8::TracedReference would always be processed on the > main thread by pushing a callback for each encountered reference. > > This CL now wires up concurrent handling for such references. In particular: > - Global handles are already marked as well and not repurposed during > the same GC cycle. > - Since global handles are not repurposed, it is enough to > double-deref to the V8 object, checking for possible null pointers. > - The bitmap for global handle flags is mostly non-atomic, with the > markbit being the exception. > - Finally, all state is wired up in CppHeap. Concurrent markers keep > their own local worklist while the mutator marker directly pushes to > the worklist owned by V8. > > Bug: v8:12600 > Change-Id: Ia67dbd18a57dbcccf4dfb9ccfdb9ee438d27fe71 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3516255 > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79736} Bug: v8:12600 Change-Id: I8545041b2c7b3daf7ecea7e3a100e27534e9b8b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571887Reviewed-by:
-
Leszek Swirski authored
Add LocalIsolate use, broker()->GetFeedbackForPropertyAccess, and generating persistent/canonical handles to fix maglev concurrent compilation. Bug: v8:7700 Change-Id: Ifd1156c72710047b5f2930837a04709419b23bc3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578546 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#79918}
-
Junliang Yan authored
Port 52b99213e73045e9ffcae970e6c3f3cd07fc8381 Bug: v8:12161 Change-Id: Iac4f31eb6be83bca0e4bd407d81f1ece271b1e67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3576124Reviewed-by:
-
Camillo Bruni authored
Change-Id: I0063c92ee99193440cdbbe18a6f0d094302e7c16 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578544Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This is a reland of commit 6879c515 Original change's description: > [osr] Enable concurrent OSR > > Fixed: v8:12161 > Change-Id: Ie6e83dd4f261fff2d1fa8613116e83ef6b61561f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3576116 > Auto-Submit: Jakob Linke <jgruber@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79857} Change-Id: I418a1166c5eff4156f0c4406f024fc1ba5746732 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3582038Reviewed-by:
-
Clemens Backes authored
The roundss / vroundss instruction is only available on AVX or SSE4_1 hardware. Thus bring back the old code path with much longer code for such old hardware. R=tebbi@chromium.org Bug: chromium:1314363 Change-Id: I79a58627c8b406817330e9f9601234cea28182c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578642Reviewed-by:
-
Jakob Gruber authored
This particular branch in CompileOptimizedOSR relies on a precise invocation count at counts 0 and 1. The invocation count is unreliable not only in the previously described situation (--always-opt), but also e.g. when forcing optimization on the first execution through other means like %OptimizeFunctionOnNextCall. Let's simply rewrite the condition to explicitly exclude kIsInProgress. Fixed: chromium:1314536 Change-Id: I27432f689c866bad3b407df7bbf276ec32c25c0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578644Reviewed-by:
-
Jakob Gruber authored
1: Clear cache entry 0 before overwriting it to maintain bookkeeping of the SharedFunctionInfo's OSR code cache state, which tracks how many cache entries there are for this particular SFI. 2: When inserting into the code cache, we don't know in advance whether the entry is already present or not (this could happen with multiple simultaneous compile jobs from different closures of the same SFI). Fixed: chromium:1314644 Bug: v8:12161 Change-Id: I0085a3a6e0c1879c3d483853220e654aa03660ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578643Reviewed-by:
-
Jakob Gruber authored
This is a reland of commit 51b99213 Fixed in reland: - bytecode_age was incorrectly still accessed as an int8 (instead of int16). - age and osr state were incorrectly reset on ia32 (16-bit write instead of 32-bit). Original change's description: > [osr] Add an install-by-offset mechanism > > .. for concurrent OSR. There, the challenge is to hit the correct > JumpLoop bytecode once compilation completes, since execution has > moved on in the meantime. > > This CL adds a new mechanism to request installation at a specific > bytecode offset. We add a new `osr_install_target` field to the > BytecodeArray: > > bitfield struct OSRUrgencyAndInstallTarget extends uint16 { > osr_urgency: uint32: 3 bit; > osr_install_target: uint32: 13 bit; > } > > // [...] > osr_urgency_and_install_target: OSRUrgencyAndInstallTarget; > bytecode_age: uint16; // Only 3 bits used. > // [...] > > Note urgency and install target are packed into one 16 bit field, > we can thus merge both checks into one comparison within JumpLoop. > Note also that these fields are adjacent to the bytecode age; we > still reset both OSR state and age with a single (now 32-bit) > store. > > The install target is the lowest 13 bits of the bytecode offset. > When set, every reached JumpLoop will check `is this my offset?`, > and if yes, jump into runtime to tier up. > > Drive-by: Rename BaselineAssembler::LoadByteField to LoadWord8Field. > > Bug: v8:12161 > Change-Id: I275d468b19df3a4816392a2fec0713a8d211ef80 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571812 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79853} Bug: v8:12161 Change-Id: I7c59b2a2aacb1d7d40fdf39396ec9d8d48b0b9ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578543Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Join instead of cancel to make use of the the main thread. Also make the Join() call explicit instead of implicitly finishing concurrency on advancing tracing form the main thread. Bug: v8:12600 Change-Id: I60d3e82bfc2e8a3ccc2dda761a5d3eb3ac7694d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578855Reviewed-by:
-
Nico Hartmann authored
To make the existing mechanism for printing JSON for turbolizer able to print types other than the ones stored in the nodes (so the verifier can print its own types here), this CL restructures the printing mechanism into a single non-private class that can be inherited to override certain parts of the printing. In this CL only GetType is made virtual to allow verifier to override it, but additional parts can be made overridable whenever necessary. Bug: v8:12619 Change-Id: Idf31f8cdb49eb6c3204c6abfbb74fc981330d6d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571818Reviewed-by:
-
Leszek Swirski authored
Bring back raw SetAccumulator, instead of the separate SetAccumulatorToNew/ExistingNode. SetAccumulator (and StoreRegister) are now expected to only ever be called on new Nodes, with some DCHECKs tracking which nodes are new guaranteeing this. Bug: v8:7700 Change-Id: I5657fa85dc05445bc3d6956ebcd5541ec1cedfad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3579362 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Map space can get disabled with --no-use-map-space. Bug: v8:12578, chromium:1314307 Change-Id: I0f25e4e10c0baa0e9785d80c189dfe86c2bc6aec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3579302Reviewed-by:
-
