• Nikolaos Papaspyrou's avatar
    heap: Fix reporting of incremental and background scopes · d609cd98
    Nikolaos Papaspyrou authored
    Method GCTracer::UpdateStatistics was responsible for copying
    incremental and background scopes to the current event, before
    reporting. It was called, however, at the end of the atomic pause and,
    as a result, some of these scopes would be prematurely copied to the
    current event (e.g., incremental and background sweeping scopes) and
    misreported.
    
    This CL fixes this by splitting the update of statistics and the
    copying of incremental and background scopes. It introduces the
    method GCTracer::FinalizeCurrentEvent which does the latter, which
    is called from GCTracer::StopCycle. It also introduces methods for
    correctly accessing and updating scopes, before the current event is
    finalized, and eliminates the distinction between
    GCTracer::AddScopeSample and GCTracer::AddScopeSampleBackground.
    
    Bug: chromium:1154636
    Change-Id: I2a6d9abb3daa2c48b2dce12dc2685cfc84130abf
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3576792Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79938}
    d609cd98
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...