- 17 Jun, 2019 28 commits
-
-
Ross McIlroy authored
Bug: v8:8801,v8:8394,v8:9183 Change-Id: I5ceaf731a1b2720f086e6791fe08caaaa55de030 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1662568 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#62224}
-
Mythri A authored
Bug: v8:8801, v8:8394, v8:9183 Change-Id: Ie2858af4863511d5f67b662ac6f6f79512f55e7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1662307 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#62223}
-
Jaroslav Sevcik authored
This in in preparation for generic (off-heap/on-heap) bytecode array accessor. Bug: v8:7790 Change-Id: Ib419831ba1db95ab938179723ef5f130f01ae0d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635895 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:9353 Change-Id: Ie090f8f89eb4372845fe2c9d6aa74154c36f2d53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1662291 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#62221}
-
Jakob Kummerow authored
which was probably added by mistake. Change-Id: Iba265309710115aae8d9a0b7c0ede7e0160a662a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1662302 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62220}
-
Ben L. Titzer authored
Extract tests related to array buffers and typed arrays to their own .cc files. R=mstarzinger@chromium.org Change-Id: Ic80205d02b62db1565670ecf2bb4c0dbe52fab49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1662301 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#62219}
-
Jakob Gruber authored
This further reduces the number of things declared in the public regexp API file, currently still named jsregexp.h. * Move JSRegExp::Flags convenience functions to regexp-compiler.h. * Set RegExpImpl methods private if possible (these will later be moved to a new hidden impl class). * Merge RegExpEngine::CompilationResult into RegExpCompileData. * Move remaining RegExpEngine methods to RegExpImpl and delete RegExpEngine. * Extract RegExpGlobalCache. * Document a few data structures. Upcoming CLs will rename RegExpImpl to RegExp and jsregexp.h to regexp.h. This should then be the only header included from other directories. Bug: v8:9359 Change-Id: I78c8f4cca495a2b95735a48b6181583bc3310bdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1662294Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#62218}
-
Maciej Goszczycki authored
Rename LargeObjectIterator to LargeObjectSpaceObjectIterator. Rename SemiSpaceIterator to SemiSpaceObjectIterator. Rename CombinedHeapIterator to CombinedHeapObjectIterator. Rename ReadOnlyHeapIterator to ReadOnlyHeapObjectIterator. Rename HeapIterator to HeapObjectIterator. Rename HeapObjectIterator to PagedSpaceObjectIterator. Rename PagedSpaces to PagedSpaceIterator. Bug: v8:9183 Change-Id: If4bd65d81e50bb45d207a897baaca8b723e4f10b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645914Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Cr-Commit-Position: refs/heads/master@{#62217}
-
Mythri A authored
Bug: v8:8801, v8:8394, v8:9183 Change-Id: Ic31f97a1b591317a004dc52c8eee777dd6353487 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1662299 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Mike Stanton authored
The only piece missing at this point was to serialize the code objects for the resolve and reject handlers. Bug: v8:7790 Change-Id: If636f9d74dfc9606cf5f45c4f02dd118fb5d8f00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1662295 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#62215}
-
Ross McIlroy authored
Bug: v8:8801,v8:8394,v8:9183 Change-Id: I55027b3ba0c78f40d82aaf2d160aaf957d02cab5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1662292 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Dan Elphick authored
Previously only AssemblerOptions created by AssemblerOptions::Default() could have inline_offheap_trampolines set to true. This fixes OutOfLineTruncateDoubleToI from generating calls via the DoubleToI trampoline. Bug: v8:9338 Change-Id: Ia4638cd185e9041c7c69996783d0ce5600e9723a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1662288Reviewed-by:
-
Michael Achenbach authored
We have too many dupes in the no-ic comparisons. We'll increase the experiment size again once bugs are fixed. TBR=jarin@chromium.org NOTRY=true Bug: chromium:961709 Change-Id: Ic946100b45fd73e1bee59f188a766384836bcdcf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660624Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#62212}
-
Sigurd Schneider authored
This reverts commit ac79b539. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim/18611 Original change's description: > [arm64] Refactor constant pool implementation > > This refactors the constant pool handling for arm64. The immediate goal > is to allow 32bit compressed pointers in the pool. The mediate goal is > to unify the implementation with the arm constant pool, which will be > done in a follow-up CL. > > Bug: v8:8054 > Change-Id: I74db4245e5e1025f2e4de4144090fa4ce25883ab > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645316 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62209} TBR=mstarzinger@chromium.org,sigurds@chromium.org,jgruber@chromium.org,georgia.kouveli@arm.com Change-Id: Iff03e81a2e70d125ef2c06b6ff3aff8d0e3688ef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8054 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1662293Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62211}
-
Michael Starzinger authored
This adds preliminary support for storing constructed WebAssembly functions in tables. Note that for now only tables at index #0 are supported, extending it to other tables indexes will be done as a follow-up. R=ahaas@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: I9aa07813e07f0ceb4eafe37af412b45c7d235722 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1640209 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#62210}
-
Sigurd Schneider authored
This refactors the constant pool handling for arm64. The immediate goal is to allow 32bit compressed pointers in the pool. The mediate goal is to unify the implementation with the arm constant pool, which will be done in a follow-up CL. Bug: v8:8054 Change-Id: I74db4245e5e1025f2e4de4144090fa4ce25883ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645316Reviewed-by:
-
Mike Stanton authored
The functions * JSCallReducer::ReducePromisePrototypeThen * JSCallReducer::ReducePromisePrototypeFinally * JSCallReducer::ReducePromisePrototypeCatch need the prototype for all receiver maps to be serialized in order to take effect. We can do this by processing our receiver hints when processing a builtin call in the serializer. Bug: v8:7790 Change-Id: I3d9144924cf6926cfcd93b60ac703cfba2d3d93a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660623 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Jakob Gruber authored
The breaking change was https://chromium-review.googlesource.com/c/v8/v8/+/1658157 Bug: v8:9359 Change-Id: I6fa956631a8e475123cf6f8f44e66f2c499d47b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660627 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#62207}
-
Thibaud Michaud authored
Make NewCompilationJob methods return a unique_ptr to explicitly transfer ownership. R=mstarzinger@chromium.org Bug: v8:9183 Change-Id: I1cc6614cc1941b1b27489443a3c330cf6e88f089 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660474Reviewed-by:
-
Thibaud Michaud authored
R=mstarzinger@chromium.org Bug: v8:9183 Change-Id: Id64bffd899afe1389748a0cd3527e41d1e028bad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660472Reviewed-by:
-
Toon Verwaest authored
Change-Id: Iacfa08afd809f5edba8e5e4e45ebe6e9c87b9814 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660625 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#62204}
-
Andreas Haas authored
In the existing code, whenever unreachable control instructions needed values from the stack which were not available, values of type kWasmVar were put on the stack. When these values were type-checked the first time, the expected type was assigned to them for later validation. This behavior has several draw-backs: * In an unobservable way, this implementation does not match the requirements of the spec. With the anyref proposal, this difference becomes observable. * Type checking functions were not read-only anymore, because if unreachable code was validated, the stack got manipulated in these functions. With the refactoring, I pulled out the handling of unreachable code out of the type checking functions. These checking functions can be validation-only functions. For type checking unreachable code, I start by popping values of the expected types off the stack. Thereby all available values on the stack get type-checked. Afterwards, I push all values again on the stack with the expected type if needed. This allows to continue the expected type checking for later instructions. R=clemensh@chromium.org Bug: v8:7581 Change-Id: Ib98e70a44bf9780626d4aa8a3e5fe8c2f230b787 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645328Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#62203}
-
Georg Schmid authored
This is a reland of a66e3e57 Original change's description: > [csa] Tweak CSA pipeline to eliminate more redundant checks > > - Lower LoadObjectField to LoadFromObject > - Mark LoadFromObject and StoreToObject as non-allocating > - Use optimizable BitcastTaggedSignedToWord in TaggedIsNotSmi check > > R=jarin@chromium.org, tebbi@chromium.org > > Change-Id: I42992d46597be795aee3702018f7efd93fcc6ebf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1657926 > Commit-Queue: Georg Schmid <gsps@google.com> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62173} R=tebbi@chromium.org Change-Id: Id7ae13ba17a2083fd4109f34ce026030716ececb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660622 Commit-Queue: Georg Schmid <gsps@google.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#62202}
-
Jakob Gruber authored
RegExp assertions (e.g.: '^', '$', '\b', ...) sequences have certain properties that this rewriter exploits: 1. They are zero-width and order-independent, thus one can remove all duplicate assertions. 2. If a subsequence is guaranteed to fail, the entire sequence fails. Any sequence always known to fail (e.g. containing both '\b' and '\B') can be rewritten to a single node that triggers failure. This CL generalizes the previous optimization for repeated assertions to be order-independent, i.e. assertions only have to be in the same sequence but not next to each other. Bug: v8:6515, v8:6126 Change-Id: I3f92f081ce8a55ad8c34c269a09a6686e3b008f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1657925 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Drive-by cleanup: alpha-sort entries in .gitignore NOTRY=true Change-Id: I14cd97d256a3bc370daad5f64e389d1efb7d50ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660613Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62200}
-
Yu Yin authored
Port 7b48dd55 https://crrev.com/c/1648155 Original Commit Message: This changes Generate_ContinueToBuiltinHelper to generate code to load the builtin address directly from the builtins table rather than going via the executable code in the trampoline's code object. The set up for Generate_ContinueToBuiltinHelper is changed so that the builtin index is stored on the stack in place of the builtin Code object which is no longer needed. Change-Id: I1c8a5a18ac998b16d84556f08637b32d758f44da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1659992 Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Yu Yin <xwafish@gmail.com> Reviewed-by:
-
Jakob Gruber authored
Bug: v8:9359 Change-Id: I06a4ccc53abff25237a1113774a0b17bdf861c86 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658157Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fc6c021..8ef7aaa Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/9c81a61..6ae683b Rolling v8/buildtools/linux64: git_revision:81ee1967d3fcbc829bac1c005c3da59739c88df9..git_revision:8c7f49102234f4f4b9349dcb258554675475e596 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/a959e4f..523c0fd TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Iec7e2e610ed51abd1fc79835737bc0f1baa80be6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1661694Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#62197}
-
- 16 Jun, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7498eac..fc6c021 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/000fc63..2e4b470 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/f72f02b..96bccf1 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Ic6497154440ff7d830ed17b542ed86b4f8d94e72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1661855Reviewed-by:
-
- 15 Jun, 2019 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/be4d13b..7498eac Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/8756a42..9c81a61 Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/ad46488..5938e05 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e502dbc..000fc63 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/539db7d..f72f02b TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I03cc05994c0671fc0a98a65dc0467e09ebe86135 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1661335Reviewed-by:
-
Johannes Henkel authored
New revision: 83b1154a9661d22bba9a368d368214cc20880419 This updates the usages of the protocol types to the new definitions, using std::vector-based implementations of protocol::Array. Change-Id: Ibb095862fed7db23f1a0b4b5b726bddbe1e2585e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1654091 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#62194}
-
- 14 Jun, 2019 9 commits
-
-
Igor Sheludko authored
Bug: chromium:973045, v8:7611, v8:9114, v8:9183, v8:9343 Tbr: verwaest@chromium.org,tebbi@chromium.org Change-Id: I08b509368972956d1c7aedf53884d2590e4cfa27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660619 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Bug: v8:8801,v8:8394,v8:9183 Change-Id: If482c6a14f389d54c6ca3891aa7b8475f7a1fce1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660617 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Mike Stanton authored
In the JSCallReducer, we need to serialize prototypes of receiver maps in order to verify that they are the promise prototype. Bug: v8:7790 Change-Id: Ie9817e531b7faaa3f11dae61a120b46ef5c49847 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660487Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#62191}
-
Mythri A authored
Bug: v8:8394, v8:9183, v8:8803 Change-Id: Icd52eaaae28f605b14c0e63d3aca18541e3c8f6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660616 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Mythri A authored
Bug: v8:8801,v8:8394,v8:9183 Change-Id: I88c0268b30d4b927f9856db7a3b054b74baf1923 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660608 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... since decompression customization for MapWord is already handled by HeapObject::MapField. Bug: v8:9353, v8:9183 Change-Id: I009cdbbf8fc7e72029e1b9be54a0f0b73050e738 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660475 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#62188}
-
Milad Farazmand authored
Port 7b48dd55 Original Commit Message: This changes Generate_ContinueToBuiltinHelper to generate code to load the builtin address directly from the builtins table rather than going via the executable code in the trampoline's code object. The set up for Generate_ContinueToBuiltinHelper is changed so that the builtin index is stored on the stack in place of the builtin Code object which is no longer needed. R=delphick@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ie696468685517333515bf4b0b78fdd7d8c4e7763 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660628Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
Sigurd Schneider authored
This is a reland of 7e7c1b10 Original change's description: > [cleanup] Add operator parameter accessor for S8x16Shuffle > > Bug: v8:7517, v8:9183 > Change-Id: Ic9beade6893b81aaa77f9c634cbeb7444260907b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/973375 > Auto-Submit: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62177} TBR=tebbi@chromium.org Bug: v8:7517, v8:9183 Change-Id: Ia72d73416b2d6b8e7e2fba97cfce39e4ab387a08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660610 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Daniel Vogelheim authored
This extends the existing Isolate::SetAllowCodeGenerationFromStringsCallback mechanism, by adding SetModifyCodeGenerationFromStringCallback, which can also modify the eval argument (it could e.g. add escaping). Bug: chromium:940927 Change-Id: I2b72ec2e3b77a5a33f428a0db5cef3f9f8ed6ba2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593336Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#62185}
-
