• Andreas Haas's avatar
    [wasm] Refactor {unreachable} validation · 0403003b
    Andreas Haas authored
    In the existing code, whenever unreachable control instructions needed
    values from the stack which were not available, values of type kWasmVar
    were put on the stack. When these values were type-checked the first
    time, the expected type was assigned to them for later validation. This
    behavior has several draw-backs:
    * In an unobservable way, this implementation does not match the
      requirements of the spec. With the anyref proposal, this difference
      becomes observable.
    * Type checking functions were not read-only anymore, because if
      unreachable code was validated, the stack got manipulated in these
      functions.
    
    With the refactoring, I pulled out the handling of unreachable code
    out of the type checking functions. These checking functions can be
    validation-only functions.
    
    For type checking unreachable code, I start by popping values of the
    expected types off the stack. Thereby all available values on the stack
    get type-checked. Afterwards, I push all values again on the stack with
    the expected type if needed. This allows to continue the expected type
    checking for later instructions.
    
    R=clemensh@chromium.org
    
    Bug: v8:7581
    Change-Id: Ib98e70a44bf9780626d4aa8a3e5fe8c2f230b787
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645328Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62203}
    0403003b
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...