[regexp] Extract more parts of the regexp compiler

Bug: v8:9359
Change-Id: I06a4ccc53abff25237a1113774a0b17bdf861c86
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658157Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#62198}

BUILD.gn

@@ -2686,7 +2686,10 @@ v8_source_set("v8_base_without_compiler") {
     "src/regexp/regexp-ast.h",
     "src/regexp/regexp-bytecodes.h",
     "src/regexp/regexp-compiler-tonode.cc",
+    "src/regexp/regexp-compiler.cc",
     "src/regexp/regexp-compiler.h",
+    "src/regexp/regexp-dotprinter.cc",
+    "src/regexp/regexp-dotprinter.h",
     "src/regexp/regexp-interpreter.cc",
     "src/regexp/regexp-interpreter.h",
     "src/regexp/regexp-macro-assembler-arch.h",
@@ -2697,6 +2700,7 @@ v8_source_set("v8_base_without_compiler") {
     "src/regexp/regexp-macro-assembler-tracer.h",
     "src/regexp/regexp-macro-assembler.cc",
     "src/regexp/regexp-macro-assembler.h",
+    "src/regexp/regexp-nodes.h",
     "src/regexp/regexp-parser.cc",
     "src/regexp/regexp-parser.h",
     "src/regexp/regexp-stack.cc",
@@ -2949,6 +2953,10 @@ v8_source_set("v8_base_without_compiler") {
     "src/objects/elements.cc",
     "src/objects/objects.cc",
     "src/parsing/parser.cc",
+
+    # Explicit template instantiation clash (these files are also very large).
+    "src/regexp/regexp-compiler-tonode.cc",
+    "src/regexp/regexp-compiler.cc",
   ]
 
   if (v8_current_cpu == "x86") {

src/regexp/jsregexp-inl.h

@@ -75,11 +75,6 @@ int32_t* RegExpImpl::GlobalCache::LastSuccessfulMatch() {
   return &register_array_[index];
 }
 
-RegExpEngine::CompilationResult::CompilationResult(Isolate* isolate,
-                                                   const char* error_message)
-    : error_message(error_message),
-      code(ReadOnlyRoots(isolate).the_hole_value()) {}
-
 }  // namespace internal
 }  // namespace v8
 

src/regexp/regexp-dotprinter.h

+// Copyright 2019 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef V8_REGEXP_REGEXP_DOTPRINTER_H_
+#define V8_REGEXP_REGEXP_DOTPRINTER_H_
+
+#include "src/common/globals.h"
+
+namespace v8 {
+namespace internal {
+
+class RegExpNode;
+
+class DotPrinter final : public AllStatic {
+ public:
+  static void DotPrint(const char* label, RegExpNode* node, bool ignore_case);
+};
+
+}  // namespace internal
+}  // namespace v8
+
+#endif  // V8_REGEXP_REGEXP_DOTPRINTER_H_

src/regexp/regexp-parser.cc

@@ -11,6 +11,7 @@
 #include "src/objects/objects-inl.h"
 #include "src/regexp/jsregexp.h"
 #include "src/regexp/property-sequences.h"
+#include "src/regexp/regexp-macro-assembler.h"
 #include "src/strings/char-predicates-inl.h"
 #include "src/utils/ostreams.h"
 #include "src/utils/utils.h"