- 22 Dec, 2016 9 commits
-
-
danno authored
* Ensure that a source position is already specified in generated code before prologue is assembled. * Ensure source position is set for instructions before their gaps are assembled (this fixes missing source position information at the beginning of deferred code). * Don't output source position information for gap moves that are redundant. This led to extraneous, confusing source positions for constants that did not end up producing any code. * Output source position information that is usable in turbolizer when --trace-turbo is specified. LOG=N Review-Url: https://codereview.chromium.org/2599433002 Cr-Commit-Position: refs/heads/master@{#41914}
-
bmeurer authored
Also support inlining the builtins String.prototype.charCodeAt and String.prototype.charAt if the index type is not statically known to be in the Unsigned32 range, but in anything in Integral32 plus minus zero and NaN. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2597913002 Cr-Commit-Position: refs/heads/master@{#41913}
-
bmeurer authored
Introduce a dedicated StringCharCodeAt builtin, that performs the core logic of String.prototype.charCodeAt and lower the StringCharCodeAt simplified operator to a call to this builtin rather than inlining the full functionality into each and every TurboFan graph using it. This can significantly reduce compile time in some cases (i.e. can easily shave off over 50% of compile time overhead for small functions that call String.prototype.charCodeAt). Currently it returns the char code as TaggedSigned value, but middle-term we should make it possible to return untagged values from builtins. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2600443002 Cr-Commit-Position: refs/heads/master@{#41912}
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2589203002 Cr-Commit-Position: refs/heads/master@{#41911}
-
yangguo authored
R=bmeurer@chromium.org BUG=v8:5767 Review-Url: https://codereview.chromium.org/2599693002 Cr-Commit-Position: refs/heads/master@{#41910}
-
bmeurer authored
Previously String element access and String.prototype.charAt were lowered to a subgraph StringFromCharCode(StringCharCodeAt(s, k)), however that can be fairly expensive both runtime and compile time wise. The dedicated StringCharAt operator is implemented via a call to a builtin that does exactly this. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2599683002 Cr-Commit-Position: refs/heads/master@{#41909}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/564d650..5c10e06 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/f3dc14e..489a5bc Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/780832e..f6f94f4 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2597893002 Cr-Commit-Position: refs/heads/master@{#41908}
-
eholk authored
This CL includes several small bug fixes for trap handlers. Among the changes: * Use the correct representation for ProtectedLoads, enabling protected loads of floating point types. * Including the protected instruction list in what gets serialized for Code objects. This is needed to allow deserialization for Wasm modules to work. * Get the context needed to through and exception from the Isolate rather than getting it as a parameter to the Protected instructions. Passing it in as an argument is problematic when code is compiled ahead of time, as the context may not be known yet. The new approach is similar to how it works for TrapIf and TrapUnless. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5277 Review-Url: https://codereview.chromium.org/2591903002 Cr-Commit-Position: refs/heads/master@{#41907}
-
sampsong authored
R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2591643005 Cr-Commit-Position: refs/heads/master@{#41906}
-
- 21 Dec, 2016 28 commits
-
-
gsathya authored
R=adamk@chromium.org Review-Url: https://codereview.chromium.org/2593243002 Cr-Commit-Position: refs/heads/master@{#41905}
-
gsathya authored
TBR=ishell@chromium.org Review-Url: https://codereview.chromium.org/2599523002 Cr-Commit-Position: refs/heads/master@{#41904}
-
danno authored
Review-Url: https://codereview.chromium.org/2597693002 Cr-Commit-Position: refs/heads/master@{#41903}
-
gsathya authored
This patch also refactors most of PromiseThen into InternalPromiseThen to be reused with PromiseCatch and also changes InternalResolvePromise to return and not branch. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2596553002 Cr-Commit-Position: refs/heads/master@{#41902}
-
Adam Klein authored
R=bmeurer@chromium.org, gsathya@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/2591613003 . Cr-Commit-Position: refs/heads/master@{#41901}
-
caitp authored
Change bytecode-expectations-printer.cc in the cctest application so that intrinsic function names are printed rather than their native context index. This minimizes the amount of unnecessary changes to the bytecode expectations that need to happen whenever the context fields are changed. BUG=v8:5769 R=neis@chromium.org, rmcilroy@chromium.org, adamk@chromium.org Review-Url: https://codereview.chromium.org/2593823002 Cr-Commit-Position: refs/heads/master@{#41900}
-
ishell authored
This is a preliminary step for constant tracking. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2595893002 Cr-Commit-Position: refs/heads/master@{#41899}
-
bjaideep authored
Port 93df0940 Original Commit Message: Literal arrays and feedback vectors for a function can be garbage collected if we don't have a rooted closure for the function, which happens often. It's expensive to come back from this (recreating boilerplates and gathering feedback again), and the cost is disproportionate if the function was inlined into optimized code. To guard against losing these arrays when we need them, we'll now create literal arrays when creating the feedback vector for the outer closure, and root them strongly in that vector. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5456 LOG=N Review-Url: https://codereview.chromium.org/2592043003 Cr-Commit-Position: refs/heads/master@{#41898}
-
danno authored
Review-Url: https://codereview.chromium.org/2593033002 Cr-Commit-Position: refs/heads/master@{#41897}
-
leszeks authored
Revert of abstract_code: return compiled code for compiled shared funcs (patchset #2 id:20001 of https://codereview.chromium.org/2592703002/ ) Reason for revert: Breaks tree: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/9970 Original issue's description: > abstract_code: return compiled code for compiled shared funcs > > SharedFunctionInfo's abstract_code was returning the bytecode array > whenever SharedFunctionInfo had a bytecode array, even if the function > was compiled (e.g. tiered up to FCG). This meant that abstract_code > could return code that is not actually the code that will run, which was > causing problems in profiling as the sampled PC did not match the known > code offset. > > This patch changes both SharedFunctionInfo and JSFunction to return the > bytecode if-and-only-if they are not compiled and have a bytecode array > to return, or they already point to the interpreter trampoline. > > BUG=v8:5758 > > Review-Url: https://codereview.chromium.org/2592703002 > Cr-Commit-Position: refs/heads/master@{#41894} > Committed: https://chromium.googlesource.com/v8/v8/+/679b31c21425ecdd86c40a8a02ac131b72f7bc6b TBR=bmeurer@chromium.org,mstarzinger@chromium.org,mvstanton@chromium.org,mythria@chromium.org,rmcilroy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5758 Review-Url: https://codereview.chromium.org/2591223002 Cr-Commit-Position: refs/heads/master@{#41896}
-
bbudge authored
On ARM Neon at least, denormals flush to zero, which may not match regular FP behavior. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2598583002 Cr-Commit-Position: refs/heads/master@{#41895}
-
leszeks authored
SharedFunctionInfo's abstract_code was returning the bytecode array whenever SharedFunctionInfo had a bytecode array, even if the function was compiled (e.g. tiered up to FCG). This meant that abstract_code could return code that is not actually the code that will run, which was causing problems in profiling as the sampled PC did not match the known code offset. This patch changes both SharedFunctionInfo and JSFunction to return the bytecode if-and-only-if they are not compiled and have a bytecode array to return, or they already point to the interpreter trampoline. BUG=v8:5758 Review-Url: https://codereview.chromium.org/2592703002 Cr-Commit-Position: refs/heads/master@{#41894}
-
mvstanton authored
Literal arrays and feedback vectors for a function can be garbage collected if we don't have a rooted closure for the function, which happens often. It's expensive to come back from this (recreating boilerplates and gathering feedback again), and the cost is disproportionate if the function was inlined into optimized code. To guard against losing these arrays when we need them, we'll now create literal arrays when creating the feedback vector for the outer closure, and root them strongly in that vector. BUG=v8:5456 Review-Url: https://codereview.chromium.org/2504153002 Cr-Commit-Position: refs/heads/master@{#41893}
-
jgruber authored
The two remaining uses of this intrinsic in debug.js and mirrors.js now simply rely on the runtime function. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2591923003 Cr-Commit-Position: refs/heads/master@{#41892}
-
titzer authored
This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891}
-
jgruber authored
No need to untag/tag flags, and we can also omit the write barrier. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2591193002 Cr-Commit-Position: refs/heads/master@{#41890}
-
titzer authored
Since WASM is no longer an AST :-( R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594973003 Cr-Commit-Position: refs/heads/master@{#41889}
-
clemensh authored
Also, provide a variadic template Return function for easier use, and refactor the underlying Return function to not use the Buffer, since that might still be needed later (for example if trap code is generated during CallIndirect, and the arguments to the call are stored in the buffer). R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2591903003 Cr-Commit-Position: refs/heads/master@{#41888}
-
littledan authored
The methods Intl.NumberFormat.prototype.v8Parse and Intl.DateTimeFormat.prototype.v8Parse were removed several months ago due to low usage and lack of standardization potential. This patch removes some runtime functions used to implement them, which were accidentally left in when they were taken out. BUG=v8:3785 Review-Url: https://codereview.chromium.org/2591103003 Cr-Commit-Position: refs/heads/master@{#41887}
-
http://crbug.com/675648epertoso authored
R=jarin@chromium.org BUG=675648 Review-Url: https://codereview.chromium.org/2598463003 Cr-Commit-Position: refs/heads/master@{#41886}
-
titzer authored
R=clemensh@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2590243003 Cr-Commit-Position: refs/heads/master@{#41885}
-
alph authored
BUG=chromium:664286 Review-Url: https://codereview.chromium.org/2595673002 Cr-Commit-Position: refs/heads/master@{#41884}
-
jshin authored
Update string-capitalize expected result because now it passes all the tests in the file. Mark fast/js/string-capitalization as failing with no_i18n. Relanding after revert because the failure was taken care of by Adam's CL at https://codereview.chromium.org/2597543002 . BUG=v8:4477, v8:4476 TEST=test262/{built-ins,intl402}/Strings/*, webkit/fast/js/*, mjsunit/string-case, intl/general/case* Cr-Original-Commit-Position: refs/heads/master@{#41834} Committed: https://chromium.googlesource.com/v8/v8/+/7c79e23c34ea971947eedc6e42d8a882617c0e47 Review-Url: https://codereview.chromium.org/2588963002 Cr-Commit-Position: refs/heads/master@{#41883}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/53a8a4b..564d650 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/70f42a7..f3dc14e Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/fcefe9f..780832e TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2593913002 Cr-Commit-Position: refs/heads/master@{#41882}
-
jyan authored
R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2593803003 Cr-Commit-Position: refs/heads/master@{#41881}
-
gsathya authored
BUG=v8:5343 Review-Url: https://codereview.chromium.org/2591033002 Cr-Commit-Position: refs/heads/master@{#41880}
-
gsathya authored
This removes RegExpPrototypeSpeciesGetter and IteratorPrototypeIterator and uses ReturnReceiver builtin instead. This patch also ports the PromiseSpecies to TF by reusing this builtin. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2590373002 Cr-Commit-Position: refs/heads/master@{#41879}
-
adamk authored
The test depends on tricky stack space requirements, so it stopped working in some configurations win FLAG_min_preparse_length was removed in commit 4a5b7e32. As a workaround, pass --no-lazy until the test can be refined to work on all configurations. BUG=v8:5729 TBR=marja@chromium.org Review-Url: https://codereview.chromium.org/2596673002 Cr-Commit-Position: refs/heads/master@{#41878}
-
- 20 Dec, 2016 3 commits
-
-
adamk authored
BUG=v8:4954 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2591853002 Cr-Original-Commit-Position: refs/heads/master@{#41873} Committed: https://chromium.googlesource.com/v8/v8/+/07277202cf136e70c147e2f000e48964332bb01c Review-Url: https://codereview.chromium.org/2591853002 Cr-Commit-Position: refs/heads/master@{#41877}
-
Adam Klein authored
This test requires its objects to live in new space, so running it through gc stress runs just makes it susceptible to flakiness, as was recently seen when turning on the --harmony-string-padding flag (which just adds an extra JS file to the bootstrapper sequence). TBR=ishell@chromium.org, jkummerow@chromium.org Review-Url: https://codereview.chromium.org/2597543002 . Cr-Commit-Position: refs/heads/master@{#41876}
-
gsathya authored
git cl format flagged this while merging Review-Url: https://codereview.chromium.org/2594693003 Cr-Commit-Position: refs/heads/master@{#41875}
-