- 20 Jan, 2017 40 commits
-
-
ishell authored
BUG= Review-Url: https://codereview.chromium.org/2645083003 Cr-Commit-Position: refs/heads/master@{#42571}
-
jgruber authored
This implements storing named captures on the regexp result object. For instance, /(?<a>.)/u.exec("b") will return a result such that: result.group.a // "b" The spec proposal is not yet final, so this may still change in the future. BUG=v8:5437 Review-Url: https://codereview.chromium.org/2630233003 Cr-Original-Commit-Position: refs/heads/master@{#42532} Committed: https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1fcf154 Review-Url: https://codereview.chromium.org/2630233003 Cr-Commit-Position: refs/heads/master@{#42570}
-
machenbach authored
Also switch on validate asm in all configuration to zero out any comparisons. BUG=chromium:673246 NOTRY=true TBR=mstarzinger@chromium.org, rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2647493004 Cr-Commit-Position: refs/heads/master@{#42569}
-
mtrofin authored
BUG=v8:5876 Review-Url: https://codereview.chromium.org/2644893004 Cr-Commit-Position: refs/heads/master@{#42568}
-
tebbi authored
Create different json files for diffferent optimization attempts of the same function. This allows to analyze the graphs of early optimization attempts that lead to deopts or to produce a proper json file in the case of a deopt loop. R=danno@chromium.org Review-Url: https://codereview.chromium.org/2649513003 Cr-Commit-Position: refs/heads/master@{#42567}
-
clemensh authored
In this particular case, we just did a (lhs)op(rhs), ignoring the case that lhs and rhs might have different signedness. This CL changes that to use the proper Cmp##op##Impl implementation, which does two comparisions for signed-vs-unsigned checks, avoiding compiler errors. R=ishell@chromium.org Review-Url: https://codereview.chromium.org/2642383002 Cr-Commit-Position: refs/heads/master@{#42566}
-
mlippautz authored
Do not DCHECK live bytes as they might be inconsistent. BUG= TBR=hpayer@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2647573004 Cr-Commit-Position: refs/heads/master@{#42565}
-
titzer authored
R=rossberg@chromium.org BUG=chromium:682659 Review-Url: https://codereview.chromium.org/2646093003 Cr-Commit-Position: refs/heads/master@{#42564}
-
marja authored
E.g., ast/ast.h uses Label but shouldn't need to include assembler.h for that. With this change, we can hope for proper layering in the future (not quite there yet). Also includes minor random include lowering and relevant IWYU fixes. BUG=v8:5294 Review-Url: https://codereview.chromium.org/2645063002 Cr-Commit-Position: refs/heads/master@{#42563}
-
rmcilroy authored
Moves ownership of the parsing Zone to ParseInfo with a shared_ptr. This is in preperation for enabling background compilation jobs for inner functions share the AST in the outer-function's parse zone memory (read-only), with the and zone being released when all compilation jobs have completed. BUG=v8:5203,v8:5215 Review-Url: https://codereview.chromium.org/2632123006 Cr-Original-Commit-Position: refs/heads/master@{#42539} Committed: https://chromium.googlesource.com/v8/v8/+/839b06b64fcaaaa9cceb2c3fd8fd5429e2932095 Review-Url: https://codereview.chromium.org/2632123006 Cr-Commit-Position: refs/heads/master@{#42562}
-
petermarshall authored
FAST_DOUBLE_ELEMENTS and FAST_HOLEY_DOUBLE_ELEMENTS kinds should both be handled by the runtime. Review-Url: https://codereview.chromium.org/2644643011 Cr-Commit-Position: refs/heads/master@{#42561}
-
clemensh authored
Test that setting breakpoints works for wasm, and that they are hit correctly. This basically tests all the layers involved: Compiling and running wasm interpreter entries, passing arguments to the interpreter, storing break point infos in wasm objects, getting the right BreakLocation from wasm frames, and getting stack information from interpreted frames. BUG=v8:5822 R=titzer@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/2629883002 Cr-Commit-Position: refs/heads/master@{#42560}
-
ahaas authored
The index input of load and store nodes has to be of type int32. However it is still possible that this index input was lowered by the Int64Lowering, for example if the index was a kTruncateInt64ToInt32 node. With this CL we check if there exists a replacement of the index and if so, use the replacement instead of the original index as the input for the lowered load and store nodes. BUG=v8:5874 R=titzer@chromium.org, eholk@chromium.org Review-Url: https://codereview.chromium.org/2644603004 Cr-Commit-Position: refs/heads/master@{#42559}
-
machenbach authored
TBR=maruel@chromium.org BUG=v8:5872 Review-Url: https://codereview.chromium.org/2645053002 Cr-Commit-Position: refs/heads/master@{#42558}
-
titzer authored
R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2644323002 Cr-Commit-Position: refs/heads/master@{#42557}
-
rossberg authored
R=titzer@chromium.org BUG= Review-Url: https://codereview.chromium.org/2640113005 Cr-Commit-Position: refs/heads/master@{#42556}
-
mlippautz authored
BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2637403011 Cr-Commit-Position: refs/heads/master@{#42555}
-
ishell authored
BUG=chromium:682706 Review-Url: https://codereview.chromium.org/2644853003 Cr-Commit-Position: refs/heads/master@{#42554}
-
yangguo authored
This particular test case is a hack that abuses Turbofan to generate code that contains a switch table. Now that some builtins use the CodeStubAssembler to implement switch tables we don't need this test case anymore. TBR=jarin@chromium.org Review-Url: https://codereview.chromium.org/2645943003 Cr-Commit-Position: refs/heads/master@{#42553}
-
marja authored
BUG=v8:5402 Review-Url: https://codereview.chromium.org/2642353002 Cr-Commit-Position: refs/heads/master@{#42552}
-
clemensh authored
Frame inspection is currently limited to locations of execution. Further details like local variables or stack content will follow later. The FrameInspector now stores a pointer to the interpreted wasm frame, and redirects certain requests there, just as for deoptimized frames. Hitting breakpoints is now also supported for wasm frames. R=yangguo@chromium.org, titzer@chromium.org BUG=v8:5822 Review-Url: https://codereview.chromium.org/2629823003 Cr-Commit-Position: refs/heads/master@{#42551}
-
franzih authored
Enable test after fix. R=adamk@chromium.org, bmeurer@chromium.org BUG=v8:5873 Review-Url: https://codereview.chromium.org/2648693003 Cr-Commit-Position: refs/heads/master@{#42550}
-
yangguo authored
Revert of [debugger api] remove legacy JSON debug protocol. (patchset #2 id:20001 of https://codereview.chromium.org/2642253005/ ) Reason for revert: Node.js relies on this Original issue's description: > [debugger api] remove legacy JSON debug protocol. > > R=jgruber@chromium.org > BUG=v8:5530 > > Review-Url: https://codereview.chromium.org/2642253005 > Cr-Commit-Position: refs/heads/master@{#42543} > Committed: https://chromium.googlesource.com/v8/v8/+/e26a58e43c51a680a0a6363e0066886f4971a41f TBR=jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5530 Review-Url: https://codereview.chromium.org/2644233003 Cr-Commit-Position: refs/heads/master@{#42549}
-
franzih authored
ReduceJSStoreDataPropertyInLiteral should not reduce the monomorphic case if the map got deleted. This has been fixed before in the context of a larger commit, which was reverted. R=adamk@chromium.org, mvstanton@chromium.org, bmeurer@chromium.org BUG=v8:5873 Review-Url: https://codereview.chromium.org/2644733007 Cr-Commit-Position: refs/heads/master@{#42548}
-
dusan.simicic authored
This patch adds destructor to ValueSerializerTest test fixture class which reset unhandled scheduled exceptions thrown from the current test. In some cases unhandled scheduled exceptions from current test (eg. from one test from ValueSerializerTestWithWasm test case) produce that Context::New(isolate()) from next test's constructor returns NULL. This error is easily reproduced when unittest file (compiled for ARM or MIPS simulator) is directly executed (not by tools/run_tests.py script), so all tests are executed together. When the script is used, each test from ValueSerializerTestWithWasm test case is separately executed and unhandled exception from one test doesn't efect to another test from the same test case. BUG= Review-Url: https://codereview.chromium.org/2644083002 Cr-Commit-Position: refs/heads/master@{#42547}
-
yangguo authored
Revert of [debugger] temporarily re-implement --expose-debug-as. (patchset #1 id:1 of https://codereview.chromium.org/2636423002/ ) Reason for revert: Flag is being removed for 5.8. Original issue's description: > [debugger] temporarily re-implement --expose-debug-as. > > This is done out of courtesy for Node.js and will be > removed as soon as we branch for version 5.8. > > R=jgruber@chromium.org > > Review-Url: https://codereview.chromium.org/2636423002 > Cr-Commit-Position: refs/heads/master@{#42437} > Committed: https://chromium.googlesource.com/v8/v8/+/cbb7145221dad688ebe86f90bfa4fdd63ea1263e TBR=jgruber@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2641283002 Cr-Commit-Position: refs/heads/master@{#42546}
-
ahaas authored
On ia32 return statements in C++ automatically convert signalling NaNs to quiet NaNs, even when bit_cast is used. This CL removes all uses of bit_cast<float> and bit_cast<double> in the wasm compiler and wasm interpreter. R=titzer@chromium.org, clemensh@chromium.org Review-Url: https://codereview.chromium.org/2639353002 Cr-Original-Commit-Position: refs/heads/master@{#42512} Committed: https://chromium.googlesource.com/v8/v8/+/7739affa5b57e0d28674d476f63de60d71728fb6 Review-Url: https://codereview.chromium.org/2639353002 Cr-Commit-Position: refs/heads/master@{#42545}
-
bmeurer authored
The %_ValueOf intrinsic is not used anymore and the runtime call %ValueOf will also disappear once all the self hosted builtins are migrated. R=rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2642303003 Cr-Commit-Position: refs/heads/master@{#42544}
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2642253005 Cr-Commit-Position: refs/heads/master@{#42543}
-
rmcilroy authored
Revert of [Parse] ParseInfo owns the parsing Zone. (patchset #4 id:60001 of https://codereview.chromium.org/2632123006/ ) Reason for revert: Crashes on Windows in: CompilerDispatcherJobTest.CompileFailureToFinalize CompilerDispatcherJobTest.ScopeChain Original issue's description: > [Parse] ParseInfo owns the parsing Zone. > > Moves ownership of the parsing Zone to ParseInfo with a shared_ptr. This is > in preperation for enabling background compilation jobs for inner functions > share the AST in the outer-function's parse zone memory (read-only), with the > and zone being released when all compilation jobs have completed. > > BUG=v8:5203,v8:5215 > > Review-Url: https://codereview.chromium.org/2632123006 > Cr-Commit-Position: refs/heads/master@{#42539} > Committed: https://chromium.googlesource.com/v8/v8/+/839b06b64fcaaaa9cceb2c3fd8fd5429e2932095 TBR=marja@chromium.org,mstarzinger@chromium.org,ahaas@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203,v8:5215 Review-Url: https://codereview.chromium.org/2645613008 Cr-Commit-Position: refs/heads/master@{#42542}
-
rmcilroy authored
Revert of [Compiler] Have renumber recurse into eagerly compiled function literals. (patchset #2 id:40001 of https://codereview.chromium.org/2648503002/ ) Reason for revert: Revert in order to revert dependent patchset https://codereview.chromium.org/2632123006/ Original issue's description: > [Compiler] Have renumber recurse into eagerly compiled function literals. > > This enables us to produce the list of eager inner functions for compilation > in one go during the outer function's renumbering step, and avoid having > to do renumbering explicitly on the inner functions, simplifying the zone > ownership. > > BUG=v8:5203, v8:5215 > > Review-Url: https://codereview.chromium.org/2648503002 > Cr-Commit-Position: refs/heads/master@{#42540} > Committed: https://chromium.googlesource.com/v8/v8/+/3541a074e241421b64ba41d81d8a99bb6ac62c5e TBR=mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203, v8:5215 Review-Url: https://codereview.chromium.org/2643233002 Cr-Commit-Position: refs/heads/master@{#42541}
-
rmcilroy authored
This enables us to produce the list of eager inner functions for compilation in one go during the outer function's renumbering step, and avoid having to do renumbering explicitly on the inner functions, simplifying the zone ownership. BUG=v8:5203, v8:5215 Review-Url: https://codereview.chromium.org/2648503002 Cr-Commit-Position: refs/heads/master@{#42540}
-
rmcilroy authored
Moves ownership of the parsing Zone to ParseInfo with a shared_ptr. This is in preperation for enabling background compilation jobs for inner functions share the AST in the outer-function's parse zone memory (read-only), with the and zone being released when all compilation jobs have completed. BUG=v8:5203,v8:5215 Review-Url: https://codereview.chromium.org/2632123006 Cr-Commit-Position: refs/heads/master@{#42539}
-
jarin authored
BUG=chromium:682671 Review-Url: https://codereview.chromium.org/2644283002 Cr-Commit-Position: refs/heads/master@{#42538}
-
marja authored
Rationale: - To do scope analysis based on PreParser, and use the result again when parsing later, PreParser and Parser need to produce the same Scopes and variable declarations in them. - This is not the case for non-simple parameters: Parser creates an additional inner Scope where the declarations were, whereas PreParser does DeclareVariableName directly in the function Scope. - So this CL fixes that by moving the Scope creation for non-simple parameters into ParserBase. - As a side product (and a partial proof that this change makes sense), PreParser::ParseEagerFunctionBody is now gone. BUG=v8:5516 Review-Url: https://codereview.chromium.org/2638333002 Cr-Commit-Position: refs/heads/master@{#42537}
-
jochen authored
BUG=chromium:681984 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2640983006 Cr-Commit-Position: refs/heads/master@{#42536}
-
bmeurer authored
Let the Typer assign proper types to Map, Set, WeakMap and WeakSet builtins. Also assign a proper type to Array.isArray, Object.assign and Object.create. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2640783006 Cr-Commit-Position: refs/heads/master@{#42535}
-
jgruber authored
Revert of [regexp] Create property on result for each named capture (patchset #5 id:80001 of https://codereview.chromium.org/2630233003/ ) Reason for revert: Breaks no18n build: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/11604 Original issue's description: > [regexp] Store named captures on the regexp result > > This implements storing named captures on the regexp result object. > For instance, /(?<a>.)/u.exec("b") will return a result such that: > > result.group.a // "b" > > The spec proposal is not yet final, so this may still change in the future. > > BUG=v8:5437 > > Review-Url: https://codereview.chromium.org/2630233003 > Cr-Commit-Position: refs/heads/master@{#42532} > Committed: https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1fcf154 TBR=yangguo@chromium.org,littledan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5437 Review-Url: https://codereview.chromium.org/2643213002 Cr-Commit-Position: refs/heads/master@{#42534}
-
bmeurer authored
Revert of [heap] Provide ObjectMarking with marking transitions (patchset #5 id:80001 of https://codereview.chromium.org/2644523002/ ) Reason for revert: Breaks the tree: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/8349/steps/Mjsunit/logs/compiled-module-seria.. Original issue's description: > [heap] Provide ObjectMarking with marking transitions > > BUG=chromium:651354 > > Review-Url: https://codereview.chromium.org/2644523002 > Cr-Commit-Position: refs/heads/master@{#42531} > Committed: https://chromium.googlesource.com/v8/v8/+/cbb8929e97ee475dab4f704a71637e76342e903a TBR=hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2647873002 Cr-Commit-Position: refs/heads/master@{#42533}
-
jgruber authored
This implements storing named captures on the regexp result object. For instance, /(?<a>.)/u.exec("b") will return a result such that: result.group.a // "b" The spec proposal is not yet final, so this may still change in the future. BUG=v8:5437 Review-Url: https://codereview.chromium.org/2630233003 Cr-Commit-Position: refs/heads/master@{#42532}
-