• clemensh's avatar
    Fix CHECK_OP implementation in Release builds · 4dcbe86e
    clemensh authored
    In this particular case, we just did a (lhs)op(rhs), ignoring the case
    that lhs and rhs might have different signedness.
    This CL changes that to use the proper Cmp##op##Impl implementation,
    which does two comparisions for signed-vs-unsigned checks, avoiding
    compiler errors.
    
    R=ishell@chromium.org
    
    Review-Url: https://codereview.chromium.org/2642383002
    Cr-Commit-Position: refs/heads/master@{#42566}
    4dcbe86e
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...