• marja's avatar
    Parsing: Create the same scopes for non-simple params in PreParser & Parser. · 35340917
    marja authored
    Rationale:
    
    - To do scope analysis based on PreParser, and use the result again when parsing
      later, PreParser and Parser need to produce the same Scopes and variable
      declarations in them.
    
    - This is not the case for non-simple parameters: Parser creates an additional
      inner Scope where the declarations were, whereas PreParser does
      DeclareVariableName directly in the function Scope.
    
    - So this CL fixes that by moving the Scope creation for non-simple parameters
      into ParserBase.
    
    - As a side product (and a partial proof that this change makes sense),
      PreParser::ParseEagerFunctionBody is now gone.
    
    BUG=v8:5516
    
    Review-Url: https://codereview.chromium.org/2638333002
    Cr-Commit-Position: refs/heads/master@{#42537}
    35340917
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...