1. 03 May, 2022 1 commit
  2. 02 May, 2022 1 commit
  3. 11 Apr, 2022 1 commit
    • Maksim Sadym's avatar
      Add `WebDriverBiDi` serialization to CDP · a913a75b
      Maksim Sadym authored
      1. Added `generateWebDriverValue` flag to `Runtime.evaluate` and `Runtime.callFunctionOn`.
      2. Added `webDriverValue` field to `RemoteObject`, and set it in case of the `generateWebDriverValue` flag was set.
      3. Added virtual method `bidiSerialize` to allow embedder-implemented serialization (like in https://crrev.com/c/3472491).
      4. Implemented V8 serialization in a separate class `V8WebDriverSerializer`.
      5. Hardcode `max_depth=1`.
      6. Added tests.
      
      Not implemented yet:
      1. `objectId`.
      2. Test of embedder-implemented serialization.
      
      Tested automatically by:
      ```
      python3 tools/run-tests.py --outdir out/foo inspector/runtime/add-web-driver-value
      ```
      
      Naming to be discussed. Suggestions are very welcome.
      
      Design doc: http://go/bidi-serialization
      
      Change-Id: Ib35ed8ff58e40b3304423cc2139050136d844e2c
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3472077Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Commit-Queue: Maksim Sadym <sadym@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#79922}
      a913a75b
  4. 30 Mar, 2022 1 commit
    • Benedikt Meurer's avatar
      [inspector] Add custom error dispatch machinery for debug evaluate. · 56cfdd68
      Benedikt Meurer authored
      This introduces a `V8InspectorClient::dispatchError()` callback that
      embedders can use to dispatch errors from scripts injected by DevTools
      (via debug evaluate). The idea here being that while these errors are
      technically caught by the inspector logic, the DevTools UX presents them
      just like other uncaught errors, with the exception that they don't
      trigger error handlers installed by the page. The latter can be quite
      confusing to developers, and surprising when for example testing these
      error handlers from DevTools. So this adds the foundations on the V8
      side to enable triggering error handlers for these technically caught,
      but morally uncaught, exceptions.
      
      On the Chromium side https://crrev.com/c/3560458 will implement and
      use the hook. And that CL also adds a web tests to check the behavior.
      
      Bug: chromium:1295750
      Change-Id: I945c8a9e9b4ec5705fc7f1891dcda185b04c8310
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3557234
      Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#79673}
      56cfdd68
  5. 08 Feb, 2022 1 commit
  6. 04 Feb, 2022 1 commit
  7. 24 Nov, 2021 2 commits
  8. 26 Oct, 2021 1 commit
  9. 07 Sep, 2021 1 commit
  10. 24 Aug, 2021 1 commit
    • Dan Elphick's avatar
      Reland "[include] Split out v8.h" · ec06bb6c
      Dan Elphick authored
      This is a reland of d1b27019
      
      Fixes include:
      Adding missing file to bazel build
      Forward-declaring classing before friend-classing them to fix win/gcc
      Add missing v8-isolate.h include for vtune builds
      
      Original change's description:
      > [include] Split out v8.h
      >
      > This moves every single class/function out of include/v8.h into a
      > separate header in include/, which v8.h then includes so that
      > externally nothing appears to have changed.
      >
      > Every include of v8.h from inside v8 has been changed to a more
      > fine-grained include.
      >
      > Previously inline functions defined at the bottom of v8.h would call
      > private non-inline functions in the V8 class. Since that class is now
      > in v8-initialization.h and is rarely included (as that would create
      > dependency cycles), this is not possible and so those methods have been
      > moved out of the V8 class into the namespace v8::api_internal.
      >
      > None of the previous files in include/ now #include v8.h, which means
      > if embedders were relying on this transitive dependency then it will
      > give compile failures.
      >
      > v8-inspector.h does depend on v8-scripts.h for the time being to ensure
      > that Chrome continue to compile but that change will be reverted once
      > those transitive #includes in chrome are changed to include it directly.
      >
      > Full design:
      > https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
      >
      > Bug: v8:11965
      > Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
      > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > Commit-Queue: Dan Elphick <delphick@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#76424}
      
      Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit
      Bug: v8:11965
      Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#76460}
      ec06bb6c
  11. 23 Aug, 2021 2 commits
    • Dan Elphick's avatar
      Revert "[include] Split out v8.h" · 44fe02ce
      Dan Elphick authored
      This reverts commit d1b27019.
      
      Reason for revert: Broke vtune build, tsan build and possibly others
      
      Original change's description:
      > [include] Split out v8.h
      >
      > This moves every single class/function out of include/v8.h into a
      > separate header in include/, which v8.h then includes so that
      > externally nothing appears to have changed.
      >
      > Every include of v8.h from inside v8 has been changed to a more
      > fine-grained include.
      >
      > Previously inline functions defined at the bottom of v8.h would call
      > private non-inline functions in the V8 class. Since that class is now
      > in v8-initialization.h and is rarely included (as that would create
      > dependency cycles), this is not possible and so those methods have been
      > moved out of the V8 class into the namespace v8::api_internal.
      >
      > None of the previous files in include/ now #include v8.h, which means
      > if embedders were relying on this transitive dependency then it will
      > give compile failures.
      >
      > v8-inspector.h does depend on v8-scripts.h for the time being to ensure
      > that Chrome continue to compile but that change will be reverted once
      > those transitive #includes in chrome are changed to include it directly.
      >
      > Full design:
      > https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
      >
      > Bug: v8:11965
      > Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
      > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
      > Commit-Queue: Dan Elphick <delphick@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#76424}
      
      Bug: v8:11965
      Change-Id: Id57313ae992e720c8b19abc975cd69729e1344aa
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113627
      Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Owners-Override: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#76428}
      44fe02ce
    • Dan Elphick's avatar
      [include] Split out v8.h · d1b27019
      Dan Elphick authored
      This moves every single class/function out of include/v8.h into a
      separate header in include/, which v8.h then includes so that
      externally nothing appears to have changed.
      
      Every include of v8.h from inside v8 has been changed to a more
      fine-grained include.
      
      Previously inline functions defined at the bottom of v8.h would call
      private non-inline functions in the V8 class. Since that class is now
      in v8-initialization.h and is rarely included (as that would create
      dependency cycles), this is not possible and so those methods have been
      moved out of the V8 class into the namespace v8::api_internal.
      
      None of the previous files in include/ now #include v8.h, which means
      if embedders were relying on this transitive dependency then it will
      give compile failures.
      
      v8-inspector.h does depend on v8-scripts.h for the time being to ensure
      that Chrome continue to compile but that change will be reverted once
      those transitive #includes in chrome are changed to include it directly.
      
      Full design:
      https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
      
      Bug: v8:11965
      Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#76424}
      d1b27019
  12. 16 Aug, 2021 1 commit
    • Camillo Bruni's avatar
      Revert "[DevTools] Implemented DevTools protocol API to retrieve V8 RunTime Call Stats." · a016cce5
      Camillo Bruni authored
      This reverts commit 91c8be95.
      
      RCS should not be exposed through the API or the inspector protocol as
      they are meant as an internal debugging feature.
      The only regularly tested and supported way is through chrome-tracing.
      
      Given that this was used mostly for an experiment to analyse chrome's
      performance, we can use pprof support as a replacement.
      
      Original change's description:
      > [DevTools] Implemented DevTools protocol API to retrieve V8 RunTime Call Stats.
      >
      > The new APIs are:
      > enableRuntimeCallStats
      > disableRuntimeCallStats
      > getRuntimeCallStats
      >
      > The RunTime Call Stats are collected per isolate.
      >
      > Change-Id: I7e520e2c866288aa9f9dc74f12572abedf0d3ac8
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1881601
      > Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#64784}
      
      Change-Id: Ia7575436e97d3420dd7e68414d89477e6a86bb05
      Bug: v8:11395
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2998585Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#76297}
      a016cce5
  13. 10 Aug, 2021 1 commit
  14. 02 Jul, 2021 2 commits
    • Zhi An Ng's avatar
      Revert "[build] Separate out inspector as a shared library" · 50fb0a2f
      Zhi An Ng authored
      This reverts commit 92bfb63c.
      
      Reason for revert: Broke build https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20shared/43249/overview
      
      Original change's description:
      > [build] Separate out inspector as a shared library
      >
      > This makes src/inspector:inspector into a v8_component producing a
      > shared library in component builds. To enable this, all of its exported
      > are now marked with V8_INSPECTOR_EXPORT.
      >
      > This also inverts the dependency between src/inspector:inspector and
      > :v8_base_without_compiler, and instead makes d8 and some tests depend on
      > inspector rather than getting it via v8.
      >
      > As a result, the no_check_targets exclusions list in .gn is reduced.
      >
      > Ultimately embedders like chromium should depend on :v8 and optionally
      > src/inspector:inspector, but to allow that transition to occur, this
      > renames :v8 to :v8_lib and introduces a new :v8 which depends on v8 and
      > inspector. Once all embedders have changed to reflect the new structure,
      > this part can be reverted.
      >
      > Bug: v8:11917
      > Change-Id: Ia8b15f07fb15acc5e1f111b1a80248def4285fd0
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999088
      > Reviewed-by: Clemens Backes <clemensb@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Commit-Queue: Dan Elphick <delphick@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#75532}
      
      Bug: v8:11917
      Change-Id: I0ed27ed95211d13b8b3438a8c0a42d577806c475
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3003452
      Auto-Submit: Zhi An Ng <zhin@chromium.org>
      Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#75533}
      50fb0a2f
    • Dan Elphick's avatar
      [build] Separate out inspector as a shared library · 92bfb63c
      Dan Elphick authored
      This makes src/inspector:inspector into a v8_component producing a
      shared library in component builds. To enable this, all of its exported
      are now marked with V8_INSPECTOR_EXPORT.
      
      This also inverts the dependency between src/inspector:inspector and
      :v8_base_without_compiler, and instead makes d8 and some tests depend on
      inspector rather than getting it via v8.
      
      As a result, the no_check_targets exclusions list in .gn is reduced.
      
      Ultimately embedders like chromium should depend on :v8 and optionally
      src/inspector:inspector, but to allow that transition to occur, this
      renames :v8 to :v8_lib and introduces a new :v8 which depends on v8 and
      inspector. Once all embedders have changed to reflect the new structure,
      this part can be reverted.
      
      Bug: v8:11917
      Change-Id: Ia8b15f07fb15acc5e1f111b1a80248def4285fd0
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999088Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#75532}
      92bfb63c
  15. 02 Jun, 2021 1 commit
  16. 27 May, 2021 1 commit
  17. 06 May, 2021 1 commit
    • Benedikt Meurer's avatar
      [inspector] Consistently pass around script ID as integer. · 51fe5571
      Benedikt Meurer authored
      Within the inspector we should be consistent about passing the script ID
      always as integer, and only convert to String16 when actually needed.
      That (a) saves memory (and some runtime overhead) when stashing away
      call frames, for example in case of async stack traces, and (b) reduces
      confusion which representation to chose.
      
      Bug: chromium:1162229
      Change-Id: I9591931da0a307779372f36aba6e155ec22bbe3d
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2876856
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74410}
      51fe5571
  18. 04 May, 2021 1 commit
  19. 30 Apr, 2021 1 commit
  20. 21 Apr, 2021 1 commit
  21. 22 Dec, 2020 1 commit
  22. 15 Dec, 2020 1 commit
  23. 29 Oct, 2020 1 commit
  24. 27 Apr, 2020 1 commit
  25. 25 Mar, 2020 1 commit
  26. 03 Feb, 2020 1 commit
    • Sigurd Schneider's avatar
      [debugger] Allow termination-on-resume when paused at a breakpoint · 9e52d5c5
      Sigurd Schneider authored
      This CL implements functionality to allow an embedder to mark a
      debug scope as terminate-on-resume. This results in a termination
      exception when that debug scope is left and execution is resumed.
      Execution of JavaScript remains possible after a debug scope is
      marked as terminate-on-resume (but before execution of the paused
      code resumes).
      This is used by blink to correctly prevent resuming JavaScript
      execution upon reload while being paused at a breakpoint.
      
      This is important for handling reloads while paused at a breakpoint
      in blink. The resume command terminates blink's nested message loop
      that is used while to keep the frame responsive while the debugger
      is paused. But if a reload is triggered while execution is paused
      on a breakpoint, but before execution is actually resumed from the
       breakpoint (that means before returning into the V8 JavaScript
      frames that are paused on the stack below the C++ frames that belong
      to the nested message loop), we re-enter V8 to do tear-down actions
      of the old frame. In this case Runtime.terminateExecution() cannot be
      used before Debugger.resume(), because the tear-down actions that
      re-enter V8 would trigger the termination exception and crash the
      browser (because the browser expected the tear-down to succeed).
      
      Hence we introduce this flag on V8 that says: It is OK if someone
      re-enters V8 (to execute JS), but upon resuming from the breakpoint
      (i.e. returning to the paused frames that are on the stack below),
      generate a termination exception.
      
      We deliberated adding a corresponding logic on the blink side (instead
      of V8) but we think this is the simplest solution.
      
      More details in the design doc:
      
      https://docs.google.com/document/d/1aO9v0YhoKNqKleqfACGUpwrBUayLFGqktz9ltdgKHMk
      
      Bug: chromium:1004038, chromium:1014415
      
      Change-Id: I896692d4c21cb0acae89c1d783d37ce45b73c113
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1924366
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#66084}
      9e52d5c5
  27. 20 Jan, 2020 1 commit
    • Sigurd Schneider's avatar
      [coverage] Add event for coverage reporting · ee8602d3
      Sigurd Schneider authored
      This CL adds a new event that enables the back-end to send coverage
      updates on its own initiative. This event can be triggered via the C++
      method `triggerPreciseCoverageDeltaUpdate` on the agent in a way that
      causes coverage data to be immediatelly collected.
      
      This is useful in the back-end to collect coverage at a certain point
      in time, i.e. when a lifecycle event such as first contentful paint
      occurs.
      
      The previous interface could not support this, because it could not
      reasonably be triggered from C++, and if triggered through the protocol,
      dispatching messages added delay that invalidated the data (i.e. data
      might have been taken too late to be accurate).
      
      TBR=yangguo@chromium.org
      
      Change-Id: I0f7201412a8d64866e6e314e5bc850354c13a9da
      Bug: chromium:1022031
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1992437
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65864}
      ee8602d3
  28. 05 Nov, 2019 1 commit
  29. 20 Sep, 2019 1 commit
  30. 16 Sep, 2019 1 commit
  31. 12 Sep, 2019 1 commit
  32. 26 Jun, 2019 1 commit
  33. 11 Jun, 2019 1 commit
  34. 15 May, 2019 1 commit
  35. 13 May, 2019 1 commit
  36. 03 May, 2019 1 commit
    • Johannes Henkel's avatar
      [DevTools] Add V8InspectorSession::state(), which returns binary (CBOR). · 9d7c1947
      Johannes Henkel authored
      Keep the existing method for compatibility, by converting
      to json from CBOR using the inspector_protocol_encoding library,
      via a v8 specific interface library that directs routines for
      converting between strings and doubles to v8's implementations.
      
      This change also brings in the encoding.h / encoding.cc files from the
      upstream inspector_protocol project. The only modification here
      are the header guards, and the namespace. I will fix roll.py to
      make it so that we pick up future changes.
      
      third_party/inspector_protocol/BUILD.gn is specific to v8, by necessity.
      third_party/inspector_protocol/.clang-format is a copy of the upstream
      file. If we don't put this, we'll find ourselves auto-formatting the roll,
      which is annoying.
      
      This is a reland of
      https://chromium-review.googlesource.com/c/v8/v8/+/1590627 with the
      only modification in the DEPS file; this time I'm including
      third_party/inspector_protocol/encoding/encoding{.h,cc} in addition to
      the relative include there. Not sure why this is needed but I'm hoping
      it gets me past the presubmit which may resolve the include path
      relative to the V8 base (the ../../third_party is needed for when V8 is
      embedded into Chromium).
      
      Change-Id: Ic76b2b5faa7e1cbdceb15aff3f369e9a303e3e85
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593646Reviewed-by: 's avatarAlexei Filippov <alph@chromium.org>
      Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Commit-Queue: Johannes Henkel <johannes@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61214}
      9d7c1947
  37. 02 May, 2019 1 commit
    • Johannes Henkel's avatar
      Revert "[DevTools] Add V8InspectorSession::state(), which returns binary (CBOR)." · c27c369a
      Johannes Henkel authored
      This reverts commit b7134d3a.
      
      Reason for revert: breaks presubmit
      
      Original change's description:
      > [DevTools] Add V8InspectorSession::state(), which returns binary (CBOR).
      > 
      > Keep the existing method for compatibility, by converting
      > to json from CBOR using the inspector_protocol_encoding library,
      > via a v8 specific interface library that directs routines for
      > converting between strings and doubles to v8's implementations.
      > 
      > This change also brings in the encoding.h / encoding.cc files from the
      > upstream inspector_protocol project. The only modification here
      > are the header guards, and the namespace. I will fix roll.py to
      > make it so that we pick up future changes.
      > 
      > third_party/inspector_protocol/BUILD.gn is specific to v8, by necessity.
      > third_party/inspector_protocol/.clang-format is a copy of the upstream
      > file. If we don't put this, we'll find ourselves auto-formatting the roll,
      > which is annoying.
      > 
      > Change-Id: I20fa8759164e7a39f8a7c30e0d2a3f8a7e4be227
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1590627
      > Reviewed-by: Alexei Filippov <alph@chromium.org>
      > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
      > Commit-Queue: Johannes Henkel <johannes@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#61187}
      
      TBR=dgozman@chromium.org,alph@chromium.org,caseq@chromium.org,johannes@chromium.org
      
      Change-Id: I67f297ef8454499036c94bf88e0d23657a579140
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1592130Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Commit-Queue: Johannes Henkel <johannes@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61189}
      c27c369a