Revert "[DevTools] Add V8InspectorSession::state(), which returns binary (CBOR)."

This reverts commit b7134d3a.

Reason for revert: breaks presubmit

Original change's description:
> [DevTools] Add V8InspectorSession::state(), which returns binary (CBOR).
> 
> Keep the existing method for compatibility, by converting
> to json from CBOR using the inspector_protocol_encoding library,
> via a v8 specific interface library that directs routines for
> converting between strings and doubles to v8's implementations.
> 
> This change also brings in the encoding.h / encoding.cc files from the
> upstream inspector_protocol project. The only modification here
> are the header guards, and the namespace. I will fix roll.py to
> make it so that we pick up future changes.
> 
> third_party/inspector_protocol/BUILD.gn is specific to v8, by necessity.
> third_party/inspector_protocol/.clang-format is a copy of the upstream
> file. If we don't put this, we'll find ourselves auto-formatting the roll,
> which is annoying.
> 
> Change-Id: I20fa8759164e7a39f8a7c30e0d2a3f8a7e4be227
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1590627
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Johannes Henkel <johannes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#61187}

TBR=dgozman@chromium.org,alph@chromium.org,caseq@chromium.org,johannes@chromium.org

Change-Id: I67f297ef8454499036c94bf88e0d23657a579140
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1592130Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61189}

include/v8-inspector.h

@@ -132,7 +132,6 @@ class V8_EXPORT V8InspectorSession {
   static bool canDispatchMethod(const StringView& method);
   virtual void dispatchProtocolMessage(const StringView& message) = 0;
   virtual std::unique_ptr<StringBuffer> stateJSON() = 0;
-  virtual std::vector<uint8_t> state() = 0;
   virtual std::vector<std::unique_ptr<protocol::Schema::API::Domain>>
   supportedDomains() = 0;
 

src/inspector/BUILD.gn

@@ -83,7 +83,6 @@ v8_header_set("inspector_test_headers") {
 v8_source_set("inspector") {
   deps = [
     "../..:v8_version",
-    "../../third_party/inspector_protocol:encoding",
   ]
 
   public_deps = [
@@ -131,8 +130,6 @@ v8_source_set("inspector") {
     "v8-heap-profiler-agent-impl.h",
     "v8-inspector-impl.cc",
     "v8-inspector-impl.h",
-    "v8-inspector-protocol-encoding.cc",
-    "v8-inspector-protocol-encoding.h",
     "v8-inspector-session-impl.cc",
     "v8-inspector-session-impl.h",
     "v8-profiler-agent-impl.cc",

src/inspector/DEPS

@@ -13,9 +13,6 @@ include_rules = [
   "+src/v8memory.h",
   "+src/inspector",
   "+src/tracing",
-  "+src/vector.h",
   "+src/debug/debug-interface.h",
   "+src/debug/interface-types.h",
-  "+../../third_party/inspector_protocol/encoding/encoding.h",
-  "+../../third_party/inspector_protocol/encoding/encoding.cc",
 ]

src/inspector/v8-inspector-protocol-encoding.cc

-// Copyright 2019 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "src/inspector/v8-inspector-protocol-encoding.h"
-
-#include <cmath>
-#include "../../third_party/inspector_protocol/encoding/encoding.h"
-#include "src/conversions.h"
-#include "src/vector.h"
-
-namespace v8_inspector {
-namespace {
-using IPEStatus = ::v8_inspector_protocol_encoding::Status;
-using ::v8_inspector_protocol_encoding::span;
-
-class Platform : public ::v8_inspector_protocol_encoding::json::Platform {
- public:
-  bool StrToD(const char* str, double* result) const override {
-    *result = v8::internal::StringToDouble(str, v8::internal::NO_FLAGS);
-    return !std::isnan(*result);
-  }
-  std::unique_ptr<char[]> DToStr(double value) const override {
-    v8::internal::ScopedVector<char> buffer(
-        v8::internal::kDoubleToCStringMinBufferSize);
-    const char* str = v8::internal::DoubleToCString(value, buffer);
-    if (str == nullptr) return nullptr;
-    std::unique_ptr<char[]> result(new char[strlen(str) + 1]);
-    memcpy(result.get(), str, strlen(str) + 1);
-    DCHECK_EQ(0, result[strlen(str)]);
-    return result;
-  }
-};
-}  // namespace
-
-IPEStatus ConvertCBORToJSON(span<uint8_t> cbor, std::vector<uint8_t>* json) {
-  Platform platform;
-  return ConvertCBORToJSON(platform, cbor, json);
-}
-
-IPEStatus ConvertJSONToCBOR(span<uint8_t> json, std::vector<uint8_t>* cbor) {
-  Platform platform;
-  return ConvertJSONToCBOR(platform, json, cbor);
-}
-
-}  // namespace v8_inspector

src/inspector/v8-inspector-protocol-encoding.h

-// Copyright 2019 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef V8_INSPECTOR_V8_INSPECTOR_PROTOCOL_ENCODING_H_
-#define V8_INSPECTOR_V8_INSPECTOR_PROTOCOL_ENCODING_H_
-
-#include "../../third_party/inspector_protocol/encoding/encoding.h"
-
-namespace v8_inspector {
-
-::v8_inspector_protocol_encoding::Status ConvertCBORToJSON(
-    ::v8_inspector_protocol_encoding::span<uint8_t> cbor,
-    std::vector<uint8_t>* json);
-
-::v8_inspector_protocol_encoding::Status ConvertJSONToCBOR(
-    ::v8_inspector_protocol_encoding::span<uint8_t> json,
-    std::vector<uint8_t>* cbor);
-
-}  // namespace v8_inspector
-
-#endif  // V8_INSPECTOR_V8_INSPECTOR_PROTOCOL_ENCODING_H_

src/inspector/v8-inspector-session-impl.cc

@@ -4,8 +4,6 @@
 
 #include "src/inspector/v8-inspector-session-impl.h"
 
-#include "src/base/logging.h"
-#include "src/base/macros.h"
 #include "src/inspector/injected-script.h"
 #include "src/inspector/inspected-context.h"
 #include "src/inspector/protocol/Protocol.h"
@@ -17,16 +15,11 @@
 #include "src/inspector/v8-debugger.h"
 #include "src/inspector/v8-heap-profiler-agent-impl.h"
 #include "src/inspector/v8-inspector-impl.h"
-#include "src/inspector/v8-inspector-protocol-encoding.h"
 #include "src/inspector/v8-profiler-agent-impl.h"
 #include "src/inspector/v8-runtime-agent-impl.h"
 #include "src/inspector/v8-schema-agent-impl.h"
 
 namespace v8_inspector {
-namespace {
-using ::v8_inspector_protocol_encoding::SpanFrom;
-using IPEStatus = ::v8_inspector_protocol_encoding::Status;
-}  // namespace
 
 // static
 bool V8InspectorSession::canDispatchMethod(const StringView& method) {
@@ -362,17 +355,8 @@ void V8InspectorSessionImpl::dispatchProtocolMessage(
 }
 
 std::unique_ptr<StringBuffer> V8InspectorSessionImpl::stateJSON() {
-  std::vector<uint8_t> json;
-  IPEStatus status = ConvertCBORToJSON(SpanFrom(state()), &json);
-  DCHECK(status.ok());
-  USE(status);
-  return v8::base::make_unique<BinaryStringBuffer>(std::move(json));
-}
-
-std::vector<uint8_t> V8InspectorSessionImpl::state() {
-  std::vector<uint8_t> out;
-  m_state->writeBinary(&out);
-  return out;
+  String16 json = m_state->toJSONString();
+  return StringBufferImpl::adopt(json);
 }
 
 std::vector<std::unique_ptr<protocol::Schema::API::Domain>>

src/inspector/v8-inspector-session-impl.h

@@ -65,7 +65,6 @@ class V8InspectorSessionImpl : public V8InspectorSession,
   // V8InspectorSession implementation.
   void dispatchProtocolMessage(const StringView& message) override;
   std::unique_ptr<StringBuffer> stateJSON() override;
-  std::vector<uint8_t> state() override;
   std::vector<std::unique_ptr<protocol::Schema::API::Domain>> supportedDomains()
       override;
   void addInspectedObject(

third_party/inspector_protocol/.clang-format

-# Defines the Chromium style for automatic reformatting.
-# http://clang.llvm.org/docs/ClangFormatStyleOptions.html
-BasedOnStyle: Chromium
-# This defaults to 'Auto'. Explicitly set it for a while, so that
-# 'vector<vector<int> >' in existing files gets formatted to
-# 'vector<vector<int>>'. ('Auto' means that clang-format will only use
-# 'int>>' if the file already contains at least one such instance.)
-Standard: Cpp11
-
-# Make sure code like:
-# IPC_BEGIN_MESSAGE_MAP()
-#   IPC_MESSAGE_HANDLER(WidgetHostViewHost_Update, OnUpdate)
-# IPC_END_MESSAGE_MAP()
-# gets correctly indented.
-MacroBlockBegin: "^\
-BEGIN_MSG_MAP|\
-BEGIN_MSG_MAP_EX|\
-BEGIN_SAFE_MSG_MAP_EX|\
-CR_BEGIN_MSG_MAP_EX|\
-IPC_BEGIN_MESSAGE_MAP|\
-IPC_BEGIN_MESSAGE_MAP_WITH_PARAM|\
-IPC_PROTOBUF_MESSAGE_TRAITS_BEGIN|\
-IPC_STRUCT_BEGIN|\
-IPC_STRUCT_BEGIN_WITH_PARENT|\
-IPC_STRUCT_TRAITS_BEGIN|\
-POLPARAMS_BEGIN|\
-PPAPI_BEGIN_MESSAGE_MAP$"
-MacroBlockEnd: "^\
-CR_END_MSG_MAP|\
-END_MSG_MAP|\
-IPC_END_MESSAGE_MAP|\
-IPC_PROTOBUF_MESSAGE_TRAITS_END|\
-IPC_STRUCT_END|\
-IPC_STRUCT_TRAITS_END|\
-POLPARAMS_END|\
-PPAPI_END_MESSAGE_MAP$"

third_party/inspector_protocol/BUILD.gn

-# Copyright 2019 the V8 project authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-static_library("encoding") {
-  sources = [
-    "encoding/encoding.cc",
-    "encoding/encoding.h",
-  ]
-}