Commit 87132919 authored by Daniel Abraham's avatar Daniel Abraham Committed by V8 LUCI CQ

Fix various typos in PDL comments + 1 event param.

Based on an analysis of auto-generated code, based on
browser_protocol.pdl and js_protocol.pdl:

https://goreportcard.com/report/github.com/daabr/chrome-vision#misspell

Bug: chromium:1213460
Change-Id: Ib96b2d2700d0bf1ac90e88accd0bc15eccbb9d7b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848874Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
Reviewed-by: 's avatarKim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74810}
parent 6da3dc6e
...@@ -175,7 +175,7 @@ domain Debugger ...@@ -175,7 +175,7 @@ domain Debugger
command enable command enable
parameters parameters
# The maximum size in bytes of collected scripts (not referenced by other heap objects) # The maximum size in bytes of collected scripts (not referenced by other heap objects)
# the debugger can hold. Puts no limit if paramter is omitted. # the debugger can hold. Puts no limit if parameter is omitted.
experimental optional number maxScriptsCacheSize experimental optional number maxScriptsCacheSize
returns returns
# Unique identifier of the debugger. # Unique identifier of the debugger.
...@@ -714,7 +714,7 @@ experimental domain HeapProfiler ...@@ -714,7 +714,7 @@ experimental domain HeapProfiler
parameters parameters
# If true 'reportHeapSnapshotProgress' events will be generated while snapshot is being taken. # If true 'reportHeapSnapshotProgress' events will be generated while snapshot is being taken.
optional boolean reportProgress optional boolean reportProgress
# If true, a raw snapshot without artifical roots will be generated # If true, a raw snapshot without artificial roots will be generated
optional boolean treatGlobalObjectsAsRoots optional boolean treatGlobalObjectsAsRoots
# If true, numerical values are included in the snapshot # If true, numerical values are included in the snapshot
optional boolean captureNumericValue optional boolean captureNumericValue
...@@ -972,13 +972,13 @@ domain Profiler ...@@ -972,13 +972,13 @@ domain Profiler
# Reports coverage delta since the last poll (either from an event like this, or from # Reports coverage delta since the last poll (either from an event like this, or from
# `takePreciseCoverage` for the current isolate. May only be sent if precise code # `takePreciseCoverage` for the current isolate. May only be sent if precise code
# coverage has been started. This event can be trigged by the embedder to, for example, # coverage has been started. This event can be trigged by the embedder to, for example,
# trigger collection of coverage data immediatelly at a certain point in time. # trigger collection of coverage data immediately at a certain point in time.
experimental event preciseCoverageDeltaUpdate experimental event preciseCoverageDeltaUpdate
parameters parameters
# Monotonically increasing time (in seconds) when the coverage update was taken in the backend. # Monotonically increasing time (in seconds) when the coverage update was taken in the backend.
number timestamp number timestamp
# Identifier for distinguishing coverage events. # Identifier for distinguishing coverage events.
string occassion string occasion
# Coverage data for the current isolate. # Coverage data for the current isolate.
array of ScriptCoverage result array of ScriptCoverage result
...@@ -1225,7 +1225,7 @@ domain Runtime ...@@ -1225,7 +1225,7 @@ domain Runtime
string origin string origin
# Human readable name describing given context. # Human readable name describing given context.
string name string name
# A system-unique execution context identifier. Unlike the id, this is unique accross # A system-unique execution context identifier. Unlike the id, this is unique across
# multiple processes, so can be reliably used to identify specific context while backend # multiple processes, so can be reliably used to identify specific context while backend
# performs a cross-process navigation. # performs a cross-process navigation.
experimental string uniqueId experimental string uniqueId
...@@ -1422,9 +1422,9 @@ domain Runtime ...@@ -1422,9 +1422,9 @@ domain Runtime
# evaluation and allows unsafe-eval. Defaults to true. # evaluation and allows unsafe-eval. Defaults to true.
experimental optional boolean allowUnsafeEvalBlockedByCSP experimental optional boolean allowUnsafeEvalBlockedByCSP
# An alternative way to specify the execution context to evaluate in. # An alternative way to specify the execution context to evaluate in.
# Compared to contextId that may be reused accross processes, this is guaranteed to be # Compared to contextId that may be reused across processes, this is guaranteed to be
# system-unique, so it can be used to prevent accidental evaluation of the expression # system-unique, so it can be used to prevent accidental evaluation of the expression
# in context different than intended (e.g. as a result of navigation accross process # in context different than intended (e.g. as a result of navigation across process
# boundaries). # boundaries).
# This is mutually exclusive with `contextId`. # This is mutually exclusive with `contextId`.
experimental optional string uniqueContextId experimental optional string uniqueContextId
......
...@@ -170,7 +170,7 @@ class V8_EXPORT V8InspectorSession { ...@@ -170,7 +170,7 @@ class V8_EXPORT V8InspectorSession {
v8::Local<v8::Context>*, v8::Local<v8::Context>*,
std::unique_ptr<StringBuffer>* objectGroup) = 0; std::unique_ptr<StringBuffer>* objectGroup) = 0;
virtual void releaseObjectGroup(StringView) = 0; virtual void releaseObjectGroup(StringView) = 0;
virtual void triggerPreciseCoverageDeltaUpdate(StringView occassion) = 0; virtual void triggerPreciseCoverageDeltaUpdate(StringView occasion) = 0;
}; };
class V8_EXPORT V8InspectorClient { class V8_EXPORT V8InspectorClient {
......
...@@ -496,8 +496,8 @@ V8InspectorSessionImpl::searchInTextByLines(StringView text, StringView query, ...@@ -496,8 +496,8 @@ V8InspectorSessionImpl::searchInTextByLines(StringView text, StringView query,
} }
void V8InspectorSessionImpl::triggerPreciseCoverageDeltaUpdate( void V8InspectorSessionImpl::triggerPreciseCoverageDeltaUpdate(
StringView occassion) { StringView occasion) {
m_profilerAgent->triggerPreciseCoverageDeltaUpdate(toString16(occassion)); m_profilerAgent->triggerPreciseCoverageDeltaUpdate(toString16(occasion));
} }
} // namespace v8_inspector } // namespace v8_inspector
...@@ -98,7 +98,7 @@ class V8InspectorSessionImpl : public V8InspectorSession, ...@@ -98,7 +98,7 @@ class V8InspectorSessionImpl : public V8InspectorSession,
V8InspectorSession::Inspectable* inspectedObject(unsigned num); V8InspectorSession::Inspectable* inspectedObject(unsigned num);
static const unsigned kInspectedObjectBufferSize = 5; static const unsigned kInspectedObjectBufferSize = 5;
void triggerPreciseCoverageDeltaUpdate(StringView occassion) override; void triggerPreciseCoverageDeltaUpdate(StringView occasion) override;
private: private:
V8InspectorSessionImpl(V8InspectorImpl*, int contextGroupId, int sessionId, V8InspectorSessionImpl(V8InspectorImpl*, int contextGroupId, int sessionId,
......
...@@ -449,7 +449,7 @@ Response V8ProfilerAgentImpl::takePreciseCoverage( ...@@ -449,7 +449,7 @@ Response V8ProfilerAgentImpl::takePreciseCoverage(
} }
void V8ProfilerAgentImpl::triggerPreciseCoverageDeltaUpdate( void V8ProfilerAgentImpl::triggerPreciseCoverageDeltaUpdate(
const String16& occassion) { const String16& occasion) {
if (!m_state->booleanProperty(ProfilerAgentState::preciseCoverageStarted, if (!m_state->booleanProperty(ProfilerAgentState::preciseCoverageStarted,
false)) { false)) {
return; return;
...@@ -465,7 +465,7 @@ void V8ProfilerAgentImpl::triggerPreciseCoverageDeltaUpdate( ...@@ -465,7 +465,7 @@ void V8ProfilerAgentImpl::triggerPreciseCoverageDeltaUpdate(
coverageToProtocol(m_session->inspector(), coverage, &out_result); coverageToProtocol(m_session->inspector(), coverage, &out_result);
double now = double now =
v8::base::TimeTicks::HighResolutionNow().since_origin().InSecondsF(); v8::base::TimeTicks::HighResolutionNow().since_origin().InSecondsF();
m_frontend.preciseCoverageDeltaUpdate(now, occassion, std::move(out_result)); m_frontend.preciseCoverageDeltaUpdate(now, occasion, std::move(out_result));
} }
Response V8ProfilerAgentImpl::getBestEffortCoverage( Response V8ProfilerAgentImpl::getBestEffortCoverage(
......
...@@ -75,7 +75,7 @@ class V8ProfilerAgentImpl : public protocol::Profiler::Backend { ...@@ -75,7 +75,7 @@ class V8ProfilerAgentImpl : public protocol::Profiler::Backend {
void consoleProfile(const String16& title); void consoleProfile(const String16& title);
void consoleProfileEnd(const String16& title); void consoleProfileEnd(const String16& title);
void triggerPreciseCoverageDeltaUpdate(const String16& occassion); void triggerPreciseCoverageDeltaUpdate(const String16& occasion);
private: private:
String16 nextProfileId(); String16 nextProfileId();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment