- 04 Jan, 2019 2 commits
-
-
Sigurd Schneider authored
Clang is known to use a lot of stack space for Debug builds, so this patch lowers the recursion depth of that test. Failing bot: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20full%20debug First failing run: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20full%20debug/6606 Change-Id: Ib1da016b190fa0d9d7d38bced19f600a284c7f01 Reviewed-on: https://chromium-review.googlesource.com/c/1396079 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#58555}
-
Mathias Bynens authored
The reference implementation used in the tests does not fully match the spec, so for the diverging cases we need to explicitly specify the correct expectation. Every single change in this patch has been verified against every major JavaScript engine using eshost + jsvu. All implementations match the spec (and the V8 implementation), with the following two exceptions: - One expectation was wrong because of a JavaScriptCore bug (that is, we inherited the incorrect expectation when importing the tests from WebKit). A comment was added for that one. - This work resulted in the discovery of bugs in Moddable/XS: https://github.com/Moddable-OpenSource/moddable/issues/112 Change-Id: I05d91d7acc5c8765e941fcd68c1086c2694c710c Reviewed-on: https://chromium-review.googlesource.com/c/1396081Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#58546}
-
- 21 Dec, 2018 1 commit
-
-
Jakob Gruber authored
This is a reland of 0e22ec73 Original change's description: > [regexp] Escape newlines when setting [[OriginalSource]] > > This escapes LineTerminator characters in a regexp pattern when > creating the string that will be stored in the [[OriginalSource]] slot. > > As an example, the source property for all following objects will equal > "\n" (a '\' character followed by 'n'): > > /\n/ > new RegExp("\n") > new RegExp("\\n") > > Bug: v8:1982, chromium:855009 > Change-Id: I3b539497a0697e3d51ec969cae49308b0b312a19 > Reviewed-on: https://chromium-review.googlesource.com/c/1384316 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58387} Bug: v8:1982, chromium:855009 Change-Id: I1ba22395477ec37e8e8c944000f9beade1e3250b Reviewed-on: https://chromium-review.googlesource.com/c/1386495Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58419}
-
- 20 Dec, 2018 2 commits
-
-
Michael Achenbach authored
This reverts commit 0e22ec73. Reason for revert: Breaks layout tests: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/28814 Original change's description: > [regexp] Escape newlines when setting [[OriginalSource]] > > This escapes LineTerminator characters in a regexp pattern when > creating the string that will be stored in the [[OriginalSource]] slot. > > As an example, the source property for all following objects will equal > "\n" (a '\' character followed by 'n'): > > /\n/ > new RegExp("\n") > new RegExp("\\n") > > Bug: v8:1982, chromium:855009 > Change-Id: I3b539497a0697e3d51ec969cae49308b0b312a19 > Reviewed-on: https://chromium-review.googlesource.com/c/1384316 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58387} TBR=yangguo@chromium.org,jgruber@chromium.org,mathias@chromium.org Change-Id: I1db7e6a0c6cd1cd995fe9f499458108e88dc8cb9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:1982, chromium:855009 Reviewed-on: https://chromium-review.googlesource.com/c/1386493Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58396}
-
Jakob Gruber authored
This escapes LineTerminator characters in a regexp pattern when creating the string that will be stored in the [[OriginalSource]] slot. As an example, the source property for all following objects will equal "\n" (a '\' character followed by 'n'): /\n/ new RegExp("\n") new RegExp("\\n") Bug: v8:1982, chromium:855009 Change-Id: I3b539497a0697e3d51ec969cae49308b0b312a19 Reviewed-on: https://chromium-review.googlesource.com/c/1384316 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#58387}
-
- 18 Dec, 2018 1 commit
-
-
Maxim Mazurok authored
- Changed "Formating" to "Formatting" in comment - Added Maxim Mazurok <maxim@mazurok.com> to AUTHORS file as required by https://www.chromium.org/developers/contributing-code#TOC-Legal-stuff Change-Id: I48633694975879013c983580fa9b8c71dcb2e8f4 Reviewed-on: https://chromium-review.googlesource.com/c/1379231 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#58303}
-
- 14 Dec, 2018 1 commit
-
-
Tamer Tas authored
R=machenbach@chromium.org CC=yangguo@chromium.org Bug: v8:8491 Change-Id: I8379825c194e588da582a3000201eea75b59140a Reviewed-on: https://chromium-review.googlesource.com/c/1371826 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58243}
-
- 30 Nov, 2018 1 commit
-
-
Peter Marshall authored
This reverts commit 4e3a17d0. Reason for revert: Web compact issues, see crbug.com/910252 Original change's description: > [runtime] Reduce spread/apply call max arguments > > Bug: chromium:906043 > Change-Id: I308b29af0644c318d73926b27e65a94913c760c7 > Reviewed-on: https://chromium-review.googlesource.com/c/1346115 > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57731} TBR=jarin@chromium.org,jgruber@chromium.org,petermarshall@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:906043 Change-Id: I240c1b55c10fd3e108e3c49f93ce1d9ca9c61780 Reviewed-on: https://chromium-review.googlesource.com/c/1356502Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#57956}
-
- 22 Nov, 2018 2 commits
-
-
Peter Marshall authored
Bug: chromium:906043 Change-Id: I308b29af0644c318d73926b27e65a94913c760c7 Reviewed-on: https://chromium-review.googlesource.com/c/1346115 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57731}
-
Michael Achenbach authored
Many tests were already skipped in debug mode, but they kept running on CQ which sets dcheck_always_on, probably equally slow. Some other tests are marked as slow based on a recent run of the arm64 sim trybot. NOTRY=true Bug: v8:7783 Change-Id: Ic022518edfa112ea6d228ae9a68653c99651dbb4 Reviewed-on: https://chromium-review.googlesource.com/c/1347479Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57724}
-
- 14 Nov, 2018 1 commit
-
-
Jakob Kummerow authored
Clang is known to use a lot of stack space for Debug builds, so this patch lowers the recursion depth of that test after recent changes made Debug-mode stack frames a bit larger. a bit of Debug-mode stack space. Bonus: drops an unnecessary cast from SerializeJSObject to save Change-Id: I22696a1d80a6a73b5049b018e72cc8a3d8693042 Reviewed-on: https://chromium-review.googlesource.com/c/1334448Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57516}
-
- 07 Nov, 2018 1 commit
-
-
Adam Klein authored
This test takes over 8 minutes to run on arm64 debug. Also removed redundant skips for another DFG test. Change-Id: I9c66c90fb3dc5c42ca04010e2d0245626a867ebd Reviewed-on: https://chromium-review.googlesource.com/c/1321037Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57303}
-
- 06 Nov, 2018 1 commit
-
-
Adam Klein authored
'simulator_run' is now used exclusively in test/*/*.status. Change-Id: I501b7ffd19e2476f4c803ed3d25cba69d67039fa Reviewed-on: https://chromium-review.googlesource.com/c/1318610Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57300}
-
- 18 Oct, 2018 1 commit
-
-
Sathya Gunasekaran authored
Bug: v8:5367 Change-Id: I92a73692e9714b929316d8971a2258e3241bc8c6 Reviewed-on: https://chromium-review.googlesource.com/c/1288643 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#56790}
-
- 16 Oct, 2018 3 commits
-
-
peterwmwong authored
This also includes ports of Array.p.toString and Array.p.toLocaleString. Many parts of the old JS implementation are preserved, because TypedArray.p.join still relies on it. These will be removed once TypedArray.p.join is ported to Torque. To simplify implementation, special handling of extremely sparse arrays has been removed. Performance improvements vary by array size, elements, and sparse-ness. Some quick numbers and graphs are here: https://docs.google.com/spreadsheets/d/125VLmRMudk8XaomLCsZQ1ewc94WCqht-8GQwU3s9BW8/edit#gid=2087673710 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.v8.try:v8_linux_noi18n_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia4069a068403ce36676c37401d349aefc976b045 Reviewed-on: https://chromium-review.googlesource.com/c/1196693 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#56699}
-
Mathias Bynens authored
This is a reland of 0d91db0b. Proposal repository: https://github.com/tc39/proposal-well-formed-stringify Intent to ship: https://groups.google.com/d/msg/v8-users/IRu3bAC_pLM/pFwz2ti1AgAJ TBR=gsathya@chromium.org Bug: v8:7782 Change-Id: I53d006650e2b4099a111d2e5bc067e4a2c7cf4a0 Reviewed-on: https://chromium-review.googlesource.com/c/1282993Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#56689}
-
Mathias Bynens authored
This reverts commit 0d91db0b. Reason for revert: <INSERT REASONING HERE> Original change's description: > Ship well-formed JSON.stringify
> > Proposal repository: > https://github.com/tc39/proposal-global > > Intent to ship: > https://groups.google.com/d/msg/v8-users/IRu3bAC_pLM/pFwz2ti1AgAJ > > Bug: v8:7782 > Change-Id: Iaf790f134917796deac0e84cc931828934a6e589 > Reviewed-on: https://chromium-review.googlesource.com/c/1260122 > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56650} TBR=gsathya@chromium.org,mathias@chromium.org Change-Id: Ie214a72a01fa81f754fd411808eb0bb748f89dbb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7782 Reviewed-on: https://chromium-review.googlesource.com/c/1282563Reviewed-by:Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#56663}
-
- 15 Oct, 2018 1 commit
-
-
Mathias Bynens authored
Proposal repository: https://github.com/tc39/proposal-global Intent to ship: https://groups.google.com/d/msg/v8-users/IRu3bAC_pLM/pFwz2ti1AgAJ Bug: v8:7782 Change-Id: Iaf790f134917796deac0e84cc931828934a6e589 Reviewed-on: https://chromium-review.googlesource.com/c/1260122 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#56650}
-
- 01 Oct, 2018 1 commit
-
-
Mathias Bynens authored
It was shipped in Chrome 66. Bug: v8:6530, v8:8238 Change-Id: I07e95073ffcf388659b9d0b16a081e0f5a5eedaf Reviewed-on: https://chromium-review.googlesource.com/1253603Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#56323}
-
- 12 Sep, 2018 1 commit
-
-
Michael Achenbach authored
NOTRY=true TBR=sigurds@chromium.org Bug: v8:7783 Change-Id: I3c4c8222b121856a58f371e3563474e17c2075fd Reviewed-on: https://chromium-review.googlesource.com/1221189Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55823}
-
- 05 Sep, 2018 1 commit
-
-
Hai Dang authored
This is a reland of 1c48d52b. It turned out that IterableToList doesn't always behave according to the ES operation with the same name. Specifically, it allows holey arrays to take its fast path, which produces an output array with holes where actually "undefined" elements should appear. This CL changes the version of IterableToList that is used for spreads (IterableToListWithSymbolLookup) such that holey arrays take the slow path. It also includes tests for such situations. Original change's description: > [interpreter] Add bytecode for leading array spreads. > > This CL improves the performance of creating [...a, b] or [...a]. > If the array literal has a leading spread, this CL emits the bytecode > [CreateArrayFromIterable] to create the literal. CreateArrayFromIterable > is implemented by [IterableToListDefault] builtin to create the initial > array for the leading spread. IterableToListDefault has a fast path to > clone efficiently if the spread is an actual array. > > The bytecode generated is now shorter. Bytecode generation is refactored > into to BuildCreateArrayLiteral, which allows VisitCallSuper to benefit > from this optimization also. > For now, turbofan also lowers the bytecode to the builtin. > > The idiomatic use of [...a] to clone the array a now performs better > than a simple for-loop, but still does not match the performance of slice. > > Bug: v8:7980 > > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Ibde659c82d3c7aa1b1777a3d2f6426ac8cc15e35 > Reviewed-on: https://chromium-review.googlesource.com/1181024 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Commit-Queue: Hai Dang <dhai@google.com> > Cr-Commit-Position: refs/heads/master@{#55520} Bug: v8:7980 Change-Id: I0b5603a12d2b588327658bf0a9b214bd0f22e237 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1201882 Commit-Queue: Hai Dang <dhai@google.com> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55639}
-
- 04 Sep, 2018 1 commit
-
-
Mike Stanton authored
Before, splice was implemented with a C++ fast path and a comprehensive JavaScript version. This impl. is entirely in Torque with a fastpath for SMI, DOUBLE and OBJECT arrays, and a comprehensive slow path. The same level of "sparse" array support as given by the array.js implementation is included. This reland addresses several issues: * Removed "sparse" array support from splice. * Addressed ClusterFuzz issue 876443: The test and code that uses the fix is in this CL. The fix in isolation can be seen here: https://chromium-review.googlesource.com/c/v8/v8/+/1199403 * Removed dead code in elements.cc BUG=chromium:876443, v8:8131, v8:1956, v8:7221 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I2d4a66c24ba1edabeca34e27e6ff8ee6136ed5f1 Reviewed-on: https://chromium-review.googlesource.com/1201783 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55610}
-
- 31 Aug, 2018 1 commit
-
-
Georg Neis authored
This reverts commit 1c48d52b. Reason for revert: Clusterfuzz found something. Original change's description: > [interpreter] Add bytecode for leading array spreads. > > This CL improves the performance of creating [...a, b] or [...a]. > If the array literal has a leading spread, this CL emits the bytecode > [CreateArrayFromIterable] to create the literal. CreateArrayFromIterable > is implemented by [IterableToListDefault] builtin to create the initial > array for the leading spread. IterableToListDefault has a fast path to > clone efficiently if the spread is an actual array. > > The bytecode generated is now shorter. Bytecode generation is refactored > into to BuildCreateArrayLiteral, which allows VisitCallSuper to benefit > from this optimization also. > For now, turbofan also lowers the bytecode to the builtin. > > The idiomatic use of [...a] to clone the array a now performs better > than a simple for-loop, but still does not match the performance of slice. > > Bug: v8:7980 > > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Ibde659c82d3c7aa1b1777a3d2f6426ac8cc15e35 > Reviewed-on: https://chromium-review.googlesource.com/1181024 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Commit-Queue: Hai Dang <dhai@google.com> > Cr-Commit-Position: refs/heads/master@{#55520} TBR=rmcilroy@chromium.org,neis@chromium.org,sigurds@chromium.org,gsathya@chromium.org,jgruber@chromium.org,dhai@google.com Change-Id: I1c86ddcc24274da9f5a8dd3d8bf8d869cbb55cb6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7980 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1199303Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55544}
-
- 30 Aug, 2018 1 commit
-
-
Hai Dang authored
This CL improves the performance of creating [...a, b] or [...a]. If the array literal has a leading spread, this CL emits the bytecode [CreateArrayFromIterable] to create the literal. CreateArrayFromIterable is implemented by [IterableToListDefault] builtin to create the initial array for the leading spread. IterableToListDefault has a fast path to clone efficiently if the spread is an actual array. The bytecode generated is now shorter. Bytecode generation is refactored into to BuildCreateArrayLiteral, which allows VisitCallSuper to benefit from this optimization also. For now, turbofan also lowers the bytecode to the builtin. The idiomatic use of [...a] to clone the array a now performs better than a simple for-loop, but still does not match the performance of slice. Bug: v8:7980 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ibde659c82d3c7aa1b1777a3d2f6426ac8cc15e35 Reviewed-on: https://chromium-review.googlesource.com/1181024Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Hai Dang <dhai@google.com> Cr-Commit-Position: refs/heads/master@{#55520}
-
- 29 Aug, 2018 1 commit
-
-
Michael Achenbach authored
This shares logic for finding additional resources in JS source code. Previously the logic was implemented for mjsunit, now it will be used across all d8-based test cases. This'll enable adding those test suites for Android testing. Bug: chromium:866862 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I7c89ba141483aaf692a03c0e168edb61bbb7b010 Reviewed-on: https://chromium-review.googlesource.com/1193873 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55503}
-
- 10 Aug, 2018 1 commit
-
-
Michael Achenbach authored
Also skip slowest test on the slowest extra variant. TBR=sigurds@chromium.org Bug: v8:7783 Change-Id: I565fa8edd9c3f20fe15af84e1b9023450ef4593e Reviewed-on: https://chromium-review.googlesource.com/1170832 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55053}
-
- 23 May, 2018 1 commit
-
-
Michael Achenbach authored
Also mark another slow tests as SLOW. TBR=jgruber@chromium.org Bug: v8:7783 Change-Id: I69a8ac82e7898fa3b374c5b66a441f040d241413 Reviewed-on: https://chromium-review.googlesource.com/1069093Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53306}
-
- 08 May, 2018 1 commit
-
-
Eric Holk authored
D8 enables the Wasm trap handler by default now, but we need to make sure the older bounds check case still gets test coverage too, as bounds checks will continue to be a supported configuration. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I5b0bdded6929a9b3a8480e87d038398b8d2a0fd8 Reviewed-on: https://chromium-review.googlesource.com/1048835Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#53078}
-
- 24 Apr, 2018 1 commit
-
-
Benedikt Meurer authored
Bug: chromium:830565 Change-Id: I1adab76e790a81f51f7b03165962992f5afecc99 Reviewed-on: https://chromium-review.googlesource.com/1023400 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52748}
-
- 28 Mar, 2018 3 commits
-
-
Michael Achenbach authored
This is a reland of 712b66da Breakage is fixed on infra side by: https://crrev.com/c/983417 Original change's description: > [build] Remove legacy isolate configurations > > Bug: chromium:669910 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Iad58563fd4bb35501493f88af83362b1206a186c > Reviewed-on: https://chromium-review.googlesource.com/982630 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52267} Bug: chromium:669910 Change-Id: I6c06a1fe9587206aa4e983befb105327bfec4154 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/983573Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52273}
-
Michael Achenbach authored
This reverts commit 712b66da. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20builder/builds/32049 Original change's description: > [build] Remove legacy isolate configurations > > Bug: chromium:669910 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Iad58563fd4bb35501493f88af83362b1206a186c > Reviewed-on: https://chromium-review.googlesource.com/982630 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52267} TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org,jgruber@chromium.org Change-Id: I1955325b0b419b38d793ab205131de8de08cb50a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:669910 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/983418Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52268}
-
Michael Achenbach authored
Bug: chromium:669910 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Iad58563fd4bb35501493f88af83362b1206a186c Reviewed-on: https://chromium-review.googlesource.com/982630Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52267}
-
- 26 Mar, 2018 1 commit
-
-
Michael Achenbach authored
Bug: chromium:669910 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ifb8719a989a4fda48241967271ebe39037643e39 Reviewed-on: https://chromium-review.googlesource.com/980032 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#52223}
-
- 07 Mar, 2018 1 commit
-
-
Ilija Pavlovic authored
If test webkit/dfg-int-overflow-in-loop is executed with option --noopt, execution will be too slow on simulator. Therefore, this test will be skipped on MIPS64 simulators. TEST=webkit/dfg-int-overflow-in-loop BUG= Change-Id: I3d116fe579a5690c817a9a9d4e8a4bf8188298cc Reviewed-on: https://chromium-review.googlesource.com/951610 Commit-Queue: Ilija Pavlović <ilija.pavlovic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51785}
-
- 08 Feb, 2018 1 commit
-
-
Adam Klein authored
This reverts commit 14108f4c. Reason for revert: Not the culprit for Canary microtask crashes Original change's description: > [builtins] Mega-revert to address the Dev blocker in crbug.com/808911. > > - Revert "[builtins] Save one word in contexts for Promise.all." > This reverts commit 7632da06. > - Revert "[builtins] Also use the Promise#then protector for Promise#finally()." > This reverts commit d4f072ce. > - Revert "[builtins] Don't mess with entered context for MicrotaskCallbacks." > This reverts commit 6703dacd. > - Revert "[debugger] Properly deal with settled promises in catch prediction." > This reverts commit 40dd0658. > - Revert "[builtins] Widen the fast-path for Promise builtins." > This reverts commit db0556b7. > - Revert "[builtins] Unify PerformPromiseThen and optimize it with TurboFan." > This reverts commit a582199c. > - Revert "[builtins] Remove obsolete PromiseBuiltinsAssembler::AppendPromiseCallback." > This reverts commit 6bf88852. > - Revert "[builtins] Turn NewPromiseCapability into a proper builtin." > This reverts commit 313b490d. > - Revert "[builtins] Inline InternalPromiseThen into it's only caller" > This reverts commit f7bd6a2f. > - Revert "[builtins] Implement Promise#catch by really calling into Promise#then." > This reverts commit b23b098f. > - Revert "[promise] Remove incorrect fast path" > This reverts commit 0f6eafe8. > - Revert "[builtins] Squeeze JSPromise::result and JSPromise::reactions into a single field." > This reverts commit 8a677a28. > - Revert "[builtins] Refactor promises to reduce GC overhead." > This reverts commit 8e7737cb. > > Tbr: hpayer@chromium.org > Bug: chromium:800651, chromium:808911, v8:5691, v8:7253 > Change-Id: I8c8ea5ed32ed62f6cd8b0d027a3707ddd891e5f1 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/906991 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Commit-Queue: Adam Klein <adamk@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51158} Change-Id: I09d958cbebd635a325809072a290f2f53df8c5d4 Tbr: adamk@chromium.org,yangguo@chromium.org,bmeurer@chromium.org Bug: chromium:800651, chromium:808911, v8:5691, v8:7253 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/908988Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#51181}
-
- 07 Feb, 2018 1 commit
-
-
Benedikt Meurer authored
- Revert "[builtins] Save one word in contexts for Promise.all." This reverts commit 7632da06. - Revert "[builtins] Also use the Promise#then protector for Promise#finally()." This reverts commit d4f072ce. - Revert "[builtins] Don't mess with entered context for MicrotaskCallbacks." This reverts commit 6703dacd. - Revert "[debugger] Properly deal with settled promises in catch prediction." This reverts commit 40dd0658. - Revert "[builtins] Widen the fast-path for Promise builtins." This reverts commit db0556b7. - Revert "[builtins] Unify PerformPromiseThen and optimize it with TurboFan." This reverts commit a582199c. - Revert "[builtins] Remove obsolete PromiseBuiltinsAssembler::AppendPromiseCallback." This reverts commit 6bf88852. - Revert "[builtins] Turn NewPromiseCapability into a proper builtin." This reverts commit 313b490d. - Revert "[builtins] Inline InternalPromiseThen into it's only caller" This reverts commit f7bd6a2f. - Revert "[builtins] Implement Promise#catch by really calling into Promise#then." This reverts commit b23b098f. - Revert "[promise] Remove incorrect fast path" This reverts commit 0f6eafe8. - Revert "[builtins] Squeeze JSPromise::result and JSPromise::reactions into a single field." This reverts commit 8a677a28. - Revert "[builtins] Refactor promises to reduce GC overhead." This reverts commit 8e7737cb. Tbr: hpayer@chromium.org Bug: chromium:800651, chromium:808911, v8:5691, v8:7253 Change-Id: I8c8ea5ed32ed62f6cd8b0d027a3707ddd891e5f1 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/906991 Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#51158}
-
- 01 Feb, 2018 1 commit
-
-
Michal Majewski authored
Bug: v8:6917 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id5a7b41502dfd4be43496b1edb958522a8eb0c31 Reviewed-on: https://chromium-review.googlesource.com/895588 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51023}
-
- 31 Jan, 2018 3 commits
-
-
Michal Majewski authored
Bug: v8:6917 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I254d2e545709029346f585b02a9edf91d3f27893 Reviewed-on: https://chromium-review.googlesource.com/893321Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#50996}
-
Benedikt Meurer authored
This implements the ideas outlined in the section "Microtask queue" of the exploration document "Promise and async/await performance" (at https://goo.gl/WHRar2), except that the microtask queue stays a linear FixedArray for now, to avoid running into trouble with the parallel scavenger. This way we can already save a significant amount of allocations, thereby reducing the GC frequency quite a bit. All items on the microtask queue are now proper structs that subclass Microtask, i.e. we also wrap JSFunction and MicrotaskCallback jobs into structs. We also consistently remember the context for every microtask (except for MicrotaskCallback where we don't have a context), and execute it later in exactly that context (as required by the spec anyways for the Promise related jobs). Particularly interesting is the PromiseReactionJobTask and its subclasses, since they are designed to have the same size as the PromiseReaction. When we resolve a JSPromise we just take the existing PromiseReaction instances and morph them into PromiseFulfillReactionJobTask or PromiseRejectReactionJobTask (depending whether you "Fulfill" or "Reject"). That way the JSPromise class is now only 6 words instead of 10 words. Also the PromiseReaction and the reaction tasks can either carry a JSPromise (for the fast native case) or a PromiseCapability (for the generic case), which means we don't always pay the overhead of having to also remember the "deferred resolve" and "deferred reject" handlers that are only relevant for the generic case anyways. It also fixes a spec violation where we called "then" before we actually enqueued the PromiseResolveThenableJob, which is observably wrong. Calling it later has the advantage that it should be fairly straight-forward now to completely avoid it for native Promise instances. This seems to save around 10-20% on the various Promise benchmarks and micro-benchmarks. We expect to gain even more as we're now able to inline various operations into TurboFan optimized code easily. Bug: v8:7253 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I893d24ca5bb046974b4f5826a8f6dd22f1210b6a Reviewed-on: https://chromium-review.googlesource.com/892819 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50980}
-
Michal Majewski authored
This is a reland of 0db74d49. Original change's description: > [test] Random seed processor > > 1. --total-timeout-sec now available for ./run-tests.py. It can be > useful with infinite seed stressing > 2. random seed dropped from the context. Now JSON progress indicator > gets it from the list of command args. > > Bug: v8:6917 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I73e535bc8face9b913c696b8d5e3a246fa231004 > Reviewed-on: https://chromium-review.googlesource.com/888524 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50964} Bug: v8:6917 Change-Id: I1ea376a4abffce5ab65f4834ea7e6d6011765ffa Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/894204Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#50978}
-