Revert "[interpreter] Add bytecode for leading array spreads."

This reverts commit 1c48d52b.

Reason for revert: Clusterfuzz found something.

Original change's description:
> [interpreter] Add bytecode for leading array spreads.
> 
> This CL improves the performance of creating [...a, b] or [...a].
> If the array literal has a leading spread, this CL emits the bytecode
> [CreateArrayFromIterable] to create the literal. CreateArrayFromIterable
> is implemented by [IterableToListDefault] builtin to create the initial
> array for the leading spread. IterableToListDefault has a fast path to
> clone efficiently if the spread is an actual array.
> 
> The bytecode generated is now shorter. Bytecode generation is refactored
> into to BuildCreateArrayLiteral, which allows VisitCallSuper to benefit
> from this optimization also.
> For now, turbofan also lowers the bytecode to the builtin.
> 
> The idiomatic use of [...a] to clone the array a now performs better
> than a simple for-loop, but still does not match the performance of slice.
> 
> Bug: v8:7980
> 
> Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
> Change-Id: Ibde659c82d3c7aa1b1777a3d2f6426ac8cc15e35
> Reviewed-on: https://chromium-review.googlesource.com/1181024
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Georg Neis <neis@chromium.org>
> Commit-Queue: Georg Neis <neis@chromium.org>
> Commit-Queue: Hai Dang <dhai@google.com>
> Cr-Commit-Position: refs/heads/master@{#55520}

TBR=rmcilroy@chromium.org,neis@chromium.org,sigurds@chromium.org,gsathya@chromium.org,jgruber@chromium.org,dhai@google.com

Change-Id: I1c86ddcc24274da9f5a8dd3d8bf8d869cbb55cb6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7980
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1199303Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55544}

src/ast/ast.cc

@@ -551,6 +551,12 @@ bool ObjectLiteral::IsFastCloningSupported() const {
              ConstructorBuiltins::kMaximumClonedShallowObjectProperties;
 }
 
+bool ArrayLiteral::is_empty() const {
+  DCHECK(is_initialized());
+  return values()->is_empty() && (boilerplate_description().is_null() ||
+                                  boilerplate_description()->is_empty());
+}
+
 int ArrayLiteral::InitDepthAndFlags() {
   if (is_initialized()) return depth();
 

src/ast/ast.h

@@ -1477,6 +1477,8 @@ class ArrayLiteral final : public AggregateLiteral {
 
   int first_spread_index() const { return first_spread_index_; }
 
+  bool is_empty() const;
+
   // Populate the depth field and flags, returns the depth.
   int InitDepthAndFlags();
 

src/builtins/builtins-definitions.h

@@ -1130,7 +1130,6 @@ namespace internal {
                                                                                \
   /* TypedArray */                                                             \
   TFS(IterableToList, kIterable, kIteratorFn)                                  \
-  TFS(IterableToListWithSymbolLookup, kIterable)                               \
   TFS(TypedArrayInitialize, kHolder, kLength, kElementSize, kInitialize,       \
       kBufferConstructor)                                                      \
   TFS(TypedArrayInitializeWithBuffer, kHolder, kLength, kBuffer, kElementSize, \

src/builtins/builtins-intl-gen.cc

@@ -177,8 +177,10 @@ void IntlBuiltinsAssembler::ListFormatCommon(TNode<Context> context,
   BIND(&has_list);
   {
     // 5. Let x be ? IterableToList(list).
-    TNode<Object> x =
-        CallBuiltin(Builtins::kIterableToListWithSymbolLookup, context, list);
+    IteratorBuiltinsAssembler iterator_assembler(state());
+    // TODO(adamk): Consider exposing IterableToList as a buitin and calling
+    // it from here instead of inlining the operation.
+    TNode<JSArray> x = iterator_assembler.IterableToList(context, list);
 
     // 6. Return ? FormatList(lf, x).
     args.PopAndReturn(CallRuntime(format_func_id, context, list_format, x));

src/builtins/builtins-iterator-gen.cc

@@ -38,7 +38,8 @@ IteratorRecord IteratorBuiltinsAssembler::GetIterator(Node* context,
 
   BIND(&if_not_callable);
   {
-    Node* ret = CallRuntime(Runtime::kThrowIteratorError, context, object);
+    Node* ret = CallRuntime(Runtime::kThrowTypeError, context,
+                            SmiConstant(MessageTemplate::kNotIterable), object);
     GotoIfException(ret, if_exception, exception);
     Unreachable();
   }

src/builtins/builtins-typed-array-gen.cc

@@ -1617,17 +1617,6 @@ TF_BUILTIN(IterableToList, TypedArrayBuiltinsAssembler) {
   Return(iterator_assembler.IterableToList(context, iterable, iterator_fn));
 }
 
-TF_BUILTIN(IterableToListWithSymbolLookup, TypedArrayBuiltinsAssembler) {
-  TNode<Context> context = CAST(Parameter(Descriptor::kContext));
-  TNode<Object> iterable = CAST(Parameter(Descriptor::kIterable));
-
-  IteratorBuiltinsAssembler iterator_assembler(state());
-  TNode<Object> iterator_fn =
-      iterator_assembler.GetIteratorMethod(context, iterable);
-
-  TailCallBuiltin(Builtins::kIterableToList, context, iterable, iterator_fn);
-}
-
 // ES6 #sec-%typedarray%.from
 TF_BUILTIN(TypedArrayFrom, TypedArrayBuiltinsAssembler) {
   TNode<Context> context = CAST(Parameter(Descriptor::kContext));

src/compiler/bytecode-graph-builder.cc

@@ -1601,12 +1601,6 @@ void BytecodeGraphBuilder::VisitCreateEmptyArrayLiteral() {
   environment()->BindAccumulator(literal);
 }
 
-void BytecodeGraphBuilder::VisitCreateArrayFromIterable() {
-  Node* iterable = NewNode(javascript()->CreateArrayFromIterable(),
-                           environment()->LookupAccumulator());
-  environment()->BindAccumulator(iterable, Environment::kAttachFrameState);
-}
-
 void BytecodeGraphBuilder::VisitCreateObjectLiteral() {
   Handle<ObjectBoilerplateDescription> constant_properties(
       ObjectBoilerplateDescription::cast(

src/compiler/js-generic-lowering.cc

@@ -513,13 +513,6 @@ void JSGenericLowering::LowerJSCreateEmptyLiteralArray(Node* node) {
   ReplaceWithStubCall(node, callable, flags);
 }
 
-void JSGenericLowering::LowerJSCreateArrayFromIterable(Node* node) {
-  CallDescriptor::Flags flags = FrameStateFlagForCall(node);
-  Callable callable = Builtins::CallableFor(
-      isolate(), Builtins::kIterableToListWithSymbolLookup);
-  ReplaceWithStubCall(node, callable, flags);
-}
-
 void JSGenericLowering::LowerJSCreateLiteralObject(Node* node) {
   CreateLiteralParameters const& p = CreateLiteralParametersOf(node->op());
   CallDescriptor::Flags flags = FrameStateFlagForCall(node);

src/compiler/js-operator.cc

@@ -1190,14 +1190,6 @@ const Operator* JSOperatorBuilder::CreateEmptyLiteralArray(
       parameters);                                   // parameter
 }
 
-const Operator* JSOperatorBuilder::CreateArrayFromIterable() {
-  return new (zone()) Operator(              // --
-      IrOpcode::kJSCreateArrayFromIterable,  // opcode
-      Operator::kNoProperties,               // properties
-      "JSCreateArrayFromIterable",           // name
-      1, 1, 1, 1, 1, 2);                     // counts
-}
-
 const Operator* JSOperatorBuilder::CreateLiteralObject(
     Handle<ObjectBoilerplateDescription> constant_properties,
     VectorSlotPair const& feedback, int literal_flags,

src/compiler/js-operator.h

@@ -733,7 +733,6 @@ class V8_EXPORT_PRIVATE JSOperatorBuilder final
       VectorSlotPair const& feedback, int literal_flags,
       int number_of_elements);
   const Operator* CreateEmptyLiteralArray(VectorSlotPair const& feedback);
-  const Operator* CreateArrayFromIterable();
   const Operator* CreateEmptyLiteralObject();
 
   const Operator* CreateLiteralObject(

src/compiler/opcodes.h

@@ -151,7 +151,6 @@
   V(JSCreateTypedArray)         \
   V(JSCreateLiteralArray)       \
   V(JSCreateEmptyLiteralArray)  \
-  V(JSCreateArrayFromIterable)  \
   V(JSCreateLiteralObject)      \
   V(JSCreateEmptyLiteralObject) \
   V(JSCloneObject)              \

src/compiler/operator-properties.cc

@@ -73,7 +73,6 @@ bool OperatorProperties::HasFrameStateInput(const Operator* op) {
     case IrOpcode::kJSCreateArray:
     case IrOpcode::kJSCreateTypedArray:
     case IrOpcode::kJSCreateLiteralArray:
-    case IrOpcode::kJSCreateArrayFromIterable:
     case IrOpcode::kJSCreateLiteralObject:
     case IrOpcode::kJSCreateLiteralRegExp:
     case IrOpcode::kJSCreateObject:

src/compiler/property-access-builder.cc

@@ -89,7 +89,6 @@ bool NeedsCheckHeapObject(Node* receiver) {
     case IrOpcode::kJSCreateIterResultObject:
     case IrOpcode::kJSCreateLiteralArray:
     case IrOpcode::kJSCreateEmptyLiteralArray:
-    case IrOpcode::kJSCreateArrayFromIterable:
     case IrOpcode::kJSCreateLiteralObject:
     case IrOpcode::kJSCreateEmptyLiteralObject:
     case IrOpcode::kJSCreateLiteralRegExp:

src/compiler/typer.cc

@@ -1215,10 +1215,6 @@ Type Typer::Visitor::TypeJSCreateEmptyLiteralArray(Node* node) {
   return Type::Array();
 }
 
-Type Typer::Visitor::TypeJSCreateArrayFromIterable(Node* node) {
-  return Type::Array();
-}
-
 Type Typer::Visitor::TypeJSCreateLiteralObject(Node* node) {
   return Type::OtherObject();
 }

src/compiler/verifier.cc

@@ -715,10 +715,6 @@ void Verifier::Visitor::Check(Node* node, const AllNodes& all) {
       // Type is Array.
       CheckTypeIs(node, Type::Array());
       break;
-    case IrOpcode::kJSCreateArrayFromIterable:
-      // Type is Array.
-      CheckTypeIs(node, Type::Array());
-      break;
     case IrOpcode::kJSCreateLiteralObject:
     case IrOpcode::kJSCreateEmptyLiteralObject:
     case IrOpcode::kJSCloneObject:

src/debug/debug-evaluate.cc

@@ -292,7 +292,6 @@ bool IntrinsicHasNoSideEffect(Runtime::FunctionId id) {
   V(ReThrow)                                  \
   V(ThrowCalledNonCallable)                   \
   V(ThrowInvalidStringLength)                 \
-  V(ThrowIteratorError)                       \
   V(ThrowIteratorResultNotAnObject)           \
   V(ThrowReferenceError)                      \
   V(ThrowSymbolIteratorInvalid)               \
@@ -478,7 +477,6 @@ bool BytecodeHasNoSideEffect(interpreter::Bytecode bytecode) {
     // Literals.
     case Bytecode::kCreateArrayLiteral:
     case Bytecode::kCreateEmptyArrayLiteral:
-    case Bytecode::kCreateArrayFromIterable:
     case Bytecode::kCreateObjectLiteral:
     case Bytecode::kCreateEmptyObjectLiteral:
     case Bytecode::kCreateRegExpLiteral:

src/feedback-vector.h

@@ -352,14 +352,11 @@ class V8_EXPORT_PRIVATE FeedbackVectorSpec {
     return AddSlot(FeedbackSlotKind::kLoadKeyed);
   }
 
-  FeedbackSlotKind GetStoreICSlot(LanguageMode language_mode) {
-    STATIC_ASSERT(LanguageModeSize == 2);
-    return is_strict(language_mode) ? FeedbackSlotKind::kStoreNamedStrict
-                                    : FeedbackSlotKind::kStoreNamedSloppy;
-  }
-
   FeedbackSlot AddStoreICSlot(LanguageMode language_mode) {
-    return AddSlot(GetStoreICSlot(language_mode));
+    STATIC_ASSERT(LanguageModeSize == 2);
+    return AddSlot(is_strict(language_mode)
+                       ? FeedbackSlotKind::kStoreNamedStrict
+                       : FeedbackSlotKind::kStoreNamedSloppy);
   }
 
   FeedbackSlot AddStoreOwnICSlot() {

src/interpreter/bytecode-array-builder.cc

@@ -973,11 +973,6 @@ BytecodeArrayBuilder& BytecodeArrayBuilder::CreateArrayLiteral(
   return *this;
 }
 
-BytecodeArrayBuilder& BytecodeArrayBuilder::CreateArrayFromIterable() {
-  OutputCreateArrayFromIterable();
-  return *this;
-}
-
 BytecodeArrayBuilder& BytecodeArrayBuilder::CreateObjectLiteral(
     size_t constant_properties_entry, int literal_index, int flags,
     Register output) {

src/interpreter/bytecode-array-builder.h

@@ -234,7 +234,6 @@ class V8_EXPORT_PRIVATE BytecodeArrayBuilder final {
   BytecodeArrayBuilder& CreateArrayLiteral(size_t constant_elements_entry,
                                            int literal_index, int flags);
   BytecodeArrayBuilder& CreateEmptyArrayLiteral(int literal_index);
-  BytecodeArrayBuilder& CreateArrayFromIterable();
   BytecodeArrayBuilder& CreateObjectLiteral(size_t constant_properties_entry,
                                             int literal_index, int flags,
                                             Register output);

src/interpreter/bytecode-generator.h

@@ -183,11 +183,11 @@ class BytecodeGenerator final : public AstVisitor<BytecodeGenerator> {
   void BuildArrayLiteralSpread(Spread* spread, Register array, Register index,
                                FeedbackSlot index_slot,
                                FeedbackSlot element_slot);
-  // Create Array literals. |expr| can be nullptr, but if provided,
-  // a boilerplate will be used to create an initial array for elements
-  // before the first spread.
-  void BuildCreateArrayLiteral(ZonePtrList<Expression>* elements,
-                               ArrayLiteral* expr);
+  void BuildArrayLiteralElementsInsertion(Register array,
+                                          int first_spread_index,
+                                          ZonePtrList<Expression>* elements,
+                                          bool skip_constants);
+
   void BuildCreateObjectLiteral(Register literal, uint8_t flags, size_t entry);
   void AllocateTopLevelRegisters();
   void VisitArgumentsObject(Variable* variable);

src/interpreter/bytecodes.h

@@ -247,7 +247,6 @@ namespace interpreter {
     OperandType::kIdx, OperandType::kFlag8)                                    \
   V(CreateArrayLiteral, AccumulatorUse::kWrite, OperandType::kIdx,             \
     OperandType::kIdx, OperandType::kFlag8)                                    \
-  V(CreateArrayFromIterable, AccumulatorUse::kReadWrite)                       \
   V(CreateEmptyArrayLiteral, AccumulatorUse::kWrite, OperandType::kIdx)        \
   V(CreateObjectLiteral, AccumulatorUse::kNone, OperandType::kIdx,             \
     OperandType::kIdx, OperandType::kFlag8, OperandType::kRegOut)              \

src/interpreter/interpreter-generator.cc

@@ -9,7 +9,6 @@
 
 #include "src/builtins/builtins-arguments-gen.h"
 #include "src/builtins/builtins-constructor-gen.h"
-#include "src/builtins/builtins-iterator-gen.h"
 #include "src/code-events.h"
 #include "src/code-factory.h"
 #include "src/debug/debug.h"
@@ -2382,21 +2381,6 @@ IGNITION_HANDLER(CreateEmptyArrayLiteral, InterpreterAssembler) {
   Dispatch();
 }
 
-// CreateArrayFromIterable
-//
-// Spread the given iterable from the accumulator into a new JSArray.
-IGNITION_HANDLER(CreateArrayFromIterable, InterpreterAssembler) {
-  Node* iterable = GetAccumulator();
-  Node* context = GetContext();
-  IteratorBuiltinsAssembler iterator_assembler(state());
-
-  Node* method = iterator_assembler.GetIteratorMethod(context, iterable);
-  Node* result =
-      CallBuiltin(Builtins::kIterableToList, context, iterable, method);
-  SetAccumulator(result);
-  Dispatch();
-}
-
 // CreateObjectLiteral <element_idx> <literal_idx> <flags>
 //
 // Creates an object literal for literal index <literal_idx> with

src/messages.h

@@ -377,7 +377,6 @@ class ErrorUtils : public AllStatic {
     "% is not a function or its return value is not async iterable")           \
   T(NotFiniteNumber, "Value need to be finite number for %()")                 \
   T(NotIterable, "% is not iterable")                                          \
-  T(NotIterableNoSymbolLoad, "% is not iterable (cannot read property %)")     \
   T(NotAsyncIterable, "% is not async iterable")                               \
   T(NotPropertyName, "% is not a valid property name")                         \
   T(NotTypedArray, "this is not a typed array.")                               \

src/runtime/runtime-internal.cc

@@ -19,7 +19,6 @@
 #include "src/parsing/parsing.h"
 #include "src/runtime/runtime-utils.h"
 #include "src/snapshot/snapshot.h"
-#include "src/string-builder-inl.h"
 
 namespace v8 {
 namespace internal {
@@ -344,31 +343,6 @@ bool ComputeLocation(Isolate* isolate, MessageLocation* target) {
   return false;
 }
 
-Handle<String> BuildDefaultCallSite(Isolate* isolate, Handle<Object> object) {
-  IncrementalStringBuilder builder(isolate);
-
-  builder.AppendString(Object::TypeOf(isolate, object));
-  if (object->IsString()) {
-    builder.AppendCString(" \"");
-    builder.AppendString(Handle<String>::cast(object));
-    builder.AppendCString("\"");
-  } else if (object->IsNull(isolate)) {
-    builder.AppendCString(" ");
-    builder.AppendString(isolate->factory()->null_string());
-  } else if (object->IsTrue(isolate)) {
-    builder.AppendCString(" ");
-    builder.AppendString(isolate->factory()->true_string());
-  } else if (object->IsFalse(isolate)) {
-    builder.AppendCString(" ");
-    builder.AppendString(isolate->factory()->false_string());
-  } else if (object->IsNumber()) {
-    builder.AppendCString(" ");
-    builder.AppendString(isolate->factory()->NumberToString(object));
-  }
-
-  return builder.Finish().ToHandleChecked();
-}
-
 Handle<String> RenderCallSite(Isolate* isolate, Handle<Object> object,
                               CallPrinter::ErrorHint* hint) {
   MessageLocation location;
@@ -384,7 +358,7 @@ Handle<String> RenderCallSite(Isolate* isolate, Handle<Object> object,
       isolate->clear_pending_exception();
     }
   }
-  return BuildDefaultCallSite(isolate, object);
+  return Object::TypeOf(isolate, object);
 }
 
 MessageTemplate::Template UpdateErrorTemplate(
@@ -414,11 +388,11 @@ MaybeHandle<Object> Runtime::ThrowIteratorError(Isolate* isolate,
                                                 Handle<Object> object) {
   CallPrinter::ErrorHint hint = CallPrinter::kNone;
   Handle<String> callsite = RenderCallSite(isolate, object, &hint);
-  MessageTemplate::Template id = MessageTemplate::kNotIterableNoSymbolLoad;
+  MessageTemplate::Template id = MessageTemplate::kNonObjectPropertyLoad;
 
   if (hint == CallPrinter::kNone) {
     Handle<Symbol> iterator_symbol = isolate->factory()->iterator_symbol();
-    THROW_NEW_ERROR(isolate, NewTypeError(id, callsite, iterator_symbol),
+    THROW_NEW_ERROR(isolate, NewTypeError(id, iterator_symbol, callsite),
                     Object);
   }
 
@@ -426,14 +400,6 @@ MaybeHandle<Object> Runtime::ThrowIteratorError(Isolate* isolate,
   THROW_NEW_ERROR(isolate, NewTypeError(id, callsite), Object);
 }
 
-RUNTIME_FUNCTION(Runtime_ThrowIteratorError) {
-  HandleScope scope(isolate);
-  DCHECK_EQ(1, args.length());
-  CONVERT_ARG_HANDLE_CHECKED(Object, object, 0);
-  RETURN_RESULT_OR_FAILURE(isolate,
-                           Runtime::ThrowIteratorError(isolate, object));
-}
-
 RUNTIME_FUNCTION(Runtime_ThrowCalledNonCallable) {
   HandleScope scope(isolate);
   DCHECK_EQ(1, args.length());

src/runtime/runtime.cc

@@ -113,7 +113,6 @@ bool Runtime::IsNonReturning(FunctionId id) {
     case Runtime::kThrowConstructorReturnedNonObject:
     case Runtime::kThrowInvalidStringLength:
     case Runtime::kThrowInvalidTypedArrayAlignment:
-    case Runtime::kThrowIteratorError:
     case Runtime::kThrowIteratorResultNotAnObject:
     case Runtime::kThrowThrowMethodMissing:
     case Runtime::kThrowSymbolIteratorInvalid:

src/runtime/runtime.h

@@ -263,7 +263,6 @@ namespace internal {
   F(ThrowConstructorReturnedNonObject, 0, 1)                         \
   F(ThrowInvalidStringLength, 0, 1)                                  \
   F(ThrowInvalidTypedArrayAlignment, 2, 1)                           \
-  F(ThrowIteratorError, 1, 1)                                        \
   F(ThrowIteratorResultNotAnObject, 1, 1)                            \
   F(ThrowNotConstructor, 1, 1)                                       \
   F(ThrowRangeError, -1 /* >= 1 */, 1)                               \

test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden

@@ -35,17 +35,17 @@ bytecodes: [
   /*   42 S> */ B(LdaSmi), I8(1),
                 B(Star), R(0),
   /*   45 S> */ B(CreateArrayLiteral), U8(0), U8(0), U8(37),
-                B(Star), R(2),
-                B(LdaZero),
                 B(Star), R(1),
+                B(LdaZero),
+                B(Star), R(2),
                 B(Ldar), R(0),
-  /*   54 E> */ B(StaInArrayLiteral), R(2), R(1), U8(1),
+  /*   54 E> */ B(StaKeyedProperty), R(1), R(2), U8(1),
                 B(LdaSmi), I8(1),
-                B(Star), R(1),
+                B(Star), R(2),
                 B(Ldar), R(0),
   /*   59 E> */ B(AddSmi), I8(1), U8(3),
-                B(StaInArrayLiteral), R(2), R(1), U8(1),
-                B(Ldar), R(2),
+                B(StaKeyedProperty), R(1), R(2), U8(1),
+                B(Ldar), R(1),
   /*   65 S> */ B(Return),
 ]
 constant pool: [
@@ -84,29 +84,29 @@ bytecodes: [
   /*   42 S> */ B(LdaSmi), I8(1),
                 B(Star), R(0),
   /*   45 S> */ B(CreateArrayLiteral), U8(0), U8(0), U8(4),
-                B(Star), R(2),
-                B(LdaZero),
                 B(Star), R(1),
-                B(CreateArrayLiteral), U8(1), U8(1), U8(37),
-                B(Star), R(4),
                 B(LdaZero),
+                B(Star), R(2),
+                B(CreateArrayLiteral), U8(1), U8(1), U8(37),
                 B(Star), R(3),
+                B(LdaZero),
+                B(Star), R(4),
                 B(Ldar), R(0),
-  /*   56 E> */ B(StaInArrayLiteral), R(4), R(3), U8(2),
-                B(Ldar), R(4),
-                B(StaInArrayLiteral), R(2), R(1), U8(4),
+  /*   56 E> */ B(StaKeyedProperty), R(3), R(4), U8(2),
+                B(Ldar), R(3),
+                B(StaKeyedProperty), R(1), R(2), U8(4),
                 B(LdaSmi), I8(1),
-                B(Star), R(1),
+                B(Star), R(2),
                 B(CreateArrayLiteral), U8(2), U8(6), U8(37),
-                B(Star), R(4),
-                B(LdaZero),
                 B(Star), R(3),
+                B(LdaZero),
+                B(Star), R(4),
                 B(Ldar), R(0),
   /*   68 E> */ B(AddSmi), I8(2), U8(7),
-                B(StaInArrayLiteral), R(4), R(3), U8(8),
-                B(Ldar), R(4),
-                B(StaInArrayLiteral), R(2), R(1), U8(4),
-                B(Ldar), R(2),
+                B(StaKeyedProperty), R(3), R(4), U8(8),
+                B(Ldar), R(3),
+                B(StaKeyedProperty), R(1), R(2), U8(4),
+                B(Ldar), R(1),
   /*   76 S> */ B(Return),
 ]
 constant pool: [
@@ -121,18 +121,50 @@ handlers: [
 snippet: "
   var a = [ 1, 2 ]; return [ ...a ];
 "
-frame size: 1
+frame size: 8
 parameter count: 1
-bytecode array length: 9
+bytecode array length: 86
 bytecodes: [
   /*   30 E> */ B(StackCheck),
   /*   42 S> */ B(CreateArrayLiteral), U8(0), U8(0), U8(37),
                 B(Star), R(0),
-  /*   52 S> */ B(CreateArrayFromIterable),
+  /*   52 S> */ B(CreateArrayLiteral), U8(1), U8(1), U8(37),
+                B(Star), R(1),
+                B(LdaConstant), U8(2),
+  /*   64 S> */ B(Star), R(2),
+                B(LdaNamedProperty), R(0), U8(3), U8(7),
+                B(Star), R(7),
+                B(CallProperty0), R(7), R(0), U8(9),
+                B(Mov), R(0), R(6),
+                B(JumpIfJSReceiver), U8(7),
+                B(CallRuntime), U16(Runtime::kThrowSymbolIteratorInvalid), R(0), U8(0),
+                B(Star), R(5),
+                B(LdaNamedProperty), R(5), U8(4), U8(11),
+                B(Star), R(4),
+                B(CallProperty0), R(4), R(5), U8(13),
+                B(Star), R(3),
+                B(JumpIfJSReceiver), U8(7),
+                B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(3), U8(1),
+                B(LdaNamedProperty), R(3), U8(5), U8(15),
+                B(JumpIfToBooleanTrue), U8(21),
+                B(LdaNamedProperty), R(3), U8(6), U8(17),
+                B(Star), R(3),
+                B(StaInArrayLiteral), R(1), R(2), U8(2),
+                B(Ldar), R(2),
+                B(Inc), U8(4),
+                B(Star), R(2),
+                B(JumpLoop), U8(35), I8(0),
+                B(Ldar), R(1),
   /*   68 S> */ B(Return),
 ]
 constant pool: [
   ARRAY_BOILERPLATE_DESCRIPTION_TYPE,
+  ARRAY_BOILERPLATE_DESCRIPTION_TYPE,
+  Smi [0],
+  SYMBOL_TYPE,
+  ONE_BYTE_INTERNALIZED_STRING_TYPE ["next"],
+  ONE_BYTE_INTERNALIZED_STRING_TYPE ["done"],
+  ONE_BYTE_INTERNALIZED_STRING_TYPE ["value"],
 ]
 handlers: [
 ]
@@ -149,32 +181,32 @@ bytecodes: [
   /*   42 S> */ B(CreateArrayLiteral), U8(0), U8(0), U8(37),
                 B(Star), R(0),
   /*   52 S> */ B(CreateArrayLiteral), U8(1), U8(1), U8(37),
-                B(Star), R(2),
+                B(Star), R(1),
                 B(LdaConstant), U8(2),
-  /*   67 S> */ B(Star), R(1),
-                B(LdaNamedProperty), R(0), U8(3), U8(5),
+  /*   67 S> */ B(Star), R(2),
+                B(LdaNamedProperty), R(0), U8(3), U8(7),
                 B(Star), R(7),
-                B(CallProperty0), R(7), R(0), U8(7),
+                B(CallProperty0), R(7), R(0), U8(9),
                 B(Mov), R(0), R(6),
                 B(JumpIfJSReceiver), U8(7),
                 B(CallRuntime), U16(Runtime::kThrowSymbolIteratorInvalid), R(0), U8(0),
                 B(Star), R(5),
-                B(LdaNamedProperty), R(5), U8(4), U8(9),
+                B(LdaNamedProperty), R(5), U8(4), U8(11),
                 B(Star), R(4),
-                B(CallProperty0), R(4), R(5), U8(11),
+                B(CallProperty0), R(4), R(5), U8(13),
                 B(Star), R(3),
                 B(JumpIfJSReceiver), U8(7),
                 B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(3), U8(1),
-                B(LdaNamedProperty), R(3), U8(5), U8(13),
+                B(LdaNamedProperty), R(3), U8(5), U8(15),
                 B(JumpIfToBooleanTrue), U8(21),
-                B(LdaNamedProperty), R(3), U8(6), U8(15),
+                B(LdaNamedProperty), R(3), U8(6), U8(17),
                 B(Star), R(3),
-                B(StaInArrayLiteral), R(2), R(1), U8(3),
-                B(Ldar), R(1),
-                B(Inc), U8(2),
-                B(Star), R(1),
-                B(JumpLoop), U8(35), I8(0),
+                B(StaInArrayLiteral), R(1), R(2), U8(2),
                 B(Ldar), R(2),
+                B(Inc), U8(4),
+                B(Star), R(2),
+                B(JumpLoop), U8(35), I8(0),
+                B(Ldar), R(1),
   /*   71 S> */ B(Return),
 ]
 constant pool: [
@@ -193,25 +225,55 @@ handlers: [
 snippet: "
   var a = [ 1, 2 ]; return [ ...a, 3 ];
 "
-frame size: 3
+frame size: 8
 parameter count: 1
-bytecode array length: 25
+bytecode array length: 98
 bytecodes: [
   /*   30 E> */ B(StackCheck),
   /*   42 S> */ B(CreateArrayLiteral), U8(0), U8(0), U8(37),
                 B(Star), R(0),
-  /*   52 S> */ B(CreateArrayFromIterable),
-                B(Star), R(2),
-                B(LdaNamedProperty), R(2), U8(1), U8(1),
+  /*   52 S> */ B(CreateArrayLiteral), U8(1), U8(1), U8(37),
                 B(Star), R(1),
+                B(LdaConstant), U8(2),
+  /*   64 S> */ B(Star), R(2),
+                B(LdaNamedProperty), R(0), U8(3), U8(7),
+                B(Star), R(7),
+                B(CallProperty0), R(7), R(0), U8(9),
+                B(Mov), R(0), R(6),
+                B(JumpIfJSReceiver), U8(7),
+                B(CallRuntime), U16(Runtime::kThrowSymbolIteratorInvalid), R(0), U8(0),
+                B(Star), R(5),
+                B(LdaNamedProperty), R(5), U8(4), U8(11),
+                B(Star), R(4),
+                B(CallProperty0), R(4), R(5), U8(13),
+                B(Star), R(3),
+                B(JumpIfJSReceiver), U8(7),
+                B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(3), U8(1),
+                B(LdaNamedProperty), R(3), U8(5), U8(15),
+                B(JumpIfToBooleanTrue), U8(21),
+                B(LdaNamedProperty), R(3), U8(6), U8(17),
+                B(Star), R(3),
+                B(StaInArrayLiteral), R(1), R(2), U8(2),
+                B(Ldar), R(2),
+                B(Inc), U8(4),
+                B(Star), R(2),
+                B(JumpLoop), U8(35), I8(0),
                 B(LdaSmi), I8(3),
-                B(StaInArrayLiteral), R(2), R(1), U8(3),
+                B(StaInArrayLiteral), R(1), R(2), U8(2),
                 B(Ldar), R(2),
+                B(Inc), U8(4),
+                B(Star), R(2),
+                B(Ldar), R(1),
   /*   71 S> */ B(Return),
 ]
 constant pool: [
   ARRAY_BOILERPLATE_DESCRIPTION_TYPE,
-  ONE_BYTE_INTERNALIZED_STRING_TYPE ["length"],
+  ARRAY_BOILERPLATE_DESCRIPTION_TYPE,
+  Smi [0],
+  SYMBOL_TYPE,
+  ONE_BYTE_INTERNALIZED_STRING_TYPE ["next"],
+  ONE_BYTE_INTERNALIZED_STRING_TYPE ["done"],
+  ONE_BYTE_INTERNALIZED_STRING_TYPE ["value"],
 ]
 handlers: [
 ]

test/cctest/interpreter/bytecode_expectations/AsyncGenerators.golden

@@ -362,7 +362,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(18),
                 B(LdaConstant), U8(14),
                 B(Star), R(19),

test/cctest/interpreter/bytecode_expectations/CallAndSpread.golden

@@ -67,7 +67,7 @@ snippet: "
 "
 frame size: 10
 parameter count: 1
-bytecode array length: 109
+bytecode array length: 112
 bytecodes: [
   /*   30 E> */ B(StackCheck),
   /*   34 S> */ B(LdaGlobal), U8(0), U8(0),
@@ -75,36 +75,38 @@ bytecodes: [
                 B(LdaNamedProperty), R(0), U8(1), U8(2),
                 B(Star), R(1),
                 B(CreateArrayLiteral), U8(2), U8(4), U8(37),
-                B(Star), R(4),
-                B(LdaConstant), U8(3),
                 B(Star), R(3),
-  /*   49 S> */ B(CreateArrayLiteral), U8(4), U8(8), U8(37),
+                B(LdaConstant), U8(3),
+                B(Star), R(4),
+  /*   49 S> */ B(CreateArrayLiteral), U8(4), U8(10), U8(37),
                 B(Star), R(8),
-                B(LdaNamedProperty), R(8), U8(5), U8(9),
+                B(LdaNamedProperty), R(8), U8(5), U8(11),
                 B(Star), R(9),
-                B(CallProperty0), R(9), R(8), U8(11),
+                B(CallProperty0), R(9), R(8), U8(13),
                 B(Mov), R(0), R(2),
                 B(JumpIfJSReceiver), U8(7),
                 B(CallRuntime), U16(Runtime::kThrowSymbolIteratorInvalid), R(0), U8(0),
                 B(Star), R(7),
-                B(LdaNamedProperty), R(7), U8(6), U8(13),
+                B(LdaNamedProperty), R(7), U8(6), U8(15),
                 B(Star), R(6),
-                B(CallProperty0), R(6), R(7), U8(15),
+                B(CallProperty0), R(6), R(7), U8(17),
                 B(Star), R(5),
                 B(JumpIfJSReceiver), U8(7),
                 B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(5), U8(1),
-                B(LdaNamedProperty), R(5), U8(7), U8(17),
+                B(LdaNamedProperty), R(5), U8(7), U8(19),
                 B(JumpIfToBooleanTrue), U8(21),
-                B(LdaNamedProperty), R(5), U8(8), U8(19),
+                B(LdaNamedProperty), R(5), U8(8), U8(21),
                 B(Star), R(5),
-                B(StaInArrayLiteral), R(4), R(3), U8(6),
-                B(Ldar), R(3),
-                B(Inc), U8(5),
-                B(Star), R(3),
+                B(StaInArrayLiteral), R(3), R(4), U8(5),
+                B(Ldar), R(4),
+                B(Inc), U8(7),
+                B(Star), R(4),
                 B(JumpLoop), U8(35), I8(0),
                 B(LdaSmi), I8(4),
-                B(StaInArrayLiteral), R(4), R(3), U8(6),
-                B(Mov), R(4), R(3),
+                B(StaInArrayLiteral), R(3), R(4), U8(5),
+                B(Ldar), R(4),
+                B(Inc), U8(7),
+                B(Star), R(4),
                 B(CallJSRuntime), U8(%reflect_apply), R(1), U8(3),
                 B(LdaUndefined),
   /*   64 S> */ B(Return),

test/cctest/interpreter/bytecode_expectations/ForAwaitOf.golden

@@ -123,7 +123,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(19),
                 B(LdaConstant), U8(11),
                 B(Star), R(20),
@@ -377,7 +377,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(19),
                 B(LdaConstant), U8(11),
                 B(Star), R(20),
@@ -653,7 +653,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(19),
                 B(LdaConstant), U8(11),
                 B(Star), R(20),
@@ -885,7 +885,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(17),
                 B(LdaConstant), U8(9),
                 B(Star), R(18),

test/cctest/interpreter/bytecode_expectations/ForOf.golden

@@ -85,7 +85,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(12),
                 B(LdaConstant), U8(7),
                 B(Star), R(13),
@@ -217,7 +217,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(13),
                 B(LdaConstant), U8(7),
                 B(Star), R(14),
@@ -361,7 +361,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(12),
                 B(LdaConstant), U8(7),
                 B(Star), R(13),
@@ -495,7 +495,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(11),
                 B(LdaConstant), U8(9),
                 B(Star), R(12),

test/cctest/interpreter/bytecode_expectations/ForOfLoop.golden

@@ -89,7 +89,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(14),
                 B(LdaConstant), U8(6),
                 B(Star), R(15),
@@ -256,7 +256,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(14),
                 B(LdaConstant), U8(11),
                 B(Star), R(15),
@@ -401,7 +401,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(12),
                 B(LdaConstant), U8(8),
                 B(Star), R(13),
@@ -550,7 +550,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(17),
                 B(LdaConstant), U8(8),
                 B(Star), R(18),
@@ -697,7 +697,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(15),
                 B(LdaConstant), U8(9),
                 B(Star), R(16),
@@ -859,7 +859,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(14),
                 B(LdaConstant), U8(12),
                 B(Star), R(15),
@@ -1007,7 +1007,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(20),
                 B(LdaConstant), U8(6),
                 B(Star), R(21),
@@ -1218,7 +1218,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(19),
                 B(LdaConstant), U8(7),
                 B(Star), R(20),

test/cctest/interpreter/bytecode_expectations/Generators.golden

@@ -203,7 +203,7 @@ bytecodes: [
                 B(TestTypeOf), U8(6),
                 B(JumpIfFalse), U8(4),
                 B(Jump), U8(18),
-                B(Wide), B(LdaSmi), I16(154),
+                B(Wide), B(LdaSmi), I16(153),
                 B(Star), R(14),
                 B(LdaConstant), U8(13),
                 B(Star), R(15),

test/cctest/interpreter/bytecode_expectations/IIFEWithOneshotOpt.golden

@@ -343,7 +343,7 @@ snippet: "
         })();
   
 "
-frame size: 5
+frame size: 4
 parameter count: 1
 bytecode array length: 32
 bytecodes: [
@@ -351,10 +351,10 @@ bytecodes: [
                 B(Star), R(0),
   /*   16 E> */ B(StackCheck),
   /*   29 S> */ B(LdaConstant), U8(0),
-                B(Star), R(3),
+                B(Star), R(1),
                 B(LdaSmi), I8(4),
-                B(Star), R(4),
-                B(CallRuntime), U16(Runtime::kCreateArrayLiteralWithoutAllocationSite), R(3), U8(2),
+                B(Star), R(2),
+                B(CallRuntime), U16(Runtime::kCreateArrayLiteralWithoutAllocationSite), R(1), U8(2),
   /*   31 E> */ B(StaGlobal), U8(1), U8(0),
   /*   60 S> */ B(LdaConstant), U8(2),
                 B(Star), R(3),
@@ -379,7 +379,7 @@ snippet: "
         })();
   
 "
-frame size: 5
+frame size: 4
 parameter count: 1
 bytecode array length: 32
 bytecodes: [
@@ -387,10 +387,10 @@ bytecodes: [
                 B(Star), R(0),
   /*   16 E> */ B(StackCheck),
   /*   29 S> */ B(LdaConstant), U8(0),
-                B(Star), R(3),
+                B(Star), R(1),
                 B(LdaSmi), I8(37),
-                B(Star), R(4),
-                B(CallRuntime), U16(Runtime::kCreateArrayLiteralWithoutAllocationSite), R(3), U8(2),
+                B(Star), R(2),
+                B(CallRuntime), U16(Runtime::kCreateArrayLiteralWithoutAllocationSite), R(1), U8(2),
   /*   31 E> */ B(StaGlobal), U8(1), U8(0),
   /*   45 S> */ B(LdaConstant), U8(2),
                 B(Star), R(3),

test/cctest/interpreter/bytecode_expectations/NewAndSpread.golden

@@ -86,7 +86,7 @@ snippet: "
 "
 frame size: 10
 parameter count: 1
-bytecode array length: 124
+bytecode array length: 127
 bytecodes: [
   /*   30 E> */ B(StackCheck),
                 B(LdaTheHole),
@@ -101,35 +101,37 @@ bytecodes: [
                 B(Mov), R(4), R(0),
                 B(Mov), R(0), R(1),
   /*   89 S> */ B(CreateArrayLiteral), U8(2), U8(1), U8(37),
-                B(Star), R(4),
-                B(LdaConstant), U8(3),
                 B(Star), R(3),
-  /*  101 S> */ B(CreateArrayLiteral), U8(4), U8(5), U8(37),
+                B(LdaConstant), U8(3),
+                B(Star), R(4),
+  /*  101 S> */ B(CreateArrayLiteral), U8(4), U8(7), U8(37),
                 B(Star), R(8),
-                B(LdaNamedProperty), R(8), U8(5), U8(6),
+                B(LdaNamedProperty), R(8), U8(5), U8(8),
                 B(Star), R(9),
-                B(CallProperty0), R(9), R(8), U8(8),
+                B(CallProperty0), R(9), R(8), U8(10),
                 B(JumpIfJSReceiver), U8(7),
                 B(CallRuntime), U16(Runtime::kThrowSymbolIteratorInvalid), R(0), U8(0),
                 B(Star), R(7),
-                B(LdaNamedProperty), R(7), U8(6), U8(10),
+                B(LdaNamedProperty), R(7), U8(6), U8(12),
                 B(Star), R(6),
-                B(CallProperty0), R(6), R(7), U8(12),
+                B(CallProperty0), R(6), R(7), U8(14),
                 B(Star), R(5),
                 B(JumpIfJSReceiver), U8(7),
                 B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(5), U8(1),
-                B(LdaNamedProperty), R(5), U8(7), U8(14),
+                B(LdaNamedProperty), R(5), U8(7), U8(16),
                 B(JumpIfToBooleanTrue), U8(21),
-                B(LdaNamedProperty), R(5), U8(8), U8(16),
+                B(LdaNamedProperty), R(5), U8(8), U8(18),
                 B(Star), R(5),
-                B(StaInArrayLiteral), R(4), R(3), U8(3),
-                B(Ldar), R(3),
-                B(Inc), U8(2),
-                B(Star), R(3),
+                B(StaInArrayLiteral), R(3), R(4), U8(2),
+                B(Ldar), R(4),
+                B(Inc), U8(4),
+                B(Star), R(4),
                 B(JumpLoop), U8(35), I8(0),
                 B(LdaSmi), I8(4),
-                B(StaInArrayLiteral), R(4), R(3), U8(3),
-                B(Mov), R(4), R(3),
+                B(StaInArrayLiteral), R(3), R(4), U8(2),
+                B(Ldar), R(4),
+                B(Inc), U8(4),
+                B(Star), R(4),
                 B(CallJSRuntime), U8(%reflect_construct), R(2), U8(2),
                 B(LdaUndefined),
   /*  116 S> */ B(Return),

test/cctest/interpreter/bytecode_expectations/PropertyLoadStoreOneShot.golden

@@ -373,16 +373,16 @@ snippet: "
         a = [1.1, [2.2, 4.5]];
        
 "
-frame size: 5
+frame size: 3
 parameter count: 1
 bytecode array length: 20
 bytecodes: [
   /*    0 E> */ B(StackCheck),
   /*    7 S> */ B(LdaConstant), U8(0),
-                B(Star), R(3),
+                B(Star), R(1),
                 B(LdaSmi), I8(4),
-                B(Star), R(4),
-                B(CallRuntime), U16(Runtime::kCreateArrayLiteralWithoutAllocationSite), R(3), U8(2),
+                B(Star), R(2),
+                B(CallRuntime), U16(Runtime::kCreateArrayLiteralWithoutAllocationSite), R(1), U8(2),
   /*    9 E> */ B(StaGlobal), U8(1), U8(0),
                 B(Star), R(0),
   /*   36 S> */ B(Return),
@@ -400,16 +400,16 @@ snippet: "
         b = [];
        
 "
-frame size: 5
+frame size: 3
 parameter count: 1
 bytecode array length: 20
 bytecodes: [
   /*    0 E> */ B(StackCheck),
   /*    7 S> */ B(LdaConstant), U8(0),
-                B(Star), R(3),
+                B(Star), R(1),
                 B(LdaSmi), I8(37),
-                B(Star), R(4),
-                B(CallRuntime), U16(Runtime::kCreateArrayLiteralWithoutAllocationSite), R(3), U8(2),
+                B(Star), R(2),
+                B(CallRuntime), U16(Runtime::kCreateArrayLiteralWithoutAllocationSite), R(1), U8(2),
   /*    9 E> */ B(StaGlobal), U8(1), U8(0),
                 B(Star), R(0),
   /*   21 S> */ B(Return),

test/cctest/interpreter/bytecode_expectations/SuperCallAndSpread.golden

@@ -93,7 +93,7 @@ snippet: "
 "
 frame size: 13
 parameter count: 1
-bytecode array length: 130
+bytecode array length: 137
 bytecodes: [
                 B(CreateRestParameter),
                 B(Star), R(2),
@@ -103,51 +103,55 @@ bytecodes: [
   /*  140 S> */ B(Ldar), R(closure),
                 B(GetSuperConstructor), R(5),
                 B(CreateEmptyArrayLiteral), U8(0),
-                B(Star), R(7),
-                B(LdaZero),
                 B(Star), R(6),
+                B(LdaZero),
+                B(Star), R(7),
                 B(LdaSmi), I8(1),
-                B(StaInArrayLiteral), R(7), R(6), U8(1),
-                B(Ldar), R(6),
-                B(Inc), U8(3),
-  /*  152 S> */ B(Star), R(6),
-                B(LdaNamedProperty), R(2), U8(0), U8(4),
+                B(StaKeyedProperty), R(6), R(7), U8(1),
+                B(LdaConstant), U8(0),
+  /*  152 S> */ B(Star), R(7),
+                B(LdaNamedProperty), R(2), U8(1), U8(8),
                 B(Star), R(12),
-                B(CallProperty0), R(12), R(2), U8(6),
+                B(CallProperty0), R(12), R(2), U8(10),
                 B(Mov), R(2), R(11),
                 B(Mov), R(1), R(4),
                 B(JumpIfJSReceiver), U8(7),
                 B(CallRuntime), U16(Runtime::kThrowSymbolIteratorInvalid), R(0), U8(0),
                 B(Star), R(10),
-                B(LdaNamedProperty), R(10), U8(1), U8(8),
+                B(LdaNamedProperty), R(10), U8(2), U8(12),
                 B(Star), R(9),
-                B(CallProperty0), R(9), R(10), U8(10),
+                B(CallProperty0), R(9), R(10), U8(14),
                 B(Star), R(8),
                 B(JumpIfJSReceiver), U8(7),
                 B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(8), U8(1),
-                B(LdaNamedProperty), R(8), U8(2), U8(12),
+                B(LdaNamedProperty), R(8), U8(3), U8(16),
                 B(JumpIfToBooleanTrue), U8(21),
-                B(LdaNamedProperty), R(8), U8(3), U8(14),
+                B(LdaNamedProperty), R(8), U8(4), U8(18),
                 B(Star), R(8),
-                B(StaInArrayLiteral), R(7), R(6), U8(1),
-                B(Ldar), R(6),
-                B(Inc), U8(3),
-                B(Star), R(6),
+                B(StaInArrayLiteral), R(6), R(7), U8(3),
+                B(Ldar), R(7),
+                B(Inc), U8(5),
+                B(Star), R(7),
                 B(JumpLoop), U8(35), I8(0),
                 B(LdaSmi), I8(1),
-                B(StaInArrayLiteral), R(7), R(6), U8(1),
-                B(Mov), R(5), R(6),
-                B(Mov), R(0), R(8),
-  /*  140 E> */ B(CallJSRuntime), U8(%reflect_construct), R(6), U8(3),
-                B(Star), R(9),
+                B(StaInArrayLiteral), R(6), R(7), U8(3),
+                B(Ldar), R(7),
+                B(Inc), U8(5),
+                B(Star), R(7),
+                B(Mov), R(5), R(8),
+                B(Mov), R(6), R(9),
+                B(Mov), R(0), R(10),
+  /*  140 E> */ B(CallJSRuntime), U8(%reflect_construct), R(8), U8(3),
+                B(Star), R(11),
                 B(Ldar), R(this),
                 B(ThrowSuperAlreadyCalledIfNotHole),
-                B(Mov), R(9), R(this),
+                B(Mov), R(11), R(this),
                 B(Ldar), R(this),
                 B(ThrowSuperNotCalledIfHole),
   /*  162 S> */ B(Return),
 ]
 constant pool: [
+  Smi [1],
   SYMBOL_TYPE,
   ONE_BYTE_INTERNALIZED_STRING_TYPE ["next"],
   ONE_BYTE_INTERNALIZED_STRING_TYPE ["done"],

test/message/fail/map-arg-non-iterable.out

-*%(basename)s:5: TypeError: number 1 is not iterable (cannot read property Symbol(Symbol.iterator))
+*%(basename)s:5: TypeError: 1 is not iterable
 new Map(1);
 ^
-TypeError: number 1 is not iterable (cannot read property Symbol(Symbol.iterator))
+TypeError: 1 is not iterable
     at new Map (<anonymous>)
     at *%(basename)s:5:1

test/message/fail/undefined-keyed-property.out

@@ -2,8 +2,8 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-*%(basename)s:6: TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
+*%(basename)s:6: TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined
 x[Symbol.iterator];
  ^
-TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
+TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined
     at *%(basename)s:6:2

test/unittests/interpreter/bytecode-array-builder-unittest.cc

@@ -375,7 +375,6 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {
       .CreateRegExpLiteral(ast_factory.GetOneByteString("wide_literal"), 0, 0)
       .CreateArrayLiteral(0, 0, 0)
       .CreateEmptyArrayLiteral(0)
-      .CreateArrayFromIterable()
       .CreateObjectLiteral(0, 0, 0, reg)
       .CreateEmptyObjectLiteral()
       .CloneObject(reg, 0, 0);

test/webkit/fast/js/toString-overrides-expected.txt

@@ -28,10 +28,10 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
 
 PASS [1].toString() is '1'
 PASS [1].toLocaleString() is 'toLocaleString'
-FAIL [1].toLocaleString() should be 1. Threw exception TypeError: string "invalid" is not a function
+FAIL [1].toLocaleString() should be 1. Threw exception TypeError: string is not a function
 PASS [/r/].toString() is 'toString2'
 PASS [/r/].toLocaleString() is 'toLocaleString2'
-FAIL [/r/].toLocaleString() should be toString2. Threw exception TypeError: string "invalid" is not a function
+FAIL [/r/].toLocaleString() should be toString2. Threw exception TypeError: string is not a function
 PASS caught is true
 PASS successfullyParsed is true