Commit 6bf88852 authored by Benedikt Meurer's avatar Benedikt Meurer Committed by Commit Bot

[builtins] Remove obsolete PromiseBuiltinsAssembler::AppendPromiseCallback.

This method is now dead code since we introduced PromiseReaction chains
as linked lists.

Bug: v8:7253, v8:7310
Change-Id: I505a23d9ba4de456dbeeba9e603e70218cf6e767
Reviewed-on: https://chromium-review.googlesource.com/897515Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51052}
parent 338f3902
......@@ -256,30 +256,6 @@ void PromiseBuiltinsAssembler::PromiseSetHandledHint(Node* promise) {
StoreObjectFieldNoWriteBarrier(promise, JSPromise::kFlagsOffset, new_flags);
}
void PromiseBuiltinsAssembler::AppendPromiseCallback(int offset, Node* promise,
Node* value) {
Node* elements = LoadObjectField(promise, offset);
Node* length = LoadFixedArrayBaseLength(elements);
CodeStubAssembler::ParameterMode mode = OptimalParameterMode();
length = TaggedToParameter(length, mode);
Node* delta = IntPtrOrSmiConstant(1, mode);
Node* new_capacity = IntPtrOrSmiAdd(length, delta, mode);
const WriteBarrierMode barrier_mode = UPDATE_WRITE_BARRIER;
int additional_offset = 0;
ExtractFixedArrayFlags flags;
flags |= ExtractFixedArrayFlag::kFixedArrays;
Node* new_elements =
ExtractFixedArray(elements, nullptr, length, new_capacity, flags, mode);
StoreFixedArrayElement(new_elements, length, value, barrier_mode,
additional_offset, mode);
StoreObjectField(promise, offset, new_elements);
}
void PromiseBuiltinsAssembler::InternalPerformPromiseThen(Node* context,
Node* promise,
Node* on_fulfilled,
......
......@@ -121,9 +121,6 @@ class PromiseBuiltinsAssembler : public CodeStubAssembler {
void PromiseSetHasHandler(Node* promise);
void PromiseSetHandledHint(Node* promise);
void AppendPromiseCallback(int offset, compiler::Node* promise,
compiler::Node* value);
void InternalPerformPromiseThen(Node* context, Node* promise,
Node* on_fulfill, Node* on_reject,
Node* result);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment