• Jakob Linke's avatar
    [maglev] Keep receiver in a stack slot for OptimizedFrame::Summarize · de18a05e
    Jakob Linke authored
    For frame inspection (i.e. not deoptimization), no RegisterValues are
    available to TranslatedState and thus any register-allocated value is
    unavailable.
    
    Stack trace collection require `function` and `receiver` values to be
    available and thus stack-allocated. Both are immutable and have fixed
    stack slots so this is not a problem; we just lost track of the receiver
    inside Maglev when function parameters were wrapped inside exception Phi
    nodes.
    
    We solve this for now by special-casing the `receiver` to reuse the
    InitialValue node instead of creating a new Phi.
    
    Bug: v8:7700
    Change-Id: I4f4de9a643b98e2fcbc7ee7a53688cc97a8d6f1d
    Fixed: chromium:1359428
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3893856Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Auto-Submit: Jakob Linke <jgruber@chromium.org>
    Commit-Queue: Jakob Linke <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83164}
    de18a05e
maglev-graph.h 3.15 KB