• Jakob Linke's avatar
    [maglev] Keep receiver in a stack slot for OptimizedFrame::Summarize · de18a05e
    Jakob Linke authored
    For frame inspection (i.e. not deoptimization), no RegisterValues are
    available to TranslatedState and thus any register-allocated value is
    unavailable.
    
    Stack trace collection require `function` and `receiver` values to be
    available and thus stack-allocated. Both are immutable and have fixed
    stack slots so this is not a problem; we just lost track of the receiver
    inside Maglev when function parameters were wrapped inside exception Phi
    nodes.
    
    We solve this for now by special-casing the `receiver` to reuse the
    InitialValue node instead of creating a new Phi.
    
    Bug: v8:7700
    Change-Id: I4f4de9a643b98e2fcbc7ee7a53688cc97a8d6f1d
    Fixed: chromium:1359428
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3893856Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Auto-Submit: Jakob Linke <jgruber@chromium.org>
    Commit-Queue: Jakob Linke <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83164}
    de18a05e
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...