• Jakob Linke's avatar
    [maglev] Keep receiver in a stack slot for OptimizedFrame::Summarize · de18a05e
    Jakob Linke authored
    For frame inspection (i.e. not deoptimization), no RegisterValues are
    available to TranslatedState and thus any register-allocated value is
    unavailable.
    
    Stack trace collection require `function` and `receiver` values to be
    available and thus stack-allocated. Both are immutable and have fixed
    stack slots so this is not a problem; we just lost track of the receiver
    inside Maglev when function parameters were wrapped inside exception Phi
    nodes.
    
    We solve this for now by special-casing the `receiver` to reuse the
    InitialValue node instead of creating a new Phi.
    
    Bug: v8:7700
    Change-Id: I4f4de9a643b98e2fcbc7ee7a53688cc97a8d6f1d
    Fixed: chromium:1359428
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3893856Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Auto-Submit: Jakob Linke <jgruber@chromium.org>
    Commit-Queue: Jakob Linke <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83164}
    de18a05e
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...