• clemensh's avatar
    [base] Pass scalar arguments by value in CHECK/DCHECK · 76723502
    clemensh authored
    This not only potentially improves performance, but also avoids weird
    linker errors, like the one below, where I used Smi::kMinValue in a
    DCHECK_EQ.
    
    > [421/649] LINK ./mksnapshot
    > FAILED: mksnapshot
    > src/base/logging.h|178| error: undefined reference to
      'v8::internal::Smi::kMinValue'
    
    R=bmeurer@chromium.org, ishell@chromium.org
    
    Review-Url: https://codereview.chromium.org/2524093002
    Cr-Commit-Position: refs/heads/master@{#41273}
    76723502
logging-unittest.cc 721 Bytes