• clemensh's avatar
    [base] Pass scalar arguments by value in CHECK/DCHECK · 76723502
    clemensh authored
    This not only potentially improves performance, but also avoids weird
    linker errors, like the one below, where I used Smi::kMinValue in a
    DCHECK_EQ.
    
    > [421/649] LINK ./mksnapshot
    > FAILED: mksnapshot
    > src/base/logging.h|178| error: undefined reference to
      'v8::internal::Smi::kMinValue'
    
    R=bmeurer@chromium.org, ishell@chromium.org
    
    Review-Url: https://codereview.chromium.org/2524093002
    Cr-Commit-Position: refs/heads/master@{#41273}
    76723502
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...