• clemensh's avatar
    [base] Pass scalar arguments by value in CHECK/DCHECK · 76723502
    clemensh authored
    This not only potentially improves performance, but also avoids weird
    linker errors, like the one below, where I used Smi::kMinValue in a
    DCHECK_EQ.
    
    > [421/649] LINK ./mksnapshot
    > FAILED: mksnapshot
    > src/base/logging.h|178| error: undefined reference to
      'v8::internal::Smi::kMinValue'
    
    R=bmeurer@chromium.org, ishell@chromium.org
    
    Review-Url: https://codereview.chromium.org/2524093002
    Cr-Commit-Position: refs/heads/master@{#41273}
    76723502
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
simdjs Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...