• Dominik Inführ's avatar
    [heap] Do not zap freed memory in NotifyObjectSizeChange · 234c904d
    Dominik Inführ authored
    Avoid zapping freed memory in NotifyObjectSizeChange. This fixes the
    linked performance regression introduced with
    https://crrrev.com/c/3607992. Beginning with that CL we would always
    zap freed memory on the main thread, while previously we only did this
    in CreateFillerForArray when the FixedArray could actually contain
    references.
    
    While we could restore the previous behaviour as well, we simply stop
    zapping freed memory in NotifyObjectSizeChange altogether for better
    throughput. The reason for zapping was to reduce floating garbage.
    However this is only relevant for incremental marking which is only
    enabled for about <1% of the overall runtime.
    
    Bug: v8:12578, chromium:1322882
    Change-Id: I004ee712b924c53edac87810504d04aa7f4a50d8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3634960Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80438}
    234c904d
heap.cc 271 KB