• Dominik Inführ's avatar
    [heap] Do not zap freed memory in NotifyObjectSizeChange · 234c904d
    Dominik Inführ authored
    Avoid zapping freed memory in NotifyObjectSizeChange. This fixes the
    linked performance regression introduced with
    https://crrrev.com/c/3607992. Beginning with that CL we would always
    zap freed memory on the main thread, while previously we only did this
    in CreateFillerForArray when the FixedArray could actually contain
    references.
    
    While we could restore the previous behaviour as well, we simply stop
    zapping freed memory in NotifyObjectSizeChange altogether for better
    throughput. The reason for zapping was to reduce floating garbage.
    However this is only relevant for incremental marking which is only
    enabled for about <1% of the overall runtime.
    
    Bug: v8:12578, chromium:1322882
    Change-Id: I004ee712b924c53edac87810504d04aa7f4a50d8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3634960Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80438}
    234c904d
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...