common-operator-reducer.cc 18.6 KB
Newer Older
1 2 3 4 5 6
// Copyright 2014 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "src/compiler/common-operator-reducer.h"

7 8
#include <algorithm>

9
#include "src/compiler/common-operator.h"
10 11
#include "src/compiler/graph.h"
#include "src/compiler/machine-operator.h"
12
#include "src/compiler/node.h"
13
#include "src/compiler/node-matchers.h"
14
#include "src/compiler/node-properties.h"
15 16 17 18 19

namespace v8 {
namespace internal {
namespace compiler {

20 21
namespace {

22
Decision DecideCondition(JSHeapBroker* broker, Node* const cond) {
23 24 25 26 27 28
  switch (cond->opcode()) {
    case IrOpcode::kInt32Constant: {
      Int32Matcher mcond(cond);
      return mcond.Value() ? Decision::kTrue : Decision::kFalse;
    }
    case IrOpcode::kHeapConstant: {
29
      HeapObjectMatcher mcond(cond);
30 31
      return mcond.Ref(broker).BooleanValue() ? Decision::kTrue
                                              : Decision::kFalse;
32 33 34 35 36 37 38 39
    }
    default:
      return Decision::kUnknown;
  }
}

}  // namespace

40
CommonOperatorReducer::CommonOperatorReducer(Editor* editor, Graph* graph,
41
                                             JSHeapBroker* broker,
42
                                             CommonOperatorBuilder* common,
43 44
                                             MachineOperatorBuilder* machine,
                                             Zone* temp_zone)
45 46
    : AdvancedReducer(editor),
      graph_(graph),
47
      broker_(broker),
48 49
      common_(common),
      machine_(machine),
50 51
      dead_(graph->NewNode(common->Dead())),
      zone_(temp_zone) {
52 53
  NodeProperties::SetType(dead_, Type::None());
}
54

55
Reduction CommonOperatorReducer::Reduce(Node* node) {
56
  DisallowHeapAccess no_heap_access;
57
  switch (node->opcode()) {
58 59
    case IrOpcode::kBranch:
      return ReduceBranch(node);
60 61 62
    case IrOpcode::kDeoptimizeIf:
    case IrOpcode::kDeoptimizeUnless:
      return ReduceDeoptimizeConditional(node);
63 64
    case IrOpcode::kMerge:
      return ReduceMerge(node);
65
    case IrOpcode::kEffectPhi:
66 67 68
      return ReduceEffectPhi(node);
    case IrOpcode::kPhi:
      return ReducePhi(node);
69 70
    case IrOpcode::kReturn:
      return ReduceReturn(node);
71 72
    case IrOpcode::kSelect:
      return ReduceSelect(node);
73 74
    case IrOpcode::kSwitch:
      return ReduceSwitch(node);
75 76
    case IrOpcode::kStaticAssert:
      return ReduceStaticAssert(node);
77
    default:
78
      break;
79 80 81 82 83
  }
  return NoChange();
}


84 85 86
Reduction CommonOperatorReducer::ReduceBranch(Node* node) {
  DCHECK_EQ(IrOpcode::kBranch, node->opcode());
  Node* const cond = node->InputAt(0);
87 88 89
  // Swap IfTrue/IfFalse on {branch} if {cond} is a BooleanNot and use the input
  // to BooleanNot as new condition for {branch}. Note we assume that {cond} was
  // already properly optimized before we get here (as guaranteed by the graph
90 91 92 93
  // reduction logic). The same applies if {cond} is a Select acting as boolean
  // not (i.e. true being returned in the false case and vice versa).
  if (cond->opcode() == IrOpcode::kBooleanNot ||
      (cond->opcode() == IrOpcode::kSelect &&
94 95
       DecideCondition(broker(), cond->InputAt(1)) == Decision::kFalse &&
       DecideCondition(broker(), cond->InputAt(2)) == Decision::kTrue)) {
96 97 98
    for (Node* const use : node->uses()) {
      switch (use->opcode()) {
        case IrOpcode::kIfTrue:
99
          NodeProperties::ChangeOp(use, common()->IfFalse());
100 101
          break;
        case IrOpcode::kIfFalse:
102
          NodeProperties::ChangeOp(use, common()->IfTrue());
103 104 105 106 107 108 109 110 111
          break;
        default:
          UNREACHABLE();
      }
    }
    // Update the condition of {branch}. No need to mark the uses for revisit,
    // since we tell the graph reducer that the {branch} was changed and the
    // graph reduction logic will ensure that the uses are revisited properly.
    node->ReplaceInput(0, cond->InputAt(0));
112
    // Negate the hint for {branch}.
113 114
    NodeProperties::ChangeOp(
        node, common()->Branch(NegateBranchHint(BranchHintOf(node->op()))));
115 116
    return Changed(node);
  }
117
  Decision const decision = DecideCondition(broker(), cond);
118 119 120 121 122
  if (decision == Decision::kUnknown) return NoChange();
  Node* const control = node->InputAt(1);
  for (Node* const use : node->uses()) {
    switch (use->opcode()) {
      case IrOpcode::kIfTrue:
123
        Replace(use, (decision == Decision::kTrue) ? control : dead());
124 125
        break;
      case IrOpcode::kIfFalse:
126
        Replace(use, (decision == Decision::kFalse) ? control : dead());
127 128 129 130 131
        break;
      default:
        UNREACHABLE();
    }
  }
132
  return Replace(dead());
133 134
}

135 136 137 138
Reduction CommonOperatorReducer::ReduceDeoptimizeConditional(Node* node) {
  DCHECK(node->opcode() == IrOpcode::kDeoptimizeIf ||
         node->opcode() == IrOpcode::kDeoptimizeUnless);
  bool condition_is_true = node->opcode() == IrOpcode::kDeoptimizeUnless;
139
  DeoptimizeParameters p = DeoptimizeParametersOf(node->op());
140 141 142 143 144 145 146 147 148 149
  Node* condition = NodeProperties::GetValueInput(node, 0);
  Node* frame_state = NodeProperties::GetValueInput(node, 1);
  Node* effect = NodeProperties::GetEffectInput(node);
  Node* control = NodeProperties::GetControlInput(node);
  // Swap DeoptimizeIf/DeoptimizeUnless on {node} if {cond} is a BooleaNot
  // and use the input to BooleanNot as new condition for {node}.  Note we
  // assume that {cond} was already properly optimized before we get here
  // (as guaranteed by the graph reduction logic).
  if (condition->opcode() == IrOpcode::kBooleanNot) {
    NodeProperties::ReplaceValueInput(node, condition->InputAt(0), 0);
150
    NodeProperties::ChangeOp(
151 152 153 154
        node,
        condition_is_true
            ? common()->DeoptimizeIf(p.kind(), p.reason(), p.feedback())
            : common()->DeoptimizeUnless(p.kind(), p.reason(), p.feedback()));
155 156
    return Changed(node);
  }
157
  Decision const decision = DecideCondition(broker(), condition);
158 159
  if (decision == Decision::kUnknown) return NoChange();
  if (condition_is_true == (decision == Decision::kTrue)) {
160 161
    ReplaceWithValue(node, dead(), effect, control);
  } else {
162
    control = graph()->NewNode(
163 164
        common()->Deoptimize(p.kind(), p.reason(), p.feedback()), frame_state,
        effect, control);
165 166 167
    // TODO(bmeurer): This should be on the AdvancedReducer somehow.
    NodeProperties::MergeControlToEnd(graph(), common(), control);
    Revisit(graph()->end());
168 169 170
  }
  return Replace(dead());
}
171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199

Reduction CommonOperatorReducer::ReduceMerge(Node* node) {
  DCHECK_EQ(IrOpcode::kMerge, node->opcode());
  //
  // Check if this is a merge that belongs to an unused diamond, which means
  // that:
  //
  //  a) the {Merge} has no {Phi} or {EffectPhi} uses, and
  //  b) the {Merge} has two inputs, one {IfTrue} and one {IfFalse}, which are
  //     both owned by the Merge, and
  //  c) and the {IfTrue} and {IfFalse} nodes point to the same {Branch}.
  //
  if (node->InputCount() == 2) {
    for (Node* const use : node->uses()) {
      if (IrOpcode::IsPhiOpcode(use->opcode())) return NoChange();
    }
    Node* if_true = node->InputAt(0);
    Node* if_false = node->InputAt(1);
    if (if_true->opcode() != IrOpcode::kIfTrue) std::swap(if_true, if_false);
    if (if_true->opcode() == IrOpcode::kIfTrue &&
        if_false->opcode() == IrOpcode::kIfFalse &&
        if_true->InputAt(0) == if_false->InputAt(0) && if_true->OwnedBy(node) &&
        if_false->OwnedBy(node)) {
      Node* const branch = if_true->InputAt(0);
      DCHECK_EQ(IrOpcode::kBranch, branch->opcode());
      DCHECK(branch->OwnedBy(if_true, if_false));
      Node* const control = branch->InputAt(1);
      // Mark the {branch} as {Dead}.
      branch->TrimInputCount(0);
200
      NodeProperties::ChangeOp(branch, common()->Dead());
201 202 203 204 205 206 207
      return Replace(control);
    }
  }
  return NoChange();
}


208 209
Reduction CommonOperatorReducer::ReduceEffectPhi(Node* node) {
  DCHECK_EQ(IrOpcode::kEffectPhi, node->opcode());
210 211 212 213
  Node::Inputs inputs = node->inputs();
  int const effect_input_count = inputs.count() - 1;
  DCHECK_LE(1, effect_input_count);
  Node* const merge = inputs[effect_input_count];
214
  DCHECK(IrOpcode::IsMergeOpcode(merge->opcode()));
215 216
  DCHECK_EQ(effect_input_count, merge->InputCount());
  Node* const effect = inputs[0];
217
  DCHECK_NE(node, effect);
218 219
  for (int i = 1; i < effect_input_count; ++i) {
    Node* const input = inputs[i];
220 221 222 223
    if (input == node) {
      // Ignore redundant inputs.
      DCHECK_EQ(IrOpcode::kLoop, merge->opcode());
      continue;
224
    }
225
    if (input != effect) return NoChange();
226
  }
227 228 229
  // We might now be able to further reduce the {merge} node.
  Revisit(merge);
  return Replace(effect);
230 231 232 233 234
}


Reduction CommonOperatorReducer::ReducePhi(Node* node) {
  DCHECK_EQ(IrOpcode::kPhi, node->opcode());
235 236 237 238
  Node::Inputs inputs = node->inputs();
  int const value_input_count = inputs.count() - 1;
  DCHECK_LE(1, value_input_count);
  Node* const merge = inputs[value_input_count];
239
  DCHECK(IrOpcode::IsMergeOpcode(merge->opcode()));
240 241 242 243 244 245 246
  DCHECK_EQ(value_input_count, merge->InputCount());
  if (value_input_count == 2) {
    Node* vtrue = inputs[0];
    Node* vfalse = inputs[1];
    Node::Inputs merge_inputs = merge->inputs();
    Node* if_true = merge_inputs[0];
    Node* if_false = merge_inputs[1];
247 248 249 250 251 252 253 254
    if (if_true->opcode() != IrOpcode::kIfTrue) {
      std::swap(if_true, if_false);
      std::swap(vtrue, vfalse);
    }
    if (if_true->opcode() == IrOpcode::kIfTrue &&
        if_false->opcode() == IrOpcode::kIfFalse &&
        if_true->InputAt(0) == if_false->InputAt(0)) {
      Node* const branch = if_true->InputAt(0);
255 256
      // Check that the branch is not dead already.
      if (branch->opcode() != IrOpcode::kBranch) return NoChange();
257
      Node* const cond = branch->InputAt(0);
258 259 260
      if (cond->opcode() == IrOpcode::kFloat32LessThan) {
        Float32BinopMatcher mcond(cond);
        if (mcond.left().Is(0.0) && mcond.right().Equals(vtrue) &&
261
            vfalse->opcode() == IrOpcode::kFloat32Sub) {
262 263
          Float32BinopMatcher mvfalse(vfalse);
          if (mvfalse.left().IsZero() && mvfalse.right().Equals(vtrue)) {
264 265
            // We might now be able to further reduce the {merge} node.
            Revisit(merge);
266 267 268 269 270 271
            return Change(node, machine()->Float32Abs(), vtrue);
          }
        }
      } else if (cond->opcode() == IrOpcode::kFloat64LessThan) {
        Float64BinopMatcher mcond(cond);
        if (mcond.left().Is(0.0) && mcond.right().Equals(vtrue) &&
272
            vfalse->opcode() == IrOpcode::kFloat64Sub) {
273 274
          Float64BinopMatcher mvfalse(vfalse);
          if (mvfalse.left().IsZero() && mvfalse.right().Equals(vtrue)) {
275 276
            // We might now be able to further reduce the {merge} node.
            Revisit(merge);
277 278 279
            return Change(node, machine()->Float64Abs(), vtrue);
          }
        }
280 281
      }
    }
282
  }
283
  Node* const value = inputs[0];
284
  DCHECK_NE(node, value);
285 286
  for (int i = 1; i < value_input_count; ++i) {
    Node* const input = inputs[i];
287 288 289 290
    if (input == node) {
      // Ignore redundant inputs.
      DCHECK_EQ(IrOpcode::kLoop, merge->opcode());
      continue;
291
    }
292
    if (input != value) return NoChange();
293
  }
294 295 296
  // We might now be able to further reduce the {merge} node.
  Revisit(merge);
  return Replace(value);
297 298
}

299 300
Reduction CommonOperatorReducer::ReduceReturn(Node* node) {
  DCHECK_EQ(IrOpcode::kReturn, node->opcode());
301 302 303 304 305 306
  Node* effect = NodeProperties::GetEffectInput(node);
  if (effect->opcode() == IrOpcode::kCheckpoint) {
    // Any {Return} node can never be used to insert a deoptimization point,
    // hence checkpoints can be cut out of the effect chain flowing into it.
    effect = NodeProperties::GetEffectInput(effect);
    NodeProperties::ReplaceEffectInput(node, effect);
307 308
    Reduction const reduction = ReduceReturn(node);
    return reduction.Changed() ? reduction : Changed(node);
309
  }
310 311 312 313
  // TODO(ahaas): Extend the reduction below to multiple return values.
  if (ValueInputCountOfReturn(node->op()) != 1) {
    return NoChange();
  }
314 315 316
  Node* pop_count = NodeProperties::GetValueInput(node, 0);
  Node* value = NodeProperties::GetValueInput(node, 1);
  Node* control = NodeProperties::GetControlInput(node);
317 318 319
  if (value->opcode() == IrOpcode::kPhi &&
      NodeProperties::GetControlInput(value) == control &&
      control->opcode() == IrOpcode::kMerge) {
320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339
    // This optimization pushes {Return} nodes through merges. It checks that
    // the return value is actually a {Phi} and the return control dependency
    // is the {Merge} to which the {Phi} belongs.

    // Value1 ... ValueN Control1 ... ControlN
    //   ^          ^       ^            ^
    //   |          |       |            |
    //   +----+-----+       +------+-----+
    //        |                    |
    //       Phi --------------> Merge
    //        ^                    ^
    //        |                    |
    //        |  +-----------------+
    //        |  |
    //       Return -----> Effect
    //         ^
    //         |
    //        End

    // Now the effect input to the {Return} node can be either an {EffectPhi}
340 341 342
    // hanging off the same {Merge}, or the effect chain doesn't depend on the
    // {Phi} or the {Merge}, in which case we know that the effect input must
    // somehow dominate all merged branches.
343

344 345 346 347
    Node::Inputs control_inputs = control->inputs();
    Node::Inputs value_inputs = value->inputs();
    DCHECK_NE(0, control_inputs.count());
    DCHECK_EQ(control_inputs.count(), value_inputs.count() - 1);
348 349
    DCHECK_EQ(IrOpcode::kEnd, graph()->end()->opcode());
    DCHECK_NE(0, graph()->end()->InputCount());
350
    if (control->OwnedBy(node, value) && value->OwnedBy(node)) {
351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378
      for (int i = 0; i < control_inputs.count(); ++i) {
        // Create a new {Return} and connect it to {end}. We don't need to mark
        // {end} as revisit, because we mark {node} as {Dead} below, which was
        // previously connected to {end}, so we know for sure that at some point
        // the reducer logic will visit {end} again.
        Node* ret = graph()->NewNode(node->op(), pop_count, value_inputs[i],
                                     effect, control_inputs[i]);
        NodeProperties::MergeControlToEnd(graph(), common(), ret);
      }
      // Mark the Merge {control} and Return {node} as {dead}.
      Replace(control, dead());
      return Replace(dead());
    } else if (effect->opcode() == IrOpcode::kEffectPhi &&
               NodeProperties::GetControlInput(effect) == control) {
      Node::Inputs effect_inputs = effect->inputs();
      DCHECK_EQ(control_inputs.count(), effect_inputs.count() - 1);
      for (int i = 0; i < control_inputs.count(); ++i) {
        // Create a new {Return} and connect it to {end}. We don't need to mark
        // {end} as revisit, because we mark {node} as {Dead} below, which was
        // previously connected to {end}, so we know for sure that at some point
        // the reducer logic will visit {end} again.
        Node* ret = graph()->NewNode(node->op(), pop_count, value_inputs[i],
                                     effect_inputs[i], control_inputs[i]);
        NodeProperties::MergeControlToEnd(graph(), common(), ret);
      }
      // Mark the Merge {control} and Return {node} as {dead}.
      Replace(control, dead());
      return Replace(dead());
379 380
    }
  }
381
  return NoChange();
382 383
}

384 385
Reduction CommonOperatorReducer::ReduceSelect(Node* node) {
  DCHECK_EQ(IrOpcode::kSelect, node->opcode());
386 387 388
  Node* const cond = node->InputAt(0);
  Node* const vtrue = node->InputAt(1);
  Node* const vfalse = node->InputAt(2);
389
  if (vtrue == vfalse) return Replace(vtrue);
390
  switch (DecideCondition(broker(), cond)) {
391 392 393 394 395 396 397
    case Decision::kTrue:
      return Replace(vtrue);
    case Decision::kFalse:
      return Replace(vfalse);
    case Decision::kUnknown:
      break;
  }
398 399 400 401
  switch (cond->opcode()) {
    case IrOpcode::kFloat32LessThan: {
      Float32BinopMatcher mcond(cond);
      if (mcond.left().Is(0.0) && mcond.right().Equals(vtrue) &&
402
          vfalse->opcode() == IrOpcode::kFloat32Sub) {
403 404 405 406
        Float32BinopMatcher mvfalse(vfalse);
        if (mvfalse.left().IsZero() && mvfalse.right().Equals(vtrue)) {
          return Change(node, machine()->Float32Abs(), vtrue);
        }
407
      }
408
      break;
409
    }
410 411 412
    case IrOpcode::kFloat64LessThan: {
      Float64BinopMatcher mcond(cond);
      if (mcond.left().Is(0.0) && mcond.right().Equals(vtrue) &&
413
          vfalse->opcode() == IrOpcode::kFloat64Sub) {
414 415 416 417 418 419
        Float64BinopMatcher mvfalse(vfalse);
        if (mvfalse.left().IsZero() && mvfalse.right().Equals(vtrue)) {
          return Change(node, machine()->Float64Abs(), vtrue);
        }
      }
      break;
420
    }
421 422
    default:
      break;
423 424 425 426
  }
  return NoChange();
}

427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446
Reduction CommonOperatorReducer::ReduceSwitch(Node* node) {
  DCHECK_EQ(IrOpcode::kSwitch, node->opcode());
  Node* const switched_value = node->InputAt(0);
  Node* const control = node->InputAt(1);

  // Attempt to constant match the switched value against the IfValue cases. If
  // no case matches, then use the IfDefault. We don't bother marking
  // non-matching cases as dead code (same for an unused IfDefault), because the
  // Switch itself will be marked as dead code.
  Int32Matcher mswitched(switched_value);
  if (mswitched.HasValue()) {
    bool matched = false;

    size_t const projection_count = node->op()->ControlOutputCount();
    Node** projections = zone_->NewArray<Node*>(projection_count);
    NodeProperties::CollectControlProjections(node, projections,
                                              projection_count);
    for (size_t i = 0; i < projection_count - 1; i++) {
      Node* if_value = projections[i];
      DCHECK_EQ(IrOpcode::kIfValue, if_value->opcode());
447 448
      const IfValueParameters& p = IfValueParametersOf(if_value->op());
      if (p.value() == mswitched.Value()) {
449 450 451 452 453 454 455 456 457 458 459 460 461 462
        matched = true;
        Replace(if_value, control);
        break;
      }
    }
    if (!matched) {
      Node* if_default = projections[projection_count - 1];
      DCHECK_EQ(IrOpcode::kIfDefault, if_default->opcode());
      Replace(if_default, control);
    }
    return Replace(dead());
  }
  return NoChange();
}
463

464 465 466 467 468 469 470 471 472 473 474 475
Reduction CommonOperatorReducer::ReduceStaticAssert(Node* node) {
  DCHECK_EQ(IrOpcode::kStaticAssert, node->opcode());
  Node* const cond = node->InputAt(0);
  Decision decision = DecideCondition(broker(), cond);
  if (decision == Decision::kTrue) {
    RelaxEffectsAndControls(node);
    return Changed(node);
  } else {
    return NoChange();
  }
}

476 477 478 479
Reduction CommonOperatorReducer::Change(Node* node, Operator const* op,
                                        Node* a) {
  node->ReplaceInput(0, a);
  node->TrimInputCount(1);
480
  NodeProperties::ChangeOp(node, op);
481 482 483 484 485 486 487 488 489
  return Changed(node);
}


Reduction CommonOperatorReducer::Change(Node* node, Operator const* op, Node* a,
                                        Node* b) {
  node->ReplaceInput(0, a);
  node->ReplaceInput(1, b);
  node->TrimInputCount(2);
490
  NodeProperties::ChangeOp(node, op);
491 492 493
  return Changed(node);
}

494 495 496
}  // namespace compiler
}  // namespace internal
}  // namespace v8