[turbofan] Optimize silent hole checks on legacy const context slots.

Currently we always generate a diamond in the graph builder for every
legacy const context slot, which we cannot get rid of until late control
reduction, even if we know after context specialization that the slot is
already initialized.

Now we generate a select instead, which the CommonOperatorReducer
happily removes during typed lowering. This greatly speeds up asm.js
code generated by Emscripten with the new POINTER_MASKING mode.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/1072353002

Cr-Commit-Position: refs/heads/master@{#27739}

src/compiler/ast-graph-builder.cc

@@ -2728,16 +2728,10 @@ Node* AstGraphBuilder::BuildRestArgumentsArray(Variable* rest, int index) {
 
 Node* AstGraphBuilder::BuildHoleCheckSilent(Node* value, Node* for_hole,
                                             Node* not_hole) {
-  IfBuilder hole_check(this);
   Node* the_hole = jsgraph()->TheHoleConstant();
   Node* check = NewNode(javascript()->StrictEqual(), value, the_hole);
-  hole_check.If(check);
-  hole_check.Then();
-  environment()->Push(for_hole);
-  hole_check.Else();
-  environment()->Push(not_hole);
-  hole_check.End();
-  return environment()->Pop();
+  return NewNode(common()->Select(kMachAnyTagged, BranchHint::kFalse), check,
+                 for_hole, not_hole);
 }
 
 

src/compiler/common-operator-reducer.cc

@@ -109,40 +109,51 @@ Reduction CommonOperatorReducer::ReduceSelect(Node* node) {
   Node* vtrue = NodeProperties::GetValueInput(node, 1);
   Node* vfalse = NodeProperties::GetValueInput(node, 2);
   if (vtrue == vfalse) return Replace(vtrue);
-  if (cond->opcode() == IrOpcode::kFloat32LessThan) {
-    Float32BinopMatcher mcond(cond);
-    if (mcond.left().Is(0.0) && mcond.right().Equals(vtrue) &&
-        vfalse->opcode() == IrOpcode::kFloat32Sub &&
-        machine()->HasFloat32Abs()) {
-      Float32BinopMatcher mvfalse(vfalse);
-      if (mvfalse.left().IsZero() && mvfalse.right().Equals(vtrue)) {
-        return Change(node, machine()->Float32Abs(), vtrue);
-      }
-    }
-    if (mcond.left().Equals(vtrue) && mcond.right().Equals(vfalse) &&
-        machine()->HasFloat32Min()) {
-      return Change(node, machine()->Float32Min(), vtrue, vfalse);
-    } else if (mcond.left().Equals(vfalse) && mcond.right().Equals(vtrue) &&
-               machine()->HasFloat32Max()) {
-      return Change(node, machine()->Float32Max(), vtrue, vfalse);
+  switch (cond->opcode()) {
+    case IrOpcode::kHeapConstant: {
+      HeapObjectMatcher<HeapObject> mcond(cond);
+      return Replace(mcond.Value().handle()->BooleanValue() ? vtrue : vfalse);
     }
-  } else if (cond->opcode() == IrOpcode::kFloat64LessThan) {
-    Float64BinopMatcher mcond(cond);
-    if (mcond.left().Is(0.0) && mcond.right().Equals(vtrue) &&
-        vfalse->opcode() == IrOpcode::kFloat64Sub &&
-        machine()->HasFloat64Abs()) {
-      Float64BinopMatcher mvfalse(vfalse);
-      if (mvfalse.left().IsZero() && mvfalse.right().Equals(vtrue)) {
-        return Change(node, machine()->Float64Abs(), vtrue);
+    case IrOpcode::kFloat32LessThan: {
+      Float32BinopMatcher mcond(cond);
+      if (mcond.left().Is(0.0) && mcond.right().Equals(vtrue) &&
+          vfalse->opcode() == IrOpcode::kFloat32Sub &&
+          machine()->HasFloat32Abs()) {
+        Float32BinopMatcher mvfalse(vfalse);
+        if (mvfalse.left().IsZero() && mvfalse.right().Equals(vtrue)) {
+          return Change(node, machine()->Float32Abs(), vtrue);
+        }
       }
+      if (mcond.left().Equals(vtrue) && mcond.right().Equals(vfalse) &&
+          machine()->HasFloat32Min()) {
+        return Change(node, machine()->Float32Min(), vtrue, vfalse);
+      } else if (mcond.left().Equals(vfalse) && mcond.right().Equals(vtrue) &&
+                 machine()->HasFloat32Max()) {
+        return Change(node, machine()->Float32Max(), vtrue, vfalse);
+      }
+      break;
     }
-    if (mcond.left().Equals(vtrue) && mcond.right().Equals(vfalse) &&
-        machine()->HasFloat64Min()) {
-      return Change(node, machine()->Float64Min(), vtrue, vfalse);
-    } else if (mcond.left().Equals(vfalse) && mcond.right().Equals(vtrue) &&
-               machine()->HasFloat64Max()) {
-      return Change(node, machine()->Float64Max(), vtrue, vfalse);
+    case IrOpcode::kFloat64LessThan: {
+      Float64BinopMatcher mcond(cond);
+      if (mcond.left().Is(0.0) && mcond.right().Equals(vtrue) &&
+          vfalse->opcode() == IrOpcode::kFloat64Sub &&
+          machine()->HasFloat64Abs()) {
+        Float64BinopMatcher mvfalse(vfalse);
+        if (mvfalse.left().IsZero() && mvfalse.right().Equals(vtrue)) {
+          return Change(node, machine()->Float64Abs(), vtrue);
+        }
+      }
+      if (mcond.left().Equals(vtrue) && mcond.right().Equals(vfalse) &&
+          machine()->HasFloat64Min()) {
+        return Change(node, machine()->Float64Min(), vtrue, vfalse);
+      } else if (mcond.left().Equals(vfalse) && mcond.right().Equals(vtrue) &&
+                 machine()->HasFloat64Max()) {
+        return Change(node, machine()->Float64Max(), vtrue, vfalse);
+      }
+      break;
     }
+    default:
+      break;
   }
   return NoChange();
 }

test/mjsunit/asm/pointer-masking.js

+// Copyright 2015 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+var stdlib = this;
+var foreign = {};
+var heap = new ArrayBuffer(64 * 1024);
+
+
+var pm1 = (function(stdlib, foreign, heap) {
+  "use asm";
+  var HEAP8 = new stdlib.Int8Array(heap);
+  const MASK1 = 1023;
+  function load1(i) {
+    i = i|0;
+    var j = 0;
+    j = HEAP8[(i & MASK1)]|0;
+    return j|0;
+  }
+  function store1(i, j) {
+    i = i|0;
+    j = j|0;
+    HEAP8[(i & MASK1)] = j;
+  }
+  return {load1: load1, store1: store1};
+})(stdlib, foreign, heap);
+
+assertEquals(0, pm1.load1(0));
+assertEquals(0, pm1.load1(1025));
+pm1.store1(0, 1);
+pm1.store1(1025, 127);
+assertEquals(1, pm1.load1(0));
+assertEquals(1, pm1.load1(1024));
+assertEquals(127, pm1.load1(1));
+assertEquals(127, pm1.load1(1025));

test/unittests/compiler/common-operator-reducer-unittest.cc

@@ -221,6 +221,28 @@ TEST_F(CommonOperatorReducerTest, RedundantSelect) {
 }
 
 
+TEST_F(CommonOperatorReducerTest, SelectWithFalseConstant) {
+  Node* p0 = Parameter(0);
+  Node* p1 = Parameter(1);
+  Node* select = graph()->NewNode(common()->Select(kMachAnyTagged),
+                                  FalseConstant(), p0, p1);
+  Reduction r = Reduce(select);
+  ASSERT_TRUE(r.Changed());
+  EXPECT_EQ(p1, r.replacement());
+}
+
+
+TEST_F(CommonOperatorReducerTest, SelectWithTrueConstant) {
+  Node* p0 = Parameter(0);
+  Node* p1 = Parameter(1);
+  Node* select = graph()->NewNode(common()->Select(kMachAnyTagged),
+                                  TrueConstant(), p0, p1);
+  Reduction r = Reduce(select);
+  ASSERT_TRUE(r.Changed());
+  EXPECT_EQ(p0, r.replacement());
+}
+
+
 TEST_F(CommonOperatorReducerTest, SelectToFloat32Abs) {
   Node* p0 = Parameter(0);
   Node* c0 = Float32Constant(0.0);