- 06 Dec, 2018 2 commits
-
-
Takuto Ikuta authored
TBR=dpranke@chromium.org Bug: 900161 Change-Id: I5e481f04f281fddb08724fd27630a3fb926c5d1b Reviewed-on: https://chromium-review.googlesource.com/c/1365196Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
-
Vadim Shtayura authored
This picks up the following changes: https://chromium.googlesource.com/infra/luci/luci-go/+log/233800ef6928..d052999e151b/cipd R=iannucci@google.com, tandrii@google.com BUG=911229 Change-Id: I3dbe7fc2db1cae876d0acdd3f8e4299e96af9d37 Reviewed-on: https://chromium-review.googlesource.com/c/1363879Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
- 05 Dec, 2018 4 commits
-
-
John Budorick authored
This is a speculative fix for subprocess being unable to find string-escape later in execution; the theory being that something (unclear what) is interfering w/ codecs' lookup logic and that calling lookup earlier would allow string-escape to be cached before any such interference. See crbug.com/912292#c2 for more. Bug: 912292 Change-Id: I0abdd394253c9a4984db7c6c81d044087edc68fd Reviewed-on: https://chromium-review.googlesource.com/c/1363753Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Clemens Hammacher authored
This reverts commit ba83229a. Reason for revert: After mail discussion we came to the conclusion that the old behavior makes more sense. Original change's description: > Fix semantics of git new-branch --upstream > > Currently, the "--upstream A" option for new-branch behaves totally > different than "--upstream_current". While "--upstream A" checks out > branch A and then creates a new branch which tracks A, > "--upstream_current" creates a new branch for the current HEAD and sets > the upstream to the previously checked out branch. > > As the documentation does not mention that any of the options changes > the currently-checked-out commit (HEAD), this CL changes the semantics > of "git new-branch --upstream A B" to be identical to "git checkout -b B > && git branch --set-upstream-to A". > > It also slightly extends the documentation to mention that in any case > the new branch is based on HEAD. > > R=iannucci@chromium.org > > Change-Id: Ic335d2caf27cb6afca1b8bc5a008424c0e880fca > Reviewed-on: https://chromium-review.googlesource.com/c/1350748 > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Auto-Submit: Clemens Hammacher <clemensh@chromium.org> TBR=iannucci@chromium.org,tandrii@chromium.org,clemensh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I7463935af172f0801c7da94d2de106a02fc4c42e Reviewed-on: https://chromium-review.googlesource.com/c/1362972Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
-
Edward Lemur authored
Bug: 877717 Change-Id: I6541a971068aae662b086eba84448bd0769f1a09 Reviewed-on: https://chromium-review.googlesource.com/c/1362405Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Check that the cache contains the needed refs, and not only the revisions, before attempting to checkout. Bug: 910547 Change-Id: Ia269132421994803866065e81fc21ecd7ac206ed Reviewed-on: https://chromium-review.googlesource.com/c/1362393Reviewed-by:
-
- 04 Dec, 2018 3 commits
-
-
Ryan Tseng authored
Right now, if clang-format is broken, a CL will still pass CQ. This adds a flag so that it will fail CQ. Bug: 911708 Change-Id: I2c71b7bc434fc611d51f688266be6a265b80f4da Reviewed-on: https://chromium-review.googlesource.com/c/1361560Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org>
-
Clemens Hammacher authored
Currently, the "--upstream A" option for new-branch behaves totally different than "--upstream_current". While "--upstream A" checks out branch A and then creates a new branch which tracks A, "--upstream_current" creates a new branch for the current HEAD and sets the upstream to the previously checked out branch. As the documentation does not mention that any of the options changes the currently-checked-out commit (HEAD), this CL changes the semantics of "git new-branch --upstream A B" to be identical to "git checkout -b B && git branch --set-upstream-to A". It also slightly extends the documentation to mention that in any case the new branch is based on HEAD. R=iannucci@chromium.org Change-Id: Ic335d2caf27cb6afca1b8bc5a008424c0e880fca Reviewed-on: https://chromium-review.googlesource.com/c/1350748Reviewed-by:
-
Andrii Shyshkalov authored
Use api.tryserver.gerrit_change_target_ref instead. Depends on https://crrev.com/c/1359892 Change-Id: If8ec0bb262035239a1ef77093808196561050c9b Reviewed-on: https://chromium-review.googlesource.com/c/1359794 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org>
-
- 03 Dec, 2018 6 commits
-
-
Sergiy Belozorov authored
R=nodir@chromium.org Bug: 911143 Change-Id: Ia506f51687a7e4636e16746483931298dfd22027 Reviewed-on: https://chromium-review.googlesource.com/c/1356520Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
-
Joe Mason authored
Bug: 908466 Change-Id: I715633c64fff343d07dbcf50c261e686d77e8c44 Reviewed-on: https://chromium-review.googlesource.com/c/1351511Reviewed-by:
Andy Perelson <ajp@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The option is --upstream, not --uptstream. R=sergiyb@chromium.org Change-Id: I007dfecae9ba576d65bbb8b96c3f2296d2152a23 Reviewed-on: https://chromium-review.googlesource.com/c/1350747 Auto-Submit: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
-
Takuto Ikuta authored
Change-Id: I60f484a709881f035dc90562658b0a598334451f Reviewed-on: https://chromium-review.googlesource.com/c/1358031 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org>
-
Takuto Ikuta authored
This is to know what build configs are popular among chromium developer. Bug: 900161 Change-Id: Id07722e70fc407b3f8668080d49033da6e1a7f34 Reviewed-on: https://chromium-review.googlesource.com/c/1358034 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This is windows version of https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1345255 Changed to use call to invoke python because python is bat file. Bug: 900161 Change-Id: I0332306387614153be7ae6dbde05fb2bc93559b1 Reviewed-on: https://chromium-review.googlesource.com/c/1355641 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
-
- 01 Dec, 2018 1 commit
-
-
Edward Lemur authored
Bug: 770408 Change-Id: Ic5029d6b12cdb6ea30704d90229ab7e365dc7273 Reviewed-on: https://chromium-review.googlesource.com/c/1354384 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 30 Nov, 2018 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/faa8db3ceb17f3bc13c4ead7e4603760a0532f99 Use reason instead of reason_message. (jchinlee@chromium.org) R=tandrii@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3321c89b8fd9ace846de08149990cda5084ee78b Reviewed-on: https://chromium-review.googlesource.com/c/1357323 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
-
Edward Lemur authored
Bug: 845642 Change-Id: I552b2da4abbac7ca7f6f3961d2b1c5002fb26f47 Reviewed-on: https://chromium-review.googlesource.com/c/1351509Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2caa3255a823c92842e4725693d35d13783fb81e python: add infra_failing_step utility method. (jbudorick@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If77b80bfe76a2b5c77a3ab10501412adac6e586b Reviewed-on: https://chromium-review.googlesource.com/c/1357259 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
Recipe Roller <recipe-roller@chromium.org>
-
erikchen authored
The function can be called by chromium_test to set a property 'do_not_retry' which will be propagated into buildbucket output. Change-Id: I32d8ea925b7cb98d9b25d24226686e116c17801c Bug: 910193 Reviewed-on: https://chromium-review.googlesource.com/c/1351542 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/793d8faa696f62fa2c774b8c854bbf4d64dff24e Separate InfraFailure behavior from StepFailure behavior. (jchinlee@chromium.org) R=tandrii@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I396fcab3dbfcbf365d32483cf08f510805da303c Reviewed-on: https://chromium-review.googlesource.com/c/1355801Reviewed-by:
-
- 29 Nov, 2018 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d0deba23a671b236ec535a9a54aa78b6dcf142ab [Testing] Add comprehensive UI test recipe. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib52d510e2a48c86f6220781178e34c8bcb52c2bd Reviewed-on: https://chromium-review.googlesource.com/c/1355779 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This CL introduces ninjalog_uploader to autoninja for posix environment. This is to collect build statistics from googler to find user side build performance bottleneck. ninjalog_uploader_wrapper is used to notify user and manage small config of upload script. Bug: 900161 Change-Id: I48ac8cd1d52f64e8fdafaec43636d2d79ef9040d Reviewed-on: https://chromium-review.googlesource.com/c/1345255Reviewed-by:
-
- 26 Nov, 2018 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/690ad21d32ae0a94512bc9ac4a6b8fcca96d67f8 Update my legal name (sergiyb@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2e6c43f4586b9b899e929147f5ddf4972c99c9d9 Reviewed-on: https://chromium-review.googlesource.com/c/1351513Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/caf2224c87491b931d6c4441b2119e0287a99347 [isolated] Expose an isolated server getter (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic43cd809209944dc9cea23d87c4cbfdc7006d30e Reviewed-on: https://chromium-review.googlesource.com/c/1351510Reviewed-by:
-
Edward Lemur authored
Use gclient setdep/getdep instead of evaluating the contents of the DEPS file, so we don't have to deal with builtin_variables. Bug: 906114 Change-Id: I2082d4a3feb84d15c251b7d99056fd4c6f925453 Reviewed-on: https://chromium-review.googlesource.com/c/1347450Reviewed-by:
-
- 23 Nov, 2018 1 commit
-
-
Aiden Benner authored
Adding the diff.noprefix flag to .gitconfig broke python formatting because git diffs were being parsed with regex that relied on the default git diff prefixs. This CL fix's this issue by always specifying prefix flags for git diffs when formatting python. Bug:846432 Change-Id: Ifde305da9574e6b46455a0237703b7364fac77e4 Reviewed-on: https://chromium-review.googlesource.com/c/1349809Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
-
- 22 Nov, 2018 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/20068b80c82fb44c9e871f18ee82e1c032c000af [recipe_modules/archive] Update archive to zip entire root by default. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I64c75b109a0b890efdb32db54b398e1688ad6067 Reviewed-on: https://chromium-review.googlesource.com/c/1347451 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
- 21 Nov, 2018 6 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/4118c738aa691c9c2b69f8b69359a9ba4fece9d7 [buildbucket] Document gitiles_commit (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3f01fc3963baa3041328c3aa400dee3e6938f111 Reviewed-on: https://chromium-review.googlesource.com/c/1347449Reviewed-by:
-
Robert Iannucci authored
Now with correct error handling. R=nodir@chromium.org, vadimsh@chromium.org Bug: 869227 Change-Id: I961fd80209c9d9988e9d03016b7c0bd253c6cdfb Reviewed-on: https://chromium-review.googlesource.com/c/1347249 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org>
-
John Budorick authored
Bug: 856278 Change-Id: I949cefd102ecc80b161d082ec40b7e059f596781 Reviewed-on: https://chromium-review.googlesource.com/c/1345050Reviewed-by:
-
Andrii Shyshkalov authored
R=ajp, ehmaldonado Change-Id: I59859048d64902669479e666c6c3d37c1fb1394c Reviewed-on: https://chromium-review.googlesource.com/c/1344642 Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
On my machine, saves 0.16s of time while loading git cl: from 0.32s to 0.16s. R=ajp, ehmaldonado Change-Id: I0febca43f11514da3e3f7be7e2c0184fb9e17409 Reviewed-on: https://chromium-review.googlesource.com/c/1344641Reviewed-by:
-
Andrii Shyshkalov authored
R=ajp, ehmaldonado Change-Id: I9c9f5e0f8ef41c0f6a00faa67acf0cf516290f09 Reviewed-on: https://chromium-review.googlesource.com/c/1345272Reviewed-by:
-
- 20 Nov, 2018 6 commits
-
-
Vadim Shtayura authored
This reverts commit f4913068. Reason for revert: panics, see b/119830955 Original change's description: > [vpython] Roll to pick up user differentiation of cached envs. > > R=vadimsh@chromium.org > > Bug: 869227 > Change-Id: I7e529c7c4d63e35a66ef93623982afc7d254d72f > Reviewed-on: https://chromium-review.googlesource.com/c/1344638 > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> > Auto-Submit: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> TBR=iannucci@chromium.org,vadimsh@chromium.org Change-Id: Ie77d559dc1787ec1b8a19076238b7018d39dd0b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869227 Reviewed-on: https://chromium-review.googlesource.com/c/1344639Reviewed-by:
-
Robert Iannucci authored
R=vadimsh@chromium.org Bug: 869227 Change-Id: I7e529c7c4d63e35a66ef93623982afc7d254d72f Reviewed-on: https://chromium-review.googlesource.com/c/1344638 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
John Budorick authored
This reverts commit 3f40c42b. Reason for revert: ast.literal_eval(False) doesn't work? Original change's description: > Don't fetch flash when fetching android_internal. > > Bug: 856278 > Change-Id: I89eccc7581daedda69dee4f99d174e8cb49c6ba1 > Reviewed-on: https://chromium-review.googlesource.com/c/1342730 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> TBR=ehmaldonado@chromium.org,jbudorick@chromium.org Change-Id: Iffb655701830984e47a2b8e7629f0ed87886a401 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 856278 Reviewed-on: https://chromium-review.googlesource.com/c/1344637Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Aiden Benner authored
Enables python formatting in git cl format by default for all files that have a .style.yapf file in a parent directory up to the repository root. If no .style.yapf file is found the --python flag still needs to be set explicitly for python formatting to be enabled. Also adds a --no-python to explicitly disable python formatting on any file even if a .style.yapf file is found. This allows default formatting to be enabled on a per project/directory basis by adding a .style.yapf file. Bug:846432 Change-Id: I40d899ec1a3e0dfca445e04b91befab113416175 Reviewed-on: https://chromium-review.googlesource.com/c/1316415 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
-
John Budorick authored
Bug: 856278 Change-Id: I89eccc7581daedda69dee4f99d174e8cb49c6ba1 Reviewed-on: https://chromium-review.googlesource.com/c/1342730Reviewed-by:
-
Aiden Benner authored
git cl format --python currently breaks on windows because FindExecutable('yapf') returns .../depot_tools/yapf (a py file) instead of .../depot_tools/yapf.bat. Also yapf.bat tries to run the yapf py file without vpython which breaks the yapf dependency. This CL fixes these two issues. Bug:846432 Change-Id: I551a4c1e6367074fa76767851bd34feb2dcfb6a2 Reviewed-on: https://chromium-review.googlesource.com/c/1341236Reviewed-by:
-
