Commits · f9328b9b72a5ea4e035c02a130575515a730edc3 · Linshizhi / Chromium_Depot_tools

25 May, 2011 1 commit

Revert 86501: Make git-cl and update_depot_tools msys-compatible. · f9328b9b

nsylvain@chromium.org authored May 25, 2011

Review URL: http://codereview.chromium.org/7008006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@86552 0039d316-1c4b-4281-b951-d872f2087c98

f9328b9b

24 May, 2011 2 commits

Make git-cl and update_depot_tools msys-compatible. · 6dbde578

cmp@chromium.org authored May 24, 2011

Review URL: http://codereview.chromium.org/7055025

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@86501 0039d316-1c4b-4281-b951-d872f2087c98

6dbde578

Allowing project name to be used to select groups of bots. · 78230020

bradnelson@google.com authored May 24, 2011

BUG=79546
TEST=None
Review URL: http://codereview.chromium.org/7063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@86460 0039d316-1c4b-4281-b951-d872f2087c98

78230020

21 May, 2011 2 commits

Revert r86185 use /bin/bash for update_depot_tools. · 711a16a9

cmp@chromium.org authored May 21, 2011

This is causing a failure with dash interpreters.
Will revert this change and do testing in that
environment before next landing.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@86211 0039d316-1c4b-4281-b951-d872f2087c98

711a16a9

Use /bin/bash for update_depot_tools. · 86def497

cmp@chromium.org authored May 21, 2011

On at least one platform /usr/bin/env is actually not
a guaranteed method to get to bash.  Fall back to using
/bin/bash for this script.
Review URL: http://codereview.chromium.org/7039045

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@86185 0039d316-1c4b-4281-b951-d872f2087c98

86def497

17 May, 2011 2 commits

For Git tools setup, also copy ssh-keygen.bat. · f33f80cb

cmp@chromium.org authored May 17, 2011

TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/7017005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@85596 0039d316-1c4b-4281-b951-d872f2087c98

f33f80cb

Install Git on Windows via depot tools. · d7ccf53c

cmp@chromium.org authored May 17, 2011

Review URL: http://codereview.chromium.org/7035005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@85568 0039d316-1c4b-4281-b951-d872f2087c98

d7ccf53c

16 May, 2011 1 commit

The Rietveld.get_pending_issue() was totally wrong. Fix it. · 5d46830b

maruel@chromium.org authored May 16, 2011

I wonder how it worked at all. That explains some weird behavior when it was
ignoring issues recently.

Also enabled limit=1000 in case there's a huge bottleneck.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7016038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@85516 0039d316-1c4b-4281-b951-d872f2087c98

5d46830b

12 May, 2011 2 commits

Early exit auto-update when running as root. · 31dcb497

maruel@chromium.org authored May 12, 2011

Otherwise it can mess with file permissions.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7016002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@85178 0039d316-1c4b-4281-b951-d872f2087c98

31dcb497

Remove presubmit warning for long lines in .grd files · 5538e022

sail@chromium.org authored May 12, 2011

The presubmit check complained about long lines in .grd files. This isn't a useful warning since .grd files aren't really source files.

The problem was that callers were passing in a file filter to InputApi.AffectedFiles but it was being ignored. Fix was to use the passed in file filter.

BUG=None
TEST=Ran on a local change and verified that I no longer got long line warnings on .grd files.
Review URL: http://codereview.chromium.org/6932060

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@85148 0039d316-1c4b-4281-b951-d872f2087c98

5538e022

10 May, 2011 2 commits

In r84572, I forgot to move CheckChangeSvnEolStyle() to commit-only check. · 8571dac9

maruel@chromium.org authored May 10, 2011

This check is also handled by the commit bot so no need to harass people when
uploading.

R=dpranke@chromium.org
BUG=none
TEST=Nobody wrote a test for PanProjectChecks() and I didn't write this function, no way I won't.

Review URL: http://codereview.chromium.org/6998008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@84814 0039d316-1c4b-4281-b951-d872f2087c98

8571dac9

Make gcl and git-cl don't throw when a vim user does :cg · 2a471073

maruel@chromium.org authored May 10, 2011

That's just noise for the maintainer.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6985002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@84803 0039d316-1c4b-4281-b951-d872f2087c98

2a471073

08 May, 2011 1 commit

Move copyright and svn mime check presubmit checks to trigger on commit only. · b1ce775c

maruel@chromium.org authored May 08, 2011

The commit bot automagically fixes these issues so the devs don't need to fix these problems

TEST=none
BUG=none
R=dpranke@chromium.org

Review URL: http://codereview.chromium.org/6948006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@84572 0039d316-1c4b-4281-b951-d872f2087c98

b1ce775c

05 May, 2011 4 commits

Enforce unicode commit message. · 1bf5097a

maruel@chromium.org authored May 05, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6928037

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@84289 0039d316-1c4b-4281-b951-d872f2087c98

1bf5097a

Add back support for git mv files. · 04d22591

maruel@chromium.org authored May 05, 2011

It was added in r80045 but was overwriten in r82495 when I synced upload.py to
r705 since upstreaming that part staled.

TBR=dpranke
TEST="git mv foo bar; git commit -a; git cl upload" shows 2 files, one A+, one D.
BUG=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@84264 0039d316-1c4b-4281-b951-d872f2087c98

04d22591

Complete apply_issue.py. · 3cdb7f36

maruel@chromium.org authored May 05, 2011

This is to be able to apply patches directly from rietveld for the try server.

TEST=tested on both svn and git with binary files. unit tests will follow up.
R=dpranke@chromium.org
BUG=

Review URL: http://codereview.chromium.org/6904152

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@84255 0039d316-1c4b-4281-b951-d872f2087c98

3cdb7f36

Pass --rmdir to git svn dcommit to delete empty directories. · 2e64fa1d

bauerb@chromium.org authored May 05, 2011

BUG=80178
TEST=none

Review URL: http://codereview.chromium.org/6902199

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@84230 0039d316-1c4b-4281-b951-d872f2087c98

2e64fa1d

02 May, 2011 1 commit

Remove unmaintained "gclient export" command, · 6e043f75

phajdan.jr@chromium.org authored May 02, 2011

introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=20990

It was intended for the tarball generation script,
but there was a better and simpler way.

BUG=80549
Review URL: http://codereview.chromium.org/6883263

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83708 0039d316-1c4b-4281-b951-d872f2087c98

6e043f75

30 Apr, 2011 1 commit

Caches socket.getfqdn(), send 'domain' when profiling. · 28924253

maruel@chromium.org authored Apr 30, 2011

Otherwise it's hard to know what's generated from automated testing.

R=chase@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6902153

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83673 0039d316-1c4b-4281-b951-d872f2087c98

28924253

29 Apr, 2011 2 commits

Don't eat newlines in CL descriptions when merging changes using drover. · 403a0f9f

rsesek@chromium.org authored Apr 29, 2011

BUG=80589
TEST=Merge a CL using drover and when prompted to upload, check that the original CL description still has its linebreaks.
Review URL: http://codereview.chromium.org/6893095

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83561 0039d316-1c4b-4281-b951-d872f2087c98

403a0f9f

Send googler profiling data. · 7ca049ba

maruel@chromium.org authored Apr 29, 2011

BUG=
TEST=

Review URL: http://codereview.chromium.org/6904055

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83507 0039d316-1c4b-4281-b951-d872f2087c98

7ca049ba

28 Apr, 2011 1 commit

Add --transitive flag. · eaab784b

floitsch@google.com authored Apr 28, 2011

When specifying a revision (with -r) propagates the date of the revision to its children.

Review URL: http://codereview.chromium.org/6873110

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83313 0039d316-1c4b-4281-b951-d872f2087c98

eaab784b

27 Apr, 2011 1 commit

presubmit_support: cache the result of ChangedContents. · 2a3ab7e8

nick@chromium.org authored Apr 27, 2011

Review URL: http://codereview.chromium.org/6897005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83228 0039d316-1c4b-4281-b951-d872f2087c98

2a3ab7e8

26 Apr, 2011 2 commits

Make subprocess2.check_call() compliant with subprocess.check_call(). · 0bcd1d34

maruel@chromium.org authored Apr 26, 2011

Rename check_call to check_call_out. It's a quite specific need when stderr is
needed or when the user doesn't want the default arguments of check_output.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6882127

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83023 0039d316-1c4b-4281-b951-d872f2087c98

0bcd1d34

Fix when entry is None. · 6f323bba

maruel@chromium.org authored Apr 26, 2011

When the tree is not versionned, svn can return <info></info>.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6899052

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83020 0039d316-1c4b-4281-b951-d872f2087c98

6f323bba

23 Apr, 2011 2 commits

Fix constructor arguments to OSError. · ff3e4a87

maruel@chromium.org authored Apr 23, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6897034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82763 0039d316-1c4b-4281-b951-d872f2087c98

ff3e4a87

Optimize presubmit checks for win32 where determining the diff · e06cb4e5

nick@chromium.org authored Apr 23, 2011

seems to take an inordinate amount of time.  The idea is to
lint whole files, and only try to compute deltas if the file
contains at least one error.

For my environment, the three affected presubmit rules took
2000ms each for a 4-file changelist.  With this change,
all my rules run in about a second, and none take anything
close to 500ms.

Also, since there seem to be environment-dependent factors at
work here, I'm proposing putting timer warnings that print
a message if any check takes longer than 500ms.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82559
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=82568
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82607
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=82653
Review URL: http://codereview.chromium.org/6883050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82762 0039d316-1c4b-4281-b951-d872f2087c98

e06cb4e5

22 Apr, 2011 3 commits

:Revert r82607 (reportedly takes forever on long changes) · 7b45069a
nick@chromium.org authored Apr 22, 2011
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82653 0039d316-1c4b-4281-b951-d872f2087c98
```
7b45069a

Optimize presubmit checks for win32 where determining the diff · 9c765d7a

nick@chromium.org authored Apr 22, 2011

seems to take an inordinate amount of time.  The idea is to
lint whole files, and only try to compute deltas if the file
contains at least one error.

For my environment, the three affected presubmit rules took
2000ms each for a 4-file changelist.  With this change,
all my rules run in about a second, and none take anything
close to 500ms.

Also, since there seem to be environment-dependent factors at
work here, I'm proposing putting timer warnings that print
a message if any check takes longer than 500ms.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82559
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=82568
Review URL: http://codereview.chromium.org/6883050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82607 0039d316-1c4b-4281-b951-d872f2087c98

9c765d7a

Add post_process argument to Checkout.apply_patch(). · 8a1396cd

maruel@chromium.org authored Apr 22, 2011

This enables doing late modifications like updating the copyright notice or fixing line endings.

Also silence the checkout operations a bit more when VOID=subprocess2.VOID.

Add corresponding unit tests.

Review URL: http://codereview.chromium.org/6891003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82587 0039d316-1c4b-4281-b951-d872f2087c98

8a1396cd

21 Apr, 2011 5 commits

Revert 82559. · cfbdd987

nick@chromium.org authored Apr 21, 2011

Review URL: http://codereview.chromium.org/6896004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82568 0039d316-1c4b-4281-b951-d872f2087c98

cfbdd987

Optimize presubmit checks for win32 where determining the diff · baa40e63

nick@chromium.org authored Apr 21, 2011

seems to take an inordinate amount of time.  The idea is to
lint whole files, and only try to compute deltas if the file
contains at least one error.

For my environment, the three affected presubmit rules took
2000ms each for a 4-file changelist.  With this change,
all my rules run in about a second, and none take anything
close to 500ms.

Also, since there seem to be environment-dependent factors at
work here, I'm proposing putting timer warnings that print
a message if any check takes longer than 500ms.
Review URL: http://codereview.chromium.org/6883050

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82559 0039d316-1c4b-4281-b951-d872f2087c98

baa40e63

Update upload.py to r705. · 1c5518ea

maruel@chromium.org authored Apr 21, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6889002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82495 0039d316-1c4b-4281-b951-d872f2087c98

1c5518ea

Move commit-queue/checkout into depot_tools so it can be reused by the try server. · dfaecd2b

maruel@chromium.org authored Apr 21, 2011

BUG=
TEST=

Review URL: http://codereview.chromium.org/6877055

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82414 0039d316-1c4b-4281-b951-d872f2087c98

dfaecd2b

Unicode input is also accepted for stdin. · 39f645ff

maruel@chromium.org authored Apr 21, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6878069

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82410 0039d316-1c4b-4281-b951-d872f2087c98

39f645ff

20 Apr, 2011 2 commits

Improve patch handling and tests. · c4b5e76d

maruel@chromium.org authored Apr 20, 2011

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6877038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82406 0039d316-1c4b-4281-b951-d872f2087c98

c4b5e76d

Pass relative paths to GIT.CaptureStatus · 512f1ef7

bauerb@chromium.org authored Apr 20, 2011

BUG=79953
TEST=see bug

Review URL: http://codereview.chromium.org/6883085

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82290 0039d316-1c4b-4281-b951-d872f2087c98

512f1ef7

19 Apr, 2011 1 commit

Only show "Depot Tools has been updated" messages when the tools are actually · 736aefea

mark@chromium.org authored Apr 19, 2011

updated; show the real last-change revision and not the current HEAD revision.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6881049

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82124 0039d316-1c4b-4281-b951-d872f2087c98

736aefea

18 Apr, 2011 2 commits

Make subprocess2.call() returned values to be the same as subprocess.call(). · 1f063db1

maruel@chromium.org authored Apr 18, 2011

Renamed the previous subprocess2.call() to subprocess2.communicate().

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6877005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81976 0039d316-1c4b-4281-b951-d872f2087c98

1f063db1

Fix drover regression introduced in r80453. · e3db8556

maruel@chromium.org authored Apr 18, 2011

getSVNInfo() is expected to fail in some use case. Make this behavior explicit.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6881008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81970 0039d316-1c4b-4281-b951-d872f2087c98

e3db8556